Rjsf-team from React-jsonschema-form Repository

Apache License 2.0

Closed
Adding properties should work when `additionalProperties` is `true` #3181

Issue Opened
Nickgros Opened Issue On Oct 5th 2022, 3:56

Nickgros

Fixes #3179

Conversion of ObjectField to TypeScript caused a regression where additionalProperties: true was not properly evaluated when adding a property.

  • Change ObjectField logic to handle additionalProperties: true.
  • Add tests to validate some of the logic in handleAddClick, including the regression
Comment
Heath-freenome commented on 1 month ago

Heath-freenome

Why didn’t you just restart it manually?

On Wed, Oct 5, 2022 at 1:15 PM Nick Grosenbacher @.***> wrote:

@.**** commented on this pull request.

In CHANGELOG.md https://github.com/rjsf-team/react-jsonschema-form/pull/3181#discussion_r988315249 :

@@ -21,7 +21,8 @@ should change the heading of the (upcoming) version to include a major version b

  • Added support for chakra-react-select v4, fixing #3152.

@rjsf/core

-- Extended Form.onChange to optionally return the id of the field that caused the change, fixing (https://github.com/rjsf-team/react-jsonschema-form/issues/2768) +- Extended Form.onChange to optionally return the id of the field that caused the change, fixing #2768

Should have just added a blank commit to start the CI pipeline...thanks for catching!

— Reply to this email directly, view it on GitHub https://github.com/rjsf-team/react-jsonschema-form/pull/3181#discussion_r988315249, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMKJCZF2XIRYNJXSY7LU7I3WBXOV5ANCNFSM6AAAAAAQ5WNSOA . You are receiving this because your review was requested.Message ID: @.***>

-- This e-mail is private and confidential and is for the addressee only. If misdirected, please notify us by telephone, confirming that it has been deleted from your system and any hard copies destroyed. You are strictly prohibited from using, printing, distributing or disseminating it or any information contained in it save to the intended recipient.

Comment
Nickgros commented on 1 month ago

Nickgros

@heath-freenome Actions went down so it never created a job to restart, so I couldn't figure out how to do it.

About Repository

A React component for building Web forms from JSON Schema.
Language: TypeScript
Star: 12070
Fork: 1990
Watchers: 12070
Open Issues: 388
https://github.com/rjsf-team/react-jsonschema-form
Apache License 2.0
Last updated: 05 Dec 2022
Tropics: