zaiste Github contribution chart
zaiste Github Stats
zaiste Most Used Languages

Activity

29 Sep 2022

Issue Comment

Zaiste

Workflow update

I want to merge this PR because

it updates CI workflow which include integration repo

Related (issues, PRs, topics)

https://github.com/saleor/devtools-integration-tests/issues/4

Steps to test feature

I have:

  • [x] Tested it locally and it doesn't break existing features
  • [ ] Added documentation if public changes are introduced
  • [ ] Added tests for my code

Forked On 29 Sep 2022 at 12:27:32

Zaiste

Finalized with other PRs

Commented On 29 Sep 2022 at 12:27:32

Zaiste

Workflow update

Created On 29 Sep 2022 at 12:27:33

Zaiste

Fix the URL parsing for the instance arg

Created On 29 Sep 2022 at 12:26:55
Create Branch
Zaiste In saleor/saleor-cli Create Branchfix-url-parsing

Zaiste

Command-line interface allowing interaction with Saleor Cloud environments.

On 29 Sep 2022 at 12:24:58

Zaiste

Introduce tests-nightly GH workflow

Pushed On 29 Sep 2022 at 12:12:44

Zaiste

Merge pull request #421 from saleor/gh-tests-nightly

Introduce tests-nightly GH workflow

Pushed On 29 Sep 2022 at 12:12:44

Zaiste

Introduce tests-nightly GH workflow

Created On 29 Sep 2022 at 12:12:42

Zaiste

Introduce tests-nightly GH workflow

I want to merge this PR because

  • It introduces workflow for running tests nightly

Related (issues, PRs, topics)

  • NA

Steps to test feature

  • NA

I have:

  • [ ] Tested it locally and it doesn't break existing features
  • [ ] Added documentation if public changes are introduced
  • [ ] Added tests for my code

Merged On 29 Sep 2022 at 12:12:34

Zaiste

Commented On 29 Sep 2022 at 12:12:34

Zaiste

Remove `boxen` from dependencies

Created On 29 Sep 2022 at 12:02:21
Create Branch
Zaiste In saleor/saleor-cli Create Branchremove-boxen-dep

Zaiste

Command-line interface allowing interaction with Saleor Cloud environments.

On 29 Sep 2022 at 12:01:52

Zaiste

Use contentBox instead of boxen

Created On 29 Sep 2022 at 11:41:59

Zaiste

Use contentBox instead of boxen

Pushed On 29 Sep 2022 at 11:41:59

Zaiste

Merge pull request #420 from saleor/content-box

Use contentBox instead of boxen

Pushed On 29 Sep 2022 at 11:41:59

Zaiste

Setup E2E tests CI/CD

This repository should have CICD with Github actions running with manual trigger (at the moment).

Via REST API this workflow can be triggered and connected to other repos - like open PR (in Storefront, CLI, Platform, etc), night tests (cron) or before a release.

Failing test should notify on email, slack, etc.

Forked On 29 Sep 2022 at 10:24:18

Zaiste

Let's prepare a initial document with the test coverage for the CLI

Commented On 29 Sep 2022 at 10:24:18
Issue Comment

Zaiste

1.14.0-rc.3 doesn’t allow me to deploy an app if I don’t have any env in my organization

Saleor-CLI 1.14.0-rc.3 doesn’t allow me to deploy an app if I don’t have any env in my organization:

(saleor3.9) ➜  saleor-taxjar git:(test-deployment) ✗ saleor app deploy
✔ Select Organization · Saleor-Maciek
✔ Organization · saleor-maciek

  No environments found for this organization 

Can I somehow skip this check? Or provide my own saleor domain?

Forked On 29 Sep 2022 at 10:20:00

Zaiste

@krzysztofwolski proposed to throw an exception when a localhost is used

Commented On 29 Sep 2022 at 10:20:00
Issue Comment

Zaiste

Check Saleor Cloud status flags and gracefully handle them

Some operations might be broken, when Saleor Cloud is at specific state: disabled, during upgrade, maintenance etc.

blocking_tasks_in_progress: bool - whether it can run any task ATM or needs to wait for some tasks to finish first
maintenance_mode: bool - whether the env is disabled for maintenance
disabled: bool - whether the env is disabled (maximum request count exceeded) 

CLI should check them and block some commands if they will fail.

For examples, if env is disabled due to maintenance, app installation will fail. Command app install should be disabled and print a message how to handle it (try again later etc).

Lets create an abstraction to check these statuses, so

  • They can be extended for new statuses
  • They can have specific messages, hints
  • They are reusable

Forked On 29 Sep 2022 at 10:18:07

Zaiste

@2can is discussing it with the cloud team

Commented On 29 Sep 2022 at 10:18:07
Issue Comment

Zaiste

1.14.0-rc.3 doesn’t allow me to deploy an app if I don’t have any env in my organization

Saleor-CLI 1.14.0-rc.3 doesn’t allow me to deploy an app if I don’t have any env in my organization:

(saleor3.9) ➜  saleor-taxjar git:(test-deployment) ✗ saleor app deploy
✔ Select Organization · Saleor-Maciek
✔ Organization · saleor-maciek

  No environments found for this organization 

Can I somehow skip this check? Or provide my own saleor domain?

Forked On 29 Sep 2022 at 09:36:19

Zaiste

There is another (blocking) problem here. As you intend to deploy a Saleor and work with your local Saleor instance, that instance must be available online so that the deploy app can reach it to initiate the installation token exchange flow. The tunnelling for Saleor platform is not yet available. This requires more discussion.

The feature implemented in #321 allows you work with your own Saleor instance as long as it's deployed somewhere and available - this is only in the context of app deploy.

I propose to close this issue and create a new one to cover this particular topic.

Commented On 29 Sep 2022 at 09:36:19
Issue Comment

Zaiste

1.14.0-rc.3 doesn’t allow me to deploy an app if I don’t have any env in my organization

Saleor-CLI 1.14.0-rc.3 doesn’t allow me to deploy an app if I don’t have any env in my organization:

(saleor3.9) ➜  saleor-taxjar git:(test-deployment) ✗ saleor app deploy
✔ Select Organization · Saleor-Maciek
✔ Organization · saleor-maciek

  No environments found for this organization 

Can I somehow skip this check? Or provide my own saleor domain?

Forked On 29 Sep 2022 at 09:29:20

Zaiste

Since 1.16 you can now set the --url (or -u) with saleor app deploy to specify the Saleor instance that you are targeting.

Commented On 29 Sep 2022 at 09:29:20
Issue Comment

Zaiste

Document "saleor dev" command

Document dev info and dev prepare

Forked On 29 Sep 2022 at 09:27:17

Zaiste

Tested (with corrected pathname)

Commented On 29 Sep 2022 at 09:27:17

Zaiste

Rename the filename for the `dev` subcommand

Created On 29 Sep 2022 at 09:25:51
Create Branch
Zaiste In saleor/saleor-cli Create Branchfix-docs-name

Zaiste

Command-line interface allowing interaction with Saleor Cloud environments.

On 29 Sep 2022 at 09:24:41

Zaiste

Test for `storefront create --demo`

Context

Command npx saleor storefront create --demo is an important starting point for people visiting the Saleor website.

This command must work no matter what, so it's a good candidate for the first "serious" integration test.

Initial test

GIVEN: Saleor CLI is installed (I can set Saleor CLI version in CICD input 💯 )

WHEN: npx saleor storefront create --demo is executed (with other flags non-interactive way)

THEN: Repository should be created locally AND Project should run locally AND Any product can be added to basket AND Can proceed to checkout

Forked On 29 Sep 2022 at 09:21:57

Zaiste

We have now a functional CLI test that covers this scenario and it shows the required argumetns to run this command in the batch (aka non-interactive) mode.

https://github.com/saleor/saleor-cli/blob/main/test/functional/storefront/create.test.ts

There was a change request regarding how storefront create works. It doesn't start in development mode. We need to decide how to test the progression from the CLI execution to the browser flow.

Commented On 29 Sep 2022 at 09:21:57
Create Branch
Zaiste In zaiste/graphism Create Branch0.2.0

Zaiste

Quickly create GraphQL servers in Deno & Deno Deploy

On 28 Sep 2022 at 06:18:34

Zaiste

refinement: decouple route from handler mapping

Pushed On 28 Sep 2022 at 06:18:33

Zaiste

task: formatting

Pushed On 28 Sep 2022 at 06:18:33

Zaiste

task: update dependencies

Pushed On 28 Sep 2022 at 06:18:33

Zaiste

release: 0.2.0

Pushed On 28 Sep 2022 at 06:18:33
Create Branch
Zaiste In zaiste/wren Create Branch0.3.0

Zaiste

A small, but powerful HTTP library for Deno & Deno Deploy, built for convenience and simplicity

On 28 Sep 2022 at 06:10:18

Zaiste

release: 0.3.0

Pushed On 28 Sep 2022 at 06:10:18