ydogandjiev Github contribution chart
ydogandjiev Github Stats
ydogandjiev Most Used Languages

Activity

26 Sep 2022

Ydogandjiev

Bump reorder-python-imports from 3.8.2 to 3.8.3 in /.github/workflows (#28)

Bumps reorder-python-imports from 3.8.2 to 3.8.3.


updated-dependencies:

  • dependency-name: reorder-python-imports dependency-type: direct:production update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Pushed On 26 Sep 2022 at 07:46:42

Ydogandjiev

Bump reorder-python-imports from 3.8.2 to 3.8.3 in /.github/workflows

Created On 26 Sep 2022 at 07:46:41

Ydogandjiev

Bump reorder-python-imports from 3.8.2 to 3.8.3 in /.github/workflows

Bumps reorder-python-imports from 3.8.2 to 3.8.3.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Merged On 26 Sep 2022 at 07:46:36

Ydogandjiev

Commented On 26 Sep 2022 at 07:46:36

Ydogandjiev

started

Started On 24 Sep 2022 at 04:59:22

Ydogandjiev

Add script for updating Portainer agent

Pushed On 19 Sep 2022 at 05:39:05

Ydogandjiev

Add bash home lab maintenance scripts

Pushed On 19 Sep 2022 at 05:36:37
Create Branch

Ydogandjiev

Description not entered by the user.

On 19 Sep 2022 at 05:33:56
Create Branch

Ydogandjiev

Description not entered by the user.

On 19 Sep 2022 at 05:33:56

Ydogandjiev

Bump release-drafter/release-drafter from 5.20.1 to 5.21.0 (#26)

Bumps release-drafter/release-drafter from 5.20.1 to 5.21.0.


updated-dependencies:

  • dependency-name: release-drafter/release-drafter dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Pushed On 17 Sep 2022 at 01:06:27

Ydogandjiev

Bump release-drafter/release-drafter from 5.20.1 to 5.21.0

Created On 17 Sep 2022 at 01:06:27

Ydogandjiev

Bump release-drafter/release-drafter from 5.20.1 to 5.21.0

Bumps release-drafter/release-drafter from 5.20.1 to 5.21.0.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Merged On 17 Sep 2022 at 01:06:21

Ydogandjiev

Commented On 17 Sep 2022 at 01:06:21

Ydogandjiev

started

Started On 15 Sep 2022 at 05:40:58

Ydogandjiev

Update dialog.submit and dialog.sendMessageToParentFromDialog

For more information about how to contribute to this repo, visit this page.

Description

Dialog.submit now throws an error if it is called when contentActions within appContext is defined and arguments are passed to the submit function since they will not do what is expected in this context.

NEED INPUT Since content actions are new, there are no built in sdk errors that truly explain what is going on in these cases, is there a new SDK error I can add to the constants file that would fit better? Or is there an existing one someone is partial to?

Main changes in the PR:

  1. change dialog.submit to throw error
  2. change sendMessageToParentFromDialog to throw error

Validation

Validation performed:

  1. ran unit tests

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

yes

End-to-end tests added:

no

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Next/remaining steps:

  • [ ] add e2e tests

Forked On 13 Sep 2022 at 11:36:36

Ydogandjiev

Same as above; if this API needs to return errors asynchronously it should return a promise chain
On 13 Sep 2022 at 11:36:36

Ydogandjiev

Update dialog.submit and dialog.sendMessageToParentFromDialog

For more information about how to contribute to this repo, visit this page.

Description

Dialog.submit now throws an error if it is called when contentActions within appContext is defined and arguments are passed to the submit function since they will not do what is expected in this context.

NEED INPUT Since content actions are new, there are no built in sdk errors that truly explain what is going on in these cases, is there a new SDK error I can add to the constants file that would fit better? Or is there an existing one someone is partial to?

Main changes in the PR:

  1. change dialog.submit to throw error
  2. change sendMessageToParentFromDialog to throw error

Validation

Validation performed:

  1. ran unit tests

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

yes

End-to-end tests added:

no

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Next/remaining steps:

  • [ ] add e2e tests

Forked On 13 Sep 2022 at 11:36:07

Ydogandjiev

This code is making non-obvious assumptions that could change in the future. It's totally not obvious why actionInfo in the context would change the behavior of this API. I think it would be good to add a separate API here specific for these actions and a new FrameContext for this flow.
On 13 Sep 2022 at 11:36:07

Ydogandjiev

Update dialog.submit and dialog.sendMessageToParentFromDialog

For more information about how to contribute to this repo, visit this page.

Description

Dialog.submit now throws an error if it is called when contentActions within appContext is defined and arguments are passed to the submit function since they will not do what is expected in this context.

NEED INPUT Since content actions are new, there are no built in sdk errors that truly explain what is going on in these cases, is there a new SDK error I can add to the constants file that would fit better? Or is there an existing one someone is partial to?

Main changes in the PR:

  1. change dialog.submit to throw error
  2. change sendMessageToParentFromDialog to throw error

Validation

Validation performed:

  1. ran unit tests

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

yes

End-to-end tests added:

no

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Next/remaining steps:

  • [ ] add e2e tests

Forked On 13 Sep 2022 at 11:34:39

Ydogandjiev

Throwing exceptions inside of a promise chain like this is not a good idea since there is no good way for developers to catch and handle them.
On 13 Sep 2022 at 11:34:39

Ydogandjiev

Update dialog.submit and dialog.sendMessageToParentFromDialog

For more information about how to contribute to this repo, visit this page.

Description

Dialog.submit now throws an error if it is called when contentActions within appContext is defined and arguments are passed to the submit function since they will not do what is expected in this context.

NEED INPUT Since content actions are new, there are no built in sdk errors that truly explain what is going on in these cases, is there a new SDK error I can add to the constants file that would fit better? Or is there an existing one someone is partial to?

Main changes in the PR:

  1. change dialog.submit to throw error
  2. change sendMessageToParentFromDialog to throw error

Validation

Validation performed:

  1. ran unit tests

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

yes

End-to-end tests added:

no

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Next/remaining steps:

  • [ ] add e2e tests

Merged On 13 Sep 2022 at 11:36:52

Ydogandjiev

Commented On 13 Sep 2022 at 11:36:52

Ydogandjiev

Update dialog.submit and dialog.sendMessageToParentFromDialog

For more information about how to contribute to this repo, visit this page.

Description

Dialog.submit now throws an error if it is called when contentActions within appContext is defined and arguments are passed to the submit function since they will not do what is expected in this context.

NEED INPUT Since content actions are new, there are no built in sdk errors that truly explain what is going on in these cases, is there a new SDK error I can add to the constants file that would fit better? Or is there an existing one someone is partial to?

Main changes in the PR:

  1. change dialog.submit to throw error
  2. change sendMessageToParentFromDialog to throw error

Validation

Validation performed:

  1. ran unit tests

Unit Tests added:

Unit tests are required for all changes. If no unit tests were added as part of this change, please explain why they aren't necessary.

yes

End-to-end tests added:

no

Additional Requirements

Change file added:

Ensure the change file meets the formatting requirements.

<Yes/No>

Next/remaining steps:

  • [ ] add e2e tests

Merged On 13 Sep 2022 at 11:36:52

Ydogandjiev

Commented On 13 Sep 2022 at 11:36:52

Ydogandjiev

started

Started On 13 Sep 2022 at 06:31:27
Issue Comment

Ydogandjiev

Admin portal not accessible via IP address

Versions

  • Pi-hole: v5.12
  • AdminLTE: v5.14.2
  • FTL: v5.17

Platform

  • OS and version: Raspbian 11
  • Platform: Raspberry Pi

Expected behavior

Pi-hole web frontend is accessible via IP address, e.g.: http://192.168.X.X/admin

Actual behavior / bug

Pi-hole web frontend returns "404 page not found" error when accessed via its IP address. Access via http://pi.hole/admin appears to work. I double-checked that the IP address is correct and also tried restarting my Pi-hole. This seemed to have started happening very recently; possible after the latest updates I installed for my Raspberry Pi OS.

Steps to reproduce

Steps to reproduce the behavior:

  1. Install latest updates for Raspberry Pi OS (Bullseye)
  2. Try to access Pi-hole admin portal via IP address
  3. See 404 error

Debug Token

  • URL: https://tricorder.pi-hole.net/VRSiUcF9/

Screenshots

image

Additional context

This issue appears to break my Pi-hole integration with Home Assistant and the Pi-hole Remote app for iOS. Both of these require access via an IP address; they are unable to resolve pi.hole.

Forked On 13 Sep 2022 at 02:01:08

Ydogandjiev

I was trying to learn Kubernetes and ended up installing k3s on several of my Raspberry Pis including the one hosting Pi-hole. At some point I noticed that all of these Pis were exhibiting this same issue so I uninstalled k3s and everything started working great again. Closing this issue.

Commented On 13 Sep 2022 at 02:01:08