steveluscher Github contribution chart
steveluscher Github Stats
steveluscher Most Used Languages

Activity

29 Sep 2022

Steveluscher

v0.9.3 (#269)

Pushed On 29 Sep 2022 at 03:31:57

Steveluscher

v0.9.3

Created On 29 Sep 2022 at 03:31:56

Steveluscher

v0.9.3

Created On 29 Sep 2022 at 03:31:51
Create Branch

Steveluscher

Description not entered by the user.

On 29 Sep 2022 at 03:31:09

Steveluscher

v0.9.3

Pushed On 29 Sep 2022 at 03:31:08

Steveluscher

v0.9.2 (#256)

Pushed On 29 Sep 2022 at 03:29:06

Steveluscher

Clarify some details in the MWA spec based on feedback

Pushed On 29 Sep 2022 at 03:29:06

Steveluscher

Update to Gradle 7.4 and AGP 7.3.0

Pushed On 29 Sep 2022 at 03:29:06

Steveluscher

Extract the interface out of AuthRepository (#263)

Pushed On 29 Sep 2022 at 03:29:06

Steveluscher

Add account label display to fakedapp and example-clientlib-ktx-app

Fixes #187

Pushed On 29 Sep 2022 at 03:29:06

Steveluscher

Update incoming sequence number handling to match latest spec revision

Fixes #257, fixes #258, fixes #259

Pushed On 29 Sep 2022 at 03:29:06

Steveluscher

Use strict inequality operator for sequence number check (#266)

Pushed On 29 Sep 2022 at 03:29:06

Steveluscher

fix: repair CommonJS require paths (#268)

Pushed On 29 Sep 2022 at 03:29:06
Create Branch

Steveluscher

Description not entered by the user.

On 29 Sep 2022 at 03:28:17

Steveluscher

fix: repair CommonJS require paths (#268)

Pushed On 29 Sep 2022 at 12:09:35

Steveluscher

fix: repair CommonJS require paths

Created On 29 Sep 2022 at 12:09:34

Steveluscher

fix: repair CommonJS require paths

Created On 29 Sep 2022 at 12:09:22

Steveluscher

fix: repair CommonJS require paths

Pushed On 29 Sep 2022 at 12:07:53
Create Branch
Steveluscher In solana-mobile/mobile-wallet-adapter Create Branchrepair-cjs-require-paths

Steveluscher

Description not entered by the user.

On 29 Sep 2022 at 12:07:39

Steveluscher

Use strict inequality operator for sequence number check (#266)

Pushed On 28 Sep 2022 at 11:15:34

Steveluscher

Use strict inequality operator for sequence number check

Created On 28 Sep 2022 at 11:15:34

Steveluscher

Use strict inequality operator for sequence number check
Merged On 28 Sep 2022 at 11:15:28

Steveluscher

Guh. Sorry. Both times I was reading your PRs I was on mobile, where positively every useful bit of context is cut off in the UI in some way.

Commented On 28 Sep 2022 at 11:15:28

Steveluscher

Use strict inequality operator for sequence number check
Merged On 28 Sep 2022 at 10:59:51

Steveluscher

There was another file in the last PR, yeah?

Commented On 28 Sep 2022 at 10:59:51

Steveluscher

Use strict inequality operator for sequence number check
Merged On 28 Sep 2022 at 10:59:26

Steveluscher

.

Commented On 28 Sep 2022 at 10:59:26

Steveluscher

Use strict inequality operator for sequence number check
Forked On 28 Sep 2022 at 10:58:56

Steveluscher

There was another file in the last PR, yeah?

Commented On 28 Sep 2022 at 10:58:56

Steveluscher

Update incoming sequence number handling to match latest spec revision

Fixes #257, fixes #258, fixes #259

Forked On 28 Sep 2022 at 06:11:15

Steveluscher

Generally !== in JS.

Commented On 28 Sep 2022 at 06:11:15
Issue Comment

Steveluscher

git-branchless CLI hangs at 100% CPU

Description of the bug

When I run git sl the CLI hangs indefinitely.

Expected behavior

The smartlog should appear.

Actual behavior

  • the CLI hangs (no output)
  • the git-branchless process consumes 100% of one CPU core
  • ps aux | grep git looks like this:
    % ps aux | grep git
    sluscher         53485  99.4 20.2 413491888 3381648 s000  R+    2:19PM   1:09.67 /Users/sluscher/.cargo/bin/git-branchless smartlog
    sluscher         53925   0.0  0.0 408104048   1456 s001  S+    2:20PM   0:00.00 grep --color=auto --exclude-dir=.bzr --exclude-dir=CVS --exclude-dir=.git --exclude-dir=.hg --exclude-dir=.svn --exclude-dir=.idea --exclude-dir=.tox git
    sluscher         53484   0.0  0.0 407976192   2144 s000  S+    2:19PM   0:00.01 /Applications/Xcode.app/Contents/Developer/usr/bin/git sl
    sluscher         53483   0.0  0.0 408128800   4944 s000  S+    2:19PM   0:00.01 git-branchless wrap -- sl 

Version of rustc

rustc 1.63.0-nightly (dc80ca78b 2022-06-21)

Automated bug report

git branchless bug-report also hangs.

Version of git-branchless

git-branchless 0.4.0

Version of git

git version 2.37.0 (Apple Git-136)

Forked On 28 Sep 2022 at 04:22:44

Steveluscher

Drat, I did git update-ref -d refs/heads/origin/master and that didn't help. Commenting out merge = refs/heads/master in .git/config did bring smartlog back to life though!

Commented On 28 Sep 2022 at 04:22:44

Steveluscher

web3.js - feat(connection): pass headers to websocket client

Created On 27 Sep 2022 at 09:37:16
Issue Comment

Steveluscher

web3.js - feat(connection): pass headers to websocket client

Problem

https://github.com/solana-labs/solana/issues/28112

Summary of Changes

Pass headers to websocket client

Fixes #

Forked On 27 Sep 2022 at 09:37:15

Steveluscher

Commented on #28112.

Commented On 27 Sep 2022 at 09:37:15
Issue Comment

Steveluscher

web3.js: Connection not passing custom headers to the Websocket client

Problem

Im currently using an RPC node that uses an Authorization header, but im unable to connect through WS since the headers are missing on the Websocket client. The custom headers on a new Connection() are not being passed to the Websocket client

https://github.com/solana-labs/solana-web3.js/blob/master/src/connection.ts#L2711-L2714

Proposed Solution

Adding it like this may fix the issue

this._rpcWebSocket = new RpcWebSocketClient(this._rpcWsEndpoint, {
      autoconnect: false,
      max_reconnects: Infinity,
      headers: httpHeaders
    }); 

Forked On 27 Sep 2022 at 09:36:50

Steveluscher

Hey there! This comes up every now and again; read this prior discussion for more! https://github.com/solana-labs/solana/pull/24833#issuecomment-1165657477

Commented On 27 Sep 2022 at 09:36:50
Issue Comment

Steveluscher

Upgrade react-native 0.70

Why

update react-native to 0.70 for sdk 47

How

  • update package versions
    • react 18.0.0 -> 18.1.0
    • react-native 0.69.5 -> 0.70.1
    • react-native-web ~0.18.7 -> ~0.18.9
    • react-test-renderer 18.0.0 -> 18.1.0
    • metro-react-native-babel-preset ~0.70.3 -> ~0.72.1
    • react-native-reanimated 2.9.1 -> 2.10.0 (because 2.9 doesn't support react-native 0.70)
    • [NCL] remove unused react-native-redash
    • [NCL] @react-navigation/native ~5.8.9 -> ~5.9.8 (fixed the deprecated Linking.removeEventListener)
  • migrate templates based on rn-upgrade helper. one exception is that we still use jsc by default in sdk 47.
    • expo-template-bare-minimum
    • bare-expo
    • bare-sandbox
    • fabric-tester
    • native-tests
    • android (expo go)
    • ios (expo go)
  • update our react-native fork to 0.70 based
  • [android] use ReactAndroid directly from react-native-lab/react-native/ReactAndroid without copying a lot of files to expo/expo to increase the repo size. close ENG-4562. i will remove android/ReactAndroid and android/ReactCommon in a separate commit.
  • [tools] update-rn: support running transformer directly in react-native-lab/react-native
  • [ios] backport folly version to previous versioned code
  • [0.70 breaking change] fix skia build error for jsi::detail::throwJSError. use throw jsi::JSError instead as upstream latest code.
  • [0.70 breaking change][updates] NativeModuleCallExceptionHandler -> JSExceptionHandler. change from https://github.com/facebook/react-native/commit/b6f7689d701d0409c23ab364356aeb95710c20fa

Test Plan

  • ✅ android expo go + unversioned NCL
  • ✅ ios expo go + unversioned NCL
  • ✅ android bare-expo
  • ✅ ios bare-expo
  • ✅ android fabric-tester
  • ✅ ios fabric-tester
  • ✅ ci passed

Checklist

  • [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [x] Conforms with the Documentation Writing Style Guide
  • [x] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Forked On 27 Sep 2022 at 05:42:09

Steveluscher

giphy

Commented On 27 Sep 2022 at 05:42:09
Issue Comment

Steveluscher

Rewrite providers to be immutable to prevent certain classes of MITM attack

Problem statement

Third party code with access to the same window sandbox as Backpack can override the Backpack providers. Threats include, but are not limited to, MITM attacks:

const oldSendTransaction = window.xnft.solana.send.bind(window.xnft.solana);
window.xnft.solana.send = (transaction) => {
  // Maliciously modify transaction.
  const evilTransaction = getModifiedTransaction(transaction);
  // Forward it to the transaction sender.
  return oldSendTransaction(evilTransaction);
}; 

Proposed solution

  • [x] #881
  • [ ] Rewrite providers using private members and deep freezing
    class ProviderThing {
      #publicKey = null  // JavaScript private member
      constructor() {
        if(new.target === ProviderThing) {
          Object.freeze(this);  // Deep freeze everything but private members
        }
      }
      getPublicKey() {
        return this.#publicKey;
      }
      setPublicKey(value) {
        this.#publicKey = value;  // Still works, despite being frozen.
      }
    } 

Forked On 27 Sep 2022 at 12:59:34

Steveluscher

I don't intend on sending a PR for the “rewrite providers using private members and deep freezing” step. If you, dear reader, would like to step up and perform that refactor, go for it!

Commented On 27 Sep 2022 at 12:59:34
Issue Comment

Steveluscher

Inject providers to `window` in such a way they can't be reassigned

Addresses #882.

Forked On 27 Sep 2022 at 12:37:03

Steveluscher

(should have maybe mentioned that I literally didn't test this) 🤞🏻

Commented On 27 Sep 2022 at 12:37:03