stanlemon Github contribution chart
stanlemon Github Stats
stanlemon Most Used Languages

Activity

20 Sep 2022

Stanlemon

started

Started On 20 Sep 2022 at 10:26:28

Stanlemon

Deploying to gh-pages from @ 283219e1f3f782aba1b668516ff78d9c9617f5a7 🚀

Pushed On 10 Sep 2022 at 06:00:34

Stanlemon

Deploying to gh-pages from @ 283219e1f3f782aba1b668516ff78d9c9617f5a7 🚀

Pushed On 10 Sep 2022 at 06:00:32
Issue Comment

Stanlemon

accessibility

Hi there. I am using jGrowl on my website, and working on accessibility improvements to said website. I noticed this discussion the owner of this repo had about accessibility: https://stackoverflow.com/questions/42764836/can-screen-reader-like-jaws-read-jgrowl-message but it looks like this was never followed up with any changes in the repository.

The only change that actually needs to happen for jGrowl to be much more accessible is for any div with id="jGrowl" to also have attributes role="alert" and aria-live="polite". Of course if you want to be even more accessible you should allow the $.jGrowl function to optionally accept a boolean for changing to aria-live="assertive" if true.

The other small change would be to add aria-label="close" to the x buttons, since right now a screenreader will read this as a multiplication sign.

I hope this helps the owner of this repo and anyone using jGrowl in the future!

Forked On 10 Sep 2022 at 05:33:53

Stanlemon

Hey @rober423 thanks for reaching out with this helpful advice! Please feel free to submit a PR with these suggestions.

Commented On 10 Sep 2022 at 05:33:53

Stanlemon

Deploying to gh-pages from @ 3a01b543a0a6e25390af2d7f06511e21047e7fa3 🚀

Pushed On 03 Sep 2022 at 07:30:07

Stanlemon

Deploying to gh-pages from @ 3a01b543a0a6e25390af2d7f06511e21047e7fa3 🚀

Pushed On 03 Sep 2022 at 07:30:06

Stanlemon

Deploying to gh-pages from @ 1a0123ef91a2e0eb65861c729653f6e19ba50fb5 🚀

Pushed On 03 Sep 2022 at 07:20:07

Stanlemon

Deploying to gh-pages from @ 1a0123ef91a2e0eb65861c729653f6e19ba50fb5 🚀

Pushed On 03 Sep 2022 at 07:20:06

Stanlemon

Update dependency puppeteer to v17 (#807)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 01 Sep 2022 at 01:04:34

Stanlemon

Update dependency puppeteer to v17

Created On 01 Sep 2022 at 01:04:33

Stanlemon

Update dependency eslint-plugin-jest to v27

Pushed On 01 Sep 2022 at 01:04:27

Stanlemon

Merge pull request #88 from stanlemon/renovate/eslint-plugin-jest-27.x

Update dependency eslint-plugin-jest to v27

Pushed On 01 Sep 2022 at 01:04:27

Stanlemon

Update dependency eslint-plugin-jest to v27

Created On 01 Sep 2022 at 01:04:27

Stanlemon

Bump jest from 28.1.3 to 29.0.1 (#57)

Bumps jest from 28.1.3 to 29.0.1.


updated-dependencies:

  • dependency-name: jest dependency-type: direct:development update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Pushed On 01 Sep 2022 at 12:57:08

Stanlemon

Bump jest from 28.1.3 to 29.0.1

Created On 01 Sep 2022 at 12:57:08

Stanlemon

started

Started On 30 Aug 2022 at 11:15:07

Stanlemon

Deploying to gh-pages from @ 71016787b056dbdb9feb9b520145503a66557e00 🚀

Pushed On 27 Aug 2022 at 06:55:11

Stanlemon

Deploying to gh-pages from @ 71016787b056dbdb9feb9b520145503a66557e00 🚀

Pushed On 27 Aug 2022 at 06:55:10

Stanlemon

Update dependency helmet to v6 (#806)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 27 Aug 2022 at 05:09:14

Stanlemon

Update dependency helmet to v6

Created On 27 Aug 2022 at 05:09:14

Stanlemon

Update jest monorepo to v29

Pushed On 27 Aug 2022 at 05:08:52

Stanlemon

Merge pull request #85 from stanlemon/renovate/major-jest-monorepo

Update jest monorepo to v29 (major)

Pushed On 27 Aug 2022 at 05:08:52

Stanlemon

Update jest monorepo to v29 (major)

Created On 27 Aug 2022 at 05:08:52

Stanlemon

Update all non-major dependencies

Created On 27 Aug 2022 at 03:04:08

Stanlemon

Update all non-major dependencies

Pushed On 27 Aug 2022 at 03:04:09

Stanlemon

Merge pull request #86 from stanlemon/renovate/all-minor-patch

Update all non-major dependencies

Pushed On 27 Aug 2022 at 03:04:09

Stanlemon

Deploying to gh-pages from @ e036b9390c5e141b5d17dfc255c11029bc089676 🚀

Pushed On 27 Aug 2022 at 03:02:18

Stanlemon

Deploying to gh-pages from @ e036b9390c5e141b5d17dfc255c11029bc089676 🚀

Pushed On 27 Aug 2022 at 03:02:17

Stanlemon

Update all non-major dependencies

Created On 27 Aug 2022 at 02:56:39