sindresorhus Github contribution chart
sindresorhus Github Stats
sindresorhus Most Used Languages

Activity

04 Oct 2022

Issue Comment

Sindresorhus

Suggestion: Make `SetNonNullable` 2nd Generic Optional

https://github.com/sindresorhus/type-fest/pull/431 added the SetNonNullable type, which is very similar to a type we use where I work (see https://github.com/sindresorhus/type-fest/issues/228#issuecomment-1136017869), but unlike this type, the one in type-fest enforces that the 2nd keys generic is passed. Is there a reason we would be opposed to making the 2nd generic optional (where the default is to make all keys non nullable)?

Forked On 04 Oct 2022 at 02:40:57

Sindresorhus

👍 Go for it.

Commented On 04 Oct 2022 at 02:40:57

Sindresorhus

Init

Pushed On 04 Oct 2022 at 02:06:08

Sindresorhus

Update readme.md

Pushed On 04 Oct 2022 at 01:26:23

Sindresorhus

Init

Pushed On 04 Oct 2022 at 12:59:27
Create Branch
Sindresorhus In xojs/xo Create Branchv0.52.4

Sindresorhus

❤️ JavaScript/TypeScript linter (ESLint wrapper) with great defaults

On 04 Oct 2022 at 12:15:17

Sindresorhus

0.52.4

Pushed On 04 Oct 2022 at 12:15:17

Sindresorhus

Fix a bug with relative extends (#686)

Pushed On 04 Oct 2022 at 12:12:01
Pull Request

Sindresorhus

Relative 'extends' no longer error out in the XO VS Code extension, nor if running XO from a different folder

Created On 04 Oct 2022 at 12:12:00
Merge

Sindresorhus

Expose styles as variables

Resolves #565

Forked On 04 Oct 2022 at 12:05:19

Sindresorhus

I think an example could be useful, as it's not clear what these properties contain or what to use them for.
On 04 Oct 2022 at 12:05:19

Sindresorhus

Expose styles as variables

Resolves #565

Merged On 04 Oct 2022 at 12:05:20

Sindresorhus

Commented On 04 Oct 2022 at 12:05:20

Sindresorhus

Update readme.md

Pushed On 04 Oct 2022 at 12:04:53

Sindresorhus

Simplify CookieJar docs (#2155)

Pushed On 04 Oct 2022 at 12:02:07

Sindresorhus

Simplify CookieJar doc

Created On 04 Oct 2022 at 12:02:06

Sindresorhus

Update App Store icon

@sindresorhus does a palette inversion quench your refresh thirst? 😃

Before | After --- | --- |

Making the icon completely flat white could also work, similar style to GitHub Desktop’s:

Forked On 04 Oct 2022 at 10:20:25

Sindresorhus

I'm fine with just keeping the existing icon.

Commented On 04 Oct 2022 at 10:20:25

Sindresorhus

Update App Store icon

@sindresorhus does a palette inversion quench your refresh thirst? 😃

Before | After --- | --- |

Making the icon completely flat white could also work, similar style to GitHub Desktop’s:

Forked On 04 Oct 2022 at 09:00:08

Sindresorhus

Not a big fan. The gradient clashes with the artwork.

Commented On 04 Oct 2022 at 09:00:08
Issue Comment

Sindresorhus

Facing an import error with webpack build

`<repo_path>/packages/backend/dist/main.js:1688 module.exports = require("<repo_path>/node_modules/file-type/index.js"); ^

Error [ERR_REQUIRE_ESM]: require() of ES Module<repo_path>/node_modules/file-type/index.js from <repo_path>/packages/backend/dist/main.js not supported. Instead change the require of index.js in /Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js to a dynamic import() which is available in all CommonJS modules. at Object.file-type (<repo_path>/packages/backend/dist/main.js:1688:18) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at fn (<repo_path>/packages/backend/dist/main.js:2207:21) at eval (webpack-internal:///../../plugins/ui-components-backend/src/service/routes/components/storybook.ts:5:67) at Module.../../plugins/ui-components-backend/src/service/routes/components/storybook.ts (<repo_path>/packages/backend/dist/main.js:1240:1) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at fn (<repo_path>/packages/backend/dist/main.js:2207:21) at eval (webpack-internal:///../../plugins/ui-components-backend/src/service/routes/components/index.ts:8:68) at Module.../../plugins/ui-components-backend/src/service/routes/components/index.ts (<repo_path>/packages/backend/dist/main.js:1218:1) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at fn (<repo_path>/packages/backend/dist/main.js:2207:21) at eval (webpack-internal:///../../plugins/ui-components-backend/src/service/routes/index.ts:7:69) at Module.../../plugins/ui-components-backend/src/service/routes/index.ts (<repo_path>/packages/backend/dist/main.js:1273:1) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at fn (/Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:2207:21) at eval (webpack-internal:///../../plugins/ui-components-backend/src/service/router.ts:11:65) at Module.../../plugins/ui-components-backend/src/service/router.ts (/Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:1207:1) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at fn (/Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:2207:21) at eval (webpack-internal:///../../plugins/ui-components-backend/src/index.ts:6:73) at Module.../../plugins/ui-components-backend/src/index.ts (/Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:1075:1) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at fn (/Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:2207:21) at eval (webpack-internal:///./src/plugins/uiComponents.ts:5:96) at Module../src/plugins/uiComponents.ts (/Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:305:1) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at fn (/Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:2207:21) at eval (webpack-internal:///./src/index.ts:23:80) at Module../src/index.ts (<repo_path>/packages/backend/dist/main.js:140:1) at webpack_require (<repo_path>/packages/backend/dist/main.js:2025:33) at /Users/4095851/lowes-repo/lowes-backstage/packages/backend/dist/main.js:3045:37 at Object. (<repo_path>/packages/backend/dist/main.js:3047:12) { code: 'ERR_REQUIRE_ESM' } `

Can anyone help me how to resolve this?

Forked On 04 Oct 2022 at 03:51:31

Sindresorhus

https://gist.github.com/sindresorhus/a39789f98801d908bbc7ff3ecc99d99c

Commented On 04 Oct 2022 at 03:51:31
Merge

Sindresorhus

Expose styles as variables

Resolves #565

Forked On 04 Oct 2022 at 03:51:11

Sindresorhus

```suggestion export const modifiers: readonly Modifiers[]; ```
On 04 Oct 2022 at 03:51:11

Sindresorhus

Expose styles as variables

Resolves #565

Merged On 04 Oct 2022 at 03:51:11

Sindresorhus

Commented On 04 Oct 2022 at 03:51:11
Issue Comment

Sindresorhus

Expose styles as variables

Resolves #565

Forked On 04 Oct 2022 at 03:50:27

Sindresorhus

This needs to be documented.

Commented On 04 Oct 2022 at 03:50:27

Sindresorhus

Expose styles as variables

Resolves #565

Merged On 04 Oct 2022 at 03:50:13

Sindresorhus

Commented On 04 Oct 2022 at 03:50:13
Merge

Sindresorhus

Expose styles as variables

Resolves #565

Forked On 04 Oct 2022 at 03:50:12

Sindresorhus

Need to export `colors` too. Combination of foreground and background.
On 04 Oct 2022 at 03:50:12

Sindresorhus

Update lint-files.js

Pushed On 03 Oct 2022 at 06:11:35

Sindresorhus

Update lint-files.js

Pushed On 03 Oct 2022 at 06:08:12
Issue Comment

Sindresorhus

Expose styles as variables?

A package I am maintaining chalk-pipe has a function to determine what type of style is passed in.

Currently Chalk only exposes the types of styles. But in my case, I want the variables.

https://github.com/LitoMore/chalk-pipe/blob/main/source/index.ts#L3-L23

Could we add some exports like this:

export const modifiers = ['rest', 'bold' , 'dim', ...];
export const colors = = ['black', 'red', 'green', ...]; 

Since we already documented which styles are supported in the readme. It's a good idea to expose these styles as variables.

Forked On 03 Oct 2022 at 05:11:31

Sindresorhus

Makes sense to me. I think we should also expose foregroundColor and backgroundColor individually, like in the types.

Commented On 03 Oct 2022 at 05:11:31

Sindresorhus

Fix typo

Pushed On 03 Oct 2022 at 04:25:09

Sindresorhus

Meta tweaks

Pushed On 03 Oct 2022 at 02:34:37

Sindresorhus

1.1.0

Pushed On 03 Oct 2022 at 02:34:37