sebmarkbage Github contribution chart
sebmarkbage Github Stats
sebmarkbage Most Used Languages

Activity

29 Sep 2022

Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:46:40

Sebmarkbage

This and cleanupAfterRender are for the general ReactDOMDispatcher. Not just Float. So seems like this shouldn't be in this specialized module.
On 29 Sep 2022 at 03:46:40

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:46:40

Sebmarkbage

Commented On 29 Sep 2022 at 03:46:40
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:43:48

Sebmarkbage

What's this comment? Is it a TODO?
On 29 Sep 2022 at 03:43:48

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:43:49

Sebmarkbage

Commented On 29 Sep 2022 at 03:43:49
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:41:29

Sebmarkbage

This is fine for now to keep these isolated but this is the kind of weird pattern we get from forcing a slice into a separate file like this. This would make more sense inline.
On 29 Sep 2022 at 03:41:29

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:41:30

Sebmarkbage

Commented On 29 Sep 2022 at 03:41:30
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:31:15

Sebmarkbage

prio.parentNode is always the same as document.head now right? ``` document.head.insertBefore(resourceEl, prior ? prior.nextSibling : head.firstChild); ```
On 29 Sep 2022 at 03:31:15

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:31:16

Sebmarkbage

Commented On 29 Sep 2022 at 03:31:16
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:25:25

Sebmarkbage

You can just stash the original promise instead of the chained one to avoid this.
On 29 Sep 2022 at 03:25:25

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:25:25

Sebmarkbage

Commented On 29 Sep 2022 at 03:25:25
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:23:42

Sebmarkbage

It might be worth putting these as globals to avoid having to create the extra closure. We're already polluting the namespace with a few other `$RX` variables. What's two more?
On 29 Sep 2022 at 03:23:42

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:23:43

Sebmarkbage

Commented On 29 Sep 2022 at 03:23:43
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:21:36

Sebmarkbage

This can be inlined.
On 29 Sep 2022 at 03:21:36

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:21:36

Sebmarkbage

Commented On 29 Sep 2022 at 03:21:36
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:19:28

Sebmarkbage

We're not expecting to call this very much. Maybe one or two times in the life time of the app. The code size matters more than the allocations/runtime. You might as well just initialize dependencies to an array here so you don't have to conditionally initialize it later.
On 29 Sep 2022 at 03:19:28

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:19:29

Sebmarkbage

Commented On 29 Sep 2022 at 03:19:29
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:14:32

Sebmarkbage

Why `thisDocument` instead of just `document`? It can't change, can it?
On 29 Sep 2022 at 03:14:32

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:14:32

Sebmarkbage

Commented On 29 Sep 2022 at 03:14:32
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 03:02:47

Sebmarkbage

This takes a snapshot of this once, but what happens if the client hydrates a sibling before this and start inserting links? Fiber can discover newly inserted links but how does the Fizz runtime discover something that Fiber inserted. Is there a case where it matters given that we don't guarantee sibling order? Seems like you could end up inserting something in mixed precedence order though. It might make sense to just query every time even though it's slower. It might help simplify the code too.
On 29 Sep 2022 at 03:02:47

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:11:04

Sebmarkbage

Commented On 29 Sep 2022 at 03:11:04

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 03:11:04

Sebmarkbage

Commented On 29 Sep 2022 at 03:11:04
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 02:51:41

Sebmarkbage

This doesn't make sense. This array is the hotest part so we definitely don't want to do anything that messes with its hidden class. Especially conditionally. I think we need to think about this some more.
On 29 Sep 2022 at 02:51:41

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 02:51:41

Sebmarkbage

Commented On 29 Sep 2022 at 02:51:41
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 02:36:59

Sebmarkbage

Maybe the relationship should be inverted here. You only need this code if you also have $RR but you always need $RC. How about instead emitting a command to call $RR which then calls $RC. So inverse the relationship. That way this condition doesn't exist here when you don't need it and you can simplify the code to listen to the result.
On 29 Sep 2022 at 02:36:59

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 02:37:00

Sebmarkbage

Commented On 29 Sep 2022 at 02:37:00
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 02:27:13

Sebmarkbage

Instead of making an inner function for flipBoundary you can just self-reference this function and call it again with the `suspenseBoundaryID` and this time without the `styleResources`.
On 29 Sep 2022 at 02:27:13

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 02:27:13

Sebmarkbage

Commented On 29 Sep 2022 at 02:27:13
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 02:26:01

Sebmarkbage

When we remove this we might cause some recalc to figure out how this applies to the tree and might need to reapply some selectors. It's probably better to do this at the same time we do the rest of the reveal. So this should move into flipBoundary.
On 29 Sep 2022 at 02:26:01

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Merged On 29 Sep 2022 at 02:26:01

Sebmarkbage

Commented On 29 Sep 2022 at 02:26:01
Merge

Sebmarkbage

[Fizz/Float] Float for stylesheet resources

Implementation of Float for Fizz and Client.

Will update with more detailed description as it gets closer to being ready

Forked On 29 Sep 2022 at 02:23:53

Sebmarkbage

Relatively to the small code, these closures add quite a bit of code. In this case you can move flipBoundary into the plain completeBoundary so you don't need a closure. It allocates once per complete call instead of once, but these will be very few calls and not long lived so it's not worth optimizing for. It creates an extra environment which isn't great neither.
On 29 Sep 2022 at 02:23:53