samccone Github contribution chart
samccone Github Stats
samccone Most Used Languages

Activity

19 Sep 2022

Issue Comment

Samccone

duplicate dt sections cause duplicate anchor tags to be generated breaking linking

URL for broken page

https://git-scm.com/docs/merge-strategies#Documentation/merge-strategies.txt-ours

Problem

There are two or more dt elements on the page with the same ID each one generates an anchor link that collides.

The following generated docs all had colliding link generation (which are now all fixed with this CL)

collision for Documentation/diff-options.txt-no
collision for Documentation/diff-options.txt-plain
collision for Documentation/git-cherry-pick.txt-codegitcherry-pickmastercode
collision for Documentation/git-config.txt-codecolumncode
collision for Documentation/git-diff-files.txt-no
collision for Documentation/git-diff-files.txt-plain
collision for Documentation/git-diff-index.txt-no
collision for Documentation/git-diff-index.txt-plain
collision for Documentation/git-diff-tree.txt-no
collision for Documentation/git-diff-tree.txt-plain
collision for Documentation/git-diff-tree.txt--s
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203-1
collision for Documentation/git-diff.txt-no
collision for Documentation/git-diff.txt-plain
collision for Documentation/git-fast-import.txt-Externaldataformat
collision for Documentation/git-fast-import.txt-Inlinedataformat
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode-1
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode-1
collision for Documentation/git-fetch.txt-codecode-1-1
collision for Documentation/git-log.txt-Defaultmode
collision for Documentation/git-log.txt---dense
collision for Documentation/git-log.txt---sparse
collision for Documentation/git-log.txt---simplify-merges
collision for Documentation/git-log.txt---ancestry-path
collision for Documentation/git-log.txt-no
collision for Documentation/git-log.txt-plain
collision for Documentation/git-merge.txt-ours
collision for Documentation/git-p4.txt---import-labels
collision for Documentation/git-pull.txt-ours
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode-1
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode-1
collision for Documentation/git-push.txt-codecode-1-1
collision for Documentation/git-push.txt-codegitpushorigincode
collision for Documentation/git-rebase.txt-ours
collision for Documentation/git-rev-list.txt-Defaultmode
collision for Documentation/git-rev-list.txt---dense
collision for Documentation/git-rev-list.txt---sparse
collision for Documentation/git-rev-list.txt---simplify-merges
collision for Documentation/git-rev-list.txt---ancestry-path
collision for Documentation/git-rev-parse.txt-emltrevgtem
collision for Documentation/git-rev-parse.txt-emltrev1gtltrev2gtem
collision for Documentation/git-rev-parse.txt-emltrevgtemegemHEADem
collision for Documentation/git-show.txt-no
collision for Documentation/git-show.txt-plain
collision for Documentation/git-svn.txt---ignore-refsltregexgt
collision for Documentation/git-svn.txt---ignore-pathsltregexgt
collision for Documentation/git-svn.txt---include-pathsltregexgt
collision for Documentation/git-svn.txt---parent
collision for Documentation/git-svn.txt--m
collision for Documentation/git-svn.txt--p
collision for Documentation/git-update-index.txt---cacheinfoltmodegtltobjectgtltpathgt
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Set-1-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unset-1-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Unspecified-1-1
collision for Documentation/gitattributes.txt-String
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Set-1-1
collision for Documentation/gitattributes.txt-Set-1-1-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unset-1-1
collision for Documentation/gitattributes.txt-Unset-1-1-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Unspecified-1-1
collision for Documentation/gitattributes.txt-Unspecified-1-1-1
collision for Documentation/gitattributes.txt-String
collision for Documentation/gitattributes.txt-String-1
collision for Documentation/gitremote-helpers.txt-emconnectem
collision for Documentation/gitremote-helpers.txt-emstateless-connectem
collision for Documentation/gitremote-helpers.txt-emexportem
collision for Documentation/gitrevisions.txt-emltrevgtem
collision for Documentation/gitrevisions.txt-emltrev1gtltrev2gtem
collision for Documentation/gitrevisions.txt-emltrevgtemegemHEADem
collision for Documentation/merge-strategies.txt-ours
collision for Documentation/rev-list-options.txt-Defaultmode
collision for Documentation/rev-list-options.txt---dense
collision for Documentation/rev-list-options.txt---sparse
collision for Documentation/rev-list-options.txt---simplify-merges
collision for Documentation/rev-list-options.txt---ancestry-path
collision for Documentation/revisions.txt-emltrevgtem
collision for Documentation/revisions.txt-emltrev1gtltrev2gtem
collision for Documentation/revisions.txt-emltrevgtemegemHEADem
collision for Documentation/technical/api-remote.txt-codenamecode
collision for Documentation/technical/api-trace2.txt-codeltevent-namegtcode 

#Documentation/merge-strategies.txt-ours

Operating system and browser

all

Steps to reproduce

visit the page click on the second ours section, reload the page, notice you are scrolled to the first ours section on the page.

Verification / testing steps

version=v2.23.0
GIT_REPO=../git/.git REBUILD_DOC=$version rake local_index | grep collision > collisions.txt
./script/server 
curl http://localhost:5000/docs/merge-strategies | grep merge-strategies.txt-ours 

Expected output when diffing vs the code before this fix:

<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours"></a>ours </dt>
+<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours-1"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours-1"></a>ours </dt>
-<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours"></a>ours </dt> 

_

Forked On 19 Sep 2022 at 10:38:26

Samccone

curl https://git-scm.com/docs/merge-strategies | grep merge-strategies.txt-ours

<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours"></a>ours </dt>
<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours"></a>ours </dt> 

Shows that this has not been deployed - @pedrorijo91 please let me know if there is anything else needed on my die.

Commented On 19 Sep 2022 at 10:38:26
Issue Comment

Samccone

duplicate dt sections cause duplicate anchor tags to be generated breaking linking

URL for broken page

https://git-scm.com/docs/merge-strategies#Documentation/merge-strategies.txt-ours

Problem

There are two or more dt elements on the page with the same ID each one generates an anchor link that collides.

The following generated docs all had colliding link generation (which are now all fixed with this CL)

collision for Documentation/diff-options.txt-no
collision for Documentation/diff-options.txt-plain
collision for Documentation/git-cherry-pick.txt-codegitcherry-pickmastercode
collision for Documentation/git-config.txt-codecolumncode
collision for Documentation/git-diff-files.txt-no
collision for Documentation/git-diff-files.txt-plain
collision for Documentation/git-diff-index.txt-no
collision for Documentation/git-diff-index.txt-plain
collision for Documentation/git-diff-tree.txt-no
collision for Documentation/git-diff-tree.txt-plain
collision for Documentation/git-diff-tree.txt--s
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203-1
collision for Documentation/git-diff.txt-no
collision for Documentation/git-diff.txt-plain
collision for Documentation/git-fast-import.txt-Externaldataformat
collision for Documentation/git-fast-import.txt-Inlinedataformat
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode-1
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode-1
collision for Documentation/git-fetch.txt-codecode-1-1
collision for Documentation/git-log.txt-Defaultmode
collision for Documentation/git-log.txt---dense
collision for Documentation/git-log.txt---sparse
collision for Documentation/git-log.txt---simplify-merges
collision for Documentation/git-log.txt---ancestry-path
collision for Documentation/git-log.txt-no
collision for Documentation/git-log.txt-plain
collision for Documentation/git-merge.txt-ours
collision for Documentation/git-p4.txt---import-labels
collision for Documentation/git-pull.txt-ours
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode-1
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode-1
collision for Documentation/git-push.txt-codecode-1-1
collision for Documentation/git-push.txt-codegitpushorigincode
collision for Documentation/git-rebase.txt-ours
collision for Documentation/git-rev-list.txt-Defaultmode
collision for Documentation/git-rev-list.txt---dense
collision for Documentation/git-rev-list.txt---sparse
collision for Documentation/git-rev-list.txt---simplify-merges
collision for Documentation/git-rev-list.txt---ancestry-path
collision for Documentation/git-rev-parse.txt-emltrevgtem
collision for Documentation/git-rev-parse.txt-emltrev1gtltrev2gtem
collision for Documentation/git-rev-parse.txt-emltrevgtemegemHEADem
collision for Documentation/git-show.txt-no
collision for Documentation/git-show.txt-plain
collision for Documentation/git-svn.txt---ignore-refsltregexgt
collision for Documentation/git-svn.txt---ignore-pathsltregexgt
collision for Documentation/git-svn.txt---include-pathsltregexgt
collision for Documentation/git-svn.txt---parent
collision for Documentation/git-svn.txt--m
collision for Documentation/git-svn.txt--p
collision for Documentation/git-update-index.txt---cacheinfoltmodegtltobjectgtltpathgt
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Set-1-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unset-1-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Unspecified-1-1
collision for Documentation/gitattributes.txt-String
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Set-1-1
collision for Documentation/gitattributes.txt-Set-1-1-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unset-1-1
collision for Documentation/gitattributes.txt-Unset-1-1-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Unspecified-1-1
collision for Documentation/gitattributes.txt-Unspecified-1-1-1
collision for Documentation/gitattributes.txt-String
collision for Documentation/gitattributes.txt-String-1
collision for Documentation/gitremote-helpers.txt-emconnectem
collision for Documentation/gitremote-helpers.txt-emstateless-connectem
collision for Documentation/gitremote-helpers.txt-emexportem
collision for Documentation/gitrevisions.txt-emltrevgtem
collision for Documentation/gitrevisions.txt-emltrev1gtltrev2gtem
collision for Documentation/gitrevisions.txt-emltrevgtemegemHEADem
collision for Documentation/merge-strategies.txt-ours
collision for Documentation/rev-list-options.txt-Defaultmode
collision for Documentation/rev-list-options.txt---dense
collision for Documentation/rev-list-options.txt---sparse
collision for Documentation/rev-list-options.txt---simplify-merges
collision for Documentation/rev-list-options.txt---ancestry-path
collision for Documentation/revisions.txt-emltrevgtem
collision for Documentation/revisions.txt-emltrev1gtltrev2gtem
collision for Documentation/revisions.txt-emltrevgtemegemHEADem
collision for Documentation/technical/api-remote.txt-codenamecode
collision for Documentation/technical/api-trace2.txt-codeltevent-namegtcode 

#Documentation/merge-strategies.txt-ours

Operating system and browser

all

Steps to reproduce

visit the page click on the second ours section, reload the page, notice you are scrolled to the first ours section on the page.

Verification / testing steps

version=v2.23.0
GIT_REPO=../git/.git REBUILD_DOC=$version rake local_index | grep collision > collisions.txt
./script/server 
curl http://localhost:5000/docs/merge-strategies | grep merge-strategies.txt-ours 

Expected output when diffing vs the code before this fix:

<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours"></a>ours </dt>
+<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours-1"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours-1"></a>ours </dt>
-<dt class="hdlist1" id="Documentation/merge-strategies.txt-ours"> <a class="anchor" href="#Documentation/merge-strategies.txt-ours"></a>ours </dt> 

_

Forked On 17 Sep 2022 at 08:27:43

Samccone

Merged, marking as fixed.

Commented On 17 Sep 2022 at 08:27:43
Issue Comment

Samccone

Handle colliding anchors in documentation pages

BUG=#1729

Changes

Addresses #1729

Forked On 17 Sep 2022 at 08:26:41

Samccone

Thank you for the review.

Commented On 17 Sep 2022 at 08:26:41
Issue Comment

Samccone

Handle colliding anchors in documentation pages

BUG=#1729

Changes

Addresses #1729

Forked On 17 Sep 2022 at 04:06:14

Samccone

That is correct, each colliding anchor now gets -1 appended until no further collusions are encountered.

Commented On 17 Sep 2022 at 04:06:14

Samccone

Handle colliding anchors in documentation pages. Add -1 to the anchor until we are no longer colliding with existing known anchors on the page.

BUG=#1729

Pushed On 11 Sep 2022 at 08:42:15
Issue Comment

Samccone

duplicate dt sections cause duplicate anchor tags to be generated breaking linking

URL for broken page

https://git-scm.com/docs/merge-strategies#Documentation/merge-strategies.txt-ours

Problem

There are two or more dt elements on the page with the same ID each one generates an anchor link that collides.

The following generated docs all had colliding link generation (which are now all fixed with this CL)

collision for Documentation/diff-options.txt-no
collision for Documentation/diff-options.txt-plain
collision for Documentation/git-cherry-pick.txt-codegitcherry-pickmastercode
collision for Documentation/git-config.txt-codecolumncode
collision for Documentation/git-diff-files.txt-no
collision for Documentation/git-diff-files.txt-plain
collision for Documentation/git-diff-index.txt-no
collision for Documentation/git-diff-index.txt-plain
collision for Documentation/git-diff-tree.txt-no
collision for Documentation/git-diff-tree.txt-plain
collision for Documentation/git-diff-tree.txt--s
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203
collision for Documentation/git-diff.txt-emgitdiffemltoptionsgtltcommitgtltcommitgt--ltpathgt82308203-1
collision for Documentation/git-diff.txt-no
collision for Documentation/git-diff.txt-plain
collision for Documentation/git-fast-import.txt-Externaldataformat
collision for Documentation/git-fast-import.txt-Inlinedataformat
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode-1
collision for Documentation/git-fetch.txt-codecode
collision for Documentation/git-fetch.txt-codecode-1
collision for Documentation/git-fetch.txt-codecode-1-1
collision for Documentation/git-log.txt-Defaultmode
collision for Documentation/git-log.txt---dense
collision for Documentation/git-log.txt---sparse
collision for Documentation/git-log.txt---simplify-merges
collision for Documentation/git-log.txt---ancestry-path
collision for Documentation/git-log.txt-no
collision for Documentation/git-log.txt-plain
collision for Documentation/git-merge.txt-ours
collision for Documentation/git-p4.txt---import-labels
collision for Documentation/git-pull.txt-ours
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode-1
collision for Documentation/git-push.txt-codecode
collision for Documentation/git-push.txt-codecode-1
collision for Documentation/git-push.txt-codecode-1-1
collision for Documentation/git-push.txt-codegitpushorigincode
collision for Documentation/git-rebase.txt-ours
collision for Documentation/git-rev-list.txt-Defaultmode
collision for Documentation/git-rev-list.txt---dense
collision for Documentation/git-rev-list.txt---sparse
collision for Documentation/git-rev-list.txt---simplify-merges
collision for Documentation/git-rev-list.txt---ancestry-path
collision for Documentation/git-rev-parse.txt-emltrevgtem
collision for Documentation/git-rev-parse.txt-emltrev1gtltrev2gtem
collision for Documentation/git-rev-parse.txt-emltrevgtemegemHEADem
collision for Documentation/git-show.txt-no
collision for Documentation/git-show.txt-plain
collision for Documentation/git-svn.txt---ignore-refsltregexgt
collision for Documentation/git-svn.txt---ignore-pathsltregexgt
collision for Documentation/git-svn.txt---include-pathsltregexgt
collision for Documentation/git-svn.txt---parent
collision for Documentation/git-svn.txt--m
collision for Documentation/git-svn.txt--p
collision for Documentation/git-update-index.txt---cacheinfoltmodegtltobjectgtltpathgt
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Set-1-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unset-1-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Unspecified-1-1
collision for Documentation/gitattributes.txt-String
collision for Documentation/gitattributes.txt-Set
collision for Documentation/gitattributes.txt-Set-1
collision for Documentation/gitattributes.txt-Set-1-1
collision for Documentation/gitattributes.txt-Set-1-1-1
collision for Documentation/gitattributes.txt-Unset
collision for Documentation/gitattributes.txt-Unset-1
collision for Documentation/gitattributes.txt-Unset-1-1
collision for Documentation/gitattributes.txt-Unset-1-1-1
collision for Documentation/gitattributes.txt-Unspecified
collision for Documentation/gitattributes.txt-Unspecified-1
collision for Documentation/gitattributes.txt-Unspecified-1-1
collision for Documentation/gitattributes.txt-Unspecified-1-1-1
collision for Documentation/gitattributes.txt-String
collision for Documentation/gitattributes.txt-String-1
collision for Documentation/gitremote-helpers.txt-emconnectem
collision for Documentation/gitremote-helpers.txt-emstateless-connectem
collision for Documentation/gitremote-helpers.txt-emexportem
collision for Documentation/gitrevisions.txt-emltrevgtem
collision for Documentation/gitrevisions.txt-emltrev1gtltrev2gtem
collision for Documentation/gitrevisions.txt-emltrevgtemegemHEADem
collision for Documentation/merge-strategies.txt-ours
collision for Documentation/rev-list-options.txt-Defaultmode
collision for Documentation/rev-list-options.txt---dense
collision for Documentation/rev-list-options.txt---sparse
collision for Documentation/rev-list-options.txt---simplify-merges
collision for Documentation/rev-list-options.txt---ancestry-path
collision for Documentation/revisions.txt-emltrevgtem
collision for Documentation/revisions.txt-emltrev1gtltrev2gtem
collision for Documentation/revisions.txt-emltrevgtemegemHEADem
collision for Documentation/technical/api-remote.txt-codenamecode
collision for Documentation/technical/api-trace2.txt-codeltevent-namegtcode 

#Documentation/merge-strategies.txt-ours

Operating system and browser

all

Steps to reproduce

visit the page click on the second ours section, reload the page, notice you are scrolled to the first ours section on the page.

Forked On 11 Sep 2022 at 08:42:14

Samccone

The change has been updated to now account for both codepaths!

Commented On 11 Sep 2022 at 08:42:14
Issue Comment

Samccone

duplicate dt sections cause duplicate anchor tags to be generated breaking linking

URL for broken page

https://git-scm.com/docs/merge-strategies#Documentation/merge-strategies.txt-ours

Problem

There are two ours dt elements on the page, each one generates an anchor link of

#Documentation/merge-strategies.txt-ours

Operating system and browser

all

Steps to reproduce

visit the page click on the second ours section, reload the page, notice you are scrolled to the first ours section on the page.

Forked On 11 Sep 2022 at 06:56:43

Samccone

Further digging shows that this is a somewhat known problem https://github.com/asciidoctor/asciidoctor/issues/3147

The solution implemented here only works inside of index_l10n_doc which means for all non-internationalized docs the headers will still collide.

Commented On 11 Sep 2022 at 06:56:43

Samccone

Handle colliding anchors in documentation pages. Add -1 to the anchor until we are no longer colliding with existing known anchors on the page.

BUG=#1729

Pushed On 10 Sep 2022 at 11:31:57

Samccone

Handle colliding anchors in documentation pages

Created On 10 Sep 2022 at 11:26:55
Create Branch
Samccone In samccone/git-scm.com Create Branchfix-anchors

Samccone

The git-scm.com website. Note that this repository is only for the website; issues with git itself should go to https://git-scm.com/community.

On 10 Sep 2022 at 11:26:02

Samccone

The git-scm.com website. Note that this repository is only for the website; issues with git itself should go to https://git-scm.com/community.

Forked On 10 Sep 2022 at 10:56:44
Issue Comment

Samccone

Add `process.stdin`, `process.stdout` and `process.stderr`

What is the problem this feature will solve?

It will allow more compatibility with node.js programs and make it easy(or maybe even stop it from being impossible) to receive user input.

What is the feature you are proposing to solve the problem?

Adding More support for process.stdin and process.stdout (specifically, process.stdin.on("data", ()=>{...} and process.stdout.write("..."))

What alternatives have you considered?

I have no fix for stdin so far, stdout I could maybe store all my lines in a string and log them whenever (would still always end in a newline, but would fix writing chars without an automatic newline)

Forked On 04 Sep 2022 at 08:55:36

Samccone

Shimming my global process.stderr does the trick in my case: (your mileage might vary)

if (typeof process.stderr == "undefined") {
  process.stderr = Bun.stderr;
} 

Commented On 04 Sep 2022 at 08:55:36
Issue Comment

Samccone

Buffer calls without new raise a type error in bun vs node 💥

Version

0.1.10

Platform

21.6.0 Darwin Kernel Version 21.6.0: Sat Jun 18 17:07:22 PDT 2022; root:xnu-8020.140.41~1/RELEASE_ARM64_T6000 arm64

What steps will reproduce the bug?

foo.js

Buffer([]) 

node foo.js 

vs

bun foo.js 

How often does it reproduce? Is there a required condition?

100% of the time

What is the expected behavior?

does not raise a type error

What do you see instead?

1 | Buffer([]);                                                                                                                                                                      │~                                                                                                                                                                                   
   ^                                                                                                                                                                                 │~                                                                                                                                                                                   
TypeError: Constructor requires 'new' operator                                                                                                                                       │~                                                                                                                                                                                   
      at /Users/samccone/repos/deconstructed/repo.js:1:0 

Additional information

No response

Forked On 02 Sep 2022 at 01:58:58

Samccone

confirmed this does not reproduce on canary v 0.1.11

Commented On 02 Sep 2022 at 01:58:58
Issue Comment

Samccone

Make it easier to get a Node.js profile from an action spawn

When looking at a Bazel profile, the subprocesses are big black boxes. When you spend 30s running an ngc action, you really want to know what's taking the time in there.

This could be something like bazel build --action_env=JS__DUMP_NODE_TRACE=//that:binary (along with making sure that action isn't a cache hit) to find out why that binary is slow.

Note: for tsc we have a great facility because they have --diagnostics and --extendedDiagnostics. Some bundlers have profilers built-in too, like @samccone did for Webpack).

Forked On 08 Aug 2022 at 05:35:04

Samccone

Do we have any (more) options if we were to use sandboxing? https://bazel.build/docs/sandboxing

Commented On 08 Aug 2022 at 05:35:04
Issue Comment

Samccone

Make it easier to get a Node.js profile from an action spawn

When looking at a Bazel profile, the subprocesses are big black boxes. When you spend 30s running an ngc action, you really want to know what's taking the time in there.

This could be something like bazel build --action_env=JS__DUMP_NODE_TRACE=//that:binary (along with making sure that action isn't a cache hit) to find out why that binary is slow.

Note: for tsc we have a great facility because they have --diagnostics and --extendedDiagnostics. Some bundlers have profilers built-in too, like @samccone did for Webpack).

Forked On 08 Aug 2022 at 04:54:28

Samccone

This would be fantastic.

Some resources:

  • https://nodejs.org/api/tracing.html
  • https://nodejs.org/en/docs/guides/simple-profiling/

Does Bazel give us the ability to instrument and trace network requests as well from subprocesses as well? If so .. having network information would also be an amazing powertool.

Commented On 08 Aug 2022 at 04:54:28