saitonakamura Github contribution chart
saitonakamura Github Stats
saitonakamura Most Used Languages

Activity

05 Oct 2022

Saitonakamura

WIP: move to scoped pixi

Created On 05 Oct 2022 at 12:31:26
Create Branch
Saitonakamura In wisebits-tech/react-pixi Create Branchmove-to-scoped-pixi

Saitonakamura

Write PIXI apps using React declarative style

On 05 Oct 2022 at 12:30:33

Saitonakamura

RFC: v9 goals

Let's discuss some v9 goals here. These are all tentative right now.

Completed

  • [x] Add stage-based lifecycle, deprecate useFrame for useUpdate https://github.com/pmndrs/react-three-fiber/pull/2279
  • [x] Remove onUpdate prop https://github.com/pmndrs/react-three-fiber/pull/2480
  • [x] Remove updateStyle from Size https://github.com/pmndrs/react-three-fiber/pull/2489
  • [x] act types for testing https://github.com/pmndrs/react-three-fiber/pull/2492
  • [x] Instance descriptors, refactor JSX types & extend https://github.com/pmndrs/react-three-fiber/pull/2465
  • [x] prefer named functions, for loops in hot paths https://github.com/pmndrs/react-three-fiber/pull/2540 (backported in v8.8.7)

TODO

  • [ ] respect React.StrictMode across renderers #2547

Pending

  • [ ] Update demand frameloop mode to keep updating delta even if it skips render. Be sure to test all frameloop modes with the useUpdate changes.
  • [ ] ? Refactor color space API (see https://github.com/pmndrs/react-three-fiber/issues/2299)
  • [ ] ? Add cpuFrameTime and gpuFrameTime for performance based rendering

Forked On 05 Oct 2022 at 11:03:02

Saitonakamura

Yeah, I think so. When upgrading to r3f v8 I erroneously update zustand to v4. I had to revert back of course but not until I had some fair share of migration experience

Commented On 05 Oct 2022 at 11:03:02

Saitonakamura

update stuff

Pushed On 04 Oct 2022 at 01:34:36

Saitonakamura

Automatically add provided reference space type to optionalFeatures

Created On 04 Oct 2022 at 01:23:45
Issue Comment

Saitonakamura

Mesh are not showing when ReferenceSpace is set to local-floor

Hello,

I'm trying to use an XR Session with referenceSpace set to 'local-floor' (default value). But it seems that all of my mesh are only showing with a referenceSpace of 'local', but then my AR session is setting ground level to the current height of the phone when the sessions is created.

Am I doing something wrong ? Do I need to add a function that use useHitTest, get the results and then update the current MatrixProjection from those results to set the current level floor ?

I feel that I'm not getting "the full picture" of the problem and maybe need some additional knowledge. If so, I'm sorry !

Thanks in advance,

EDIT: I just realized that I'm getting an error as the local-floor reference space is not supported for the session. Any ideas ?

Forked On 04 Oct 2022 at 01:23:14

Saitonakamura

I think it's a good idea to automatically add selected reference space type to optional features

Commented On 04 Oct 2022 at 01:23:14
Create Branch
Saitonakamura In wisebits-tech/react-xr Create Branchsync-reference-space-type

Saitonakamura

🤳 VR/AR with react-three-fiber

On 04 Oct 2022 at 01:22:40

Saitonakamura

fix: fixed outdated callbacks (#183)

Pushed On 04 Oct 2022 at 12:57:14

Saitonakamura

v5.0.1

Pushed On 04 Oct 2022 at 12:57:14

Saitonakamura

chore(docs): fix deprecated components (#184)

Pushed On 04 Oct 2022 at 12:57:14

Saitonakamura

fix(XR): purge session cache on exit (#188)

Pushed On 04 Oct 2022 at 12:57:14

Saitonakamura

v5.0.2

Pushed On 04 Oct 2022 at 12:57:14

Saitonakamura

fix(XR): eagerly call sessionstart when late (#191)

Pushed On 04 Oct 2022 at 12:57:14

Saitonakamura

v5.0.3

Pushed On 04 Oct 2022 at 12:57:14

Saitonakamura

move to keychain from ssh-agent

Pushed On 04 Oct 2022 at 11:45:41
Issue Comment

Saitonakamura

Version 6.5.4's MSDF font rendering is broken

image

I believe this PR breaks MSDF font rendering: https://github.com/pixijs/pixijs/pull/8652/

You can see in 6.5.3, the MSDF font is rendered very crispy and clear. After upgrading to 6.5.4, the font rendering is very blurry.

Forked On 04 Oct 2022 at 08:34:20

Saitonakamura

Yeah, it looks like those grey rectangles, but not over the whole symbol, rather on the edges

Commented On 04 Oct 2022 at 08:34:20

Saitonakamura

Testing SSH signing

Pushed On 03 Oct 2022 at 06:23:39

Saitonakamura

git config

Pushed On 03 Oct 2022 at 06:20:48

Saitonakamura

RFC: v9 goals

Let's discuss some v9 goals here. These are all tentative right now.

Completed

  • [x] Add stage-based lifecycle, deprecate useFrame for useUpdate https://github.com/pmndrs/react-three-fiber/pull/2279
  • [x] Remove onUpdate prop https://github.com/pmndrs/react-three-fiber/pull/2480
  • [x] Remove updateStyle from Size https://github.com/pmndrs/react-three-fiber/pull/2489
  • [x] act types for testing https://github.com/pmndrs/react-three-fiber/pull/2492
  • [x] Instance descriptors, refactor JSX types & extend https://github.com/pmndrs/react-three-fiber/pull/2465
  • [x] prefer named functions, for loops in hot paths https://github.com/pmndrs/react-three-fiber/pull/2540 (backported in v8.8.7)

TODO

  • [ ] respect React.StrictMode across renderers #2547

Pending

  • [ ] Update demand frameloop mode to keep updating delta even if it skips render. Be sure to test all frameloop modes with the useUpdate changes.
  • [ ] ? Refactor color space API (see https://github.com/pmndrs/react-three-fiber/issues/2299)
  • [ ] ? Add cpuFrameTime and gpuFrameTime for performance based rendering

Forked On 03 Oct 2022 at 02:00:39

Saitonakamura

What are your thoughts on updating to zustand v4?

Commented On 03 Oct 2022 at 02:00:39

Saitonakamura

git config split

Pushed On 02 Oct 2022 at 07:52:55

Saitonakamura

signers

Pushed On 02 Oct 2022 at 07:32:15

Saitonakamura

test sign

Pushed On 02 Oct 2022 at 07:24:33
Issue Comment

Saitonakamura

Exit VR button is not working

  • Enter VR works, but after quit the VR scene, Exit VR button does not work.
  • onMove of Interaction is a really good feature, but state update is not working inside this function. In the earlier version, state update was working properly, just there was no onMove method, so I had to find the intersection point in useFrame with hoverState while controllers moving.

Forked On 28 Sep 2022 at 12:34:21

Saitonakamura

You may want to update to update to https://github.com/pmndrs/react-xr/releases/tag/v5.0.1 for proper onMove

Commented On 28 Sep 2022 at 12:34:21
Issue Comment

Saitonakamura

GSAP and framer-motion-3d animations don't work

We've been building a VR game with @react-three/vr which is an absolute blast. We have found some issues where GSAP and framer-motion-3d don't work. That may be because they use requestAnimationFrame, but we're not sure.

Does anyone know why this doesn't work and can we help to fix this? :)

Forked On 26 Sep 2022 at 03:26:42

Saitonakamura

@meesrutten does that ^ helps?

Commented On 26 Sep 2022 at 03:26:42
Issue Comment

Saitonakamura

Interactive component high CPU usage when wrapping large models

When wrapping large/ complex models in the very useful Interactive component the CPU usage increases a lot. This causes stuttering in VR headsets and laptop fans to go crazy. This doesn't happen with simple models.

  • After clicking the Enter VR button, Chrome taskmanager indicates that the tab is using around 20% CPU.
  • Hovering over the simple cube wrapped with an interactive component increases the CPU usage to ~25%.
  • Hovering over the complex cube wrapped with an interactive component increases the CPU usage to ~90%.

simple cube: 2 KB, 24 vertices complex cube: 12 MB, 280.260 vertices

The more complex the model, the more heavy it becomes when wrapped within an Interactive component and hovered with the controller ray.

See the used cubes and try it out using this repo: https://github.com/Korben3/inter-example

image

Forked On 26 Sep 2022 at 03:25:11

Saitonakamura

There's also https://github.com/pmndrs/drei#meshbounds by the way. I'm closing this for now since I'm not sure about simple cube cpu consumption (if you have a repro however I'm willing to investigate) and I'm not sure if anything can be done on the react-xr side to prevent cpu consumption with complex objects

Commented On 26 Sep 2022 at 03:25:11

Saitonakamura

Added limassol

Created On 26 Sep 2022 at 02:57:24

Saitonakamura

Added limassol

Pushed On 26 Sep 2022 at 02:57:14

Saitonakamura

BeerJS: International JavaScript Community Meta Page

Forked On 26 Sep 2022 at 02:54:54
Issue Comment

Saitonakamura

Limassol request

New Chapter Request

Where will your community be located: city, state/province/etc, country?

Cyrpus, Limassol /limassol

Who will be your admins?

just me for now, @saitonakamura

Do you have twitter handles I can include in announcing your new chapter?

Sure, https://twitter.com/SaitoNakamura

Forked On 26 Sep 2022 at 02:54:44

Saitonakamura

Awesome, thanks

Commented On 26 Sep 2022 at 02:54:44

Saitonakamura

Update README.md

Pushed On 26 Sep 2022 at 02:54:14

Saitonakamura

BeerJS: Reno, NV, US | Star and Watch for updates

Forked On 26 Sep 2022 at 02:49:29