robvk Github contribution chart
robvk Github Stats
robvk Most Used Languages

Activity

02 Oct 2022

Robvk

Here are the week4 exercises and tests
Forked On 02 Oct 2022 at 08:17:16

Robvk

This does not test that the function does not modify the original fruitBasket, you are not even calling the function. Think again
On 02 Oct 2022 at 08:17:16

Robvk

Here are the week4 exercises and tests
Forked On 02 Oct 2022 at 08:16:23

Robvk

Why are these empty comment lines here?
On 02 Oct 2022 at 08:16:23

Robvk

Here are the week4 exercises and tests
Forked On 02 Oct 2022 at 08:15:33

Robvk

`i` is not a good variable name
On 02 Oct 2022 at 08:15:33

Robvk

Here are the week4 exercises and tests
Forked On 02 Oct 2022 at 08:16:35

Robvk

You can remove this and all other TODO lines as well
On 02 Oct 2022 at 08:16:35

Robvk

Here are the week4 exercises and tests
Forked On 02 Oct 2022 at 08:16:03

Robvk

Nice solution!
On 02 Oct 2022 at 08:16:03

Robvk

Here are the week4 exercises and tests
Forked On 02 Oct 2022 at 08:15:19

Robvk

Why did you comment out this code? Also why create a new function definition? You should add your code in the provided function
On 02 Oct 2022 at 08:15:19

Robvk

Here are the week4 exercises and tests
Merged On 02 Oct 2022 at 08:17:52

Robvk

Couple issues to fix and I am also missing exercise 5. Please add it and fix the issues

Commented On 02 Oct 2022 at 08:17:52

Robvk

Here are the week4 exercises and tests
Merged On 02 Oct 2022 at 08:17:51

Robvk

Couple issues to fix and I am also missing exercise 5. Please add it and fix the issues

Commented On 02 Oct 2022 at 08:17:51

Robvk

Eda Uludag week4 Homework
Forked On 02 Oct 2022 at 08:12:47

Robvk

Why did you duplicate this? It is not needed
On 02 Oct 2022 at 08:12:47

Robvk

Eda Uludag week4 Homework
Forked On 02 Oct 2022 at 08:13:02

Robvk

Very clean!
On 02 Oct 2022 at 08:13:02

Robvk

Eda Uludag week4 Homework
Forked On 02 Oct 2022 at 08:12:22

Robvk

This does not test that the original fruitBasket array is not changed, you are not even calling the function. Take another look
On 02 Oct 2022 at 08:12:22

Robvk

Eda Uludag week4 Homework
Forked On 02 Oct 2022 at 08:11:11

Robvk

Beautiful code 🤩
On 02 Oct 2022 at 08:11:11

Robvk

Eda Uludag week4 Homework
Merged On 02 Oct 2022 at 08:13:36

Robvk

Two things to look at and you are done! This is the type of homework I love to see, cleaaaaan! Well done

Commented On 02 Oct 2022 at 08:13:36

Robvk

Eda Uludag week4 Homework
Merged On 02 Oct 2022 at 08:13:36

Robvk

Two things to look at and you are done! This is the type of homework I love to see, cleaaaaan! Well done

Commented On 02 Oct 2022 at 08:13:36

Robvk

Alan Hussain w4 JavaScript
Forked On 02 Oct 2022 at 08:04:31

Robvk

Although on one line this is very hard to read and understand quickly. Sometimes it is better to just write it out, so something like: ``` const totalTasks = mondayTasks.map((task) => { if (typeof task.duration === 'number') { return task.duration / 60; } }) ``` This would also help point you to a bug here. If the duration is not a number this would return a `false` and then it would break in your `reduce` statement as it tries to add `false` to a number. In the above case it is more obvious that you need to do something if the duration is not a number. When starting to code I would add the rule that you do not do this kind of && logic until you get to React as it makes it overly complicated.
On 02 Oct 2022 at 08:04:31

Robvk

Alan Hussain w4 JavaScript
Merged On 02 Oct 2022 at 08:10:14

Robvk

A couple of things left to do. Also, for next homework make sure to first checkout main before creating your branch so only that weeks homework is in the PR.

Commented On 02 Oct 2022 at 08:10:14

Robvk

Alan Hussain w4 JavaScript
Forked On 02 Oct 2022 at 07:55:20

Robvk

Clean!
On 02 Oct 2022 at 07:55:20

Robvk

Alan Hussain w4 JavaScript
Forked On 02 Oct 2022 at 08:05:25

Robvk

This does not test that the original is not modified, you are not even calling the function
On 02 Oct 2022 at 08:05:25

Robvk

Alan Hussain w4 JavaScript
Merged On 02 Oct 2022 at 08:10:14

Robvk

A couple of things left to do. Also, for next homework make sure to first checkout main before creating your branch so only that weeks homework is in the PR.

Commented On 02 Oct 2022 at 08:10:14

Robvk

Update README.md

Make it clearer that Conway's Game of Life is the prep exercise

Pushed On 29 Sep 2022 at 01:21:37

Robvk

Fix systeminformation breaking change

Pushed On 29 Sep 2022 at 01:20:36

Robvk

Fix breaking dependency change

Pushed On 29 Sep 2022 at 01:20:36

Robvk

Add warning comment

Pushed On 29 Sep 2022 at 01:20:36

Robvk

Merge branch 'HackYourFuture:main' into main

Pushed On 29 Sep 2022 at 01:20:36

Robvk

Update hashes

Pushed On 29 Sep 2022 at 01:20:36

Robvk

Merge pull request #86 from remarcmij/main

Fix breaking dependencies

Pushed On 29 Sep 2022 at 01:20:36

Robvk

Fix breaking dependencies

Created On 29 Sep 2022 at 01:20:35

Robvk

Fix breaking dependencies

Created On 29 Sep 2022 at 07:58:58

Robvk

Fix breaking dependencies

Pushed On 29 Sep 2022 at 07:58:58

Robvk

Merge pull request #22 from HackYourHomework/fix-dependencies

Fix breaking dependencies

Pushed On 29 Sep 2022 at 07:58:58

Robvk

Edajavascript-week3-homework
Forked On 27 Sep 2022 at 09:51:48

Robvk

Hi @Eda96 , I am still missing the test results. Could you please add them

Commented On 27 Sep 2022 at 09:51:48

Robvk

mohammed_alqayahdi-w3-JavaScript

I tried to solve all the exercises,

Forked On 27 Sep 2022 at 09:51:12

Robvk

Hi @alqayadhi, I am still missing the test results and question 5

Commented On 27 Sep 2022 at 09:51:12

Robvk

George Abdallah -homework javascript week 3

Created On 27 Sep 2022 at 09:43:18

Robvk

Revert "Use getName function as otherwise it is undefined"

This reverts commit 21737f717c5c96d8d4a33e3e55af810d7dac8a9b.

Pushed On 27 Sep 2022 at 07:56:21

Robvk

Use getName function as otherwise it is undefined

Pushed On 26 Sep 2022 at 01:40:56