robinheinze Github contribution chart
robinheinze Github Stats
robinheinze Most Used Languages

Activity

03 Oct 2022

Robinheinze

Ignite v8: Maverick

This will be the draft PR for Ignite v8, code-named Maverick.

Milestone (more info here): https://github.com/infinitered/ignite/milestone/19

Merged On 26 Sep 2022 at 06:40:48

Robinheinze

💯

Commented On 26 Sep 2022 at 06:40:48
Issue Comment

Robinheinze

testing and mocking apisauce examples

Hello

We have recently investigating React Native for cross-platform mobile development and been using this awesome library. I am in the point of investigating unit testing and trying to mock the async of apisauce in my Redux's Actions.

I followed the recommended approach in Redux Writing Test documentation here with no success. My JS is level is pretty beginner and was wondering if anyone using this library can share what you did for testing/mocking Actions in Redux.

Forked On 20 Sep 2022 at 09:23:21

Robinheinze

@skellock I just used this example 5 years later 😆

Commented On 20 Sep 2022 at 09:23:21

Robinheinze

Feat/design updates

Please verify the following:

  • [ ] yarn ci:test jest tests pass with new tests, if relevant
  • [ ] README.md has been updated with your changes, if relevant

Describe your PR

Forked On 14 Sep 2022 at 10:08:28

Robinheinze

Since this is not a border, I would not use `colors.border`. If this is only used in this component and doesn't represent an intentional design choice to make all "inactive elements" this color throughout the app, then I think it's fine to use palette.
On 14 Sep 2022 at 10:08:28

Robinheinze

Feat/design updates

Please verify the following:

  • [ ] yarn ci:test jest tests pass with new tests, if relevant
  • [ ] README.md has been updated with your changes, if relevant

Describe your PR

Merged On 14 Sep 2022 at 10:08:28

Robinheinze

Commented On 14 Sep 2022 at 10:08:28

Robinheinze

feat(boilerplate): add empty state component to demoPodcastListScreen

Please verify the following:

  • [ ] yarn ci:test jest tests pass with new tests, if relevant
  • [ ] README.md has been updated with your changes, if relevant

Describe your PR

Per issue #2079 ListEmptyComponent prop is added to show an empty state component when the podcasts list is somehow not loaded. Note that the design is temporary.

Photos/Videos

|Empty state component| Overall flow| |-|-| ||CleanShot 2022-09-01 at 09 26 11|

Issue

A. As you can see here when the app is loaded for the first time the empty state component will show up for a few seconds but not on reload. B. When there are no favorite items the component will also show up - working on fixing this

|Issue A|Issue B| |-|-| |CleanShot 2022-09-01 at 09 21 06||

Merged On 08 Sep 2022 at 07:59:11

Robinheinze

Looks great!

Commented On 08 Sep 2022 at 07:59:11
Issue Comment

Robinheinze

[Maverick] Generators should not nest files by default

Describe the bug

Currently, generators nest models, components, etc in named folders in ./app/models/<folder>/<file>. Remove the <folder> by default and use frontmatter to customize this.

Ignite version

Maverick

Additional info

No

Forked On 02 Sep 2022 at 08:29:49

Robinheinze

Fixed by #2111

Commented On 02 Sep 2022 at 08:29:49
Issue Comment

Robinheinze

[Maverick] Update generated file names to be CamelCase instead of kebab-case

model.ts ---> Model.ts component.tsx ---> Component.tsx name-screen.tsx ---> NameScreen.tsx

Forked On 02 Sep 2022 at 08:29:07

Robinheinze

Fixed by #2115

Commented On 02 Sep 2022 at 08:29:07
Issue Comment

Robinheinze

feat(boilerplate): add empty state component to demoPodcastListScreen

Please verify the following:

  • [ ] yarn ci:test jest tests pass with new tests, if relevant
  • [ ] README.md has been updated with your changes, if relevant

Describe your PR

Per issue #2079 ListEmptyComponent prop is added to show an empty state component when the podcasts list is somehow not loaded. Note that the design is temporary.

Photos/Videos

|Empty state component| Overall flow| |-|-| ||CleanShot 2022-09-01 at 09 26 11|

Issue

A. As you can see here when the app is loaded for the first time the empty state component will show up for a few seconds but not on reload. B. When there are no favorite items the component will also show up - working on fixing this

|Issue A|Issue B| |-|-| |CleanShot 2022-09-01 at 09 21 06||

Forked On 02 Sep 2022 at 08:27:16

Robinheinze

@kateinkim For Issue A, I think it would make more sense to have a loading state. So when we start to fetch episodes, set a loading flag to true, then to false once we've finished fetching. Then in the empty state, we show the loading spinner if that loading flag is true, and otherwise we can show the empty state. So it only shows if we tried to load data and didn't get any. Does that make sense?

Commented On 02 Sep 2022 at 08:27:16

Robinheinze

Change generator filenames to pascal case (#2115)

Pushed On 02 Sep 2022 at 08:06:49

Robinheinze

Change generator filenames to pascal case

Created On 02 Sep 2022 at 08:06:47

Robinheinze

Change generator filenames to pascal case

Created On 02 Sep 2022 at 06:57:56
Create Branch
Robinheinze In infinitered/ignite Create Branchgenerator-casing

Robinheinze

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more!

On 02 Sep 2022 at 06:56:38

Robinheinze

Remove deep nesting from generators (#2111)

Pushed On 02 Sep 2022 at 06:03:41

Robinheinze

Remove deep nesting from generators

Created On 02 Sep 2022 at 06:03:39
Issue Comment

Robinheinze

Remove deep nesting from generators

Please verify the following:

  • [x] yarn ci:test jest tests pass with new tests, if relevant
  • [x] README.md has been updated with your changes, if relevant

Describe your PR

By default, we are moving away from deeply nested structure, so this moves generated components, models, and screens out of their individual named folders and into the relevant root folder instead.

If the user prefers it the old way, the templates can be updated using front-matter and the destinationDir property:

destinationDir: app/models/<%= props.kebabCaseName %>/<%= props.kebabCaseName %>\" 

Visuals

Forked On 02 Sep 2022 at 06:03:31

Robinheinze

Actually, I think I will do that in a separate PR since it's a fairly substantial change and I don't want to hold this part up in case i don't finish before EOD.

Commented On 02 Sep 2022 at 06:03:31
Issue Comment

Robinheinze

Remove deep nesting from generators

Please verify the following:

  • [x] yarn ci:test jest tests pass with new tests, if relevant
  • [x] README.md has been updated with your changes, if relevant

Describe your PR

By default, we are moving away from deeply nested structure, so this moves generated components, models, and screens out of their individual named folders and into the relevant root folder instead.

If the user prefers it the old way, the templates can be updated using front-matter and the destinationDir property:

destinationDir: app/models/<%= props.kebabCaseName %>/<%= props.kebabCaseName %>\" 

Visuals

Forked On 02 Sep 2022 at 06:02:16

Robinheinze

@cdanwards that's a great point. I think we should match the new pattern. I'll update this PR to do that as well.

Commented On 02 Sep 2022 at 06:02:16

Robinheinze

Remove deep nesting from generators

Created On 01 Sep 2022 at 10:23:31
Create Branch
Robinheinze In infinitered/ignite Create Branchfix/generator-nesting

Robinheinze

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more!

On 01 Sep 2022 at 10:14:51