rmariuzzo Github contribution chart
rmariuzzo Github Stats
rmariuzzo Most Used Languages

Activity

03 Oct 2022

Issue Comment

Rmariuzzo

Is this support in React 18?

I am worried if this feature is still supported in React version 18?

Forked On 03 Oct 2022 at 07:22:01

Rmariuzzo

This week I will triage issues, then next week will try to fix/improve anything needed.

Commented On 03 Oct 2022 at 07:22:01
Issue Comment

Rmariuzzo

maintenance of library

I don't know why the maintenance of this awesome library is stopped currently the version of react is 18 and this library only supports react version up to 16 I have many issues while using this library with my Next.js projects which are using react 18 as dependencies on of the issues I'm still facing when I use this library to open sign-in page from next-auth library I have to do more then one clicks so that new window opens up

Forked On 03 Oct 2022 at 07:19:48

Rmariuzzo

I'm aiming on focusing more time on this library this week and next week.

Commented On 03 Oct 2022 at 07:19:48

Rmariuzzo

Upgrade rollup deps.

Pushed On 03 Oct 2022 at 07:11:21

Rmariuzzo

Update docs.

Pushed On 03 Oct 2022 at 07:06:07
Create Branch

Rmariuzzo

🔲 Pop new windows in React, using `window.open`.

On 03 Oct 2022 at 06:59:39

Rmariuzzo

0.2.2

Pushed On 03 Oct 2022 at 06:59:38
Issue Comment

Rmariuzzo

Include children in NewWindow type definition

Fixes https://github.com/rmariuzzo/react-new-window/issues/118

This PR simply adds children?: React.ReactNode to NewWindow's type definition, which seems to be enough.

Forked On 03 Oct 2022 at 12:47:51

Rmariuzzo

Will deploy a new version soon today.

Commented On 03 Oct 2022 at 12:47:51

Rmariuzzo

Include children in NewWindow type definition

Fixes https://github.com/rmariuzzo/react-new-window/issues/118

This PR simply adds children?: React.ReactNode to NewWindow's type definition, which seems to be enough.

Merged On 03 Oct 2022 at 12:47:37

Rmariuzzo

Commented On 03 Oct 2022 at 12:47:37

Rmariuzzo

started

Started On 03 Oct 2022 at 01:49:09

Rmariuzzo

started

Started On 15 Sep 2022 at 02:38:12

Rmariuzzo

started

Started On 13 Sep 2022 at 07:39:56

Rmariuzzo

Update index.en-US.md

Pushed On 01 Sep 2022 at 03:19:45

Rmariuzzo

An enterprise-class UI design language and React UI library

Forked On 01 Sep 2022 at 03:19:08

Rmariuzzo

started

Started On 31 Aug 2022 at 03:08:44

Rmariuzzo

V1.9.1 is completely broken

This commit broke a lot:

https://github.com/rmariuzzo/Laravel-JS-Localization/commit/9e570ee76466cb6529651fd43faf3f33af133e9c

When the default directory is used: The following error is triggered because of a missing DIRECTORY_SEPERATOR

[Exception] /workspaceresources/lang doesn't exists!

Also i'm sure version 4 of laravel doesn't work because the $langs variable is overwriten, and therefor it also misses the /

Forked On 26 Aug 2022 at 02:10:31

Rmariuzzo

Thank you both for your good advices. I appreciate it.

Commented On 26 Aug 2022 at 02:10:31

Rmariuzzo

Revert "Supports ever changing lang folder (#170)"

This reverts commit 9e570ee76466cb6529651fd43faf3f33af133e9c.

Pushed On 26 Aug 2022 at 01:07:15

Rmariuzzo

Supports ever changing lang folder

From laravel 4 to 8.x we've seen changes to where the lang folder lives and this breaks the functionality of this package.

This PR makes this path customisable, so the package does not need to be updated every time laravel makes an update to the location of this folder.

Forked On 26 Aug 2022 at 12:58:51

Rmariuzzo

Also, I appreciate your advice, I will make a call for more maintainers to make double review as you suggested.

Commented On 26 Aug 2022 at 12:58:51

Rmariuzzo

Supports ever changing lang folder

From laravel 4 to 8.x we've seen changes to where the lang folder lives and this breaks the functionality of this package.

This PR makes this path customisable, so the package does not need to be updated every time laravel makes an update to the location of this folder.

Forked On 26 Aug 2022 at 12:57:27

Rmariuzzo

I apologize for this, that's on me. I removed the broken version from Packagist, I think that should alleviate that issue. Please, let me know if not.

Commented On 26 Aug 2022 at 12:57:27

Rmariuzzo

V1.9.1 is completely broken

This commit broke a lot:

https://github.com/rmariuzzo/Laravel-JS-Localization/commit/9e570ee76466cb6529651fd43faf3f33af133e9c

When the default directory is used: The following error is triggered because of a missing DIRECTORY_SEPERATOR

[Exception] /workspaceresources/lang doesn't exists!

Also i'm sure version 4 of laravel doesn't work because the $langs variable is overwriten, and therefor it also misses the /

Forked On 26 Aug 2022 at 12:54:54

Rmariuzzo

#172 I made a PR that fixes the problem

I review your PR, looks fine to me. @SanderSander and @Chomiciak can you check the PR too? 🙇

Commented On 26 Aug 2022 at 12:54:54

Rmariuzzo

V1.9.1 is completely broken

This commit broke a lot:

https://github.com/rmariuzzo/Laravel-JS-Localization/commit/9e570ee76466cb6529651fd43faf3f33af133e9c

When the default directory is used: The following error is triggered because of a missing DIRECTORY_SEPERATOR

[Exception] /workspaceresources/lang doesn't exists!

Also i'm sure version 4 of laravel doesn't work because the $langs variable is overwriten, and therefor it also misses the /

Forked On 26 Aug 2022 at 12:54:15

Rmariuzzo

I removed the broken version from Packagist, I think that should help for now: https://packagist.org/packages/mariuzzo/laravel-js-localization

Commented On 26 Aug 2022 at 12:54:15

Rmariuzzo

Fix path issues in v1.9.1

Fixes for the paths in v1.9.1

Merged On 26 Aug 2022 at 12:53:10

Rmariuzzo

LGTM, will wait to double check before merging.

Commented On 26 Aug 2022 at 12:53:10

Rmariuzzo

V1.9.1 is completely broken

This commit broke a lot:

https://github.com/rmariuzzo/Laravel-JS-Localization/commit/9e570ee76466cb6529651fd43faf3f33af133e9c

When the default directory is used: The following error is triggered because of a missing DIRECTORY_SEPERATOR

[Exception] /workspaceresources/lang doesn't exists!

Also i'm sure version 4 of laravel doesn't work because the $langs variable is overwriten, and therefor it also misses the /

Forked On 26 Aug 2022 at 12:51:20

Rmariuzzo

I apologize, will try to remove the version ASAP. 😞

Commented On 26 Aug 2022 at 12:51:20

Rmariuzzo

Updated lang path getting mechanism

Defining of localization folder has been updated: Laravel 9 has new lang folder path: '/lang', this causes an exception: 'resources/lang doesn't exists!' during the files creation.

In Laravel 5.0 (also available in newer version) App::langPath() method has been added, which helps to get lang folder absolute path, so there is no need to manually build path to lang folder anymore

Forked On 26 Aug 2022 at 03:44:25

Rmariuzzo

@wilpat also there's another request that does that too: https://github.com/rmariuzzo/Laravel-JS-Localization/pull/166

I'm willing to combine both effort when possible.

Commented On 26 Aug 2022 at 03:44:25

Rmariuzzo

Updated lang path getting mechanism

Defining of localization folder has been updated: Laravel 9 has new lang folder path: '/lang', this causes an exception: 'resources/lang doesn't exists!' during the files creation.

In Laravel 5.0 (also available in newer version) App::langPath() method has been added, which helps to get lang folder absolute path, so there is no need to manually build path to lang folder anymore

Forked On 26 Aug 2022 at 03:27:48

Rmariuzzo

Thank you @m0stwan1ed for you contribution. I was reading through pending PR and I included an option to specify the language directory. Apart from that, do you consider this PR needed?

Commented On 26 Aug 2022 at 03:27:48

Rmariuzzo

Supports ever changing lang folder

From laravel 4 to 8.x we've seen changes to where the lang folder lives and this breaks the functionality of this package.

This PR makes this path customisable, so the package does not need to be updated every time laravel makes an update to the location of this folder.

Forked On 26 Aug 2022 at 03:26:05

Rmariuzzo

@wilpat released: https://github.com/rmariuzzo/Laravel-JS-Localization/releases/tag/v1.9.1

Commented On 26 Aug 2022 at 03:26:05
Create Branch

Rmariuzzo

🌐 Convert your Laravel messages and consume them in the front-end!

On 26 Aug 2022 at 03:23:15

Rmariuzzo

Supports ever changing lang folder (#170)

  • Allows users add the name of their lang directory

  • Updates README

Pushed On 26 Aug 2022 at 03:12:53

Rmariuzzo

Supports ever changing lang folder

Created On 26 Aug 2022 at 03:12:53