rikusen0335 Github contribution chart
rikusen0335 Github Stats
rikusen0335 Most Used Languages

Activity

02 Dec 2022

Rikusen0335

update readme due to dead service

Pushed On 02 Dec 2022 at 03:36:02
Issue Comment

Rikusen0335

Type Definition doesn't work

Initial checklist

Affected packages and versions

remark-directive@2.0.1

Link to runnable example

No response

Steps to reproduce

This problem is probably not a package issue itself, so I couldn't reproduce.


Quick note: I use astro to develop, so I chose vite as a build tools.

Expected behavior

Getting a type like visit(tree: Tree, (node: Node) => { ... }) (I'm not sure if these type are correct, just writing for example) and so I can use complenition like node.name ...

Actual behavior

As this image shows, like visit function won't show its type.

Runtime

Node v16

Package manager

yarn 1

OS

macOS

Build and bundle tools

Vite

Forked On 30 Nov 2022 at 02:24:20

Rikusen0335

Thanks @ChristianMurphy !

I finally figured it out and that was not a problem of this lib as you said.

We need to do like this in .ts file:

import type { Root } from 'remark-directive';
import type { Plugin } from 'unified';

const customComponentRemarkPlugin: Plugin<[], Root> = () => {
  return (tree) => {
    visit(tree, (node) => {
    }
  }
} 

Commented On 30 Nov 2022 at 02:24:20
Issue Comment

Rikusen0335

MDXv2 broken with remark-heading-id

Initial checklist

Affected packages and versions

2.0.0

Link to runnable example

No response

Steps to reproduce

  • Install & import remark-heading-id
  • in MDX remarkPlugins, add remark-heading-id
  • Try to parse MDX: ## foo {#heading}

Expected behavior

The plugin handles the {#...} extended markup syntax, and MDX parses the document normally

Actual behavior

Get error: Could not parse expression with acorn: Unexpected character '#'

It makes sense that MDX thinks that {...} syntax is inline JS, but I would have thought plugins can be used to support heading ID Markdown extended syntax.

Runtime

Node v16

Package manager

npm v8

OS

Windows

Build and bundle tools

No response

Forked On 29 Nov 2022 at 08:34:12

Rikusen0335

I'd say thank you @Eyas that repo helped me a lot.

Commented On 29 Nov 2022 at 08:34:12

Rikusen0335

started

Started On 29 Nov 2022 at 08:32:23

Rikusen0335

started

Started On 26 Nov 2022 at 06:07:43

Rikusen0335

started

Started On 26 Nov 2022 at 06:07:39

Rikusen0335

Overlay scroll disable

The overlay doesn't disable the scroll on other components of the screen. How should i do that?

Forked On 24 Nov 2022 at 08:27:25

Rikusen0335

What is currently actual behavior?

Commented On 24 Nov 2022 at 08:27:25

Rikusen0335

Overlay scroll disable

The overlay doesn't disable the scroll on other components of the screen. How should i do that?

Forked On 24 Nov 2022 at 01:18:55

Rikusen0335

Sorry I can't get what are you talking about, could you make an example gif that describe the issue or tell me more context.

Commented On 24 Nov 2022 at 01:18:55
Issue Comment

Rikusen0335

💡 RFC: Ignoring specific folder or files

Background & Motivation

So there's Local History extension in VSCode which make a local duplicate to safely save work by typing Ctrl+C, and astro language tool take it like スクリーンショット 2022-11-16 18 45 45

Now I wanted to, simply, ignore spefic folder or file like .gitignore do.

Proposed Solution

Possible solutions

Make a option called like astro.ignorePath so that we can set it: "astro.ignorePath": [".history", "node_modules"]

Alternatives considered

Nothing.

Risks, downsides, and/or tradeoffs

This shouldn't affect to any

Open Questions

Nothing

Detailed Design

No response

Help make it happen!

  • [ ] I am willing to submit a PR to implement this change.
  • [ ] I am willing to submit a PR to implement this change, but would need some guidance.
  • [X] I am not willing to submit a PR to implement this change.

Forked On 18 Nov 2022 at 12:57:59

Rikusen0335

@Princesseuh I confirm it does work, I have to look for that. Thank you so much though!

Commented On 18 Nov 2022 at 12:57:59

Rikusen0335

Failed to compile.

Hi Team, @knowingharsh

Now, I can't import react-coach-mark after installing this lib

Module not found: Error: Can't resolve 'react-coach-mark' 

Forked On 14 Nov 2022 at 05:30:02

Rikusen0335

@muile-dev Thanks for reporting! Now closing the issue.

Did you fix the issue by using 1.0.4?

Commented On 14 Nov 2022 at 05:30:02

Rikusen0335

Failed to compile.

Hi Team, @knowingharsh

Now, I can't import react-coach-mark after installing this lib

Module not found: Error: Can't resolve 'react-coach-mark' 

Forked On 11 Nov 2022 at 05:54:26

Rikusen0335

I released 1.0.4 now, you may fix that with this new version.

Commented On 11 Nov 2022 at 05:54:26

Rikusen0335

bump version

Pushed On 11 Nov 2022 at 05:53:58

Rikusen0335

Failed to compile.

Hi Team, @knowingharsh

Now, I can't import react-coach-mark after installing this lib

Module not found: Error: Can't resolve 'react-coach-mark' 

Forked On 11 Nov 2022 at 05:51:16

Rikusen0335

Have you figured it out?

Commented On 11 Nov 2022 at 05:51:16

Rikusen0335

Failed to compile.

Hi Team, @knowingharsh

Now, I can't import react-coach-mark after installing this lib

Module not found: Error: Can't resolve 'react-coach-mark' 

Forked On 09 Nov 2022 at 02:11:42

Rikusen0335

Hello @muile-dev ! @knowingharsh is currently inactive, so I am here to support you.

Could you provide me what version are you using? Since recently I released 1.0.3 and it may causes this issue. Also give it a try 1.0.2 if you are using 1.0.3.

Commented On 09 Nov 2022 at 02:11:42

Rikusen0335

Library doesn't work. Demo is broken.

Did anyone get this to work?

Forked On 09 Nov 2022 at 09:47:59

Rikusen0335

FYI I forgot to push changes. It should be fine now.

Commented On 09 Nov 2022 at 09:47:59

Rikusen0335

:construction: wip, to make demo work

Pushed On 09 Nov 2022 at 09:46:27

Rikusen0335

Fix "Invalid Hook Call Warning" error

Hello! I am always grateful to use your product.

I have installed this library on a project using React 18. I found that I get the error Hooks can only be called inside the body of a function component when I mix different versions of React.

This is the PR that solves the error. I hope you can check it out!

reference: https://ja.reactjs.org/warnings/invalid-hook-call-warning.html

Forked On 04 Nov 2022 at 09:25:21

Rikusen0335

FYI: I published the 1.0.3 release including your PR. Thank you very much!

Commented On 04 Nov 2022 at 09:25:21

Rikusen0335

Library doesn't work. Demo is broken.

Did anyone get this to work?

Forked On 04 Nov 2022 at 09:21:28

Rikusen0335

@gollumnima if you still looking at this lib

Commented On 04 Nov 2022 at 09:21:28

Rikusen0335

Library doesn't work. Demo is broken.

Did anyone get this to work?

Forked On 04 Nov 2022 at 09:16:23

Rikusen0335

So the point is useEffect in pages/DemoOnePage.tsx, that doing like "watch" props which is like really bad behavior, I will investigate deep in deep in the future.

Also at this issue, some linter will warn you that like rerender must be in dependencies but please ignore it. If you using vscode or like that codeActionsOnSave, use Cmd+K S to save it without formatting and lintering.

Take a look at this in detail: https://github.com/microsoft/vscode/issues/38695#issuecomment-423422531

Commented On 04 Nov 2022 at 09:16:23

Rikusen0335

Library doesn't work. Demo is broken.

Did anyone get this to work?

Forked On 04 Nov 2022 at 09:12:43

Rikusen0335

Hey! Sorry for pasting long time, but I did demo is working now (a bit weird behaviour is still there)

Please give it a try with this branch: https://github.com/knowingharsh/react-coach-mark/tree/refactor-demo This is just really experimental, please care about that.

Commented On 04 Nov 2022 at 09:12:43
Create Branch

Rikusen0335

A light weight coach mark library on react for guided UI experience and live tutorials.

On 04 Nov 2022 at 09:10:20

Rikusen0335

Fix "Invalid Hook Call Warning" error

Hello! I am always grateful to use your product.

I have installed this library on a project using React 18. I found that I get the error Hooks can only be called inside the body of a function component when I mix different versions of React.

This is the PR that solves the error. I hope you can check it out!

reference: https://ja.reactjs.org/warnings/invalid-hook-call-warning.html

Forked On 04 Nov 2022 at 08:06:29

Rikusen0335

Let me wait to make a release of new version of this package.

Commented On 04 Nov 2022 at 08:06:29

Rikusen0335

update package.json

Pushed On 04 Nov 2022 at 08:06:01

Rikusen0335

Merge pull request #14 from kenichi-morihara/feature/morihara/bugfix_update_package.json

Fix "Invalid Hook Call Warning" error

Pushed On 04 Nov 2022 at 08:06:01

Rikusen0335

Fix "Invalid Hook Call Warning" error

Created On 04 Nov 2022 at 08:06:00

Rikusen0335

Fix "Invalid Hook Call Warning" error

Hello! I am always grateful to use your product.

I have installed this library on a project using React 18. I found that I get the error Hooks can only be called inside the body of a function component when I mix different versions of React.

This is the PR that solves the error. I hope you can check it out!

reference: https://ja.reactjs.org/warnings/invalid-hook-call-warning.html

Forked On 04 Nov 2022 at 08:05:43

Rikusen0335

This should be safe if I merged, so just gonna merge it

@kenichi-morihara ありがとうございます :smile:

Commented On 04 Nov 2022 at 08:05:43