pmndrs Github contribution chart
pmndrs Github Stats
pmndrs Most Used Languages

Activity

05 Oct 2022

Dswistowski

started

Started On 05 Oct 2022 at 10:01:21

Hamadasatco

started

Started On 05 Oct 2022 at 09:48:27

Imayolas

started

Started On 05 Oct 2022 at 09:33:13

Matteo1222

started

Started On 05 Oct 2022 at 09:27:48

IdkMan2

started

Started On 05 Oct 2022 at 09:19:56

Arieltonglet

started

Started On 05 Oct 2022 at 09:16:23

Elorenn

started

Started On 05 Oct 2022 at 08:50:27

Wiledal

fix: add euler to vectorToTuple

Pushed On 05 Oct 2022 at 08:03:05

Changeset-bot

fix(options): deep-compare props on rerender
Forked On 05 Oct 2022 at 08:01:32

Changeset-bot

ðŸĶ‹ Changeset detected

Latest commit: a14d9d00c356777ffce1d3f340d8d1bc5aba66fb

The changes in this PR will be included in the next version bump.

| Name | Type | | ------------------- | ----- | | @react-three/rapier | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Commented On 05 Oct 2022 at 08:01:32
Issue Comment

Vercel

fix(options): deep-compare props on rerender
Forked On 05 Oct 2022 at 08:01:32

Vercel

The latest updates on your projects. Learn more about Vercel for Git ↗ïļŽ

| Name | Status | Preview | Updated | | :--- | :----- | :------ | :------ | | react-three-rapier | 🔄 Building (Inspect) | | Oct 5, 2022 at 8:01PM (UTC) |

Commented On 05 Oct 2022 at 08:01:32

Wiledal

fix(options): deep-compare props on rerender

Created On 05 Oct 2022 at 08:01:30
Create Branch
Wiledal In pmndrs/react-three-rapier Create Branchfix/less-rerenders

Wiledal

ðŸĪš Rapier physics in React

On 05 Oct 2022 at 08:00:52

Evanwork1234

started

Started On 05 Oct 2022 at 07:45:15

Novastar88

started

Started On 05 Oct 2022 at 07:41:14

Davidtheclark

started

Started On 05 Oct 2022 at 07:34:33

Baturalpk

started

Started On 05 Oct 2022 at 07:18:56

Erikgregorywebb

started

Started On 05 Oct 2022 at 07:08:19

Shaomingquan

started

Started On 05 Oct 2022 at 06:40:41
Started

Mcansh

started

Started On 05 Oct 2022 at 06:30:28

Ilimitless

started

Started On 05 Oct 2022 at 06:18:20
Issue Comment

Krispya

RFC: v9 goals

Let's discuss some v9 goals here. These are all tentative right now.

Completed

  • [x] Add stage-based lifecycle, deprecate useFrame for useUpdate https://github.com/pmndrs/react-three-fiber/pull/2279
  • [x] Remove onUpdate prop https://github.com/pmndrs/react-three-fiber/pull/2480
  • [x] Remove updateStyle from Size https://github.com/pmndrs/react-three-fiber/pull/2489
  • [x] act types for testing https://github.com/pmndrs/react-three-fiber/pull/2492
  • [x] Instance descriptors, refactor JSX types & extend https://github.com/pmndrs/react-three-fiber/pull/2465
  • [x] prefer named functions, for loops in hot paths https://github.com/pmndrs/react-three-fiber/pull/2540 (backported in v8.8.7)

TODO

  • [ ] respect React.StrictMode across renderers #2547

Pending

  • [ ] Update demand frameloop mode to keep updating delta even if it skips render. Be sure to test all frameloop modes with the useUpdate changes.
  • [ ] ? Refactor color space API (see https://github.com/pmndrs/react-three-fiber/issues/2299)
  • [ ] ? Add cpuFrameTime and gpuFrameTime for performance based rendering

Forked On 05 Oct 2022 at 06:13:39

Krispya

That would be great. If you start a branch, I can do review and assist.

Commented On 05 Oct 2022 at 06:13:39
Issue Comment

Rec0iL99

Cannot find module 'immer' from 'node_modules/zustand/middleware/immer.js'

Hello, I'm using zustand together with the immer middleware according to the code below:

import zustand from 'zustand'
import { immer } from 'zustand/middleware/immer'

type CounterStore = {
  counter: number
  increment(): void
  decrement(): void
}

export const counterStore = zustand(immer<CounterStore>((set) => ({
  counter: 0,
  increment(){ set(state => state.counter++) },
  decrement(){ set(state => state.counter--) }
}))) 

But when I try to run tests using jest I get this error:

 FAIL  tests/pages/index.spec.tsx
  ● Test suite failed to run

    Cannot find module 'immer' from 'node_modules/zustand/middleware/immer.js'

    Require stack:
      node_modules/zustand/middleware/immer.js
      src/store/counterStore.ts
      src/store/index.ts
      src/pages/index.tsx

    However, Jest was able to find:
        './immer.d.ts'
        './immer.js'

    You might want to include a file extension in your import, or update your 'moduleFileExtensions', which is currently ['js', 'mjs', 'cjs', 'jsx', 'ts', 'tsx', 'json', 'node'].

    See https://jestjs.io/docs/configuration#modulefileextensions-arraystring 

Jest is using the default "moduleFileExtensions" configuration as you can see in the error and the file having the "js" extension should be exported without any problem.

Has anyone caught this error?

Forked On 05 Oct 2022 at 06:12:32

Rec0iL99

@leandroluk even I had faced this issue before and installing immer explicitly in my project did do the job.

@dai-shi can this be solved by moving immer from the devDeps to first level deps in the library's package.json? This would be helpful since the people using zustand need not explicitly install immer in their projects to use the immer middleware from zustand since immer would come installed with zustand out of the box.

Commented On 05 Oct 2022 at 06:12:32

Wlskhhh

started

Started On 05 Oct 2022 at 06:11:46
Issue Comment

Leandroluk

Cannot find module 'immer' from 'node_modules/zustand/middleware/immer.js'

Hello, I'm using zustand together with the immer middleware according to the code below:

import zustand from 'zustand'
import { immer } from 'zustand/middleware/immer'

type CounterStore = {
  counter: number
  increment(): void
  decrement(): void
}

export const counterStore = zustand(immer<CounterStore>((set) => ({
  counter: 0,
  increment(){ set(state => state.counter++) },
  decrement(){ set(state => state.counter--) }
}))) 

But when I try to run tests using jest I get this error:

 FAIL  tests/pages/index.spec.tsx
  ● Test suite failed to run

    Cannot find module 'immer' from 'node_modules/zustand/middleware/immer.js'

    Require stack:
      node_modules/zustand/middleware/immer.js
      src/store/counterStore.ts
      src/store/index.ts
      src/pages/index.tsx

    However, Jest was able to find:
        './immer.d.ts'
        './immer.js'

    You might want to include a file extension in your import, or update your 'moduleFileExtensions', which is currently ['js', 'mjs', 'cjs', 'jsx', 'ts', 'tsx', 'json', 'node'].

    See https://jestjs.io/docs/configuration#modulefileextensions-arraystring 

Jest is using the default "moduleFileExtensions" configuration as you can see in the error and the file having the "js" extension should be exported without any problem.

Has anyone caught this error?

Forked On 05 Oct 2022 at 06:01:36

Leandroluk

Looking at the middleware code I saw that it imports the immer, and I thought it was not necessary to install it and that it was already internally in zustand because of the middleware. To solve the problem just install the immer

Commented On 05 Oct 2022 at 06:01:36

Andreseichi

started

Started On 05 Oct 2022 at 06:01:00

Antonymott

started

Started On 05 Oct 2022 at 05:43:09
Issue Comment

Github-actions

feat: add OnDragStartProps to onDragStart of PivotControls

Why

Sometimes we need to know what exact component we're going to interact with.

What

onDragStart callback now provides props object: { component, axis, origin, directions }

Checklist

  • [x] Ready to be merged

Forked On 05 Oct 2022 at 05:42:20

Github-actions

:tada: This PR is included in version 9.34.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

Commented On 05 Oct 2022 at 05:42:20