okbel Github contribution chart
okbel Github Stats
okbel Most Used Languages

Activity

30 Sep 2022

Issue Comment

Okbel

Relative path from a working directory

Is there an existing issue for this?

  • [X] I have searched the existing issues

Does this issue exist in the latest version?

  • [X] I'm using the latest release

Describe the bug?

Hello!

diff_relative this directive is not returning the relative path from the folder I'm in.

 with:
      diff_relative: "true"
      files: |
        web/** 

returns paths with web prefixed. Is this expected?

Apologies if I misunderstood the functionality of diff_relative. I've also tried using a boolean, non-string like value. (true) I couldn't find the example to get the relative path within a specific folder.

Thank you!

To Reproduce

Running this part within a GH action

 with:
      diff_relative: "true"
      files: |
        web/** 

What OS are you seeing the problem on?

macos-11

Expected behavior?

To return paths only relative to the working folder.

Relevant log output

No response

Anything else?

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Forked On 30 Sep 2022 at 08:33:54

Okbel

Thank you so much @jackton1 🙏 Much appreciation for your work!

Commented On 30 Sep 2022 at 08:33:54

Okbel

started

Started On 29 Sep 2022 at 09:17:47

Okbel

started

Started On 22 Sep 2022 at 02:55:25

Okbel

started

Started On 14 Sep 2022 at 04:47:27

Okbel

started

Started On 13 Sep 2022 at 01:24:35
Issue Comment

Okbel

`import.meta.url` error in .mts files

Bug Report

🔎 Search Terms

import, imoprt.meta, nodenext

🕗 Version & Regression Information

  • This is a crash
  • This changed between versions 4.5 and 4.6
  • This is the behavior in every version I tried, and I reviewed the FAQ for entries about ECMA Script modules in Node.JS
  • I was unable to test this on prior versions because there is nothing about it

⏯ Playground Link

4.5.5 - playground

4.7.4 (both .ts and .mts filex) - playground

💻 Code

// .mts file
import.meta.url 

🙁 Actual behavior

error TS1470: The 'import.meta' meta-property is not allowed in files which will build into CommonJS output. 

🙂 Expected behavior

It compiles

Forked On 10 Sep 2022 at 05:22:46

Okbel

Can confirm 👍

Commented On 10 Sep 2022 at 05:22:46

Okbel

started

Started On 10 Sep 2022 at 04:23:48

Okbel

started

Started On 10 Sep 2022 at 09:25:33

Okbel

started

Started On 10 Sep 2022 at 07:16:07

Okbel

started

Started On 05 Sep 2022 at 07:49:16

Okbel

started

Started On 05 Sep 2022 at 02:36:40
Started

Okbel

started

Started On 05 Sep 2022 at 02:27:15
Started

Okbel

started

Started On 05 Sep 2022 at 02:27:14

Okbel

started

Started On 05 Sep 2022 at 01:46:24

Okbel

Update code owners

Description

Added Dev Rel as code owners (for the moment just Lee).

Type of Change

  • [ ] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [x] Other (changes to the codebase, but not to examples)

Merged On 05 Sep 2022 at 01:07:32

Okbel

LGTM!

Commented On 05 Sep 2022 at 01:07:32

Okbel

Updated demo URL for wasm-rust-hello-world (#382)

Updated demo URL for wasm-rust-hello-world

Pushed On 25 Aug 2022 at 04:22:26
Pull Request

Okbel

Updated demo URL for `wasm-rust-hello-world`

Created On 25 Aug 2022 at 04:22:25

Okbel

Updated demo URL for `wasm-rust-hello-world`

Also checking that automatic deployments work for both wasm rust examples

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Merged On 25 Aug 2022 at 04:22:21

Okbel

Commented On 25 Aug 2022 at 04:22:21

Okbel

WASM API Routes examples (#380)

  • Add edge-api-routes/wasm-hello-world example

  • Add edge-api-routes/wasm-xor example

  • wasm-xor: update README link to deployment

  • wasm: update READMEs

  • Updated wasm-hello-world

  • Updated wasm-xor

  • Renamed examples

  • Updated readmes after renaming

Merged On 25 Aug 2022 at 03:52:37

Okbel

Commented On 25 Aug 2022 at 03:52:37

Okbel

WASM API Routes examples

Description

Adding two Edge API Route examples that use WebAssembly.

Demo URL

🔜

Type of Change

  • [x] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

New Example Checklist

  • [ ] 🛫 npm run new-example was used to create the example
  • [x] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • [ ] 📱 Is it responsive? Are mobile and tablets considered?

Merged On 25 Aug 2022 at 02:58:27

Okbel

Left some comments and I think it might be valuable to rename the examples from wasm-xor to wasm-rust-xor so when clicking the example users will have a hint that it uses rust. (As we will add other languages go, python, ruby etc)

Other than that, I believe LGTM!

Commented On 25 Aug 2022 at 02:58:27

Okbel

WASM API Routes examples

Description

Adding two Edge API Route examples that use WebAssembly.

Demo URL

🔜

Type of Change

  • [x] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

New Example Checklist

  • [ ] 🛫 npm run new-example was used to create the example
  • [x] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • [ ] 📱 Is it responsive? Are mobile and tablets considered?

Merged On 25 Aug 2022 at 02:57:53

Okbel

Left some comments and I think it might be valuable to rename the examples from wasm-xor to wasm-rust-xor so when clicking the example users will have a hint that it uses rust. (As we will add other languages go, python, ruby etc)

Commented On 25 Aug 2022 at 02:57:53
Merge

Okbel

WASM API Routes examples

Description

Adding two Edge API Route examples that use WebAssembly.

Demo URL

🔜

Type of Change

  • [x] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

New Example Checklist

  • [ ] 🛫 npm run new-example was used to create the example
  • [x] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • [ ] 📱 Is it responsive? Are mobile and tablets considered?

Forked On 25 Aug 2022 at 02:52:57

Okbel

We are at Version 28.1.4 just in case
On 25 Aug 2022 at 02:52:57

Okbel

WASM API Routes examples

Description

Adding two Edge API Route examples that use WebAssembly.

Demo URL

🔜

Type of Change

  • [x] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

New Example Checklist

  • [ ] 🛫 npm run new-example was used to create the example
  • [x] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • [ ] 📱 Is it responsive? Are mobile and tablets considered?

Merged On 25 Aug 2022 at 02:52:57

Okbel

Commented On 25 Aug 2022 at 02:52:57
Merge

Okbel

WASM API Routes examples

Description

Adding two Edge API Route examples that use WebAssembly.

Demo URL

🔜

Type of Change

  • [x] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

New Example Checklist

  • [ ] 🛫 npm run new-example was used to create the example
  • [x] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • [ ] 📱 Is it responsive? Are mobile and tablets considered?

Forked On 25 Aug 2022 at 02:52:18

Okbel

Please, remove personal emails. Codeowners are already set.
On 25 Aug 2022 at 02:52:18

Okbel

WASM API Routes examples

Description

Adding two Edge API Route examples that use WebAssembly.

Demo URL

🔜

Type of Change

  • [x] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

New Example Checklist

  • [ ] 🛫 npm run new-example was used to create the example
  • [x] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • [ ] 📱 Is it responsive? Are mobile and tablets considered?

Merged On 25 Aug 2022 at 02:52:18

Okbel

Commented On 25 Aug 2022 at 02:52:18
Create Branch
Okbel In vercel/examples Create Branchwasm

Okbel

Enjoy our curated collection of examples and solutions. Use these patterns to build your own robust and scalable applications.

On 25 Aug 2022 at 10:43:32
Pull Request

Okbel

New Example: Streams

Created On 16 Aug 2022 at 12:32:17
Pull Request

Okbel

New Streaming Example

Created On 16 Aug 2022 at 12:29:50
Create Branch
Okbel In vercel/examples Create Branchexamples-streams

Okbel

Enjoy our curated collection of examples and solutions. Use these patterns to build your own robust and scalable applications.

On 16 Aug 2022 at 12:29:35