nickgros Github contribution chart
nickgros Github Stats
nickgros Most Used Languages

Activity

05 Oct 2022

Nickgros

PORTALS-2351: follow/unfollow button for discussion forum
Merged On 05 Oct 2022 at 08:54:07

Nickgros

LGTM!

Commented On 05 Oct 2022 at 08:54:07

Nickgros

HtmlPreview component

Pushed On 05 Oct 2022 at 08:51:10

Nickgros

Merge branch 'develop' into PORTALS-2316d

Pushed On 05 Oct 2022 at 08:51:10

Nickgros

Merge branch 'develop' into PORTALS-2316d

Pushed On 05 Oct 2022 at 08:51:10

Nickgros

Revert changes in getFileHandleContent

Pushed On 05 Oct 2022 at 08:51:10

Nickgros

Suggested changes from review #1813

Pushed On 05 Oct 2022 at 08:51:10

Nickgros

Fix compile error

Pushed On 05 Oct 2022 at 08:51:10

Nickgros

Merge pull request #1813 from nickgros/PORTALS-2316d

Pushed On 05 Oct 2022 at 08:51:10

Nickgros

PORTALS-2316: HtmlPreview component

Created On 05 Oct 2022 at 08:51:10

Nickgros

Fix compile error

Pushed On 05 Oct 2022 at 08:33:03

Nickgros

Suggested changes from review #1813

Pushed On 05 Oct 2022 at 08:17:32

Nickgros

remove secondary label to avoid redundancy

Pushed On 05 Oct 2022 at 08:16:00

Nickgros

Merge pull request #855 from vpchung/people-card

Pushed On 05 Oct 2022 at 08:16:00

Nickgros

Remove secondary label to avoid redundancy

Created On 05 Oct 2022 at 08:15:59

Nickgros

Remove secondary label to avoid redundancy

In the Person card, we have Grant Name as one of the secondary labels, which is redundant with the "Related Grants" information on the details page. Ergo, we'd like to remove the secondary label.

Merged On 05 Oct 2022 at 08:15:53

Nickgros

Commented On 05 Oct 2022 at 08:15:53

Nickgros

Adding properties should work when `additionalProperties` is `true`

Fixes #3179

Conversion of ObjectField to TypeScript caused a regression where additionalProperties: true was not properly evaluated when adding a property.

  • Change ObjectField logic to handle additionalProperties: true.
  • Add tests to validate some of the logic in handleAddClick, including the regression

Forked On 05 Oct 2022 at 08:15:14

Nickgros

Should have just added a blank commit to start the CI pipeline...thanks for catching!
On 05 Oct 2022 at 08:15:14

Nickgros

Adding properties should work when `additionalProperties` is `true`

Fixes #3179

Conversion of ObjectField to TypeScript caused a regression where additionalProperties: true was not properly evaluated when adding a property.

  • Change ObjectField logic to handle additionalProperties: true.
  • Add tests to validate some of the logic in handleAddClick, including the regression

Merged On 05 Oct 2022 at 08:15:14

Nickgros

Commented On 05 Oct 2022 at 08:15:14

Nickgros

Update CHANGELOG.md

Co-authored-by: Heath C 51679588+heath-freenome@users.noreply.github.com

Pushed On 05 Oct 2022 at 08:14:35

Nickgros

Upgrade to RJSF v5

Created On 05 Oct 2022 at 07:48:21
Create Branch

Nickgros

To help quickly integrate your React app with the Synapse API backend

On 05 Oct 2022 at 07:48:05

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Merged On 05 Oct 2022 at 07:45:22

Nickgros

Commented On 05 Oct 2022 at 07:45:22

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Forked On 05 Oct 2022 at 07:45:22

Nickgros

But the cap is indeed 50, so no issue. Still worth changing.
On 05 Oct 2022 at 07:45:22

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Forked On 05 Oct 2022 at 07:44:33

Nickgros

The team has 22 members so if it is hard-capped at 20, it will cause an issue today
On 05 Oct 2022 at 07:44:33

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Merged On 05 Oct 2022 at 07:44:34

Nickgros

Commented On 05 Oct 2022 at 07:44:34

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Forked On 05 Oct 2022 at 07:41:03

Nickgros

No reason we couldn't export this and use it there. The file size limit shouldn't have been added here but it will be in the next PR.
On 05 Oct 2022 at 07:41:03

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Merged On 05 Oct 2022 at 07:41:04

Nickgros

Commented On 05 Oct 2022 at 07:41:04

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Merged On 05 Oct 2022 at 07:38:08

Nickgros

Commented On 05 Oct 2022 at 07:38:08

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Forked On 05 Oct 2022 at 07:38:07

Nickgros

I think it's hard-capped at 20. Not an issue today since the team is not that large, but I can update this to fetch all members
On 05 Oct 2022 at 07:38:07

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Forked On 05 Oct 2022 at 07:37:01

Nickgros

I like the idea but am worried those practices change more frequently than we would update the page
On 05 Oct 2022 at 07:37:01

Nickgros

PORTALS-2316: HtmlPreview component

Adds HtmlPreview component

  • Given raw HTML and a file handle, renders the raw HTML (if the user is on the trusted team) or renders sanitized HTML.

  • If the rendered HTML is different than the raw HTML, the user can open the untrusted content in a new window.

  • Component has not yet been exposed via MarkdownSynapse - this PR does not include:

    • Parsing the preview widget descriptor
    • Fetching the file referenced by the preview descriptor
    • Asking the user to log in if they can't download the referenced file as Anonymous
    • Determining how to preview the file (e.g. download the file contents or a preview file handle?)
    • Downloading the file handle contents.

image

Merged On 05 Oct 2022 at 07:37:02

Nickgros

Commented On 05 Oct 2022 at 07:37:02

Nickgros

PORTALS-2351: follow/unfollow button for discussion forum
Forked On 05 Oct 2022 at 07:32:06

Nickgros

Add one test to verify unfollow/deleting the subscription and then I'll approve
On 05 Oct 2022 at 07:32:06

Nickgros

PORTALS-2351: follow/unfollow button for discussion forum
Merged On 05 Oct 2022 at 07:32:06

Nickgros

Commented On 05 Oct 2022 at 07:32:06

Nickgros

Update CHANGELOG.md

Pushed On 05 Oct 2022 at 07:23:45

Nickgros

Adding properties should work when `additionalProperties` is `true`

Fixes #3179

Conversion of ObjectField to TypeScript caused a regression where additionalProperties: true was not properly evaluated when adding a property.

  • Change ObjectField logic to handle additionalProperties: true.
  • Add tests to validate some of the logic in handleAddClick, including the regression

Forked On 05 Oct 2022 at 07:23:37

Nickgros

Making a small change to kick off the GH action runner ```suggestion - Extended `Form.onChange` to optionally return the `id` of the field that caused the change, fixing [#2768](https://github.com/rjsf-team/react-jsonschema-form/pull/2768) ```
On 05 Oct 2022 at 07:23:37

Nickgros

Adding properties should work when `additionalProperties` is `true`

Fixes #3179

Conversion of ObjectField to TypeScript caused a regression where additionalProperties: true was not properly evaluated when adding a property.

  • Change ObjectField logic to handle additionalProperties: true.
  • Add tests to validate some of the logic in handleAddClick, including the regression

Merged On 05 Oct 2022 at 07:23:38

Nickgros

Commented On 05 Oct 2022 at 07:23:38

Nickgros

Adding properties should work when `additionalProperties` is `true`

Fixes #3179

Conversion of ObjectField to TypeScript caused a regression where additionalProperties: true was not properly evaluated when adding a property.

  • Change ObjectField logic to handle additionalProperties: true.
  • Add tests to validate some of the logic in handleAddClick, including the regression

Merged On 05 Oct 2022 at 07:22:13

Nickgros

Commented On 05 Oct 2022 at 07:22:13

Nickgros

Adding properties should work when `additionalProperties` is `true`

Fixes #3179

Conversion of ObjectField to TypeScript caused a regression where additionalProperties: true was not properly evaluated when adding a property.

  • Change ObjectField logic to handle additionalProperties: true.
  • Add tests to validate some of the logic in handleAddClick, including the regression

Forked On 05 Oct 2022 at 07:22:12

Nickgros

```suggestion - Fixed a regression in earlier v5 beta versions where additional properties could not be added when `additionalProperties` was `true` ([#3719](https://github.com/rjsf-team/react-jsonschema-form/pull/3719)). ```
On 05 Oct 2022 at 07:22:12