nick-barth Github contribution chart
nick-barth Github Stats
nick-barth Most Used Languages

Activity

26 Nov 2022

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Forked On 26 Nov 2022 at 05:49:22

Nick-barth

Why not just change the data in your JSON file?
On 26 Nov 2022 at 05:49:22

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Merged On 26 Nov 2022 at 05:49:23

Nick-barth

Commented On 26 Nov 2022 at 05:49:23

Nick-barth

yusufDemir-react-week2
Forked On 26 Nov 2022 at 05:35:24

Nick-barth

Error and loading should be the responsibility of the parent. If there is an error, or it's loading, you shouldn't even render the Products component.
On 26 Nov 2022 at 05:35:24

Nick-barth

yusufDemir-react-week2
Forked On 26 Nov 2022 at 05:34:35

Nick-barth

Error should be the responsibility of the parent. If there is an error, you shouldn't even render the Categories component.
On 26 Nov 2022 at 05:34:35

Nick-barth

yusufDemir-react-week2
Merged On 26 Nov 2022 at 05:36:07

Nick-barth

Commented On 26 Nov 2022 at 05:36:07

Nick-barth

yusufDemir-react-week2
Merged On 26 Nov 2022 at 05:36:07

Nick-barth

Commented On 26 Nov 2022 at 05:36:07

Nick-barth

Nidaulzafar w2

Netlify Link:

https://nidaulzafar-w2.netlify.app/

Forked On 26 Nov 2022 at 05:32:42

Nick-barth

use a ternary here, ie ```const url = category === '' ? `https://fakestoreapi.com/products` : `https://fakestoreapi.com/products/category/${category}`;```
On 26 Nov 2022 at 05:32:42

Nick-barth

Nidaulzafar w2

Netlify Link:

https://nidaulzafar-w2.netlify.app/

Forked On 26 Nov 2022 at 05:31:20

Nick-barth

Why use an image? An SVG is smaller and quicker, and you can change colors, size, and it has a transparent background.
On 26 Nov 2022 at 05:31:20

Nick-barth

Nidaulzafar w2

Netlify Link:

https://nidaulzafar-w2.netlify.app/

Forked On 26 Nov 2022 at 05:33:40

Nick-barth

Ok, this is almost perfect, but why not keep data in here, that way you only have to pass Url and you can change data, and return {data, isLoading, error}
On 26 Nov 2022 at 05:33:40

Nick-barth

Nidaulzafar w2

Netlify Link:

https://nidaulzafar-w2.netlify.app/

Merged On 26 Nov 2022 at 05:33:47

Nick-barth

Commented On 26 Nov 2022 at 05:33:47

Nick-barth

Nidaulzafar w2

Netlify Link:

https://nidaulzafar-w2.netlify.app/

Merged On 26 Nov 2022 at 05:33:47

Nick-barth

Commented On 26 Nov 2022 at 05:33:47

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:19:46

Nick-barth

Organise your imports, put your vendor stuff on top, 'react-router-dom' and 'react', and put your routes below.
On 26 Nov 2022 at 05:19:46

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:29:06

Nick-barth

Each? Should be `product`, or `item`.
On 26 Nov 2022 at 05:29:06

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:28:00

Nick-barth

Inconsistent, but this one is better.
On 26 Nov 2022 at 05:28:00

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:24:17

Nick-barth

semantically incorrect, component should be a header.
On 26 Nov 2022 at 05:24:17

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:27:39

Nick-barth

semantically incorrect, component should be p
On 26 Nov 2022 at 05:27:39

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:22:21

Nick-barth

usually boolean variables are, isLoading, isAdmin, hasAccess, etc.
On 26 Nov 2022 at 05:22:21

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:22:48

Nick-barth

Probably an early return would be better here, so you wouldn't even enter the block.
On 26 Nov 2022 at 05:22:48

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:24:07

Nick-barth

semantically incorrect, component should be p
On 26 Nov 2022 at 05:24:07

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:23:22

Nick-barth

Loading should be set in finally, right now if you error out loading will stay true.
On 26 Nov 2022 at 05:23:22

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Merged On 26 Nov 2022 at 05:29:19

Nick-barth

Commented On 26 Nov 2022 at 05:29:19

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:20:41

Nick-barth

Misuse of ```<p>``` and CardActions
On 26 Nov 2022 at 05:20:41

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Forked On 26 Nov 2022 at 05:20:08

Nick-barth

error handling and loading states.
On 26 Nov 2022 at 05:20:08

Nick-barth

BetulYasar-React-Js-Week2

https://ecommerce-reactjs-app-week2.netlify.app/

Merged On 26 Nov 2022 at 05:29:19

Nick-barth

Commented On 26 Nov 2022 at 05:29:19

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Forked On 26 Nov 2022 at 05:18:33

Nick-barth

destructure props.
On 26 Nov 2022 at 05:18:33

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Forked On 26 Nov 2022 at 05:17:57

Nick-barth

This should be removed, and you should destructure the props from props, instead of having selectedCategories.
On 26 Nov 2022 at 05:17:57

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Forked On 26 Nov 2022 at 05:18:19

Nick-barth

Why make a component out of this? This is not re-usable as well, you should pass the title as a prop.
On 26 Nov 2022 at 05:18:19

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Forked On 26 Nov 2022 at 05:14:32

Nick-barth

Why are you using anonymous functions here?
On 26 Nov 2022 at 05:14:32

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Merged On 26 Nov 2022 at 05:18:48

Nick-barth

Commented On 26 Nov 2022 at 05:18:48

Nick-barth

Nida zafar week1

Link to netlify

https://nidaulzafar.netlify.app/

Forked On 26 Nov 2022 at 05:17:27

Nick-barth

Why make this a component? Why pass everything? as selectedCategory? The index, selected, and clickHandler are not selected categories. If you wanted this to be a custom component you would just spread these props.
On 26 Nov 2022 at 05:17:27