mikaelkaron Github contribution chart
mikaelkaron Github Stats
mikaelkaron Most Used Languages

Activity

03 Oct 2022

Mikaelkaron

started

Started On 03 Oct 2022 at 10:30:48

Mikaelkaron

build(package): bump deps

Pushed On 30 Sep 2022 at 01:33:05

Mikaelkaron

feat: Pass around TokenSetParameters instead of TokenSet as it's an interface

BREAKING CHANGES: This changes some public signatures but should be easy to change dependent code

Pushed On 30 Sep 2022 at 01:33:05

Mikaelkaron

build(package): bump deps

Pushed On 29 Sep 2022 at 08:47:07

Mikaelkaron

build(release): make sure package-lock.json is commited after release

Pushed On 29 Sep 2022 at 08:47:07

Mikaelkaron

Fix for "this" being undefined

Fixing an issue where "this" could end up being undefined for some reason in WDIO.

Here is the error trace I am consistently receiving:

2022-06-15T03:58:16.658Z ERROR @wdio/local-runner: Failed launching test session: Error: Couldn't initialise "@wdio/cucumber-framework".
TypeError: Cannot read property 'Symbol(source-map-support/sharedData)' of undefined
    at initializeSharedData (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/@cucumber/cucumber/node_modules/@cspotcode/source-map-support/source-map-support.js:49:20)
    at Object.<anonymous> (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/@cucumber/cucumber/node_modules/@cspotcode/source-map-support/source-map-support.js:78:18)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Module._compile (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/pirates/lib/index.js:136:24)
    at Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at require.extensions.<computed> (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/ts-node/src/index.ts:1445:43)
    at Object.newLoader [as .js] (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/pirates/lib/index.js:141:7)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Module.require (internal/modules/cjs/loader.js:974:19)
    at safeRequire (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/@wdio/utils/build/utils.js:192:15)
    at initialisePlugin (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/@wdio/utils/build/initialisePlugin.js:30:50)
    at Runner.run (/Users/yexe017/Projects/OH/gcom-react-order-history/test/end-to-end/node_modules/@wdio/runner/build/index.js:82:56)
    at processTicksAndRejections (internal/process/task_queues.js:95:5) 

Here is the package.config for the project in question:

{
  "scripts": {
    "check-types": "tsc",
    "clean": "read -p \"Are you sure you want to clean the project? [y/n] \" REPLY; if [[ $REPLY =~ ^[Yy]$ ]]; then rm -R .git .github .codeclimate.yml .travis.yml wdio.BUILD.conf.js src/features/**; fi",
    "test": "run-s test:*",
    "test:lint": "eslint 'src/**/*.ts'",
    "format": "npx prettier --write .",
    "test:features": "wdio run wdio.BUILD.conf.ts",
    "wdio:mock": "wdio run wdio.MOCK.conf.ts",
    "wdio:dev": "wdio run wdio.DEV.conf.ts",
    "wdio:qa": "wdio run wdio.QA.conf.ts",
    "wdio:prod": "wdio run wdio.PROD.conf.ts",
    "wdio": "wdio run wdio.conf.js"
  },
  "devDependencies": {
    "@babel/cli": "^7.16.8",
    "@babel/core": "^7.16.12",
    "@babel/plugin-proposal-export-default-from": "^7.16.7",
    "@babel/preset-env": "^7.16.11",
    "@babel/preset-typescript": "^7.16.7",
    "@babel/register": "^7.16.9",
    "@typescript-eslint/eslint-plugin": "^5.10.1",
    "@typescript-eslint/parser": "^5.10.1",
    "@typescript-eslint/types": "^5.10.1",
    "@wdio/cli": "^7.20.2",
    "@wdio/config": "^7.20.1",
    "@wdio/cucumber-framework": "^7.20.2",
    "@wdio/local-runner": "^7.20.2",
    "@wdio/sauce-service": "^7.20.2",
    "@wdio/selenium-standalone-service": "^7.20.1",
    "@wdio/spec-reporter": "^7.20.0",
    "@wdio/static-server-service": "^7.20.0",
    "@wdio/types": "^7.20.0",
    "chromedriver": "^101.0.0",
    "eslint": "^8.7.0",
    "eslint-config-prettier": "^8.3.0",
    "eslint-plugin-import": "^2.25.4",
    "eslint-plugin-wdio": "^7.4.2",
    "http-server": "^14.1.0",
    "node-fetch": "^2.6.1",
    "ts-node": "^10.4.0",
    "typescript": "^4.5.5",
    "wdio-chromedriver-service": "^7.3.2",
    "webdriverio": "^7.16.13"
  }
} 

Forked On 28 Sep 2022 at 06:29:08

Mikaelkaron

I'm running into the same problem using tsx as a loader and @graphql-codegen/cli - this patch fixes the problem

Commented On 28 Sep 2022 at 06:29:08

Mikaelkaron

started

Started On 27 Sep 2022 at 12:03:49
Issue Comment

Mikaelkaron

JSON Schema Definitions not work

Prerequisites

  • [X] I have written a descriptive issue title
  • [X] I have searched existing issues to ensure the issue has not already been raised

"@fastify/swagger": "7.4.1",

Issue

Hi Guys, I add new schema with addSchema in my fastify like this :

{
  $id: 'http://foo/common.json',
  type: 'object',
  definitions: {
    foo: {
      $id: '#address',
      type: 'object',
      properties: {
        city: { type: 'string' }
      }
    }
  }
} 

and used in my route schema

 schema: {
      body: {
        $ref: 'http://foo/common.json#/definitions/foo'
      }
    }, 

its work in fastify no error found, but error in swagger

Could not resolve reference: Could not resolve pointer: /definitions/def-0/definitions/foo ddoes not exist in document

and when i check /documentation/json there is no my definitions inside -> definitions -> def-0

and models only {}

Forked On 27 Sep 2022 at 10:03:41

Mikaelkaron

Any chance this could get a bump?

I ran into this (again) when trying the official examples from the docs for fuent-json-schema in fastify.

Commented On 27 Sep 2022 at 10:03:41

Mikaelkaron

fix: update fastify version plugin annotation to 4.x

Pushed On 26 Sep 2022 at 07:02:29

Mikaelkaron

fix: move @types/async-retry from devDependencies to dependencies

Pushed On 26 Sep 2022 at 05:42:02

Mikaelkaron

fix: make FastifyRequest.session compatible with @fastify/secure-session

Pushed On 26 Sep 2022 at 03:54:36

Mikaelkaron

feat: bump deps

BREAKING CHANGE: This bumps fastify@4

Pushed On 26 Sep 2022 at 02:03:27

Mikaelkaron

fix: auto-fix eslint

Pushed On 26 Sep 2022 at 02:03:27

Mikaelkaron

feat: bump deps

BREAKING CHANGE: This bumps fastify@4

Pushed On 25 Sep 2022 at 09:12:28

Mikaelkaron

fix: auto-fix eslint

Pushed On 25 Sep 2022 at 09:12:28
Issue Comment

Mikaelkaron

Add check for `Buffer`

closes #10

Checklist

Forked On 25 Sep 2022 at 10:37:32

Mikaelkaron

The issue with this PR is, that it is a breaking change. Also it would mean that it would probably not work in Browser because Browser does not have a builtin Buffer. So a instanceof Buffer would throw.

This is true.

Also i can not agree with the assessment, that Array.isArray(Buffer.from([])) or Buffer.from([]) is returning true. So the Array Merge logic does not get applied. I assume It happens only if there is a buffer polyfill existing which is using Array as parent class.

I was to quick on my assessment there, the array merge logic does indeed not get applied. I'll try to rework the MR to manage these two points.

Commented On 25 Sep 2022 at 10:37:32
Issue Comment

Mikaelkaron

Add check for `Buffer`

closes #10

Checklist

Forked On 23 Sep 2022 at 09:37:57

Mikaelkaron

For sure. I was planning on doing that anyways, just made a draft to know if you are ok with the solution.

Commented On 23 Sep 2022 at 09:37:57

Mikaelkaron

Delete CNAME

Pushed On 22 Sep 2022 at 03:11:32

Mikaelkaron

Create CNAME

Pushed On 22 Sep 2022 at 03:10:30

Mikaelkaron

Create index.html

Pushed On 22 Sep 2022 at 03:10:10
Create Branch

Mikaelkaron

eXaminer public website

On 22 Sep 2022 at 03:09:09
Create Branch

Mikaelkaron

eXaminer public website

On 22 Sep 2022 at 03:07:16
Issue Comment

Mikaelkaron

`Buffer` is merged like `Array`

Prerequisites

  • [X] I have written a descriptive issue title
  • [X] I have searched existing issues to ensure the bug has not already been reported

Fastify version

4

Plugin version

1.1.0

Node.js version

16.17.0

Operating system

Linux

Operating system version (i.e. 20.04, 11.3, 10)

20.04

Description

Since Buffer is in essence just a Uint8Array it gets mangled by deepmerge.

Steps to Reproduce

import { deepmerge } from '@fastify/deepmerge'
const merge = deepmerge()
const merged = JSON.stringify(merge({}, { buffer: Buffer.of(1, 2, 3) })) // {"buffer":{"0":1,"1":2,"2":3}} 

Expected Behavior

import { deepmerge } from '@fastify/deepmerge'
const merge = deepmerge()
const merged = JSON.stringify(merge({}, { buffer: Buffer.of(1, 2, 3) })) // {"buffer":{"type":"Buffer","data":[1,2,3]}} 

Forked On 22 Sep 2022 at 06:30:40

Mikaelkaron

All for that. One could also be allowed to provide isMergeableObject and similar functions as arguments to deepmerge to control this in a case by case basis.

Commented On 22 Sep 2022 at 06:30:40

Mikaelkaron

wip: Add check for `Buffer`

Created On 21 Sep 2022 at 07:10:56

Mikaelkaron

Add check for Buffer

closes #10

Pushed On 21 Sep 2022 at 07:10:01

Mikaelkaron

Forked On 21 Sep 2022 at 07:07:38

Mikaelkaron

Update 2022-09-15-your-filename.md

Pushed On 15 Sep 2022 at 03:56:41

Mikaelkaron

started

Started On 15 Sep 2022 at 03:38:15

Mikaelkaron

started

Started On 15 Sep 2022 at 03:22:56

Mikaelkaron

started

Started On 15 Sep 2022 at 03:19:57

Mikaelkaron

Update 2022-09-14-mikaels-first-post.md

Pushed On 14 Sep 2022 at 06:33:29

Mikaelkaron

Create teraz1.jpg

Pushed On 14 Sep 2022 at 06:32:00

Mikaelkaron

Create 2022-09-14-mikaels-first-post.md

Pushed On 14 Sep 2022 at 06:29:49