mehulkar Github contribution chart
mehulkar Github Stats
mehulkar Most Used Languages

Activity

01 Dec 2022

Issue Comment

Mehulkar

Filter out workspaces before generating dependency graph?

Which project is this feature idea for?

Turborepo

Describe the feature you'd like to request

Filter out workspaces prior to creating the dependency graph

After installing Turborepo and attempting to begin using it to orchestrate tasks across our monorepo, it has become apparent that we have some cyclic dependency issues (thank you!) in one of our workspaces.

This prevents me from utilising Turborepo in workspaces other than the one with cyclic dependency issues as I get the cyclic dependency error before any tasks are attempted.

 "workspaces": {
    "packages": [
      "core/*",
      "personalise/*", // 👈 would like to run tasks in here.
      "packages/*" // 👈 has some cyclic deps issues, would like to ignore.
    ]
  }, 

Describe the solution you'd like

Filter out workspaces prior to creating the dependency graph.

Describe alternatives you've considered

Running Turborepo individually inside the packages that don't have cyclic dependency issues - this doesn't seem to work.

Forked On 01 Dec 2022 at 07:45:29

Mehulkar

@andrewmcoupe im out of office for the rest of the year. If you made a PR, @nathanhammond or @tknickman may be able to help get it merged in the meantime! Look for util.ValidateGraph() uses to see where cycles are being checked!

Commented On 01 Dec 2022 at 07:45:29
Issue Comment

Mehulkar

feat(cli): auto excludes for frameworks

We never need to cache .next/cache/**, this PR extends our framework inference to also include globs that can be automatically added to includes and excludes.

For now this is being used ONLY for the excludes on Next.js, but could be extended in the future.

NOTE: This can be done now by adding the glob to your outputs:

{
  "pipeline": {
    "build": {
      "outputs": [".next/**", "!.next/cache/**"]
    },
    "lint": {
      "outputs": []
    }
  }
} 

Because we support this now, we want to solve this via documentation only instead of adding this automatically (too magic-y)

Forked On 21 Nov 2022 at 08:58:42

Mehulkar

I'm a bit concerned that we just got rid of magic outputs defaults in #2712, and then we're adding it back in 🤔 . Would it make more sense to put this in examples/templates/docs instead of in framework inference?

Commented On 21 Nov 2022 at 08:58:42
Pull Request

Mehulkar

Refactor Summary structs for more flexible use

Created On 21 Nov 2022 at 08:49:28

Mehulkar

Initialize DryRunSummary early and pass consistently for printers

Pushed On 21 Nov 2022 at 08:47:17

Mehulkar

Combine DryRun functions for multi and single package contexts

Pushed On 21 Nov 2022 at 08:47:17

Mehulkar

Initialize RunSummary outside DryRuns

We want to be able to use this RunSummary for RealRuns too eventually

Pushed On 21 Nov 2022 at 08:47:17

Mehulkar

Rename structs to better reflect what they contain

Pushed On 21 Nov 2022 at 08:47:17

Mehulkar

Comments

Pushed On 21 Nov 2022 at 08:47:17

Mehulkar

Only initialize summary for dry runs

Pushed On 21 Nov 2022 at 08:47:17
Create Branch
Mehulkar In vercel/turbo Create Branchmk/run-summary-prework

Mehulkar

Incremental bundler and build system optimized for JavaScript and TypeScript, written in Rust – including Turbopack and Turborepo.

On 21 Nov 2022 at 08:46:07

Mehulkar

feat(cli): auto excludes for frameworks

We never need to cache .next/cache/**, this PR extends our framework inference to also include globs that can be automatically added to includes and excludes.

For now this is being used ONLY for the excludes on Next.js, but could be extended in the future.

NOTE: This can be done now by adding the glob to your outputs:

{
  "pipeline": {
    "build": {
      "outputs": [".next/**", "!.next/cache/**"]
    },
    "lint": {
      "outputs": []
    }
  }
} 

Because we support this now, we want to solve this via documentation only instead of adding this automatically (too magic-y)

Merged On 21 Nov 2022 at 08:23:36

Mehulkar

Isn't .next/ already git-ignored?

Commented On 21 Nov 2022 at 08:23:36
Merge

Mehulkar

feat(docs): update ent link for turborepo

Link to new enterprise page (https://vercel.com/solutions/turborepo) for Turborepo

Forked On 21 Nov 2022 at 07:58:03

Mehulkar

Where is this contextual-enterprise string coming from?
On 21 Nov 2022 at 07:58:03

Mehulkar

feat(docs): update ent link for turborepo

Link to new enterprise page (https://vercel.com/solutions/turborepo) for Turborepo

Merged On 21 Nov 2022 at 07:58:14

Mehulkar

Commented On 21 Nov 2022 at 07:58:14

Mehulkar

feat(docs): update ent link for turborepo

Link to new enterprise page (https://vercel.com/solutions/turborepo) for Turborepo

Merged On 21 Nov 2022 at 07:58:14

Mehulkar

Commented On 21 Nov 2022 at 07:58:14

Mehulkar

fix(docs): update add to project docs

Address two issues with the "add to project" docs.

  1. provide reference to turbo.json docs
  2. include .gitignore step

Merged On 21 Nov 2022 at 03:34:55

Mehulkar

Commented On 21 Nov 2022 at 03:34:55

Mehulkar

Add Go Unit tests to test workflow (#2768)

Also reduces set of files that will trigger go lint and unit tests

Pushed On 19 Nov 2022 at 12:10:57
Pull Request

Mehulkar

Add Go Unit tests to test workflow

Created On 19 Nov 2022 at 12:10:56
Issue Comment

Mehulkar

Add Go Unit tests to test workflow
Forked On 19 Nov 2022 at 12:10:42

Mehulkar

Merging since the benchmarking failures are unrelated to this change

Commented On 19 Nov 2022 at 12:10:42

Mehulkar

Reduce set of files that will trigger go lint and unit tests

Pushed On 18 Nov 2022 at 08:05:27
Merge

Mehulkar

Add Go Unit tests to test workflow
Forked On 18 Nov 2022 at 07:59:20

Mehulkar

I can change that. I copied it from Go Lint, but that one could be scoped down as well
On 18 Nov 2022 at 07:59:20

Mehulkar

Add Go Unit tests to test workflow
Merged On 18 Nov 2022 at 07:59:20

Mehulkar

Commented On 18 Nov 2022 at 07:59:20
Create Branch
Mehulkar In vercel/turbo Create Branchmehulkar/turbo-560-log-resolved-task-config-in-dry-run

Mehulkar

Incremental bundler and build system optimized for JavaScript and TypeScript, written in Rust – including Turbopack and Turborepo.

On 18 Nov 2022 at 07:45:44
Pull Request

Mehulkar

Log the raw, resolved task definition in Dry Run

Created On 18 Nov 2022 at 07:27:54
Issue Comment

Mehulkar

Log the raw, resolved task definition in Dry Run

Log the task definition in dry runs. This will be useful when we move towards composable turbo.json, where the task definition is composed of multiple configs.

Forked On 18 Nov 2022 at 07:27:54

Mehulkar

Will re-open when ready.

Commented On 18 Nov 2022 at 07:27:54
Pull Request

Mehulkar

Add Go Unit tests to test workflow

Created On 18 Nov 2022 at 06:46:41

Mehulkar

Add Go Unit tests to test workflow

Pushed On 18 Nov 2022 at 06:46:35

Mehulkar

Delete go-unit workflow

Pushed On 18 Nov 2022 at 06:46:35

Mehulkar

docs: Fix 404s (#2764)

Pushed On 18 Nov 2022 at 06:42:57

Mehulkar

Update metro.config.js (#2759)

Force Metro to resolve (sub)dependencies only from the nodeModulesPaths. Without this line, the native app was crashing due to the following error:

Error: Unable to resolve module ./packages/ui/node_modules/react-native/Libraries/HeapCapture/NativeJSCHeapCapture from /Users/username/code/turbo/with-react-native-web/apps/native/.

"Failed to call into JavaScript module method RCTDeviceEventEmitter.emit(). Module has not been registered as callable. Registered callable JavaScript modules (n = 0): .
        A frequent cause of the error is that the application entry file path is incorrect. This can also happen when the JS bundle is corrupt or there is an early initialization error when loading React Native." 

I followed the Expo docs and added step 3 to get this example working again for me.

https://docs.expo.dev/guides/monorepos/#modify-the-metro-config:~:text=%2C%0A%5D%3B-,//%203.%20Force%20Metro%20to%20resolve%20(sub)dependencies%20only%20from%20the%20%60nodeModulesPaths%60%0Aconfig.resolver.disableHierarchicalLookup%20%3D%20true%3B,-module.exports

Pushed On 18 Nov 2022 at 06:42:57
Issue Comment

Mehulkar

chore(examples): add package manager
Forked On 18 Nov 2022 at 06:31:05

Mehulkar

Need to check , but I think our test suite also sets the packageManager when it's running through the examples. may need to disable that or update that mechanism

Commented On 18 Nov 2022 at 06:31:05

Mehulkar

chore(examples): add package manager
Merged On 18 Nov 2022 at 06:30:30

Mehulkar

Commented On 18 Nov 2022 at 06:30:30
Merge

Mehulkar

chore(examples): add package manager
Forked On 18 Nov 2022 at 06:30:22

Mehulkar

What does that caret do? I don't see it in the docs https://nodejs.org/api/corepack.html
On 18 Nov 2022 at 06:30:22

Mehulkar

chore(examples): add package manager
Merged On 18 Nov 2022 at 06:30:30

Mehulkar

Commented On 18 Nov 2022 at 06:30:30
Create Branch
Mehulkar In vercel/turbo Create Branchmk/go-unit-tests

Mehulkar

Incremental bundler and build system optimized for JavaScript and TypeScript, written in Rust – including Turbopack and Turborepo.

On 18 Nov 2022 at 06:29:08