may-hartov Github contribution chart
may-hartov Github Stats
may-hartov Most Used Languages

Activity

01 Sep 2022

May-hartov

removed redundant files

Pushed On 01 Sep 2022 at 11:11:17

May-hartov

Merge pull request #2 from microsoft/dev/mahartov/removeRedundantFiles

removed redundant files

Pushed On 01 Sep 2022 at 11:11:17

May-hartov

removed redundant files

Created On 01 Sep 2022 at 11:11:16

May-hartov

removed redundant files

Created On 01 Sep 2022 at 11:11:06
Create Branch
May-hartov In microsoft/powerbi-client-vue-js Create Branchdev/mahartov/removeRedundantFiles

May-hartov

Power BI Vue.js component. This library lets you embed Power BI report, dashboard, dashboard tile, report visual, or Q&A in your Vue.js application.

On 01 Sep 2022 at 11:10:58

May-hartov

Added README.md

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Created a normal vue app

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 243784: Added owners.txt to powerbi-client-vue-js

Added owners.txt

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 242681: Adding OneBranch pipeline YAML config file for powerbi-client-vue-js-Buddy

The Pipeline is running successfully and publishing the needed artifacts, which are:

  1. Source artifacts.
  2. Build artifacts.
  3. Tgz Package.

The published outputs can be seen in the image below:

MicrosoftTeams-image.png

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 255151: Embedding Components for Vue wrapper

This PR consists of only Components and Test files for those components.

Coding checklist

  • [X] Use kebab-case for events
  • [X] Declare Props with camelCase and use kebab-case in templates
  • [X] Data should always return a function
  • [X] Validate props with good definitons
  • [X] Stay consistent with your shorthand directive used in project
  • [X] Use PascalCase for naming components
  • [X] Template expression should only have basic javascript
  • [X] Use suitable datatype assigned to the variable
  • [X] Don't call a function in $created and $watch function
  • [X] Use keywords (const / let ) provided by typescript smartly instead of var keyword
  • [X] Use $refs instead of jquery
  1. Embedding Dashboard component

PowerBIDashboardEmbed.gif

  1. Embedding Tile component

PowerBITileEmbed.gif

  1. Embedding PaginatedReport component

PowerBIPaginatedReportEmbed.gif

  1. Embedding Visual Component PowerBIVisual.gif

  2. Embedding QnA Component Qna.gif

Related work items: #739756

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 274163: [Vue wrapper]: Add SDK type at the service instance creation

We add the SDK type at the service instance creation to keep a log of wrapper usage

Fiddler log - image (2).png

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 241482: [Vue Wrapper]: Initial Demo App

This PR contains demo app for Embedding Power BI Report component

  1. constant.ts - It contains all constants used in App.vue
  2. App.vue - It contains basic structure for demo app and also functionalities
  3. PowerBIBaseEmbed.vue - Base component to hold common properties for all the Power BI entities
  4. PowerBIReportEmbed.vue - It contains code for Embedding Report component
  5. utils.ts - It contains utility functions which are used in the code.
  6. tests folder - It contains test files for testing all components

Screenshots

GIF PowerBIReportEmbed.gif

  1. Homepage: image.png

  2. Embed Report button clicked: image (2).png

  3. Delete Visual clicked: image (3).png

  4. Hide Filter Pane clicked: image (4).png

  5. Console.log for all events: image.png

  6. Set Event Clicked (Data Selected): image (2).png

Coding checklist

  • [X] Use kebab-case for events
  • [X] Declare Props with camelCase and use kebab-case in templates
  • [X] Data should always return a function
  • [X] Validate props with good definitons
  • [X] Stay consistent with your shorthand directive used in project
  • [X] Use PascalCase for naming components
  • [X] Template expression should only have basic javascript
  • [X] Use suitable datatype assigned to the variable
  • [X] Don't call a function in $created and $watch function
  • [X] Use keywords (const / let ) provided by typescript smartly instead of var keyword
  • [X] Use $refs instead of jquery

Related work items: #770877, #775185

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 286753: [Vue wrapper]: Update config for build and resolve build and pack issues

Related work items: #739756

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 269233: [Vue wrapper]: Setup Readme file and other license files

Modified Readme file

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 294011: Added package to demo and Replaced deleteVisual with changeVisualType

Added package to demo and Replaced deleteVisual with changeVisualType

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 296468: [Vue wrapper]: Update the code with the Bug Bash issues

Added try catch for getVisualByName

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 296848: updated demo dependency of pbiVue to npm

updated demo dependency of pbiVue to npm We are about to release to NPM so version 1.0.0 will be available with the release

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 296862: removed private from package to unblock release

removed private from package to unblock release

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 297846: Update OneBranch Pipeline to include README.md, SECURITY.md and LISENCE.txt

  1. Updated the copy tasks to include README.md, SECURITY.md and LISENCE.txt in the output folders.
  2. Updated the cmd file name to remove CDPx reference.

Related work items: #886906

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

version bump

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 298406: release version bump 1.0.1

version bump

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merged PR 299286: Update Vue.js pipeline for getting a folder structure similar to javascript SDK.

Updated the copy tasks to give the output folder structure which will have README.md and package.json in the same folder. It will be similar to the JavaScript SDK output folder.

Output folder structure -

image.png

Related work items: #890881

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merge remote-tracking branch 'ado/main' into dev/mahartov/mirror_101

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Merge pull request #1 from microsoft/dev/mahartov/mirror_101

Dev/mahartov/mirror 101

Pushed On 01 Sep 2022 at 11:08:31

May-hartov

Dev/mahartov/mirror 101

Created On 01 Sep 2022 at 11:08:30

May-hartov

Dev/mahartov/mirror 101

Created On 01 Sep 2022 at 11:08:23
Create Branch
May-hartov In microsoft/powerbi-client-vue-js Create Branchdev/mahartov/mirror_101

May-hartov

Power BI Vue.js component. This library lets you embed Power BI report, dashboard, dashboard tile, report visual, or Q&A in your Vue.js application.

On 01 Sep 2022 at 11:08:09

May-hartov

Merged PR 234536: [Developer Samples]: Add config folders and update variable names

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

updated reference in Java samples

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

undo previous commit

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Merged PR 243931: [Developer Samples]: Add try catch block for encryption samples

Here we handle the case when we have cloud gateway.

In case of cloud gateway, when we try to get the gateway information using gatewayId, the call throws a 404 Not Found error. This error indicates the existence of cloud gateway.

In case of on-premises gateway, we get a success response with information like publicKey(required for encryption).

So here, we add try catch block to handle the 404 error and continue the flow with cloud gateway.

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Merged PR 239856: [Developer Samples]: Update reference to environment variables

Related work items: #766862, #769896

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Updated README.md - add encrypt credentials samples in main readme

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Merged PR 279360: [Developer Samples]: Migrate react samples from msal to msal-react, update python requirements.txt

  1. python encryption samples requirements.txt update

  2. Migrating react samples from msal to @azure/msal-react

References - https://github.com/AzureAD/microsoft-authentication-library-for-js/blob/dev/lib/msal-react/docs/class-components.md https://docs.microsoft.com/en-us/azure/active-directory/develop/tutorial-v2-react

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Merged PR 285470: Developer samples - NodeJS: Upgrade sample to use MSAL authentication library instead of ADAL

Upgrade NodeJS samples to use MSAL authentication library instead of ADAL

  1. Master User Authentication

image.png

  1. Service Principal Authentication

image (2).png

Related work items: #769133

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Merge remote-tracking branch 'ado/master' into dev/mahartov/msalAndEnhancements

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Merge pull request #194 from microsoft/dev/mahartov/msalAndEnhancements

Dev/mahartov/msal and enhancements

Pushed On 30 Aug 2022 at 02:26:59

May-hartov

Dev/mahartov/msal and enhancements

Created On 30 Aug 2022 at 02:26:56

May-hartov

Dev/mahartov/msal and enhancements

Created On 30 Aug 2022 at 12:21:32
Create Branch
May-hartov In microsoft/PowerBI-Developer-Samples Create Branchdev/mahartov/msalAndEnhancements

May-hartov

A collection of Power BI samples for developer use.

On 30 Aug 2022 at 12:20:40

May-hartov

Release 1.12.0

Release version 1.12.0 Includes

  • Grouped column filters
  • Hierarchy slicers
  • Show or hide the status bar

Merged On 30 Aug 2022 at 06:30:32

May-hartov

Commented On 30 Aug 2022 at 06:30:32