luisorbaiceta Github contribution chart
luisorbaiceta Github Stats
luisorbaiceta Most Used Languages

Activity

04 Oct 2022

Luisorbaiceta

started

Started On 04 Oct 2022 at 12:45:25
Issue Comment

Luisorbaiceta

Make sure fastify-cli and Fastify docs offer the same structure

Some folks have been letting me know that we offer some different opinions on how to structure an application between the core Fastify docs, our fastify-cli, and how we would do it in practice.

As an example, our docs do not cover fastify-autoload.

https://twitter.com/next2you/status/1572713374781419520?s=20&t=A9cDBoz8vpsHJ_UO_W5dyw

Forked On 02 Oct 2022 at 10:11:15

Luisorbaiceta

In my opinion, fastify-cli should bootstrap the bare minimum and any extras like autoload could be added with a flag like --with-autoload. This would need to be documented too

Commented On 02 Oct 2022 at 10:11:15

Luisorbaiceta

started

Started On 02 Oct 2022 at 06:47:45

Luisorbaiceta

Optimize <img /> loading 🖼️ (#372)

  • sanjaiyan-optimise-img

  • more optimizations :)

  • Update organisations.html

CLS improvement

Pushed On 30 Sep 2022 at 12:33:17

Luisorbaiceta

Optimize `<img />` loading 🖼️

Created On 30 Sep 2022 at 12:33:17

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Merged On 30 Sep 2022 at 12:32:51

Luisorbaiceta

👌

Commented On 30 Sep 2022 at 12:32:51
Issue Comment

Luisorbaiceta

added new organization (MarsX)

Checklist

Forked On 29 Sep 2022 at 10:44:14

Luisorbaiceta

Thanks!

Commented On 29 Sep 2022 at 10:44:14

Luisorbaiceta

added new organization (MarsX)

Checklist

Merged On 29 Sep 2022 at 09:55:27

Luisorbaiceta

👌

Commented On 29 Sep 2022 at 09:55:27
Issue Comment

Luisorbaiceta

[Menu] Expose onEntryFocus and onOpenAutoFocus

This PR exposes the cited events to allow some primitives to opt out of the default focusFirst when menu is opened

Forked On 28 Sep 2022 at 05:19:53

Luisorbaiceta

This issue is blocking #1137 as well

Commented On 28 Sep 2022 at 05:19:53
Issue Comment

Luisorbaiceta

[DropdownMenu] Proxy focus when non-modal but portalled

When non-modal, but portalled, the content is at the end of the DOM, tabbing out should proxy focus back to near the trigger.

Forked On 28 Sep 2022 at 05:17:49

Luisorbaiceta

Right now, focus next is being prevented even for non-portalled menus. I'm not saying that menus should be navigated with tabs but when focus is inside a menu, tab press should close the menu and focus the next focusable element in the DOM. See this comment for more reference.

Commented On 28 Sep 2022 at 05:17:49
Issue Comment

Luisorbaiceta

[DropdownMenu] Tab press should focus next focusable element outside DropdownMenu

Bug report

To meet WAI-ARIA requirements tab press inside the DropdownMenu should focus the next focusable element outside it

Current Behavior

Nothing happens

Expected behavior

Focus next focusable element outside the primitive

Forked On 28 Sep 2022 at 05:13:33

Luisorbaiceta

duplicate of #1308

Commented On 28 Sep 2022 at 05:13:33
Issue Comment

Luisorbaiceta

[Menubar] Add Menubar primitive

This PR is intended for the Menubar implementation. Closes #1133

  • [x] Discuss API (Following the WAI-ARIA pattern for Menubar)
  • [ ] Add integration tests
  • [ ] Add stories for visual testing
  • [ ] On right or left arrow press, if next focusable element is next tab it should open the tab and focus its trigger as described in WAI-ARIA

Depends on: #1565

Suggested API

<Menubar.Root>
  <Menubar.Menu>
    <Menubar.Trigger />
    <Menubar.Content>
      <Menubar.Item />
    </Menubar.Content>
  </Menubar.Menu>
  <Menubar.Menu>
    <Menubar.Trigger />
    <Menubar.Content>
      <Menubar.Item />
      <Menubar.SubMenu>
        <Menubar.Trigger />
        <Menubar.Content>
          <Menubar.Item />
        </Menubar.Content>
      </Menubar.SubMenu>
    </Menubar.Content>
  </Menubar.Menu>
</Menubar.Root> 

For Menus and Submenus the Dropdown implementation will be used. Any additional behaviour will be added via its controlled api

Forked On 28 Sep 2022 at 05:10:49

Luisorbaiceta

Hi everyone! A review would really help to push this forward 🙃

Commented On 28 Sep 2022 at 05:10:49

Luisorbaiceta

Update swc

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Fix

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Fix wasm

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Fix

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Revert "Update swc"

This reverts commit c3db1023cb77a773d43f381d511f96f87528a9e5.

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Revert "Fix"

This reverts commit 082e766ee5526d7f3a2f30e5e1638658fcee206e.

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Revert "Fix wasm"

This reverts commit fbf1bd1198cfb8daabc6a9ec4e57d1348fe51f0a.

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Revert "Fix"

This reverts commit 112589e2d92392ee1f66aaff64063e3d971c4780.

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Rename flight parameters to rsc/next (#40979)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Remove outdated warning (#40988)

Cleans up a leftover warning as it's no longer relevant to be shown at this particular spot.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

misc: add MANGLING_DEBUG option (#40958)

Context:

I am doing some work re: bundle size so I'm spending a lot of time looking at the bundles we generate. This debug options basically deactives mangling and beautifies the output whilst keeping the dead code elimination from Terser which is helpful for me to check what I'm removing.

this is what the output is like with it.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Fix wrong code condition used when bundling the server (#40987)

We observed this bug when using .tsx as the extension (currently the condition only matches .m?js). Besides that, react/jsx-runtime shouldn't be external too because it has React imported.

Bug

  • [ ] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Move pagesDir handling out of wrappedRender (#40995)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Fix unused CSS module imports are tracked on the server (#40996)

Reported by @hanneslund, when a CSS modules file gets imported in server components, during collectClientComponentsAndCSSForDependency in our client entry plugin it will always be collected no matter it is used or not. Due to the restriction that we have to collect these imports to create the client entry, it has to run in the finishMake compiler phase and at that time, module optimization hasn't started yet.

To fix that issue, we run another pass in afterOptimizeModules just to collect CSS imports for the server style manifest and we can filter out unused modules there.

Bug

  • [ ] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Add test case for react-server import condition (#40997)

The react-server condition for exports is already covered. This PR adds a new test case to cover the imports condition for internal dependencies.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

v12.3.2-canary.12

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Skip creating virtual app client entry for pages (#41000)

When there're only one edge route in pages/ and one in app/, the virtual client entry is split into pages chunks which is not expected. We should only create client virtual entries for app/, not pages/, now we skip the pages/ entries for client entry now

Bug

  • [ ] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Disable msw in production

Pushed On 28 Sep 2022 at 05:04:14

Luisorbaiceta

Disable msw in production

Created On 28 Sep 2022 at 10:39:18

Luisorbaiceta

Disable msw in production

Pushed On 28 Sep 2022 at 10:39:02

Luisorbaiceta

The React Framework

Forked On 28 Sep 2022 at 10:38:24

Luisorbaiceta

started

Started On 28 Sep 2022 at 07:44:27

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Forked On 28 Sep 2022 at 06:51:18

Luisorbaiceta

Digging further I've found that either we set a container with a fixed aspect ratio and make the logos fill or we target the image logos like this: ```css .logo-img { aspect-ratio: attr(width) / attr(height); } ```
On 28 Sep 2022 at 06:51:18

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Merged On 28 Sep 2022 at 06:51:19

Luisorbaiceta

Commented On 28 Sep 2022 at 06:51:19

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Forked On 27 Sep 2022 at 07:54:35

Luisorbaiceta

`width` needs to be set too, to fully prevent CLS. Lets see if with `160` we get a good generic aspect ratio for the logos
On 27 Sep 2022 at 07:54:35

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Merged On 27 Sep 2022 at 07:54:39

Luisorbaiceta

Commented On 27 Sep 2022 at 07:54:39

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Merged On 27 Sep 2022 at 07:54:39

Luisorbaiceta

Commented On 27 Sep 2022 at 07:54:39

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Merged On 27 Sep 2022 at 07:52:39

Luisorbaiceta

Commented On 27 Sep 2022 at 07:52:39

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Forked On 27 Sep 2022 at 07:52:00

Luisorbaiceta

`width` needs to be set too to fully prevent CLS. Lets see if with `160` we get a good generic aspect ratio
On 27 Sep 2022 at 07:52:00

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Merged On 27 Sep 2022 at 07:52:39

Luisorbaiceta

Commented On 27 Sep 2022 at 07:52:39

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Forked On 27 Sep 2022 at 04:13:39

Luisorbaiceta

https://web.dev/optimize-cls/
On 27 Sep 2022 at 04:13:39

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Merged On 27 Sep 2022 at 04:13:39

Luisorbaiceta

Commented On 27 Sep 2022 at 04:13:39
Issue Comment

Luisorbaiceta

Optimize `<img />` loading 🖼️

Optimize <img /> loading 🖼️

Forked On 26 Sep 2022 at 06:01:24

Luisorbaiceta

Does not affect large contentful paint so I agree with parallelizing and lazy loading the assets. It does affect cumulative layout shift in the organizations page though. Could you fix that? The height property will let the browser know beforehand how much space has to save to avoid this issue

Commented On 26 Sep 2022 at 06:01:24