kutsan Github contribution chart
kutsan Github Stats
kutsan Most Used Languages

Activity

25 Nov 2022

Kutsan

started

Started On 25 Nov 2022 at 10:47:14
Issue Comment

Kutsan

Can't convert milliseconds timestamp

Environment details

  • OS: Linux
  • Node.js version: 8.x
  • npm version: 6.x
  • @google-cloud/bigquery version:

Steps to reproduce

When trying to insert a timestamp which is in milliseconds to BigQuery I get the following error:

BigQuery: PartialFailureError  [{"errors":[{"message":"Timestamp field value is out of range:1571872447236999936","reason":"invalid"}],"row":{"startTime":"1571872447237","sessionId":"daccbf09-a8d9-4905-b777-d1c3ab5fb0e9-pzuojj","sessionLength":"22"}}] 

Here is the actual value of timestamp 1571872447237

Forked On 24 Nov 2022 at 02:39:57

Kutsan

We were having the same problem and had to convert the date to ISO format.

new Date(parsedData.event.event_timestamp_ms).toISOString(); 

Commented On 24 Nov 2022 at 02:39:57

Kutsan

[Question] Is there a way to customize property threshold for new lines?

I saw in another issue that it was maybe possible to adjust the property threshold before lines get added. Just curious if there's a way to adjust that threshold. Thanks!

Forked On 24 Nov 2022 at 11:36:17

Kutsan

Hi, currently there isn't a way to optionally set the threshold without forking the whole project. I'd like to keep the options at their reasonable defaults. Besides, as far as I know there isn't a clean way to make this since it's a JSON config and you can't really accept user input. It needs to be like below and I don't like the look of it.

{
  "extends": ["stylelint-config-clean-order", "stylelint-config-clean-order/minimal-threshold"]
} 

Commented On 24 Nov 2022 at 11:36:17

Kutsan

started

Started On 18 Nov 2022 at 12:40:38

Kutsan

started

Started On 16 Nov 2022 at 09:06:00

Kutsan

started

Started On 13 Nov 2022 at 10:57:20

Kutsan

started

Started On 11 Nov 2022 at 12:26:26

Kutsan

Forked On 10 Nov 2022 at 09:24:10

Kutsan

feat(kitty): add custom kitty icon, thanks @DinkDonk

Pushed On 08 Nov 2022 at 05:39:26

Kutsan

Add "after-comment" to "at-rule-empty-line-before" ignore list?

https://stylelint.io/user-guide/rules/at-rule-empty-line-before/#after-comment

Forked On 08 Nov 2022 at 05:37:37

Kutsan

Thanks! It makes sense. I added this in v2.1.0.

Commented On 08 Nov 2022 at 05:37:37

Kutsan

feat: add after-comment to at-rule-empty-line-before ignore list

Pushed On 08 Nov 2022 at 05:31:19

Kutsan

2.1.0

Pushed On 08 Nov 2022 at 05:31:19
Create Branch

Kutsan

A clean and complete config for stylelint-order.

On 08 Nov 2022 at 05:31:20

Kutsan

started

Started On 07 Nov 2022 at 07:34:36

Kutsan

started

Started On 06 Nov 2022 at 05:47:51
Started

Kutsan

started

Started On 02 Nov 2022 at 02:41:41

Kutsan

started

Started On 01 Nov 2022 at 08:40:49

Kutsan

started

Started On 01 Nov 2022 at 08:07:18

Kutsan

started

Started On 01 Nov 2022 at 05:59:56

Kutsan

[fix] Check styles that was imported from other file

Issue: https://github.com/Intellicode/eslint-plugin-react-native/issues/165#issuecomment-983636750

Forked On 01 Nov 2022 at 07:29:54

Kutsan

Friendly ping @Intellicode.

Commented On 01 Nov 2022 at 07:29:54

Kutsan

started

Started On 28 Oct 2022 at 11:07:34

Kutsan

About emptyLineBefore

"emptyLineBefore": "threshold",
"emptyLineMinimumPropertyThreshold": 5    // larger than 4 

👆 it is better? for example:

  • styling with <col> effectively, like this:
<colgroup>
  <col style="background-color: yellow; width: 20%" span="2" />
</colgroup> 

Only border, background, width and visibility are applied to <col> elements. https://www.w3.org/TR/CSS21/tables.html#columns

  • emptyLineBefor is unnecessary, like this:
p {
  color: #000;
  background-color: #fff;
} 

Forked On 26 Oct 2022 at 09:19:35

Kutsan

@wimhendrikx You're right, I should have digged the docs a little more. 😬

I added this in https://github.com/kutsan/stylelint-config-clean-order/commit/83fbd4039c1d3bb2ba12f0bee4705aba84c76dac and published with version v2.0.0. It would be great if you can test it.

Commented On 26 Oct 2022 at 09:19:35

Kutsan

Set severty as "warning"?

I find "error" a bit too harsh for bad properties order.

When I am creating my styles I firstly don't care about the order and what to see if I make real errors. As a last step I let my linter auto-fix my code.

Forked On 26 Oct 2022 at 09:17:16

Kutsan

Thanks Wim, you're right. I use the same workflow and it does make sense to use warning severity. This is added in https://github.com/kutsan/stylelint-config-clean-order/commit/58ff866b37afe6bf703255cc10625f0f5de47990 and published with v2.0.0 version. Thanks again!

Commented On 26 Oct 2022 at 09:17:16

Kutsan

test: fix the test case with new changes

Pushed On 26 Oct 2022 at 09:13:20
Create Branch

Kutsan

A clean and complete config for stylelint-order.

On 26 Oct 2022 at 09:11:52

Kutsan

feat!: use warning level severity

Pushed On 26 Oct 2022 at 09:11:52

Kutsan

feat!: add emptyLineBefore after 5 and more properties

Pushed On 26 Oct 2022 at 09:11:52

Kutsan

2.0.0

Pushed On 26 Oct 2022 at 09:11:52