krispya Github contribution chart
krispya Github Stats
krispya Most Used Languages

Activity

09 Dec 2022

Krispya

Fixed another bug but it's still inacturate

Pushed On 09 Dec 2022 at 06:09:00

Krispya

Fix edge detection. Vertex detection still broke

Pushed On 09 Dec 2022 at 12:47:00

Krispya

My test case plus some small fixes

Pushed On 08 Dec 2022 at 06:48:19

Krispya

Fix TriangleHelper not updating on set properly

Pushed On 08 Dec 2022 at 06:09:15

Krispya

Simplified Debug code so it is reliable

Pushed On 08 Dec 2022 at 07:06:45

Krispya

Fix debug lifecycle cleaning itself up

Pushed On 08 Dec 2022 at 06:07:55

Krispya

Debug scene objects are placed in a group now. drawTriangle can win z fights 8)

Pushed On 08 Dec 2022 at 12:43:55

Krispya

Split out wire and filled draw calls. Change drawWireSphere to be three circles instead of a whole sphere mesh

Pushed On 07 Dec 2022 at 05:27:04

Krispya

Added draw sphere and some result vars to sphere caster

Pushed On 07 Dec 2022 at 02:26:27

Krispya

Add material options for the helpers I currently implement

Pushed On 06 Dec 2022 at 10:44:49

Krispya

Debug now has pooling! Added a wip TriangleHelper

Pushed On 06 Dec 2022 at 07:20:28

Krispya

Added a point helper. Filled out other lighting draw methods

Pushed On 06 Dec 2022 at 12:04:58

Krispya

Implement a debug interface. WIP sphere casting

Pushed On 05 Dec 2022 at 05:02:21
Issue Comment

Krispya

Add support for pre-step and post-step logic

Hi!

Looking for thoughts on adding pre-step and post-step events.

Use cases for this include creating custom character and vehicle controllers, where forces should only be applied once per physics step. When not using timestep="vary", applying forces on each frame isn't desirable, as not every frame will step the physics world, some will just interpolate.

This could come in the form of hooks, e.g.

import { usePreStep, usePostStep } from "@react-three/rapier"

usePreStep(() => { /* called before stepping the world */ })
usePostStep(() => { /* called after stepping the world */ }) 

Or via signals/event handlers on the wrapped rapier World, e.g.

world.onPreStep.add(() => { /* called before stepping the world */ })
world.onPostStep.add(() => { /* called after stepping the world */ }) 

Or maybe a combination of both.

Keen to hear thoughts, and as usual, happy to help implement 🙂

Forked On 04 Dec 2022 at 02:00:35

Krispya

I think both useBeforePhysicsStep and useAfterPhysicsStep should be within the same loop as the physics step - running only once for a rapier physics step.

To get interpolated values, you could already use useFrame with a lower priority than the <Physics /> updatePriority.

(Correct me if you don't think this is right)

Makes perfect sense to me.

Commented On 04 Dec 2022 at 02:00:35

Krispya

No longer walk up slopes that are too steep. WIP snap to ground code.

Pushed On 01 Dec 2022 at 12:48:06

Krispya

Implemented some more advanced slope interactions. Working on improving slope and uneven terrain

Pushed On 30 Nov 2022 at 05:28:48

Krispya

Testing a bunch of ideas for ground detection

Pushed On 30 Nov 2022 at 01:00:59

Krispya

Fix some ground state issues. Implement experimental sphere casting. Make Sliding its own component.

Pushed On 29 Nov 2022 at 08:44:28

Krispya

Messing with shadows. Might have overdone it

Pushed On 29 Nov 2022 at 12:29:36

Krispya

Name anonymous functions for profiling

Pushed On 28 Nov 2022 at 07:35:34
Issue Comment

Krispya

RFC: v9 goals

Let's discuss some v9 goals here. These are all tentative right now.

Completed

  • [x] Add stage-based lifecycle, deprecate useFrame for useUpdate https://github.com/pmndrs/react-three-fiber/pull/2279
  • [x] Remove onUpdate prop https://github.com/pmndrs/react-three-fiber/pull/2480
  • [x] Remove updateStyle from Size https://github.com/pmndrs/react-three-fiber/pull/2489
  • [x] act types for testing https://github.com/pmndrs/react-three-fiber/pull/2492
  • [x] Instance descriptors, refactor JSX types & extend https://github.com/pmndrs/react-three-fiber/pull/2465
  • [x] prefer named functions, for loops in hot paths https://github.com/pmndrs/react-three-fiber/pull/2540 (backported in v8.8.7)
  • [x] upgrade Zustand to v4 #2558
  • [x] export all public types #2559, #2583

TODO

  • [ ] respect React.StrictMode across renderers #2547
  • [ ] redirect react-native-web entrypoint #2566

Pending

  • [ ] Update demand frameloop mode to keep updating delta even if it skips render. Be sure to test all frameloop modes with the useUpdate changes.
  • [ ] ? Refactor color space API (see https://github.com/pmndrs/react-three-fiber/issues/2299)
  • [ ] ? Add cpuFrameTime and gpuFrameTime for performance based rendering

Forked On 28 Nov 2022 at 07:09:51

Krispya

Thanks so much for all your hard work Cody. I wanted to add here some type exports for the different r3f props which were previously exported as Vector3, Color, etc.

Commented On 28 Nov 2022 at 07:09:51

Krispya

More reliable ground detection implemented

Pushed On 28 Nov 2022 at 09:16:54

Krispya

Did another take at the CCT with simplified ground detection

Pushed On 28 Nov 2022 at 07:55:45
Issue Comment

Krispya

Add support for pre-step and post-step logic

Hi!

Looking for thoughts on adding pre-step and post-step events.

Use cases for this include creating custom character and vehicle controllers, where forces should only be applied once per physics step. When not using timestep="vary", applying forces on each frame isn't desirable, as not every frame will step the physics world, some will just interpolate.

This could come in the form of hooks, e.g.

import { usePreStep, usePostStep } from "@react-three/rapier"

usePreStep(() => { /* called before stepping the world */ })
usePostStep(() => { /* called after stepping the world */ }) 

Or via signals/event handlers on the wrapped rapier World, e.g.

world.onPreStep.add(() => { /* called before stepping the world */ })
world.onPostStep.add(() => { /* called after stepping the world */ }) 

Or maybe a combination of both.

Keen to hear thoughts, and as usual, happy to help implement 🙂

Forked On 26 Nov 2022 at 07:34:37

Krispya

Yeah, it's an interesting problem space. I added the ability to customize the stage lifecycle but it's really something for a power user. I don't think people should have to think about it when interacting with a library. My suggestion for both mental model and backwards compatibility is to make something like those hooks as suggested and then with v9 have the ability to split out those loops into their own stages if the user is so inclined. Otherwise they get slotted into lifecycle automatically be default.

I think the part that isn't clear from just the hooks is that useBeforePhysicsStep would presumably be inside the same loop as the physics step, meaning it can be fixed or unconstrained while useAfterPhysicsStep, if it is meant for interpolation, has to always be in an unconstrained loop. This would be a big gotcha for people who aren't intimate with the Rapier lifecycle as useAfterPhysicsStep would not be an actual effect.

Maybe a way to configure the loops these physics stages fall under (fixed or "varying) would make it more clear and also preempt more robust customization with v9.

Commented On 26 Nov 2022 at 07:34:37

Krispya

Add documentation for running examples locally

Pushed On 26 Nov 2022 at 01:57:26

Krispya

OreintedBox type now extends Box3

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Revert "OreintedBox type now extends Box3"

This reverts commit f3ed0f4751d58681ac99fc69c346421ba53cd35d.

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Merge pull request #471 from krispya/dev/doc-local-example

Update doc for how to run examples locally

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Fix case with new three.js by forcing normalization

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Update CHANGELOG.md

Pushed On 26 Nov 2022 at 01:57:26

Krispya

BufferGeometry -> Geometry

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Example fixes

Pushed On 26 Nov 2022 at 01:57:26

Krispya

lint fixes

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Remove unused variable

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Merge pull request #474 from gkjohnson/fix-vertex-attribute

Fix case with new three.js by forcing normalization

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Bump ansi-regex from 4.1.0 to 5.0.1

Bumps ansi-regex from 4.1.0 to 5.0.1.


updated-dependencies:

  • dependency-name: ansi-regex dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Bump json-schema and jsprim

Bumps json-schema and jsprim. These dependencies needed to be updated together.

Updates json-schema from 0.2.3 to 0.4.0

Updates jsprim from 1.4.1 to 1.4.2


updated-dependencies:

  • dependency-name: json-schema dependency-type: indirect
  • dependency-name: jsprim dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Bump node-forge and @parcel/utils

Removes node-forge. It's no longer used after updating ancestor dependency @parcel/utils. These dependencies need to be updated together.

Removes node-forge

Updates @parcel/utils from 2.0.0 to 2.7.0


updated-dependencies:

  • dependency-name: node-forge dependency-type: indirect
  • dependency-name: "@parcel/utils" dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Merge pull request #477 from gkjohnson/dependabot/npm_and_yarn/node-forge-and-parcel/utils--removed

Bump node-forge and @parcel/utils

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Merge pull request #475 from gkjohnson/dependabot/npm_and_yarn/ansi-regex-5.0.1

Bump ansi-regex from 4.1.0 to 5.0.1

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Merge pull request #476 from gkjohnson/dependabot/npm_and_yarn/json-schema-and-jsprim-0.4.0

Bump json-schema and jsprim

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Bump postcss and @parcel/transformer-postcss

Bumps postcss and @parcel/transformer-postcss. These dependencies needed to be updated together.

Updates postcss from 6.0.1 to 8.4.14

Updates @parcel/transformer-postcss from 2.0.0 to 2.7.0


updated-dependencies:

  • dependency-name: postcss dependency-type: indirect
  • dependency-name: "@parcel/transformer-postcss" dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Merge pull request #478 from gkjohnson/dependabot/npm_and_yarn/postcss-and-parcel/transformer-postcss-8.4.14

Bump postcss and @parcel/transformer-postcss

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Update skinnedMesh.js

Pushed On 26 Nov 2022 at 01:57:26

Krispya

Latest ground detection code. Will change!

Pushed On 25 Nov 2022 at 10:18:49

Krispya

Various updates

Pushed On 25 Nov 2022 at 10:16:02

Krispya

Fix up debug components

Pushed On 25 Nov 2022 at 07:44:24

Krispya

Update Wander actions. PCT now sets initial position. Added isNearGround flag

Pushed On 24 Nov 2022 at 07:12:12

Krispya

Fixed linting. Fixed the player rig and animations. Improved ground detection

Pushed On 23 Nov 2022 at 09:19:38