krebbl Github contribution chart
krebbl Github Stats
krebbl Most Used Languages

Activity

18 Nov 2022

Create Branch

Krebbl

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Ionic, PhoneGap CLI, PhoneGap Build, Cordova, or Sencha Touch app with OneSignal. Supports Android, iOS, and Amazon's Fire OS platforms. https://onesignal.com

On 18 Nov 2022 at 06:25:43

Krebbl

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Ionic, PhoneGap CLI, PhoneGap Build, Cordova, or Sencha Touch app with OneSignal. Supports Android, iOS, and Amazon's Fire OS platforms. https://onesignal.com

Forked On 18 Nov 2022 at 06:07:38

Krebbl

ExtraErrors are merged into errorSchema again and again

Prerequisites

What theme are you using?

core

Version

5.x Beta.10

Current Behavior

The passed extraErrors are rendered multiple times when typing into an input field.

Expected Behavior

The extraErrors should only be displayed once.

Steps To Reproduce

See example: https://codesandbox.io/s/vigilant-violet-8txkdr

Given the following Form config:

import validator from "@rjsf/validator-ajv6";
import Form from "@rjsf/core";

const schema = {
    "$schema": "http://json-schema.org/draft-07/schema#",
    "type": "object",
    "properties": {
        "email": {
            "type": "string",
            "format": "email"
        },
        "password": {
            "type": "string"
        },
        "passwordConfirmation": {
            "type": "string"
        }
    },
    "required": [
        "email",
        "password",
        "passwordConfirmation"
    ],
    "additionalProperties": false
}
...
<Form
   validator={validator}
   extraErrors={{email: {__errors: ["test"]}}}
   schema={schema}
   onSubmit={handleSubmit}
> 

When typing something into the password field, the extra errors are appended in the UI again and again.

Environment

- OS: MaxOS
- Node: 16.7
- npm: 8.15 

Anything else?

No response

Forked On 14 Oct 2022 at 09:50:51

Krebbl

@heath-freenome Thanks for letting me! I just tried it in the linked code sandbox and the issue unfortunately still exists.

https://codesandbox.io/s/vigilant-violet-8txkdr?file=/package.json

Commented On 14 Oct 2022 at 09:50:51

Krebbl

ExtraErrors are merged into errorSchema again and again

Prerequisites

What theme are you using?

core

Version

5.x Beta.10

Current Behavior

The passed extraErrors are rendered multiple times when typing into an input field.

Expected Behavior

The extraErrors should only be displayed once.

Steps To Reproduce

See example: https://codesandbox.io/s/vigilant-violet-8txkdr

Given the following Form config:

import validator from "@rjsf/validator-ajv6";
import Form from "@rjsf/core";

const schema = {
    "$schema": "http://json-schema.org/draft-07/schema#",
    "type": "object",
    "properties": {
        "email": {
            "type": "string",
            "format": "email"
        },
        "password": {
            "type": "string"
        },
        "passwordConfirmation": {
            "type": "string"
        }
    },
    "required": [
        "email",
        "password",
        "passwordConfirmation"
    ],
    "additionalProperties": false
}
...
<Form
   validator={validator}
   extraErrors={{email: {__errors: ["test"]}}}
   schema={schema}
   onSubmit={handleSubmit}
> 

When typing something into the password field, the extra errors are appended in the UI again and again.

Environment

- OS: MaxOS
- Node: 16.7
- npm: 8.15 

Anything else?

No response

Forked On 05 Oct 2022 at 05:56:57

Krebbl

I'm not able to reproduce this issue on the main branch, so it seems to be fixed there. Waiting for the next beta release now.

Commented On 05 Oct 2022 at 05:56:57
Create Branch

Krebbl

A React component for building Web forms from JSON Schema.

On 04 Oct 2022 at 07:27:31

Krebbl

A React component for building Web forms from JSON Schema.

Forked On 04 Oct 2022 at 07:25:00

Krebbl

ExtraErrors are merged into errorSchema again and again

Prerequisites

What theme are you using?

core

Version

5.x Beta.9

Current Behavior

The passed extraErrors are rendered multiple times when typing into an input field.

Expected Behavior

The extraErrors should only be displayed once.

Steps To Reproduce

Given the following Form config:

import validator from "@rjsf/validator-ajv6";
import Form from "@rjsf/core";

const schema = {
    "$schema": "http://json-schema.org/draft-07/schema#",
    "type": "object",
    "properties": {
        "email": {
            "type": "string",
            "format": "email"
        },
        "password": {
            "type": "string"
        },
        "passwordConfirmation": {
            "type": "string"
        }
    },
    "required": [
        "email",
        "password",
        "passwordConfirmation"
    ],
    "additionalProperties": false
}
...
<Form
   validator={validator}
   extraErrors={{email: {__errors: ["test"]}}}
   schema={schema}
   onSubmit={handleSubmit}
> 

When typing something into the password field, the extra errors are appended in the UI again and again.

Environment

- OS: MaxOS
- Node: 16.7
- npm: 8.15 

Anything else?

No response

Forked On 03 Oct 2022 at 02:59:38

Krebbl

The issue seems to be caused by this line https://github.com/rjsf-team/react-jsonschema-form/blob/33896dc2d196775a3fde63099efdfbdf11514393/packages/core/src/components/Form.tsx#L565 Here the newErrorSchema is merged with the extraErrors but instead of replacing the field errors the extraErrors.email.__errors are appended everytime it runs.

Commented On 03 Oct 2022 at 02:59:38

Krebbl

fix README

Pushed On 21 Sep 2022 at 06:13:52

Krebbl

fix updating app

Pushed On 21 Sep 2022 at 06:13:52

Krebbl

fix updating app

Pushed On 16 Sep 2022 at 10:14:00

Krebbl

fix updating app

Pushed On 16 Sep 2022 at 09:52:43

Krebbl

build image before starting container again

Pushed On 16 Sep 2022 at 09:43:13

Krebbl

add docker to allow docker builds

Pushed On 16 Sep 2022 at 09:32:31
Create Branch
Krebbl In krebbl/mkr-portfolio Create Branchmain

Krebbl

Portfolio

On 16 Sep 2022 at 07:39:57
Create Branch

Krebbl

Portfolio

On 16 Sep 2022 at 07:11:30