koistya Github contribution chart
koistya Github Stats
koistya Most Used Languages

Activity

17 Sep 2022

Issue Comment

Koistya

[Dialog] Add imperative methods to display them directly

Refer to the call and implementation of the ant-design dialog box. This solution brings more flexibility and concise code.

Will there be such a solution?

import { Dialog } from "@material-ui/core";

Dialog.show({
  type: "info",
  title:  "Message",
  content: "Hello",
  onOk: () => { ... }
}); 

Benchmark

  • https://ant.design/components/modal/#components-modal-demo-hooks
  • http://bootboxjs.com/
  • https://dev.to/dmtrkovalenko/the-neatest-way-to-handle-alert-dialogs-in-react-1aoe

Forked On 17 Sep 2022 at 03:39:18

Koistya

@CarbonPool most likely you want imperative handler(s) to be set on the instance of the dialog component rather than relying on static methods, for example:

import * as React from "react";
import { Button, Container } from "@mui/material";
import { ConfirmDialog, DialogElement } from "./ConfirmDialog.js";

export function Example(): JSX.Element {
  const dialogRef = React.useRef<DialogElement>(null);

  return (
    <Container>
      <Button onClick={() => dialogRef.current?.open()}>Open Me</Button>
      
      <ConfirmDialog ref={dialogRef} onConfirm={...} />
    </Container>
  );
} 

https://github.com/kriasoft/react-starter-kit/discussions/2004

Commented On 17 Sep 2022 at 03:39:18

Koistya

Alter entryFileName resolution

Pushed On 12 Sep 2022 at 06:25:02

Koistya

Alter entryFileName resolution

Pushed On 12 Sep 2022 at 06:20:13

Koistya

Alter entryFileName resolution

Pushed On 12 Sep 2022 at 06:19:14

Koistya

feat(node-resolve): add new option, modulePaths (#1104)

  • [node-resolve] Implement new modulePaths option

  • Add unit tests distinguishing modulePaths from moduleDirectories

  • Document new option

  • Update packages/node-resolve/test/test.js

Co-authored-by: Tom Jenkinson tjenkinson@users.noreply.github.com

  • Update packages/node-resolve/README.md

Co-authored-by: Tom Jenkinson tjenkinson@users.noreply.github.com

  • fixup! Update packages/node-resolve/test/test.js

  • Reject moduleDirectories containing a slash

  • chore: arbitrary edit to kick github's actions ui

Co-authored-by: Andrew Hyndman ahyndman@dropbox.com Co-authored-by: Tom Jenkinson tjenkinson@users.noreply.github.com Co-authored-by: Andrew Powell shellscape@users.noreply.github.com

Pushed On 12 Sep 2022 at 06:17:20

Koistya

chore(release): node-resolve v14.1.0

Pushed On 12 Sep 2022 at 06:17:20

Koistya

chore(repo): correct READMEs, minimatch to picomatch (#1260)

  • fix(babel): correct minimatch to picomatch

  • fix(buble): correct minimatch to picomatch

  • fix(commonjs): correct minimatch to picomatch

  • fix(dsv): correct minimatch to picomatch

  • fix(dynamic-import): correct minimatch to picomatch

  • docs(graphql): correct minimatch to picomatch

  • fix(image): correct minimatch to picomatch

  • fix(inject): correct minimatch to picomatch

  • fix(replace): correct minimatch to picomatch

  • fix(strip): correct minimatch to picomatch

  • fix(sucrase): correct minimatch to picomatch

  • docs(typescript): correct minimatch to picomatch

  • fix(url): correct minimatch to picomatch

  • fix(yaml): correct minimatch to picomatch

Pushed On 12 Sep 2022 at 06:17:20

Koistya

fix(run): compatability with commonjs plugin

Pushed On 12 Sep 2022 at 06:17:20

Koistya

Alter entryFileName resolution

Pushed On 12 Sep 2022 at 06:17:20

Koistya

Alter entryFileName resolution

Pushed On 12 Sep 2022 at 06:16:22
Issue Comment

Koistya

fix(run): compatability with `commonjs` plugin

Rollup Plugin Name: run

This PR contains:

  • [x] bugfix
  • [ ] feature
  • [ ] refactor
  • [ ] documentation
  • [ ] other

Are tests included?

  • [ ] yes (bugfixes and features will not be merged without tests)
  • [x] no

Breaking Changes?

  • [ ] yes (breaking changes will not be merged unless absolutely necessary)
  • [x] no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers:

Description

The facadeModuleId variable includes ?commonjs suffix breaking chank.facadeModuleId === input

Forked On 10 Sep 2022 at 08:18:22

Koistya

@shellscape pushed

Commented On 10 Sep 2022 at 08:18:22

Koistya

fix(commonjs): Only proxy detected commonjs entry points (#1180)

  • fix(commonjs): Only proxy detected commonjs entry points

  • chore(commonjs): Make tests work on Node 18

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): commonjs v22.0.1

Pushed On 10 Sep 2022 at 08:17:44

Koistya

fix(typescript): fix declaration file generation for single file outputs (#1201)

Previously, type declaration files were only emitted if outputOptions.dir was used and not outputOptions.file or, as a side effect, if the tsconfig file was specified via a qualified path. This commit fixes that, such that types are also emitted for single file builds.

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): typescript v8.3.4

Pushed On 10 Sep 2022 at 08:17:44

Koistya

fix(dynamic-import-vars): exclude external imports (#1193)

  • fix: exclude external imports

  • test: add test

  • chore: change to http

  • chore: feedback comments

  • refactor: review comments

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): dynamic-import-vars v1.4.4

Pushed On 10 Sep 2022 at 08:17:44

Koistya

fix(commonjs): Exclude multi-line template strings from indent (#1229)

Fixes #1228

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): commonjs v22.0.2

Pushed On 10 Sep 2022 at 08:17:44

Koistya

feat(typescript): allow override of forced noEmit and emitDeclarationOnly compiler options (#1242)

  • add documentation

  • add noForceEmit option and apply in code

  • fix that issue with | undefined

  • tests WIP

  • MR feedback for README

  • fix tests

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): typescript v8.4.0

Pushed On 10 Sep 2022 at 08:17:44

Koistya

feat(typescript): support 4.7 nodenext (#1194)

  • Support typescript 4.7 nodenext module

  • Begin fixing tests

  • Add nodenext test

  • Try things out

  • Fix tests

  • Require typescript 3.7

  • Add test

  • Iron out last details

  • Fix linter warnings

  • Use type cast

  • Fix glob

  • Use RegExp.prototype.test

  • chore: comment on glob

  • chore: simplify glob

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): typescript v8.5.0

Pushed On 10 Sep 2022 at 08:17:44

Koistya

fix(node-resolve): preserve moduleSideEffects when re-resolving files (#1245)

BREAKING CHANGES: Requires Rollup>=2.78.0

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): node-resolve v14.0.0

Pushed On 10 Sep 2022 at 08:17:44

Koistya

fix(node-resolve): handle circular commonjs (#1259)

Pushed On 10 Sep 2022 at 08:17:44

Koistya

chore(release): node-resolve v14.0.1

Pushed On 10 Sep 2022 at 08:17:44

Koistya

fix(run): compatability with commonjs plugin

Pushed On 10 Sep 2022 at 08:17:44

Koistya

Alter entryFileName resolution

Pushed On 10 Sep 2022 at 08:17:44
Issue Comment

Koistya

chore: Upgrade Yarn; fix nightly build

Closes #353

Basically followed steps by @koistya in #354 PR, but I also had to add explicit pnp requirement in .yarnrc file and -j unlimited argument in package.json for yarn run start and yarn run build commands.

Forked On 05 Sep 2022 at 06:09:58

Koistya

@andrewstec cool, thank you!

Commented On 05 Sep 2022 at 06:09:58

Koistya

chore: Upgrade Yarn; fix nightly build (#355)

Pushed On 05 Sep 2022 at 06:09:34

Koistya

chore: Upgrade Yarn; fix nightly build

Created On 05 Sep 2022 at 06:09:33
Issue Comment

Koistya

Patch/nightly build failed upgrade yarn

Closes #353

@koistya If there is a way to test the nightly build just by waiting, let's do that. I only did some very basic testing to see that I can yarn install and yarn start.

Yarn install fixed in the first commit with a yarn upgrade:

ubuntu@gothboots:~/andrew-relay-starter-kit$ yarn install
➤ YN0000: ┌ Resolution step
➤ YN0002: │ @endemolshinegroup/cosmiconfig-typescript-loader@npm:3.0.2 [f3640] doesn't provide typescript (p07f79), requested by ts-node
➤ YN0002: │ @types/webpack-dev-server@npm:4.7.2 doesn't provide webpack (p8da21), requested by webpack-dev-server
➤ YN0002: │ app@workspace:. doesn't provide graphql (pf8a9e), requested by graphql-config
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code
➤ YN0000: └ Completed in 0s 915ms
➤ YN0000: ┌ Fetch step
➤ YN0013: │ yargs@npm:17.5.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yn@npm:3.1.1 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ yocto-queue@npm:0.1.0 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ youch@npm:2.2.2 can't be found in the cache and will be fetched from the remote registry
➤ YN0013: │ zx@npm:6.2.2 can't be found in the cache and will be fetched from the remote registry
➤ YN0000: └ Completed in 4s 259ms
➤ YN0000: ┌ Link step
➤ YN0000: │ ESM support for PnP uses the experimental loader API and is therefore experimental
➤ YN0007: │ app@workspace:. must be built because it never has been before or the last one failed
➤ YN0007: │ argon2@npm:0.28.5 must be built because it never has been before or the last one failed
➤ YN0007: │ esbuild@npm:0.14.34 must be built because it never has been before or the last one failed
➤ YN0000: └ Completed in 3s 964ms
➤ YN0000: Done with warnings in 9s 586ms 

Then yarn start breaks after the upgrade so we need to add the foreach module in the second commit:

ubuntu@gothboots:~/andrew-relay-starter-kit$ yarn run start
➤ YN0000: rollup v2.75.5
➤ YN0000: bundles ./index.ts → dist...
➤ YN0000: <w> [webpack-dev-server] "hot: true" automatically applies HMR plugin, you don't have to add it manually to your webpack configuration.
➤ YN0000: <i> [webpack-dev-server] [HPM] Proxy created: /api,/auth  -> http://localhost:8080
➤ YN0000: <i> [webpack-dev-server] Project is running at:
➤ YN0000: <i> [webpack-dev-server] Loopback: http://localhost:3000/
➤ YN0000: <i> [webpack-dev-server] On Your Network (IPv4): http://10.0.0.192:3000/
➤ YN0000: <i> [webpack-dev-server] On Your Network (IPv6): http://[fe80::20f:feff:fef4:d4e3]:3000/
➤ YN0000: <i> [webpack-dev-server] Content not from webpack is served from './public' directory
➤ YN0000: <i> [webpack-dev-server] 404s will fallback to '/index.html' 

The build was also breaking with the new foreach module plugin, and had to be copied in the third commit to be included in the rollup configuration:

ubuntu@gothboots:~/andrew-relay-starter-kit$ yarn run build
➤ YN0000: ➤ YN0000: Successfully set enableGlobalCache to false
➤ YN0000: ➤ YN0000: ┌ Resolution step
➤ YN0000: ➤ YN0000: └ Completed in 0s 241ms
➤ YN0000: ➤ YN0000: ┌ Post-resolution validation
➤ YN0000: ➤ YN0068: │ babel-plugin-relay ➤ dependencies ➤ @babel/runtime: No matching package in the dependency tree; you may not need this rule anymore.
➤ YN0000: ➤ YN0000: └ Completed
➤ YN0000: ➤ YN0000: ┌ Fetch step
➤ YN0000: ➤ YN0000: └ Completed
➤ YN0000: ➤ YN0000: ┌ Link step
➤ YN0000: ➤ YN0073: │ Skipped due to mode=update-lockfile
➤ YN0000: ➤ YN0000: └ Completed
➤ YN0000: ➤ YN0000: Done with warnings in 0s 457ms
➤ YN0000: 
➤ YN0000: ./index.ts → ./dist...
➤ YN0000: created ./dist in 17.2s
➤ YN0000: app:
➤ YN0000:   assets by status 640 KiB [emitted]
➤ YN0000:     assets by path static/js/*.js 635 KiB
➤ YN0000:       assets by chunk 574 KiB (id hint: vendors)
➤ YN0000:         asset static/js/731.4792c211.js 534 KiB [emitted] [immutable] [minimized] (id hint: vendors) 2 related assets
➤ YN0000:         asset static/js/860.b97b415b.js 39.4 KiB [emitted] [immutable] [minimized] (id hint: vendors) 1 related asset
➤ YN0000:       + 7 assets
➤ YN0000:     asset index.html 4.35 KiB [emitted]
➤ YN0000:     asset assets.json 1.27 KiB [emitted]
➤ YN0000:   assets by status 19 KiB [compared for emit]
➤ YN0000:     assets by path *.png 14.7 KiB
➤ YN0000:       asset logo512.png 9.44 KiB [compared for emit] [from: public/logo512.png] [copied]
➤ YN0000:       asset logo192.png 5.22 KiB [compared for emit] [from: public/logo192.png] [copied]
➤ YN0000:     asset favicon.ico 3.78 KiB [compared for emit] [from: public/favicon.ico] [copied]
➤ YN0000:     asset manifest.json 485 bytes [compared for emit] [from: public/manifest.json] [copied]
➤ YN0000:     asset robots.txt 67 bytes [compared for emit] [from: public/robots.txt] [copied]
➤ YN0000:   Entrypoint main 568 KiB (2.33 MiB) = static/js/runtime-main.8f514298.js 3.66 KiB static/js/731.4792c211.js 534 KiB static/js/main.9310a4e9.js 30.1 KiB 3 auxiliary assets
➤ YN0000:   orphan modules 869 KiB [orphan] 483 modules
➤ YN0000:   runtime modules 8.71 KiB 12 modules
➤ YN0000:   cacheable modules 1.74 MiB
➤ YN0000:     modules by path ../node_modules/ 1.63 MiB 318 modules
➤ YN0000:     modules by path ./ 112 KiB
➤ YN0000:       modules by path ./routes/ 40.6 KiB
➤ YN0000:         ./routes/Home.tsx 1.35 KiB [built] [code generated]
➤ YN0000:         ./routes/AccountSettings.tsx + 2 modules 8.75 KiB [built] [code generated]
➤ YN0000:         + 3 modules
➤ YN0000:       modules by path ./core/ 22.8 KiB
➤ YN0000:         ./core/AuthProvider.tsx + 1 modules 12.2 KiB [built] [code generated]
➤ YN0000:         ./core/history.ts 2.91 KiB [built] [code generated]
➤ YN0000:         ./core/Auth.ts + 4 modules 7.73 KiB [built] [code generated]
➤ YN0000:       ./index.tsx + 22 modules 47.7 KiB [built] [code generated]
➤ YN0000:       ./config.ts 859 bytes [built] [code generated]
➤ YN0000:   app (webpack 5.73.0) compiled successfully in 29679 ms
➤ YN0000: 
➤ YN0000: workers:
➤ YN0000:   asset proxy.js 847 KiB [emitted] (name: main)
➤ YN0000:   orphan modules 1.05 MiB [orphan] 509 modules
➤ YN0000:   runtime modules 884 bytes 4 modules
➤ YN0000:   cacheable modules 903 KiB
➤ YN0000:     modules by path ../node_modules/relay-runtime/ 504 KiB 102 modules
➤ YN0000:     modules by path ../node_modules/react-relay/ 261 KiB 63 modules
➤ YN0000:     modules by path ../node_modules/mime/ 37.5 KiB 4 modules
➤ YN0000:     modules by path ../node_modules/@babel/runtime/ 14.6 KiB 3 modules
➤ YN0000:     modules by path ../node_modules/fbjs/lib/*.js 5.29 KiB 3 modules
➤ YN0000:     modules by path ../node_modules/@cloudflare/kv-asset-handler/dist/*.js 12.5 KiB 2 modules
➤ YN0000:     modules by path ../node_modules/react/ 6.94 KiB
➤ YN0000:       ../node_modules/react/index.js 190 bytes [built] [code generated]
➤ YN0000:       ../node_modules/react/cjs/react.production.min.js 6.75 KiB [built] [code generated]
➤ YN0000:     ./workers/proxy.ts + 42 modules 59.9 KiB [built] [code generated]
➤ YN0000:     ../node_modules/invariant/browser.js 1.36 KiB [built] [code generated]
➤ YN0000:   workers (webpack 5.73.0) compiled successfully in 18813 ms
➤ YN0000: Done in 32s 532ms 

Extra note:

I added the job unlimited argument to the build command too, but I didn't notice much of a difference with the build time. I'm not too sure exactly what rollup is doing or how yarn plugins work, so just FYI that you may want to change some stuff around. Be careful with this pull-request 🌵 .

Forked On 05 Sep 2022 at 04:55:15

Koistya

@andrewstec you can bump Yarn from 4.0.0-rc.6 to 4.0.0-rc.15 (latest) like this:

$ yarn set version 4.0.0-rc.15
$ yarn install
$ yarn dlx @yarnpkg/sdks@3.0.0-rc.15 vscode 

Note, that the latest Yarn version (v4) already comes with most plugins, so we can remove workspace plugins from the PR.

Commented On 05 Sep 2022 at 04:55:15
Issue Comment

Koistya

PWA Feature required

Need to add PWA Feature

Forked On 05 Sep 2022 at 02:51:53

Koistya

Zero-config and framework-agnostic PWA Plugin for Vite

https://vite-plugin-pwa.netlify.app/

Commented On 05 Sep 2022 at 02:51:53

Koistya

feat: Integrate Google Analytics v4 (#2003)

Pushed On 05 Sep 2022 at 02:46:03

Koistya

feat: Integrate Google Analytics v4

Created On 05 Sep 2022 at 02:46:02

Koistya

feat: Integrate Google Analytics v4

Pushed On 05 Sep 2022 at 02:40:13

Koistya

feat: Integrate Google Analytics v4

Pushed On 05 Sep 2022 at 02:21:04
Create Branch
Koistya In koistya/react-starter-kit Create Branchanalytics

Koistya

ReactJS / Flux Starter Kit - a skeleton for an isomorphic web application (SPA) built with Facebook's React.js library and powered by Flux architecture. It also uses Babel (ES6), JSX, Gulp, Webpack, BrowserSync, Jest, Flow

On 05 Sep 2022 at 12:51:58

Koistya

feat: Integrate Google Analytics v4

Created On 05 Sep 2022 at 12:51:55

Koistya

feat: Add an optional name argument to useTheme(..) (#2002)

Pushed On 04 Sep 2022 at 12:36:44

Koistya

feat: Add an optional `name` argument to `useTheme(..)`

Created On 04 Sep 2022 at 12:36:43

Koistya

feat: Add an optional `name` argument to `useTheme(..)`

Created On 04 Sep 2022 at 12:34:00
Create Branch
Koistya In koistya/react-starter-kit Create Branchkoistya/theme

Koistya

ReactJS / Flux Starter Kit - a skeleton for an isomorphic web application (SPA) built with Facebook's React.js library and powered by Flux architecture. It also uses Babel (ES6), JSX, Gulp, Webpack, BrowserSync, Jest, Flow

On 04 Sep 2022 at 12:32:13

Koistya

feat: Integrate Hono.js (router) (#34)

Pushed On 28 Aug 2022 at 10:05:45