kof Github contribution chart
kof Github Stats
kof Most Used Languages

Activity

29 Sep 2022

Issue Comment

Kof

Changes made to content editable components are lost if not synchronised before you stop editing

  1. Start editing a Heading
  2. Make some changes and click elsewhere so it would loose focus as fast as possible after making the change
  3. If synchronisation doesn't happen between the edit and focus loss, the component content rollbacks to the previous state

Forked On 29 Sep 2022 at 08:32:00

Kof

Fixed, PR inbound, release next week

Commented On 29 Sep 2022 at 08:32:00

Kof

fix github/google login, don"t use _json key, github may not provide it

simplify the functions a bit

Pushed On 29 Sep 2022 at 08:30:59

Kof

remove as string assertions

Pushed On 29 Sep 2022 at 08:30:59

Kof

Merge pull request #312 from webstudio-is/307-login-with-github-doesnt-work-with-a-particular-account

Fix github login

Pushed On 29 Sep 2022 at 08:30:59

Kof

Merge branch 'main' into 288-changes-made-to-content-editable-components-are-lost-if-not-synchronised-before-you-stop-editing

Pushed On 29 Sep 2022 at 08:30:59

Kof

Fix saving text change when quickly pressing esc after editing

Created On 29 Sep 2022 at 08:30:32
Create Branch
Kof In webstudio-is/webstudio-designer Create Branch288-changes-made-to-content-editable-components-are-lost-if-not-synchronised-before-you-stop-editing

Kof

🖌 Webstudio Visual Designer

On 29 Sep 2022 at 08:29:59
Issue Comment

Kof

Login with Github doesn't work with a particular account

We might have a problem that restricts github accounts or maybe there is some error that we don't show to the user, I have an account that can't login with github.

Forked On 29 Sep 2022 at 08:13:48

Kof

fixed, will be released next week

Commented On 29 Sep 2022 at 08:13:48
Issue Comment

Kof

Feature: CSSProperty control

Before requesting a review

  • [ ] if the PR is WIP - use draft mode
  • [ ] made a self-review
  • [ ] added inline comments where things may be not obvious (the "why", not "what")
  • [ ] what kind of review is needed?
    • [ ] conceptual
    • [ ] detailed
    • [ ] with testing

Test cases

  • [ ] step by step interaction description and what is expected to happen

Before merging

  • [ ] tested locally and on preview environment (preview dev login: 5de6)
  • [ ] updated test cases document
  • [ ] added tests
  • [ ] if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

Forked On 29 Sep 2022 at 06:12:23

Kof

Question: why not CssValueControl? We do try to define a value, right?

Commented On 29 Sep 2022 at 06:12:23
Issue Comment

Kof

Dragging links on canvas is disabled

Turns out we accidentally disabled dragging links on canvas

https://www.loom.com/share/2ab9e07ff73443bcb78b80b785be1b09

Forked On 28 Sep 2022 at 07:45:44

Kof

Looked into it briefly, seems like some bug in the d&d logic @rpominov

Commented On 28 Sep 2022 at 07:45:44

Kof

fix github/google login, don"t use _json key, github may not provide it

simplify the functions a bit

Pushed On 28 Sep 2022 at 07:25:10

Kof

remove as string assertions

Pushed On 28 Sep 2022 at 07:25:10

Kof

Merge pull request #312 from webstudio-is/307-login-with-github-doesnt-work-with-a-particular-account

Fix github login

Pushed On 28 Sep 2022 at 07:25:10

Kof

Fix github login

Created On 28 Sep 2022 at 07:25:10

Kof

remove as string assertions

Pushed On 28 Sep 2022 at 06:13:11

Kof

Fix github login

Created On 28 Sep 2022 at 03:44:46
Create Branch
Kof In webstudio-is/webstudio-designer Create Branch307-login-with-github-doesnt-work-with-a-particular-account

Kof

🖌 Webstudio Visual Designer

On 28 Sep 2022 at 03:44:17

Kof

move flush css function to the corresponding packages

Pushed On 28 Sep 2022 at 01:38:58

Kof

separate critical css and remix stuff on canvas and in designer

We need to reuse canvas stuff on the published site as well

Pushed On 28 Sep 2022 at 01:38:58

Kof

Merge branch 'main' into 305-critical-css-extraction-broken-on-main

Pushed On 28 Sep 2022 at 01:38:58

Kof

Merge branch 'main' into 305-critical-css-extraction-broken-on-main

Pushed On 28 Sep 2022 at 01:38:58

Kof

Merge pull request #311 from webstudio-is/305-critical-css-extraction-broken-on-main

Separate remix root document + critical css extraction on canvas from designer

Pushed On 28 Sep 2022 at 01:38:58

Kof

Merge branch 'main' into 252-fonts-manager-and-fonts-selector

Pushed On 28 Sep 2022 at 01:38:58

Kof

move flush css function to the corresponding packages

Pushed On 28 Sep 2022 at 01:35:26

Kof

separate critical css and remix stuff on canvas and in designer

We need to reuse canvas stuff on the published site as well

Pushed On 28 Sep 2022 at 01:35:26

Kof

Merge branch 'main' into 305-critical-css-extraction-broken-on-main

Pushed On 28 Sep 2022 at 01:35:26

Kof

Merge branch 'main' into 305-critical-css-extraction-broken-on-main

Pushed On 28 Sep 2022 at 01:35:26

Kof

Merge pull request #311 from webstudio-is/305-critical-css-extraction-broken-on-main

Separate remix root document + critical css extraction on canvas from designer

Pushed On 28 Sep 2022 at 01:35:26

Kof

Separate remix root document + critical css extraction on canvas from designer

Created On 28 Sep 2022 at 01:35:26
Issue Comment

Kof

Separate remix root document + critical css extraction on canvas from designer

Before requesting a review

  • [x] if the PR is WIP - use draft mode
  • [x] made a self-review
  • [x] added inline comments where things may be not obvious (the "why", not "what")
  • [x] what kind of review is needed?
    • [x] conceptual
    • [x] detailed
    • [ ] with testing

Test cases

  • [ ] step by step interaction description and what is expected to happen

Before merging

  • [ ] tested locally and on preview environment (preview dev login: 5de6)
  • [ ] updated test cases document
  • [ ] added tests
  • [ ] if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

Forked On 28 Sep 2022 at 01:35:20

Kof

@rpominov let me know if you find anything, I will merge it to rebase the other PR on top

Commented On 28 Sep 2022 at 01:35:20

Kof

fix: process is not defined in worker, so url is defined in a different way

Pushed On 28 Sep 2022 at 11:50:48

Kof

fix: tests

Pushed On 28 Sep 2022 at 11:50:48

Kof

fixes

Pushed On 28 Sep 2022 at 11:50:48

Kof

Merge pull request #310 from webstudio-is/fix/http-client-env

fix: http-client should not have process.env

Pushed On 28 Sep 2022 at 11:50:48

Kof

Merge branch 'main' into 252-fonts-manager-and-fonts-selector

Pushed On 28 Sep 2022 at 11:50:48
Issue Comment

Kof

Omit `ref` prop from `TextFieldProps`

cc @okonet

Forked On 28 Sep 2022 at 11:45:17

Kof

@okonet this one already merged somewhere and can be closed?

Commented On 28 Sep 2022 at 11:45:17

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Merged On 28 Sep 2022 at 11:43:09

Kof

Commented On 28 Sep 2022 at 11:43:09

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Forked On 28 Sep 2022 at 11:43:08

Kof

Again, I mentioned in the CR that if type is not optional, this logic doesn't make sense, what makes sense is validating after new URL the set hostname
On 28 Sep 2022 at 11:43:08

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Forked On 28 Sep 2022 at 11:42:24

Kof

no need for template
On 28 Sep 2022 at 11:42:24

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Merged On 28 Sep 2022 at 11:42:24

Kof

Commented On 28 Sep 2022 at 11:42:24

Kof

fix: process is not defined in worker, so url is defined in a different way

Pushed On 28 Sep 2022 at 11:39:55

Kof

fix: tests

Pushed On 28 Sep 2022 at 11:39:55

Kof

fixes

Pushed On 28 Sep 2022 at 11:39:55

Kof

Merge pull request #310 from webstudio-is/fix/http-client-env

fix: http-client should not have process.env

Pushed On 28 Sep 2022 at 11:39:55

Kof

Merge branch 'main' into 305-critical-css-extraction-broken-on-main

Pushed On 28 Sep 2022 at 11:39:55

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Merged On 28 Sep 2022 at 10:49:33

Kof

Commented On 28 Sep 2022 at 10:49:33

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Forked On 28 Sep 2022 at 10:49:33

Kof

Unless you think the url could come from env and be undefined or empty string, in this case you could do new URL(apiUrl) and then check for hostname for example, so you have an actual validation
On 28 Sep 2022 at 10:49:33

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Merged On 28 Sep 2022 at 10:47:56

Kof

Commented On 28 Sep 2022 at 10:47:56

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Forked On 28 Sep 2022 at 10:47:56

Kof

wait this doesn't make any sense, this URL is not optional and so shouldn't accept a null at type level, but then validate in code to not accept null, it should only accept string strictly and so you don't even have to do this runtime check
On 28 Sep 2022 at 10:47:56

Kof

fix: http-client should not have process.env

process.env is not defined in the worker state, so URL is defined in a different way.

Merged On 28 Sep 2022 at 10:45:22

Kof

A number of cosmetic change requests there, approving so you can merge once fixed

Commented On 28 Sep 2022 at 10:45:22