kentcdodds Github contribution chart
kentcdodds Github Stats
kentcdodds Most Used Languages

Activity

29 Sep 2022

Kentcdodds

add lsminter as a contributor for doc (#187)

  • update README.md [skip ci]

  • update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>

Pushed On 29 Sep 2022 at 10:59:06

Kentcdodds

add lsminter as a contributor for doc

Created On 29 Sep 2022 at 10:59:05

Kentcdodds

Pre not rendering, swapped to code block

The pre element wasn't rendering the warning:

Screen Shot 2022-09-29 at 11 56 23 AM

Swapping it to a code block fixes the rendering issue:

Screen Shot 2022-09-29 at 11 55 59 AM

Forked On 29 Sep 2022 at 10:58:39

Kentcdodds

@All-contributors please add @lsminter for docs

Commented On 29 Sep 2022 at 10:58:39

Kentcdodds

Pre not rendering, swapped to code block (#186)

  • pre tag not rendering, swapped to codeblock

  • removed pre-tag

Pushed On 29 Sep 2022 at 10:58:35

Kentcdodds

Pre not rendering, swapped to code block

Created On 29 Sep 2022 at 10:58:33

Kentcdodds

Pre not rendering, swapped to code block

The pre element wasn't rendering the warning:

Screen Shot 2022-09-29 at 11 56 23 AM

Swapping it to a code block fixes the rendering issue:

Screen Shot 2022-09-29 at 11 55 59 AM

Merged On 29 Sep 2022 at 10:58:26

Kentcdodds

Thanks!

Commented On 29 Sep 2022 at 10:58:26

Kentcdodds

user page scaffold

Pushed On 29 Sep 2022 at 10:20:01

Kentcdodds

ship page finished

Pushed On 29 Sep 2022 at 09:09:23

Kentcdodds

Date range validation

I'm building a date range picker with two date inputs and I'd like to validate that the end date does not come before the start date and the start is not after the end. It would be cool if I could somehow dynamically set the min and max based on other fields in the form or even have some way to set that via useValidatedInput/Field/etc. so I can control the state myself with whatever I need and just pass what those validation values should be dynamically.

Forked On 29 Sep 2022 at 05:28:36

Kentcdodds

Yup. Got a workaround for now. But yeah I think it would be cool if there were some way to dynamically set the value of a built-in validation. Maybe if you make a built-in validation a function it should return what the attribute value should be? Seems like it may be sensible to separate built-in validations from custom ones:

let formValidations = {
  startDate: {
    type: 'date',
    required: true,
  },
  endDate: {
    type: 'date',
    required: true,
    min(value, formData) {
      // return the value you want set for this attribute
      return dateFns.format(
        dateFns.parseISO(formData.get('startDate')),
        'yyyy-MM-dd',
      )
    },
    custom: {
      myCustomThing: () => {
        // whatever I need
      },
    },
  },
} 

In fact, "validations" does not seem necessarily the right name for this object. It really should be "formElements". So then custom could be customValidators.

This is starting to give me sold angular-formly vibes :) http://angular-formly.com

Commented On 29 Sep 2022 at 05:28:36

Kentcdodds

feat: make `ServerFormInfo`'s `submittedFormData` more type-safe

As suggested by @kentcdodds in https://github.com/brophdawg11/remix-validity-state/issues/7#issuecomment-1245857252 & https://github.com/brophdawg11/remix-validity-state/issues/7#issuecomment-1245875487

Forked On 29 Sep 2022 at 04:32:39

Kentcdodds

Yeah, this is tricky. I kinda hate this idea, but what if every value in the `submittedFormData` was an array? That way we can handle multiple entries. Or maybe it's only an array if there are multiple entries... I think maybe it would be better to update the field config to handle multiple entries first and then we can think about how to handle the submitted data post-validation on the server 🤔
On 29 Sep 2022 at 04:32:39

Kentcdodds

feat: make `ServerFormInfo`'s `submittedFormData` more type-safe

As suggested by @kentcdodds in https://github.com/brophdawg11/remix-validity-state/issues/7#issuecomment-1245857252 & https://github.com/brophdawg11/remix-validity-state/issues/7#issuecomment-1245875487

Merged On 29 Sep 2022 at 04:32:39

Kentcdodds

Commented On 29 Sep 2022 at 04:32:39

Kentcdodds

Seven PRs with various bugfixes and requested features

Hello!

First, thanks so much for this awesome package, it has saved me hours of dev time! I've been using it to develop a dozen little babel plugins that do various things for my projects, but I've run into some difficulties using it. My strategy has been to copy-paste some on-the-fly fixes between projects which is not ideal, so I went ahead and bundled these fixes/features together into my own babel-plugin-tester fork which my team and I have been using successfully for a little while.

Today, I feel confident enough to contribute these fixes back upstream and hopefully retire the fork. They are:

  1. #88: fix plugin order application for fixtures
    • Fixes #74
  2. #89: fix fixtureOutputExt being ignored in root options.json
  3. #90: add support for only, skip, and title test options in fixtures
  4. #91: add support for arbitrary run order of plugin under test
    • Implements #76
  5. #92: bring back (lightweight) plugin name inference
    • Partially reverts #78
  6. #93: fix README typos, update with latest features, verbiage improvements

Additional details are in each PR. With the exception of #91 (which relies on #88), each PR is self-contained and doesn't rely on merging the others, so they can be modified, rejected, or accepted as desired. I also submitted a PR that combines these other six PRs together since the octopus merge strategy can't do it effectively.

Thanks again for this plugin!

Forked On 29 Sep 2022 at 12:10:55

Kentcdodds

Alright. I've given you access to the repo as well as access to publish the package on npm.

The tooling in this repo is a bit dated. Auto-publish used to work on travis, but now CI no longer runs at all. I'd change it to GitHub actions if I were you, but it's completely up to you. Do with it as you see fit. Thanks!

Commented On 29 Sep 2022 at 12:10:55

Kentcdodds

Seven PRs with various bugfixes and requested features

Hello!

First, thanks so much for this awesome package, it has saved me hours of dev time! I've been using to develop a dozen little babel plugins that do various things for my projects, but I've run into some difficulties using it. My strategy has been to copy-paste some on-the-fly fixes between projects which is not ideal, so I went ahead and bundled these fixes/features together into my own babel-plugin-tester fork which my team and I have been using successfully for a little while.

Today, I feel confident enough to contribute these fixes back upstream and hopefully retire the fork. They are:

  1. #88: fix plugin order application for fixtures
    • Fixes #74
  2. #89: fix fixtureOutputExt being ignored in root options.json
  3. #90: add support for only, skip, and title test options in fixtures
  4. #91: add support for arbitrary run order of plugin under test
    • Implements #76
  5. #92: bring back (lightweight) plugin name inference
    • Partially reverts #78
  6. #93: fix README typos, update with latest features, verbiage improvements

Additional details are in each PR. With the exception of #91 (which relies on #88), each PR is self-contained and doesn't rely on merging the others, so they can be modified, rejected, or accepted as desired. I also submitted a PR that combines these other six PRs together since the octopus merge strategy can't do it effectively.

Thanks again for this plugin!

Forked On 29 Sep 2022 at 09:33:21

Kentcdodds

Wow! This is amazing! How would you like commit access? I don't use this package anymore since I don't write or maintain babel plugins these days. Would you like to take over maintenance?

Commented On 29 Sep 2022 at 09:33:21

Kentcdodds

work on booker fullstack component

Pushed On 28 Sep 2022 at 11:07:20

Kentcdodds

prisma migration and ship/brand scaffold

Pushed On 28 Sep 2022 at 10:26:03

Kentcdodds

finish starport page

Pushed On 28 Sep 2022 at 09:36:27

Kentcdodds

add event when a stream starts

Pushed On 28 Sep 2022 at 09:22:09

Kentcdodds

fix ts issue

Pushed On 28 Sep 2022 at 09:12:33

Kentcdodds

small changes

Pushed On 28 Sep 2022 at 08:33:55

Kentcdodds

upgrade deps

Pushed On 28 Sep 2022 at 08:33:55

Kentcdodds

fix timezone issue

Pushed On 28 Sep 2022 at 08:22:12

Kentcdodds

checkpoint

Pushed On 28 Sep 2022 at 07:04:20

Kentcdodds

fix mocks for email

Pushed On 28 Sep 2022 at 06:47:50

Kentcdodds

add build step to playwright

Pushed On 28 Sep 2022 at 06:05:00

Kentcdodds

focus test ��

Pushed On 28 Sep 2022 at 06:01:04

Kentcdodds

fix vitest

Pushed On 28 Sep 2022 at 05:56:50

Kentcdodds

update course descriptions

Pushed On 28 Sep 2022 at 05:45:53

Kentcdodds

Fix typo in JS to Know (#374)

In the code snippet for Rest/Spread in the "JS to know for React" page, each key in the object obj2 is set to a value of '{key} from obj2'. The h key is erroneously being set to 'g from obj2'.

Pushed On 28 Sep 2022 at 04:02:41