karesztrk Github contribution chart
karesztrk Github Stats
karesztrk Most Used Languages

Activity

25 Sep 2022

Karesztrk

Sample unit test

Pushed On 25 Sep 2022 at 04:16:22

Karesztrk

Debugging

Pushed On 25 Sep 2022 at 04:16:22

Karesztrk

Interactivity

Pushed On 25 Sep 2022 at 04:16:22

Karesztrk

Invoice Table action column

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Version bump

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Payment Table action column

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Tax Table action column

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Partner Table redesign and action column

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Custom fonts

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Fixed dark color theme

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Merge branch 'master' into dev

Pushed On 25 Sep 2022 at 01:04:54

Karesztrk

Invoice Table action column

Pushed On 25 Sep 2022 at 12:52:03

Karesztrk

Version bump

Pushed On 25 Sep 2022 at 12:52:03

Karesztrk

Payment Table action column

Pushed On 25 Sep 2022 at 12:52:03

Karesztrk

Tax Table action column

Pushed On 25 Sep 2022 at 12:52:03

Karesztrk

Partner Table redesign and action column

Pushed On 25 Sep 2022 at 12:52:03

Karesztrk

Custom fonts

Pushed On 25 Sep 2022 at 12:52:03

Karesztrk

Fixed dark color theme

Pushed On 25 Sep 2022 at 12:52:03

Karesztrk

Dev

Created On 25 Sep 2022 at 12:52:03

Karesztrk

Dev

Created On 25 Sep 2022 at 12:49:25

Karesztrk

Invoice Table action column

Pushed On 25 Sep 2022 at 12:49:04

Karesztrk

Version bump

Pushed On 25 Sep 2022 at 12:49:04

Karesztrk

Payment Table action column

Pushed On 25 Sep 2022 at 12:49:04

Karesztrk

Tax Table action column

Pushed On 25 Sep 2022 at 12:49:04

Karesztrk

Partner Table redesign and action column

Pushed On 25 Sep 2022 at 12:49:04

Karesztrk

Custom fonts

Pushed On 25 Sep 2022 at 12:49:04

Karesztrk

Fixed dark color theme

Pushed On 25 Sep 2022 at 12:49:04
Create Branch

Karesztrk

Description not entered by the user.

On 23 Sep 2022 at 04:12:05
Create Branch

Karesztrk

Description not entered by the user.

On 23 Sep 2022 at 03:28:36

Karesztrk

started

Started On 16 Sep 2022 at 03:42:15

Karesztrk

Dev

Created On 15 Sep 2022 at 05:58:45

Karesztrk

README update

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Header added to the Layout

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Authentication redirects

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Localized currency display

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Dashboard chart

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Additional chart formatting & styling

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Finance page

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Merge branch 'master' into dev

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

Version bump

Pushed On 15 Sep 2022 at 05:58:44

Karesztrk

README update

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Header added to the Layout

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Authentication redirects

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Localized currency display

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Dashboard chart

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Additional chart formatting & styling

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Finance page

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Chart animation turned off and added default focus ring behavior

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Merge branch 'master' into dev

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Version bump

Pushed On 15 Sep 2022 at 05:53:59

Karesztrk

Dev

Created On 15 Sep 2022 at 05:43:11

Karesztrk

Version dump

Pushed On 15 Sep 2022 at 05:42:54

Karesztrk

Localized currency display

Pushed On 14 Sep 2022 at 05:11:57

Karesztrk

Dashboard chart

Pushed On 14 Sep 2022 at 05:11:57

Karesztrk

Additional chart formatting & styling

Pushed On 14 Sep 2022 at 05:11:57

Karesztrk

Finance page

Pushed On 14 Sep 2022 at 05:11:57

Karesztrk

Chart animation turned off and added default focus ring behavior

Pushed On 14 Sep 2022 at 05:11:57

Karesztrk

Dev

Created On 14 Sep 2022 at 05:11:56

Karesztrk

Dev

Created On 14 Sep 2022 at 05:11:31

Karesztrk

Additional chart formatting & styling

Pushed On 14 Sep 2022 at 05:08:37

Karesztrk

Finance page

Pushed On 14 Sep 2022 at 05:08:37

Karesztrk

Chart animation turned off and added default focus ring behavior

Pushed On 14 Sep 2022 at 05:08:37

Karesztrk

started

Started On 13 Sep 2022 at 04:44:38
Issue Comment

Karesztrk

[BUG] page.click clicks incorrect item due to element reuse

Context:

System:

  • OS: macOS 11.3
  • Memory: 216.95 MB / 16.00 GB

Binaries:

  • Node: 14.17.6 - ~/.volta/tools/image/node/14.17.6/bin/node
  • Yarn: 1.22.11 - ~/.volta/tools/image/yarn/1.22.11/bin/yarn
  • npm: 6.14.15 - ~/.volta/tools/image/node/14.17.6/bin/npm
  • playwright: 1.16.2

Languages:

  • Bash: 3.2.57 - /bin/bash

Code Snippet

Help us help you! Put down a short code snippet that illustrates your bug and that we can run and debug locally. For example:

const {chromium, webkit, firefox} = require('playwright');

(async () => {
  const browser = await chromium.launch();
  // ...
})(); 

Describe the bug

I found a race condition when clicking an element. Should we be throwing an error/warning instead of clicking the wrong element? When Page is Loaded, table is loaded unsorted.

| Item | Date | | ---- | --------- | | One | <dateOne> | | Two | <dateTwo> |

After Sort

| Item | Date | | ---- | --------- | | Two | <dateTwo> | | One | <dateOne>|

Problem

await page.click('"Date"'); // To sort by date. This triggers a network call to fetch the data.
await page.click('"Two"'); // Expected to click "Two", but clicks "One", without any error/warning 

Workaround

await Promise.all([
  this.page.waitForResponse(/-Date/), // Based on the URL
  this.page.click('"Date"'),
]);
await page.click('"Two"'); 

If it was clicking Two sorted/unsorted, it's not an issue. But it's clicking One after sort, without any kind of warning/error. This was happening in an unrelated area of the tests, so had to dig in to find the root cause.

Forked On 13 Sep 2022 at 03:06:28

Karesztrk

Hey guys. I'm experiencing the same issue inside a <table> rendered by React ^18.1.0 @sidharthv96 's workaround indeed solves the problem. However im interested in about how to overcome with this in React since im already using key= for each row inside the table. Any advice @dgozman ?

Commented On 13 Sep 2022 at 03:06:28

Karesztrk

Dashboard chart

Pushed On 10 Sep 2022 at 12:23:35
Issue Comment

Karesztrk

Bar charts with time scale

Is your feature request related to a problem? Please describe. I'd like to let ResponsiveBar know that the x-axis is a time scale, so that it automatically calculates a sensible amount of ticks and their positions without them overlapping.

RIght now, this is not possible. There is no way to make the x-axis of ResponsiveBar be a time scale. As a result, the component interprets the tick values as simple strings, and thus adds a label to each bar. This creates lots of labels that overlap if the series is long enough.

Describe the solution you'd like I'd like to set the x-scale format to time, similar to nivo line charts as in https://nivo.rocks/storybook/?path=/story/line--time-scale.

Describe alternatives you've considered The only solution I have found is to calculate the tick positions axisBottom.tickValues myself.

Additional context This issue has also been discussed in #407 and #283.

Forked On 10 Sep 2022 at 10:36:29

Karesztrk

What alternative do you recommend if Bar chart is not the way to go to display time based series?

Commented On 10 Sep 2022 at 10:36:29

Karesztrk

Localized currency display

Pushed On 04 Sep 2022 at 03:45:38

Karesztrk

README update

Pushed On 03 Sep 2022 at 07:55:35

Karesztrk

Header added to the Layout

Pushed On 03 Sep 2022 at 07:55:35

Karesztrk

Authentication redirects

Pushed On 03 Sep 2022 at 07:55:35

Karesztrk

Dev

Created On 03 Sep 2022 at 07:55:35

Karesztrk

Dev

Created On 03 Sep 2022 at 07:53:57

Karesztrk

Authentication redirects

Pushed On 03 Sep 2022 at 07:53:36

Karesztrk

[Request for Feature] Support integer values for nested form field keys.

Describe the bug dirtyFields and isDirty are inconsistent with expected values. dirtyFields will zero out after blur and change events when there are still dirty fields. This is for version 6.3.3. This seems to only happen with nested fields with number properties. Nested Fields with string properties work as expected.

To Reproduce Steps to reproduce the behavior:

  1. Go to codesandbox linked below
  2. Enter values into Left #1, Left #2
  3. Validate that IsDirty === true
  4. Delete value from Left #2

Additional repros are in codesandbox

Codesandbox link (Required) https://codesandbox.io/s/react-hook-form-dirty-repro-tedbi

Expected behavior IsDirty should be true Left DirtyFields should equal ['left.1']

Desktop (please complete the following information):

  • OS: MacOS (10.15.4)
  • Browser [Chrome, Firefox]
  • Version [Chrome: 84.0, FF: 79.0]

Forked On 26 Aug 2022 at 08:46:13

Karesztrk

Hi guys. Can any of your recall the release that fixed the issue? I cannot find the matching PR. Although @RookY2K found it in v6.3.3...I'm still experiencing it in v6.15.8

Commented On 26 Aug 2022 at 08:46:13

Karesztrk

Header added to the Layout

Pushed On 25 Aug 2022 at 05:05:26