kadamwhite Github contribution chart
kadamwhite Github Stats
kadamwhite Most Used Languages

Activity

08 Dec 2022

Kadamwhite

Allow installation on PHP 8

Pushed On 08 Dec 2022 at 08:43:11

Kadamwhite

Bump versions 1.4.3
Merged On 08 Dec 2022 at 06:55:31

Kadamwhite

Commented On 08 Dec 2022 at 06:55:31
Issue Comment

Kadamwhite

Fix README assets section

Now that the plugin builds its own assets for releases, the "Assets" section of the README is incorrect and should be rephrased.

Forked On 08 Dec 2022 at 05:41:11

Kadamwhite

Resolved in 92f57105e22b64be58236d3b2b42c51cf957b4f4

Commented On 08 Dec 2022 at 05:41:11

Kadamwhite

Properly load scripts and styles

Created On 08 Dec 2022 at 04:16:58
Create Branch

Kadamwhite

Adds a widget and REST endpoint for the purpose of displaying post revisions inline on the frontend.

On 08 Dec 2022 at 04:12:20

Kadamwhite

Description not entered by the user.

On 07 Dec 2022 at 09:23:28

Kadamwhite

Description not entered by the user.

On 07 Dec 2022 at 09:22:08
Issue Comment

Kadamwhite

Quick questions

Hi ! Looks like an awesome project. Before setting it up, I'd like to ask some questions.

  • If I understand well, it's 1 install of cavalcade per site ? Or can it manage many websites on different servers ?
  • Did you already try it with a woocommerce subscription ? Just to be sure of the compatibility. Thanks a lot !

Forked On 05 Dec 2022 at 06:06:07

Kadamwhite

Hello, @agenceKanvas! If I understand your question correctly, Cavalcade is designed for use on a multisite network, where one WordPress install (and one Cavalcade plugin install) manages multiple individual sites. You would need to install Cavalcade on each server on which you have WordPress running, if you are running multiple different sites or networks on different servers.

Commented On 05 Dec 2022 at 06:06:07

Kadamwhite

Update with new HM branding

Description We have new branding from the HM website to add to the library. See sketch file.

Background: The full HM website rebrand includes: Logo Colours Spacing and Grid UI Elements Typography

Long term, we would need to determine which elements would be added to the Pattern Library. This also determines what tools can use the Pattern Library as it's a one size fits all approach.

Another consideration is the new font is a Google font which would have to be self-hosted and we need to determine where this would be hosted and ensure a solution was in place that doesn't adversely impact other sites if the font is changed in the future.

Immediate deliverable:

In the immediate, we have agreed to update the Pattern Library with only the brand colours (including applying them to the logo). These changes to the library need to be recorded as a minor release with no breaking changes. This will enable sites using the Pattern library (Engineering Handbook, Company Handbook and H2 ) to update automatically.

Once the library is updated, sites using the library should be checked and any styling issues resulting from the rebranding need to to be fixed.

Acceptance Criteria:

  1. Long form and short form logo colours are updated https://www.sketch.com/s/d8053156-0933-4e9d-8b52-a5d3f9a752ed/a/L03mbq4
  2. Branding colour palette added to the library https://www.sketch.com/s/d8053156-0933-4e9d-8b52-a5d3f9a752ed/a/R1zxoe8
  3. Changes to library recorded as a minor release with no breaking changes. This will enable sites using the Pattern library to update automatically.
  4. All sites using the Pattern Library accept the changes and do not have broken styling.

Forked On 30 Nov 2022 at 05:41:02

Kadamwhite

I did indeed miss that, @CoreyBenefiel, but I'll get on that today.

Commented On 30 Nov 2022 at 05:41:02

Kadamwhite

Allow custom mysql flags for db exec command

Fixes https://github.com/humanmade/altis-local-server/issues/548

Forked On 29 Nov 2022 at 04:10:43

Kadamwhite

Elsewhere in this file the comments are all on their own line before the code they're describing, rather than line-ending comments. I'd suggest maintaining "keep comments on their own line" for consistency with the existing style.
On 29 Nov 2022 at 04:10:43

Kadamwhite

Allow custom mysql flags for db exec command

Fixes https://github.com/humanmade/altis-local-server/issues/548

Merged On 29 Nov 2022 at 04:10:44

Kadamwhite

Commented On 29 Nov 2022 at 04:10:44
Issue Comment

Kadamwhite

Reduce number of DB queries

Fixes #117

The DB query fetches pretty much everything, just varying on statuses and site ID which won't change unless someone needs to query the jobs directly.

The resulting array is then filtered in PHP instead so the trade off is an 0(n) process in PHP rather than additional requests to the db each time wp_next_scheduled() is called.

Forked On 22 Nov 2022 at 04:32:26

Kadamwhite

Ah, nuts, had been hoping this would scale.

Given the primary problem we're aiming to have an impact on is TTFB for end user page requests there is an alternative approach we could take which would be to use the pre_get_scheduled_event filter to just return true on any non-admin requests, provided they are in the init hook, as init will run in the admin context.

That makes sense, and feels like a good compromise.

Commented On 22 Nov 2022 at 04:32:26

Kadamwhite

Differentiate release workflow action names

Pushed On 17 Nov 2022 at 06:13:24

Kadamwhite

Differentiate release workflow action names

Pushed On 17 Nov 2022 at 06:13:00

Kadamwhite

Add action to build to release-develop branch

Pushed On 17 Nov 2022 at 06:12:05

Kadamwhite

Add README updates for development workflow

Pushed On 17 Nov 2022 at 06:12:05

Kadamwhite

Merge pull request #9 from wikimedia/develop-release

Introduce a Develop branch and release-develop build

Pushed On 17 Nov 2022 at 06:12:05

Kadamwhite

Add action to build to release-develop branch

Pushed On 17 Nov 2022 at 06:10:22

Kadamwhite

Add README updates for development workflow

Pushed On 17 Nov 2022 at 06:10:22

Kadamwhite

Merge pull request #9 from wikimedia/develop-release

Introduce a Develop branch and release-develop build

Pushed On 17 Nov 2022 at 06:10:22

Kadamwhite

Introduce a Develop branch and release-develop build

Created On 17 Nov 2022 at 06:10:21

Kadamwhite

Wordpress theme created for https://diff.wikimedia.org/

On 17 Nov 2022 at 05:55:30

Kadamwhite

Introduce a Develop branch and release-develop build

Created On 17 Nov 2022 at 05:48:18
Create Branch
Kadamwhite In wikimedia/shiro-wordpress-theme Create Branchdevelop-release

Kadamwhite

WordPress theme used by Wikimedia Foundation

On 17 Nov 2022 at 05:47:41
Create Branch

Kadamwhite

WordPress theme used by Wikimedia Foundation

On 17 Nov 2022 at 05:33:55
Create Branch
Kadamwhite In wikimedia/shiro-wordpress-theme Create Branchrelease-develop

Kadamwhite

WordPress theme used by Wikimedia Foundation

On 17 Nov 2022 at 05:33:54
Create Branch

Kadamwhite

WordPress theme used by Wikimedia Foundation

On 17 Nov 2022 at 05:32:33