julen Github contribution chart
julen Github Stats
julen Most Used Languages

Activity

27 Sep 2022

Issue Comment

Julen

Units: Consider adding nutrition/energy units

Hi, first of all, thanks for working on all the i18n-related specs — they are truly valuable for developers working on apps facing international users.

I'm opening this request as a signal to show the interest/importance of having nutritional units in the list of units sanctioned for use in ECMAScript. I'm aware this list is intentionally downsized, mainly due to the increased download size incurred in shipping implementations.

The justification for the request is backed up by the global nature of the food industry — it affects every single human being. When it comes to (online) food stores, there are regulations that require nutritional data to be displayed to customers (e.g. EU nutrition declaration, FDA Code of Federal Regulations, Nutrition labeling of food).

All in all, having energy units like energy-foodcalorie, energy-joule, energy-kilocalorie, and energy-kilojoule would help fulfill such requirements natively in JavaScript.

Forked On 27 Sep 2022 at 01:01:04

Julen

Does CLDR have this data?

Unless I'm looking at the wrong place, I can find data for energy-foodcalorie, here are some examples:

  • de: https://github.com/unicode-org/cldr-json/blob/0fd7b0b3b6e4f83e0df96ce55f87f39b91932377/cldr-json/cldr-units-full/main/de/units.json#L859-L870
  • en: https://github.com/unicode-org/cldr-json/blob/0fd7b0b3b6e4f83e0df96ce55f87f39b91932377/cldr-json/cldr-units-full/main/en/units.json#L419-L423
  • es: https://github.com/unicode-org/cldr-json/blob/0fd7b0b3b6e4f83e0df96ce55f87f39b91932377/cldr-json/cldr-units-full/main/es/units.json#L481-L486

Commented On 27 Sep 2022 at 01:01:04

Julen

FontPluginQt: Initialize the default fixed-width font

Pushed On 18 Sep 2022 at 03:01:38

Julen

Tab: Make back/forward keyboard shortcuts platform-specific

This commit changes how we set the back and forward button key bindings to use platform-specific standard key sequences.

For example, in Mac OS X, the back action will be now triggered via Cmd+← and Cmd+[, whereas previously the action was mapped to Alt+←, which is not standard in Mac OS X.

Pushed On 18 Sep 2022 at 03:01:38

Julen

Tab: Conditionally enable back/forward buttons

Pushed On 18 Sep 2022 at 03:01:38

Julen

Tab: Conditionally enable back/forward buttons

Created On 18 Sep 2022 at 06:55:03

Julen

Tab: Conditionally enable back/forward buttons

Pushed On 18 Sep 2022 at 06:54:51
Create Branch
Julen In julen/ladybird Create Branchtab/conditionally-enable-back-forward

Julen

Ladybird web browser

On 18 Sep 2022 at 06:53:42
Merge

Julen

Tab: Make back/forward keyboard shortcuts platform-specific

This commit changes how we set the back and forward button key bindings to use platform-specific standard key sequences.

For example, in Mac OS X, the back action will be now triggered via Cmd+← and Cmd+[, whereas previously the action was mapped to Alt+←, which is not standard in Mac OS X.

Forked On 17 Sep 2022 at 05:54:43

Julen

I didn't know about `QKeySequence::StandardKey`, thanks for the suggestion! I made the change and it works great in Mac, but can't say if other platforms are left intact so someone else may want to check it. As an added bonus, since the actual key binding is retrieved using `QKeySequence::keyBindings()` which returns a list, and in conjunction with `setShortcuts` (plural), it allows us to set multiple platform-specific key bindings in one go. So in Mac, for the back button this maps to both <kbd>Cmd+←</kbd> and <kbd>Cmd+[</kbd>.
On 17 Sep 2022 at 05:54:43

Julen

Tab: Make back/forward keyboard shortcuts platform-specific

This commit changes how we set the back and forward button key bindings to use platform-specific standard key sequences.

For example, in Mac OS X, the back action will be now triggered via Cmd+← and Cmd+[, whereas previously the action was mapped to Alt+←, which is not standard in Mac OS X.

Merged On 17 Sep 2022 at 05:54:43

Julen

Commented On 17 Sep 2022 at 05:54:43

Julen

WebView: Notify LibWeb whenever the viewport is scrolled

Pushed On 17 Sep 2022 at 05:49:11

Julen

WebView: Implement page_did_request_scroll_into_view()

This makes #foo links actually scroll the #foo element into view.

Pushed On 17 Sep 2022 at 05:49:11

Julen

Tab: Make back/forward keyboard shortcuts platform-specific

This commit changes how we set the back and forward button key bindings to use platform-specific standard key sequences.

For example, in Mac OS X, the back action will be now triggered via Cmd+← and Cmd+[, whereas previously the action was mapped to Alt+←, which is not standard in Mac OS X.

Pushed On 17 Sep 2022 at 05:49:11

Julen

Tab: Make back/forward keyboard shortcuts native to Mac OS X

In Mac OS X, the common keyboard shortcuts to navigate back and forward in a web browser history are Cmd+← and Cmd+→ respectively. This commit changes that while keeping the existing Alt+← and Alt+→ shortcuts in other platforms intact.

Pushed On 17 Sep 2022 at 04:12:14

Julen

Tab: Make back/forward keyboard shortcuts native to Mac OS X

Created On 17 Sep 2022 at 04:11:54
Create Branch
Julen In julen/ladybird Create Branchfeature/macos-specific-key-bindings

Julen

Ladybird web browser

On 17 Sep 2022 at 04:11:24

Julen

Ladybird web browser

Forked On 17 Sep 2022 at 04:04:43