jamonholmgren Github contribution chart
jamonholmgren Github Stats
jamonholmgren Most Used Languages

Activity

04 Oct 2022

Jamonholmgren

fix: 2234 - Remove SafeAreaView in favor of useSafeAreaInsets hook

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant
  • [ ] ~README.md has been updated with your changes, if relevant~

Describe your PR

There is an issue with the SafeAreaView from react-native-safe-area-context that causes the top inset to not be set on first render. So you see the content, then it re-renders and jumps down to it's final resting place. The fix is to not use SafeAreaView and use the useSafeAreaInsets hook instead.

This PR changes the Screen component to use the hook and apply the insets as screen padding if they are passed in, which fixes #2234.

Old behavior

https://user-images.githubusercontent.com/1761434/193369617-27e9df6b-5489-4ee2-bc25-2026ae9e1414.MP4

New (fixed) behavior

https://user-images.githubusercontent.com/1761434/193369658-838e3a9b-2469-43c5-b4c2-f47e6d5ae0f3.MP4

Multiple edges passed in (top and bottom)

Ugly, but it shows it still works

Forked On 04 Oct 2022 at 04:23:29

Jamonholmgren

Probably prefer this style. ```suggestion style={[$containerStyle, { backgroundColor }, insetPadding ]} ```
On 04 Oct 2022 at 04:23:29

Jamonholmgren

fix: 2234 - Remove SafeAreaView in favor of useSafeAreaInsets hook

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant
  • [ ] ~README.md has been updated with your changes, if relevant~

Describe your PR

There is an issue with the SafeAreaView from react-native-safe-area-context that causes the top inset to not be set on first render. So you see the content, then it re-renders and jumps down to it's final resting place. The fix is to not use SafeAreaView and use the useSafeAreaInsets hook instead.

This PR changes the Screen component to use the hook and apply the insets as screen padding if they are passed in, which fixes #2234.

Old behavior

https://user-images.githubusercontent.com/1761434/193369617-27e9df6b-5489-4ee2-bc25-2026ae9e1414.MP4

New (fixed) behavior

https://user-images.githubusercontent.com/1761434/193369658-838e3a9b-2469-43c5-b4c2-f47e6d5ae0f3.MP4

Multiple edges passed in (top and bottom)

Ugly, but it shows it still works

Merged On 04 Oct 2022 at 04:24:34

Jamonholmgren

Commented On 04 Oct 2022 at 04:24:34

Jamonholmgren

fix: 2234 - Remove SafeAreaView in favor of useSafeAreaInsets hook

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant
  • [ ] ~README.md has been updated with your changes, if relevant~

Describe your PR

There is an issue with the SafeAreaView from react-native-safe-area-context that causes the top inset to not be set on first render. So you see the content, then it re-renders and jumps down to it's final resting place. The fix is to not use SafeAreaView and use the useSafeAreaInsets hook instead.

This PR changes the Screen component to use the hook and apply the insets as screen padding if they are passed in, which fixes #2234.

Old behavior

https://user-images.githubusercontent.com/1761434/193369617-27e9df6b-5489-4ee2-bc25-2026ae9e1414.MP4

New (fixed) behavior

https://user-images.githubusercontent.com/1761434/193369658-838e3a9b-2469-43c5-b4c2-f47e6d5ae0f3.MP4

Multiple edges passed in (top and bottom)

Ugly, but it shows it still works

Merged On 04 Oct 2022 at 04:24:33

Jamonholmgren

Commented On 04 Oct 2022 at 04:24:33

Jamonholmgren

Flicker in the middle of navigation animation

When navigating to a new screen, a short flicker/jump appears. I am using SafeAreaProvider wrapped around the rest of my app and then using SafeAreaView at the root of my screens.

https://user-images.githubusercontent.com/5333875/138173288-c2dbd192-68eb-40e9-9745-4fab8a529da0.mov

  • react-native: 0.66.1
  • react-native-safe-area-context: 3.3.2
  • @react-navigation/stack 6.0.11
  • @react-navigation/native-stack: 6.2.5
  • @react-navigation/native: 6.0.6
  • iOS: 15, iPhone 13
  • macOS 11.6 (Big Sur)
  • Macbook Pro 13" M1

Forked On 04 Oct 2022 at 04:19:30

Jamonholmgren

@m-sterspace Thanks -- your code fixed a long-standing issue in the new GasBuddy RN app. It'll impact millions. :-)

Commented On 04 Oct 2022 at 04:19:30
Issue Comment

Jamonholmgren

ignit-cli generator failed

Describe the bug

generating components, models, navigators, or screens is not working

steps to reproduce:

  1. npx ignite-cli@next new PizzaApp --yes
  2. cd PizzaApp
  3. yarn install
  4. npx ignite generate component spinner

expect: create the component spinner actual: command failed

 ERROR  Failed to compile with 4 errors                              10:49:37 AM

 error  

Entry module not found: Error: Can't resolve 'react-color' in '/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp'

 error  

Entry module not found: Error: Can't resolve 'react-ideal-image' in '/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp'

 error  

Entry module not found: Error: Can't resolve 'react-waypoint' in '/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp'

 error  in /Users/amjadomari/.npm/_npx/0e11d984049d509d/node_modules/ignite/src/app/index.js

Module build failed (from ./node_modules/babel-loader/lib/index.js):
Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@babel/plugin-transform-react-constant-elements' imported from /Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/babel-virtual-resolve-base.js
    at __node_internal_ (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:2844:9)
    at __node_internal_ (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:2802:11)
    at new NodeError (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:2795:5)
    at packageResolve (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3451:9)
    at moduleResolve (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3485:18)
    at defaultResolve (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3524:13)
    at /Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3547:14
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:63:103)
    at _next (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:65:194)
    at /Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:65:364
    at new Promise (<anonymous>)
    at /Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:65:97
    at resolve (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/vendor/import-meta-resolve.js:3537:19)
    at /Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/config/files/import-meta-resolve.js:38:38
    at Generator.next (<anonymous>)
    at asyncGeneratorStep (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/config/files/import-meta-resolve.js:20:103)
    at _next (/Users/amjadomari/Documents/ReactNativeProjects/PizzaApp/node_modules/@babel/core/lib/config/files/import-meta-resolve.js:22:194)

 @ multi (webpack)-inject-plugin/dist/webpack-inject-plugin.module.js /Users/amjadomari/.npm/_npx/0e11d984049d509d/node_modules/ignite/src/app/index.js 

Ignite version

8.2.0

Additional info

System
  platform           darwin                                                                
  arch               x64                                                                   
  cpu                8 cores      Apple M1                                                 
  directory          PizzaApp     /Users/amjadomari/Documents/ReactNativeProjects/PizzaApp 

JavaScript (and globally-installed packages)
  node               14.17.5                                   /usr/local/bin/node 
  npm                8.15.0                                    /usr/local/bin/npm  
    cordova          11.0.0                                                        
    npm              8.15.0                                                        
    react-native     0.69.2                                                        
    yarn             1.22.19                                                       
  yarn               1.22.19                                   /usr/local/bin/yarn 
  pnpm               6.29.1                                    /usr/local/bin/pnpm 
                     <no pnpm global package info available>                       
  expo               46.0.13                                   managed             

Ignite
  ignite-cli         8.2.0        /Users/amjadomari/.npm/_npx/e31027f3785124a8/node_modules/.bin/ignite      
  ignite src         build        /Users/amjadomari/.npm/_npx/e31027f3785124a8/node_modules/ignite-cli/build 

Android
  java               16.0.2       /usr/bin/java 
  android home       -            undefined     

iOS
  xcode              14.0.1     
  cocoapods          1.11.3       /usr/local/bin/pod 

Tools
  git                git version 2.37.0 (Apple Git-136)   /usr/bin/git 

Forked On 02 Oct 2022 at 06:11:15

Jamonholmgren

@AmjadOmari Can you try without the @next tag? Version 8 is now released.

Commented On 02 Oct 2022 at 06:11:15
Issue Comment

Jamonholmgren

Fix various issues launching new template

Describe the bug

Platform: web Ignite-cli: next

Bugs experienced: process is not defined.

Fix:

+  "overrides": {
+    "react-error-overlay": "6.0.9"
+  }, 

No such asset assets/images/rnr-image-1.png

Fix: atm i just copied rmr-image@2.png to the path

Ignite version

8.0.0-beta.8

Additional info

npx ignite-cli@next doctor
System
  platform           linux                                                 
  arch               x64                                                   
  cpu                12 cores     Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz 
  directory          roktools     /home/ahmedbodi/work/multicoin/roktools  

JavaScript (and globally-installed packages)
  node               16.17.1      /home/ahmedbodi/.nvm/versions/node/v16.17.1/bin/node 
  npm                8.15.0       /home/ahmedbodi/.nvm/versions/node/v16.17.1/bin/npm  
    corepack         0.12.1                                                            
    npm              8.15.0                                                            
  yarn               -            not installed                                        
  pnpm               -            not installed                                        
  expo               46.0.13      managed                                              

Ignite
  ignite-cli         8.0.0-beta.8   /home/ahmedbodi/.npm/_npx/2351a7c35afcf833/node_modules/.bin/ignite      
  ignite src         build          /home/ahmedbodi/.npm/_npx/2351a7c35afcf833/node_modules/ignite-cli/build 

Android
  java               11.0.16      /usr/bin/java 
  android home       -            undefined     

Tools
/home/ahmedbodi/.npm/_npx/2351a7c35afcf833/node_modules/gluegun/build/index.js:15
    throw up;
    ^

Error: Command failed: git -v
unknown option: -v
usage: git [--version] [--help] [-C <path>] [-c <name>=<value>]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p | --paginate | -P | --no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           [--super-prefix=<path>] [--config-env=<name>=<envvar>]
           <command> [<args>]``` 

Forked On 30 Sep 2022 at 12:42:40

Jamonholmgren

@ahmedbodi Could you submit a PR for this?

Commented On 30 Sep 2022 at 12:42:40

Jamonholmgren

Update react-native, react and flipper dependencies

Version 5.0.1 removed react as a peerDependency. This change was causing an issue in Ignite when using npm. Since that change was made to fix another issue, I explored other fixes. Updating the react-native, react and react-native-flipper dependencies to recent versions also solved the issue in Ignite.

I was able to package this library locally and install it into several test projects using both yarn and npm and with recent and older versions of react-native. With these dependency updates everything still worked as expected.

Merged On 29 Sep 2022 at 09:15:20

Jamonholmgren

release the kraken

Commented On 29 Sep 2022 at 09:15:20
Issue Comment

Jamonholmgren

Implement ignite-cli remove-demo-markup command

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant

Describe your PR

  • Closes #2228
  • Removes comments related to our demo mark notation noted below
  • Runs prettier format after comment removal to clean up spacing
@demo remove-file
@demo remove-current-line
@demo remove-next-line
@demo remove-block-start
@demo remove-block-end 

in the following comment types

//
/* */
{/* */} 

NOTE: this will currently NOT handle the case for a multi line @demo markup comment such as the following:

/*   @demo

    more content here

*/ 

image

Forked On 28 Sep 2022 at 06:13:13

Jamonholmgren

This looks amazing.

Commented On 28 Sep 2022 at 06:13:13

Jamonholmgren

Implement ignite-cli remove-demo-markup command

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant

Describe your PR

  • Closes #2228
  • Removes comments related to our demo mark notation noted below
  • Runs prettier format after comment removal to clean up spacing
@demo remove-file
@demo remove-current-line
@demo remove-next-line
@demo remove-block-start
@demo remove-block-end 

in the following comment types

//
/* */
{/* */} 

NOTE: this will currently NOT handle the case for a multi line @demo markup comment such as the following:

/*   @demo

    more content here

*/ 

image

Merged On 28 Sep 2022 at 06:13:05

Jamonholmgren

Commented On 28 Sep 2022 at 06:13:05

Jamonholmgren

Implement ignite-cli remove-demo-markup command

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant

Describe your PR

  • Closes #2228
  • Removes comments related to our demo mark notation noted below
  • Runs prettier format after comment removal to clean up spacing
@demo remove-file
@demo remove-current-line
@demo remove-next-line
@demo remove-block-start
@demo remove-block-end 

in the following comment types

//
/* */
{/* */} 

NOTE: this will currently NOT handle the case for a multi line @demo markup comment such as the following:

/*   @demo

    more content here

*/ 

image

Forked On 28 Sep 2022 at 06:10:24

Jamonholmgren

Maybe `--only-markup` ?
On 28 Sep 2022 at 06:10:24

Jamonholmgren

Implement ignite-cli remove-demo-markup command

Please verify the following:

  • [x] yarn test jest tests pass with new tests, if relevant

Describe your PR

  • Closes #2228
  • Removes comments related to our demo mark notation noted below
  • Runs prettier format after comment removal to clean up spacing
@demo remove-file
@demo remove-current-line
@demo remove-next-line
@demo remove-block-start
@demo remove-block-end 

in the following comment types

//
/* */
{/* */} 

NOTE: this will currently NOT handle the case for a multi line @demo markup comment such as the following:

/*   @demo

    more content here

*/ 

image

Merged On 28 Sep 2022 at 06:10:24

Jamonholmgren

Commented On 28 Sep 2022 at 06:10:24
Issue Comment

Jamonholmgren

Remove demo does not remove unused assets

Describe the bug

Running npx ignite-cli remove-demo does not remove unused assets like icons and images

Ignite version

8.0.0

Additional info

System
  platform           win32
  arch               x64
  cpu                8 cores      11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz
  directory          PizzaApp    C:\Users\Vijay\Desktop\PizzaApp

JavaScript (and globally-installed packages)
  node               16.17.0      C:\Program Files\nodejs\node.EXE
  npm                8.15.0       C:\Program Files\nodejs\npm.CMD
    corepack         0.12.1
    jshint           2.13.5
    npm              8.15.0
    yarn             1.22.19
  yarn               1.22.19      C:\Program Files\nodejs\yarn.CMD
    http-server      14.1.1
    localtunnel      2.0.2
  pnpm               -            not installed
  expo               46.0.13      managed

Ignite
  ignite-cli         8.0.0        C:\Users\Vijay\AppData\Local\npm-cache\_npx\e31027f3785124a8\node_modules\.bin\ignite.CMD
  ignite src         build        C:\Users\Vijay\AppData\Local\npm-cache\_npx\e31027f3785124a8\node_modules\ignite-cli\build

Android
  java               17.0.4.1     C:\Program Files\Eclipse Adoptium\jdk-17.0.4.101-hotspot\bin\java.EXE
  android home       -            C:\Users\Vijay\AppData\Local\Android\Sdk

Tools
  git                git version 2.37.3.windows.1   C:\Program Files\Git\cmd\git.EXE 

Forked On 28 Sep 2022 at 02:49:50

Jamonholmgren

Thanks @vijjusri14!

@joshuayoes we’ll have to think through how to approach this. I suppose for now we could just have a demo folder that could be manually removed?

Commented On 28 Sep 2022 at 02:49:50
Issue Comment

Jamonholmgren

Ensure that password isn't stored in AsyncStorage by default

In the AuthenticationStore, the password prop is a normal text type:

https://github.com/infinitered/ignite/blob/01c2a11957b37303441fd4abbc4350d9e5d6159a/boilerplate/app/models/AuthenticationStore.ts#L8

Which means it's persisted into AsyncStorage as plain text:

https://github.com/infinitered/ignite/blob/7832f96b0dbb973d15d68f213dfe4b67d66381d7/boilerplate/app/models/helpers/setupRootStore.ts#L43

We should make sure it's not. I don't know for sure that it's a major problem, but it doesn't feel right.

Forked On 27 Sep 2022 at 04:46:32

Jamonholmgren

While we're in there, any types.optional(types.string, "") could be shortened to just an empty string, which is the same thing.

- authPassword: types.optional(types.string, ""), 
+ authPassword: "", 

Commented On 27 Sep 2022 at 04:46:32

Jamonholmgren

Initial Maverick branch

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Merge branch 'master' into maverick

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Default Splash Screen Implementation; Splash Screen Generator (#1965)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Removes storybook; Updates Text, Button, and Screen components; Starts updating theming. (#1992)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Runs linter on boilerplate.

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

More linting fixes.

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

More linting fixes.

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

fix(boilerplate): defined children props for Text, Button

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

fix(screen): fixed arguments for onContentSizeChange

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

chore: moved TODO to make linter happy

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

RN/Expo Unite! (#1985)

  • feat(boilerplate): unified vanilla and expo build

  • feat(commands): reworked new for unified flow

  • feat(commands): updated help to remove expo switch

  • chore: removed expo related tests

  • fix(new): const in favor of let

  • chore(boilerplate): linter updates

  • vendor(expo-constants): downgrade to remove ios warning

  • fix(boilerplate): unified metro and babel configs

  • fix(boilerplate): fixed some deps as per expo doctor

  • fix(metro-config): fixing issue with Expo metro config setup

  • fix(new): added expo dep warning, fixed log message

  • fix(boilerplate): fix expo-font version and app.tsx for expo

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Adds Crash Reporting boilerplate (#1996)

  • feat(utils): initial crash reporting boilerplate

  • fix(crash-reporting): early exit from reporting in dev

  • fix(crash-reporting): reworked early return

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Merge branch 'master' into maverick

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

feature(maverick): initial demo screen (#2002)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Updates components: Icon, AutoImage. Removes components: Wallpaper, Gradient. (#2004)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

feat(generators): Add front matter support to generator templates (#1630 by @kateinkim)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

docs: Navigation / styling documentation (#1980 by @silasjmatson and @jamonholmgren)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

Adds observer to navigator, other navigator cleanup (#2005 by @jamonholmgren)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

docs(readme): #1924 added more troubleshooting tips (#2006)

Pushed On 27 Sep 2022 at 03:14:07

Jamonholmgren

docs: Expanded generator template docs, front matter docs (#2008 by @jamonholmgren)

Pushed On 27 Sep 2022 at 03:14:07
Create Branch
Jamonholmgren In infinitered/ignite Create Branchmaster-restore-maverick-history

Jamonholmgren

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more!

On 27 Sep 2022 at 03:09:52
Create Branch
Jamonholmgren In infinitered/ignite Create Branchmaster-backup-restore-maverick-history

Jamonholmgren

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more!

On 27 Sep 2022 at 03:09:37
Create Branch
Jamonholmgren In infinitered/ignite Create Branchmaverick

Jamonholmgren

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more!

On 27 Sep 2022 at 03:08:53

Jamonholmgren

Optimize the preparation of translated texts under different platforms

Created On 26 Sep 2022 at 07:03:47

Jamonholmgren

Ignite v8: Maverick

Created On 26 Sep 2022 at 07:03:46

Jamonholmgren

fix(ci): TESTING MAVERICK RELEASE (#2219)

⚠️ DANGER ZONE ⚠️

Pushed On 26 Sep 2022 at 06:47:55

Jamonholmgren

Maverick test

Created On 26 Sep 2022 at 06:47:54

Jamonholmgren

Maverick test

Created On 26 Sep 2022 at 06:43:34
Create Branch
Jamonholmgren In infinitered/ignite Create Branchmaverick-test

Jamonholmgren

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more!

On 26 Sep 2022 at 06:43:08