jacqueswho Github contribution chart
jacqueswho Github Stats
jacqueswho Most Used Languages

Activity

30 Sep 2022

Jacqueswho

Update issue templates to be assigned to `@rjsf-team/reviewers`

See https://github.com/orgs/rjsf-team/teams/reviewers/

this makes it easier to add / remove people and also set up granular notifications for rjsf-specific reviews.

We could also do autoassignment in the future! https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team#about-auto-assignment

Merged On 30 Sep 2022 at 05:53:33

Jacqueswho

Commented On 30 Sep 2022 at 05:53:33

Jacqueswho

Update issue templates for new packages

Reasons for making this change

  • Also added nickgros as a default assignee
  • Changed default for version to 5.x

Checklist

  • [ ] I'm updating documentation
  • [ ] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 29 Sep 2022 at 05:57:32

Jacqueswho

Commented On 29 Sep 2022 at 05:57:32

Jacqueswho

chore: convert semantic-ui to typescript

Reasons for making this change

  • Updated .eslintrc to use the typescript version
  • Update package.json to switch from js to ts?(x), adding necessary type imports and typings block
  • Refactored all of the .js file to Typescript
    • Reworked a few components to deal with unavailable props in types
  • Converted the tests, renaming the snapshots accordingly, updating those templates that differed by just some whitespace rendering

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [x] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 27 Sep 2022 at 06:39:50

Jacqueswho

Commented On 27 Sep 2022 at 06:39:50

Jacqueswho

chore: convert semantic-ui to typescript

Reasons for making this change

  • Updated .eslintrc to use the typescript version
  • Update package.json to switch from js to ts?(x), adding necessary type imports and typings block
  • Refactored all of the .js file to Typescript
    • Reworked a few components to deal with unavailable props in types
  • Converted the tests, renaming the snapshots accordingly, updating those templates that differed by just some whitespace rendering

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [x] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Forked On 27 Sep 2022 at 06:39:50

Jacqueswho

I don't remember doing this code, could have been a contribution
On 27 Sep 2022 at 06:39:50

Jacqueswho

chore: convert semantic-ui to typescript

Reasons for making this change

  • Updated .eslintrc to use the typescript version
  • Update package.json to switch from js to ts?(x), adding necessary type imports and typings block
  • Refactored all of the .js file to Typescript
    • Reworked a few components to deal with unavailable props in types
  • Converted the tests, renaming the snapshots accordingly, updating those templates that differed by just some whitespace rendering

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [x] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 27 Sep 2022 at 06:38:41

Jacqueswho

looks good

Commented On 27 Sep 2022 at 06:38:41

Jacqueswho

fix: playground now builds to dist, made upload work properly

Reasons for making this change

Fixed playground deploy broken by #3115

  • Updated ci.yml to change packages/playground/build to packages/playground/dist

Checklist

  • [ ] I'm updating documentation
  • [ ] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 22 Sep 2022 at 05:33:42

Jacqueswho

Commented On 22 Sep 2022 at 05:33:42

Jacqueswho

fix: Rename WithThemeProps back to version 4.x ThemeProps

Reasons for making this change

During my own migration to v5 beta I found one breaking-change that wasn't documented and need not have been made, so I reverted it

  • Renamed the WithThemeProps type back to the name it had in version 4.x, ThemeProps
    • This avoids an unnecessary breaking-change
  • Updated all Typescript based themes to use this renamed type
  • Updated the CHANGELOG.md accordingly

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [x] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 22 Sep 2022 at 05:31:51

Jacqueswho

Commented On 22 Sep 2022 at 05:31:51

Jacqueswho

fix: Updated CHANGELOG.md for last PR that was missing it

Reasons for making this change

  • fixed the documentation, but forgot to update the CHANGELOG

Checklist

  • [ ] I'm updating documentation
  • [ ] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 21 Sep 2022 at 06:26:24

Jacqueswho

Commented On 21 Sep 2022 at 06:26:24

Jacqueswho

Programmatic submit does not work properly in Firefox

Prerequisites

What theme are you using?

core

Version

5.0.0-beta6

Current Behavior

When using Firefox programmatic submit ends up embedding a copy of the entire page into the rendered form

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm: 

Anything else?

No response

Forked On 21 Sep 2022 at 06:25:02

Jacqueswho

ill take a look

Commented On 21 Sep 2022 at 06:25:02

Jacqueswho

fix: add formElement upgrade instructions

Reasons for making this change

  • Updated the 5.x upgrade guide to document the change from a simple variable to a RefObject

Checklist

  • [x] I'm updating documentation
  • [ ] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 20 Sep 2022 at 05:30:06

Jacqueswho

Commented On 20 Sep 2022 at 05:30:06

Jacqueswho

fix: Add programmatic form validation support

Reasons for making this change

Fixes https://github.com/rjsf-team/react-jsonschema-form/issues/2755, https://github.com/rjsf-team/react-jsonschema-form/issues/2552, https://github.com/rjsf-team/react-jsonschema-form/issues/2381, https://github.com/rjsf-team/react-jsonschema-form/issues/2343, https://github.com/rjsf-team/react-jsonschema-form/issues/1006, https://github.com/rjsf-team/react-jsonschema-form/issues/246

  • Updated the Form to add a new validateForm() function by refactoring that portion of the code out of the onSubmit() callback
  • Updated the playground to add a new Prog. Validate button to programmatically validate a form
    • Moved the Share button onto the next line and changed Programmatically Submit button to Prog. Submit
    • Added an alert when the form is submitted
  • Updated the validation.md documentation with this new capability
  • Updated the CHANGELOG.md file accordingly

Checklist

  • [ ] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [x] I've updated docs if needed
    • [x] I've updated the changelog with a description of the PR
  • [x] I'm adding a new feature
    • [x] I've updated the playground with an example use of the feature

Merged On 19 Sep 2022 at 05:54:24

Jacqueswho

Commented On 19 Sep 2022 at 05:54:24

Jacqueswho

Rc5.0.0 beta.7

Reasons for making this change

Releasing 5.0.0-beta.7

Checklist

  • [ ] I'm updating documentation
  • [ ] I'm adding or updating code
    • [ ] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [ ] I've updated docs if needed
    • [ ] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 14 Sep 2022 at 07:43:56

Jacqueswho

Commented On 14 Sep 2022 at 07:43:56

Jacqueswho

ci: npm publish only after publish-release

Pushed On 12 Sep 2022 at 09:16:44

Jacqueswho

ci: updates to worfkflows

Pushed On 12 Sep 2022 at 08:49:48

Jacqueswho

fix: #3104 by adding new templates

Reasons for making this change

Fixes #3104 as follows:

  • Updated the CHANGELOG.md appropriately
  • Updated the documentation to discuss the new ArraySchemaField field and the FieldErrorTemplate and FieldHelpTemplate templates
  • Updated ArrayField to get the new ArraySchemaField when rendering the children of an array item
  • Updated fields/index.ts to add ArraySchemaField as SchemaField
  • Refactored the ErrorList component from inside SchemaField.tsx as the new FieldErrorTemplate
  • Refactored the Help component from inside SchemaField.tsx as the new FieldHelpTemplate
  • Updated SchemaField to get the FieldErrorTemplate and FieldHelpTemplate from the registry/uiOptions using getTemplate()
    • Used these templates to render the errors and help components to the Field
  • Updated the tests to verify the new ArraySchemaField, FieldErrorTemplate and FieldHelpTemplate implementations
  • Updated the types.ts in the utils package to add new FieldErrorProps and FieldHelpProps as well as FieldErrorTemplate and FieldHelpTemplate to the TemplatesType
  • Updated the getTemplates() tests to add the two new templates

Checklist

  • [x] I'm updating documentation
  • [x] I'm adding or updating code
    • [x] I've added and/or updated tests. I've run npm run test:update to update snapshots, if needed.
    • [x] I've updated docs if needed
    • [x] I've updated the changelog with a description of the PR
  • [ ] I'm adding a new feature
    • [ ] I've updated the playground with an example use of the feature

Merged On 12 Sep 2022 at 06:56:17

Jacqueswho

Commented On 12 Sep 2022 at 06:56:17
Create Branch

Jacqueswho

Javascript Trixta Library, to help integrate with Trixta Space

On 10 Sep 2022 at 07:24:14

Jacqueswho

chore(release): @trixtateam/trixta-js@v5.6.3

Pushed On 10 Sep 2022 at 07:24:14

Jacqueswho

fix: fixed form data types

Pushed On 10 Sep 2022 at 07:22:11

Jacqueswho

Merge pull request #72 from trixtateam/fix/formData-types

fix: fixed form data types

Pushed On 10 Sep 2022 at 07:22:11

Jacqueswho

fix: fixed form data types

Created On 10 Sep 2022 at 07:22:10

Jacqueswho

fix: fixed form data types
Merged On 10 Sep 2022 at 07:22:03

Jacqueswho

Commented On 10 Sep 2022 at 07:22:03

Jacqueswho

chore(release): @trixtateam/trixta-js@v5.6.2

Pushed On 09 Sep 2022 at 01:21:16
Create Branch

Jacqueswho

Javascript Trixta Library, to help integrate with Trixta Space

On 09 Sep 2022 at 01:21:16

Jacqueswho

fix: make form data method parameter optional

Pushed On 09 Sep 2022 at 01:19:06

Jacqueswho

Merge pull request #71 from trixtateam/fix/optional-formData

fix: make form data method parameter optional

Pushed On 09 Sep 2022 at 01:19:06

Jacqueswho

fix: make form data method parameter optional

Created On 09 Sep 2022 at 01:19:06

Jacqueswho

fix: make form data method parameter optional
Merged On 09 Sep 2022 at 01:03:07

Jacqueswho

Commented On 09 Sep 2022 at 01:03:07
Create Branch

Jacqueswho

Javascript Trixta Library, to help integrate with Trixta Space

On 09 Sep 2022 at 07:18:46

Jacqueswho

chore(release): @trixtateam/trixta-js@v5.6.1

Pushed On 09 Sep 2022 at 07:18:46