huozhi Github contribution chart
huozhi Github Stats
huozhi Most Used Languages

Activity

05 Dec 2022

Pull Request

Huozhi

Display error digest if presented

Created On 05 Dec 2022 at 10:27:24
Create Branch
Huozhi In huozhi/next.js Create Branchfeat/error-digest-display

Huozhi

The React Framework

On 05 Dec 2022 at 10:25:30

Huozhi

Adding head element checking for root layout (#43597)

Update

We removed the <head> element checking for root layout in #41621. Since we also need <head> for preload in the future, and also css-in-js will require that. We're adding back the head element checking to make sure user always provide valid root layout including it.

Issue

An issue was reported here that the Emotion/MUI site was suffering from FOUC.

After an inspection, I noticed that the SSRed HTML didn't contain the inserted styles at all - despite them being inserted through useServerInsertedHTML. I managed to debug it down and discovered that their layout was missing <head></head> and thus the stream transformer skipped the insertion altogether cause of this check: https://github.com/vercel/next.js/blob/fbc98abab31a54dbc2b6c88a064b579a10f34871/packages/next/server/node-web-streams-helper.ts#L177-L183

I've figured that at the very least we could surface this as a console error in development to nudge the user to fix the missing <head/>

cc @huozhi

Co-authored-by: Jiachi Liu 4800338+huozhi@users.noreply.github.com

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Fixed broken Cloudinary example (#43646)

Adding TypeScript as a dependency to fix the Cloudinary example

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Revert: 'Minimized runtime errors in app dir' (#43648)

Reverts: #43511

It incorrectly shows render errors minimized although it should only be for uncaught errors/rejections. Keep old behaviour for now.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Update create-next-app template (#43482)

Refreshes create-next-app template designed by @evilrabbit. Credits to members of Vercel's Design team @dizzyup + @emilkowalski for support on CSS optimizations + code clean up.

The refreshed template includes one new dependency: @next/font. The main script + related test have been updated to reflect this.

Before:

Before -
Dark Before -
Light

After:

After -
Dark After -
Light

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

fix: properly handle trailingSlash: true and rewrites (#43641)

Fixes #43623

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Co-authored-by: Wyatt Johnson accounts+github@wyattjoh.ca

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

@next/font fallback fonts order fix (#43633)

The fallback fonts are applied in the wrong order which can cause the generated fallback font not to get applied.

ref: slack

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Update cache handling for app (#43659)

This updates the app directory caching.

x-ref: slack thread

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

v13.0.7-canary.1

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Remove resolved app directory todos (#43672)

All of these todos have been handled right before Next.js conf / shortly after, this PR is cleaning them up.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Update test config (#43661)

Updates our test config to take advantage of more concurrency and also updates to leverage the playwright docker image to reduce flakes from actions/setup-node stalling or playwright dependencies stalling on apt install.

This reduces our test times from upwards of 30 minutes down to back around 15 minutes.

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Update flakey app logbox test (#43682)

x-ref: https://github.com/vercel/next.js/actions/runs/3611458418/attempts/2 x-ref: https://github.com/vercel/next.js/actions/runs/3611458418/attempts/1 x-ref: https://github.com/vercel/next.js/actions/runs/3611571327/jobs/6086144720

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Update flakey GSSP preview test (#43702)

Ensures we grab a new port when launching fresh server as the existing port may still be held up.

x-ref: https://github.com/vercel/next.js/actions/runs/3611678257/jobs/6086329090

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Fix typo in comment (#43685)

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Fix typos in 1.bug_report.yml (#43697)

Found some tiny typos when using the bug template.

Documentation / Examples

  • [x] Make sure the linting passes by running pnpm build && pnpm lint
  • [x] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

docs: Add notes about NEXT_MANUAL_SIG_HANDLE (#43686)

It seems that setting NEXT_MANUAL_SIG_HANDLE in .env file is not working, so I added some notes.

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Disable jest autorun in this repo (#43727)

When someone installs jest extension it will run all the tests that is not possible in this repo because there is so many

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

perf: disable prefetching for links in viewport in development for app routes (#43730)

There has been a few complaints about memory usage of the Next.js 13 dev server. One of the reasons why is that prefetching is always enabled when a link is visible on app routes (and not on pages). Disabling this behaviour, whilst keeping prefetching on hover/click, should help improve resources usage.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [x] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

Merge branch 'canary' into suspensey-dynamic

Pushed On 05 Dec 2022 at 02:28:53

Huozhi

update tests

Pushed On 03 Dec 2022 at 01:43:29

Huozhi

update tests

Pushed On 03 Dec 2022 at 01:39:58

Huozhi

update tests

Pushed On 03 Dec 2022 at 01:38:26

Huozhi

fix tests

Pushed On 03 Dec 2022 at 01:29:07

Huozhi

prefer width and height before viewBox

fix ratio

Pushed On 03 Dec 2022 at 01:22:49

Huozhi

prefer width and height before viewBox

Pushed On 03 Dec 2022 at 01:15:26

Huozhi

fix tests

Pushed On 02 Dec 2022 at 07:35:08

Huozhi

fix tests

Pushed On 02 Dec 2022 at 07:27:50

Huozhi

fix react mismatch

Pushed On 02 Dec 2022 at 06:48:11

Huozhi

Revert: 'Minimized runtime errors in app dir'

Reverts: #43511

It incorrectly shows render errors minimized although it should only be for uncaught errors/rejections. Keep old behaviour for now.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Merged On 02 Dec 2022 at 05:38:25

Huozhi

Commented On 02 Dec 2022 at 05:38:25

Huozhi

Adding head element checking for root layout

Update

We removed the <head> element checking for root layout in #41621. Since we also need <head> for preload in the future, and also css-in-js will require that. We're adding back the head element checking to make sure user always provide valid root layout including it.

Issue

An issue was reported here that the Emotion/MUI site was suffering from FOUC.

After an inspection, I noticed that the SSRed HTML didn't contain the inserted styles at all - despite them being inserted through useServerInsertedHTML. I managed to debug it down and discovered that their layout was missing <head></head> and thus the stream transformer skipped the insertion altogether cause of this check: https://github.com/vercel/next.js/blob/fbc98abab31a54dbc2b6c88a064b579a10f34871/packages/next/server/node-web-streams-helper.ts#L177-L183

I've figured that at the very least we could surface this as a console error in development to nudge the user to fix the missing <head/>

cc @huozhi

Merged On 02 Dec 2022 at 04:41:43

Huozhi

Thanks!

Commented On 02 Dec 2022 at 04:41:43
Issue Comment

Huozhi

Adding head element checking for root layout

Update

We removed the <head> element checking for root layout in #41621. Since we also need <head> for preload in the future, and also css-in-js will require that. We're adding back the head element checking to make sure user always provide valid root layout including it.

Issue

An issue was reported here that the Emotion/MUI site was suffering from FOUC.

After an inspection, I noticed that the SSRed HTML didn't contain the inserted styles at all - despite them being inserted through useServerInsertedHTML. I managed to debug it down and discovered that their layout was missing <head></head> and thus the stream transformer skipped the insertion altogether cause of this check: https://github.com/vercel/next.js/blob/fbc98abab31a54dbc2b6c88a064b579a10f34871/packages/next/server/node-web-streams-helper.ts#L177-L183

I've figured that at the very least we could surface this as a console error in development to nudge the user to fix the missing <head/>

cc @huozhi

Forked On 02 Dec 2022 at 04:41:33

Huozhi

Added the head checking logic back so it's required in root layout

Commented On 02 Dec 2022 at 04:41:33
Issue Comment

Huozhi

Throw error when viewBox is missing for svg

Fixes: #319

Forked On 02 Dec 2022 at 04:31:15

Huozhi

I think it's related to scale, like if viewBox is presented, width and height should still be used for the size. But satori so far seems stripped the width and height props in SVGNodeToImage.

IMO we should just keep the original svg props there, and you can witdth and height on image to scale it. wdyt? @shuding

Commented On 02 Dec 2022 at 04:31:15

Huozhi

Remove useState from next/image (#43587)

This PR remove React.useState() from the next/image component. It was only used in the onError case and it was causing Safari to become very slow when there were many images on the same page. We were seeing 1s delay blocking the main thread when there were about 350 images on the same page. Chrome and Firefox were not slow.

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Group redirect status imports (#43480)

Group imports from the same source that were separated

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Fix Failed to copy traced files for Edge functions and handle its files with middleware-manifest.json (#43326)

Bug

  • [x] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

fixes: #41395 fixes: #42751. This PR is a follow-up PR of PR 43304.

This fix works by checking if the page is listed in middleware-manifest.json's functions, if true then skip the handleTraceFiles process. This also fixes the two issues aforementioned by copying files listed in middleware-manifest.json for those pages.

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Fix "infer pnpm with example" test outside test suite (#43487)

Fixes pnpm w/ example being the only test outside the test suite.

Before:

describe('create next app', () => {
  // ...
})

it('should infer pnpm as the package manager with example', () => { ... }) 

After:

describe('create next app', () => {
  // ...

  it('should infer pnpm as the package manager with example', () => { ... })
}) 

Documentation / Examples

  • [X] Make sure the linting passes by running pnpm build && pnpm lint

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Update next/link default legacyBehavior (#42623)

Bug

Fixes #42621

  • [x] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

fix: Dynamic Usage Error when using previewData with generateStaticParams and appDir (#43395)

fixes #43392

Bug

  • [x] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [] Related issues linked using fixes #number
  • [] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [x] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Minimized runtime errors in app dir (#43511)

Currently when there's a runtime error - the error overlay opens up in full screen mode. In app it should open in the minimized state.

Build errors will still have to open up in full screen since the app will not be runnable due to it being broken.

Before

image

After

image

Fixes #43460

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

v13.0.6-canary.3

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

chore: add issue labeler (#43599)

Follow-up of #43228. This PR adds a new GitHub Action that matches the issue's body for the dropdown list items and adds the relevant labels to the issue for triaging automatically.

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

chore(examples): Update active-class-name example (#43581)

I updated the active-class-name example to stop using the legacy behavior.

Documentation / Examples

  • [x] Make sure the linting passes by running pnpm build && pnpm lint
  • [x] The "examples guidelines" are followed from our contributing doc

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

chore: fix issue labeler (#43606)

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Changed output mode on app directory test application (#43607)

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Fix deploy button in with-xata example (#43608)

The deploy button of the with-xata example is not working properly because we were lacking the integration to configure the env variables.

Deploy with
Vercel

Taking advantage of the PR, some other changes:

  • Adding alt to next/image to fix build with latest version
  • Update readme to add more information in the Xata CLI section
  • Use a new command to initialize the database schema on first deployment
  • Remove hardcoded URL in xata.codegen.ts
  • Remove deprecated formatVersion in schema.template.json
  • Update dependencies

Note: The integration is still work in progress, it works for the Deploy to Vercel button but we want to improve the UI/UX before submitting it to the Marketplace, keeping it unlisted for a while.

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

adding note that edge api routes are not supported with ISR (#43572)

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Improve docs for URL Imports (#43615)

This improves the examples and ensures the config at the beginning will work for each of the examples below.

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Fix output: standalone test for app directory (#43618)

This test was ensuring app directory is working correctly with output: 'standalone'. Instead of removing config we should conditionally set it for the test.

Reverts vercel/next.js#43607

x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832699 x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832421

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

v13.0.6-canary.4

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

v13.0.6

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Add with-cloudinary example (#43250)

Added an image gallery example using Next.js and Cloudinary.

Edit: This is now ready to ship!

Co-authored-by: Balázs Orbán 18369201+balazsorban44@users.noreply.github.com Co-authored-by: JJ Kasper 22380829+ijjk@users.noreply.github.com

Pushed On 02 Dec 2022 at 04:00:52

Huozhi

Update react next tag (#43617)

Fixes #43033

Also remove the unsued react-dom files: bundles for bun, and react-dom-test-utils

x-ref: https://github.com/facebook/react/pull/25713

Bug

  • [x] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Pushed On 02 Dec 2022 at 04:00:52
Pull Request

Huozhi

Throw error when viewBox is missing for svg

Created On 02 Dec 2022 at 03:58:12
Create Branch
Huozhi In vercel/satori Create Branchfix/missing-viewbox

Huozhi

Enlightened library to convert HTML and CSS to SVG

On 02 Dec 2022 at 03:57:56

Huozhi

rm warning

Pushed On 02 Dec 2022 at 03:32:12

Huozhi

Revert "Root layout head not required (#41621)"

This reverts commit bdc53ef65182810fbc65273d293fdc256c07b0c3.

Pushed On 02 Dec 2022 at 03:32:12
Create Branch
Huozhi In vercel/next.js Create Branchrevert-41621-root-layout-head

Huozhi

The React Framework

On 02 Dec 2022 at 03:26:49

Huozhi

Fix dev commands, use pnpm instead of yarn (#60)

Co-authored-by: Wu Jianbo jianbo.wu@shopee.com

Pushed On 02 Dec 2022 at 01:38:57

Huozhi

Fix dev commands, use pnpm instead of yarn

Created On 02 Dec 2022 at 01:38:56

Huozhi

Fix dev commands, use pnpm instead of yarn

Fix dev commands, use pnpm instead of yarn

Merged On 02 Dec 2022 at 01:38:20

Huozhi

Thanks!

Commented On 02 Dec 2022 at 01:38:20

Huozhi

chore: disable auto-labeling

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Remove useState from next/image (#43587)

This PR remove React.useState() from the next/image component. It was only used in the onError case and it was causing Safari to become very slow when there were many images on the same page. We were seeing 1s delay blocking the main thread when there were about 350 images on the same page. Chrome and Firefox were not slow.

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Group redirect status imports (#43480)

Group imports from the same source that were separated

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Fix Failed to copy traced files for Edge functions and handle its files with middleware-manifest.json (#43326)

Bug

  • [x] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

fixes: #41395 fixes: #42751. This PR is a follow-up PR of PR 43304.

This fix works by checking if the page is listed in middleware-manifest.json's functions, if true then skip the handleTraceFiles process. This also fixes the two issues aforementioned by copying files listed in middleware-manifest.json for those pages.

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Fix "infer pnpm with example" test outside test suite (#43487)

Fixes pnpm w/ example being the only test outside the test suite.

Before:

describe('create next app', () => {
  // ...
})

it('should infer pnpm as the package manager with example', () => { ... }) 

After:

describe('create next app', () => {
  // ...

  it('should infer pnpm as the package manager with example', () => { ... })
}) 

Documentation / Examples

  • [X] Make sure the linting passes by running pnpm build && pnpm lint

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Update next/link default legacyBehavior (#42623)

Bug

Fixes #42621

  • [x] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

fix: Dynamic Usage Error when using previewData with generateStaticParams and appDir (#43395)

fixes #43392

Bug

  • [x] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [] Related issues linked using fixes #number
  • [] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [x] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Minimized runtime errors in app dir (#43511)

Currently when there's a runtime error - the error overlay opens up in full screen mode. In app it should open in the minimized state.

Build errors will still have to open up in full screen since the app will not be runnable due to it being broken.

Before

image

After

image

Fixes #43460

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

v13.0.6-canary.3

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

chore: add issue labeler (#43599)

Follow-up of #43228. This PR adds a new GitHub Action that matches the issue's body for the dropdown list items and adds the relevant labels to the issue for triaging automatically.

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

chore(examples): Update active-class-name example (#43581)

I updated the active-class-name example to stop using the legacy behavior.

Documentation / Examples

  • [x] Make sure the linting passes by running pnpm build && pnpm lint
  • [x] The "examples guidelines" are followed from our contributing doc

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

chore: fix issue labeler (#43606)

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Changed output mode on app directory test application (#43607)

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Fix deploy button in with-xata example (#43608)

The deploy button of the with-xata example is not working properly because we were lacking the integration to configure the env variables.

Deploy with
Vercel

Taking advantage of the PR, some other changes:

  • Adding alt to next/image to fix build with latest version
  • Update readme to add more information in the Xata CLI section
  • Use a new command to initialize the database schema on first deployment
  • Remove hardcoded URL in xata.codegen.ts
  • Remove deprecated formatVersion in schema.template.json
  • Update dependencies

Note: The integration is still work in progress, it works for the Deploy to Vercel button but we want to improve the UI/UX before submitting it to the Marketplace, keeping it unlisted for a while.

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

adding note that edge api routes are not supported with ISR (#43572)

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have a helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] e2e tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm build && pnpm lint
  • [ ] The "examples guidelines" are followed from our contributing doc

Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Improve docs for URL Imports (#43615)

This improves the examples and ensures the config at the beginning will work for each of the examples below.

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Fix output: standalone test for app directory (#43618)

This test was ensuring app directory is working correctly with output: 'standalone'. Instead of removing config we should conditionally set it for the test.

Reverts vercel/next.js#43607

x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832699 x-ref: https://github.com/vercel/next.js/actions/runs/3594732606/jobs/6055832421

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

v13.0.6-canary.4

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

v13.0.6

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

Add with-cloudinary example (#43250)

Added an image gallery example using Next.js and Cloudinary.

Edit: This is now ready to ship!

Co-authored-by: Balázs Orbán 18369201+balazsorban44@users.noreply.github.com Co-authored-by: JJ Kasper 22380829+ijjk@users.noreply.github.com

Pushed On 02 Dec 2022 at 01:35:41

Huozhi

pass down RecoverOnError

Pushed On 02 Dec 2022 at 12:59:22

Huozhi

fix test

Pushed On 02 Dec 2022 at 12:54:55

Huozhi

fix esm

Pushed On 02 Dec 2022 at 12:52:12