hasparus Github contribution chart
hasparus Github Stats
hasparus Most Used Languages

Activity

05 Oct 2022

Hasparus

Confirm pending deletes when selecting another saved query

Pushed On 05 Oct 2022 at 12:39:24

Hasparus

chore: explicitly pass registry-url to setup-node action

Pushed On 05 Oct 2022 at 03:19:57

Hasparus

fix: append NPM_AUTH_TOKEN to .npmrc for publish

Pushed On 05 Oct 2022 at 03:19:57

Hasparus

fix: Move NPM env vars up

Pushed On 05 Oct 2022 at 03:19:57

Hasparus

Bump versions to: 0.15.3-develop.0 [skip ci]

Pushed On 05 Oct 2022 at 03:19:57

Hasparus

fix: Move NPM env vars up

Pushed On 05 Oct 2022 at 02:53:52

Hasparus

fix: append NPM_AUTH_TOKEN to .npmrc for publish

Pushed On 05 Oct 2022 at 02:29:47

Hasparus

Merge pull request #2340 from system-ui/develop

docs updates and peer deps

Pushed On 05 Oct 2022 at 02:25:51

Hasparus

Update CHANGELOG.md [skip ci]

Pushed On 05 Oct 2022 at 02:25:51

Hasparus

Bump version to: 0.15.2 [skip ci]

Pushed On 05 Oct 2022 at 02:25:51

Hasparus

Bump versions to: 0.15.2 [skip ci]

Pushed On 05 Oct 2022 at 02:25:51

Hasparus

chore: explicitly pass registry-url to setup-node action

Pushed On 05 Oct 2022 at 02:25:51

Hasparus

Fix ESLint scripts

Pushed On 05 Oct 2022 at 02:00:07

Hasparus

Pass toast message through props

Pushed On 05 Oct 2022 at 01:57:10

Hasparus

Bump version to 0.1.14

Pushed On 05 Oct 2022 at 01:57:10

Hasparus

Remove console logs

Pushed On 05 Oct 2022 at 01:57:10

Hasparus

Merge pull request #9 from edgeandnode/piotr/toast

Pass toast message through props

Pushed On 05 Oct 2022 at 01:57:10

Hasparus

Pass toast message through props

Created On 05 Oct 2022 at 01:57:10

Hasparus

Pass toast message through props

We're now expecting the user to handle displaying messages with a Toast component compatible with @edgeandnode/components.

Previous GraphiQL Playground we've used had its own snackbar implementation, but @cmwhited convinced me this is a responsibility of the host application. Same toast component should be displayed to communicate network errors.

To support this, we can notice that @radix-ui/react-toast exports a context provider to wrap the whole application:

  • https://www.radix-ui.com/docs/primitives/components/toast#provider

Forked On 05 Oct 2022 at 01:56:54

Hasparus

@benface @cmwhited Currently @edgeandnode/components has the simplest usage of the ToastProvider. (Same as Hosted Service.) We only ever render one Toast.Root, so putting it right above it was correct. I didn't extract it out, because I wasn't sure yet why it was needed and Radix docs aren't so clear on this, so I think I'm gonna have to read the source.

Commented On 05 Oct 2022 at 01:56:54

Hasparus

Remove console logs

Pushed On 05 Oct 2022 at 01:53:29

Hasparus

Remove console logs

Pushed On 05 Oct 2022 at 01:53:12

Hasparus

Pass toast message through props

We're now expecting the user to handle displaying messages with a Toast component compatible with @edgeandnode/components.

Previous GraphiQL Playground we've used had its own snackbar implementation, but @cmwhited convinced me this is a responsibility of the host application. Same toast component should be displayed to communicate network errors.

To support this, we can notice that @radix-ui/react-toast exports a context provider to wrap the whole application:

  • https://www.radix-ui.com/docs/primitives/components/toast#provider

Forked On 05 Oct 2022 at 01:52:31

Hasparus

Thanks. Good catch.
On 05 Oct 2022 at 01:52:31

Hasparus

Pass toast message through props

We're now expecting the user to handle displaying messages with a Toast component compatible with @edgeandnode/components.

Previous GraphiQL Playground we've used had its own snackbar implementation, but @cmwhited convinced me this is a responsibility of the host application. Same toast component should be displayed to communicate network errors.

To support this, we can notice that @radix-ui/react-toast exports a context provider to wrap the whole application:

  • https://www.radix-ui.com/docs/primitives/components/toast#provider

Merged On 05 Oct 2022 at 01:52:31

Hasparus

Commented On 05 Oct 2022 at 01:52:31
Issue Comment

Hasparus

It's not obvious that `@theme-ui/core` doesn't apply `styles.root`.

Describe the bug The default 8px margin that Chrome puts on the element is present, even when styling root to have margin and padding set to 0.

To Reproduce Steps to reproduce the behavior:

Have "@theme-ui/core": "^0.14.5" (not using the complete theme-ui package since the mdx package causes problems with Vite build). Inspect body and find a margin: 8px applied by default to the element

Expected behavior Expected the to have margin: 0 on the body.

Screenshots

Additional context I'm using React v18 and Vite as a builder. I saw this issue, but it's marked as resolved. Has there been a regression?

Forked On 04 Oct 2022 at 03:38:17

Hasparus

:rocket: Issue was released in v0.15.2 :rocket:

Commented On 04 Oct 2022 at 03:38:17
Issue Comment

Hasparus

Add `@mdx-js/react` to peerDeps for `gatsby-plugin-theme-ui`

Closes https://github.com/system-ui/theme-ui/issues/2330, hopefully.

Published as 0.15.2-canary.1

Version

Published prerelease version: v0.15.2-develop.0

🐛 Bug Fix

  • Add @mdx-js/react to peerDeps for gatsby-plugin-theme-ui #2331 (@hasparus)

Authors: 1

Forked On 04 Oct 2022 at 03:38:13

Hasparus

:rocket: PR was released in v0.15.2 :rocket:

Commented On 04 Oct 2022 at 03:38:13
Issue Comment

Hasparus

Fix MDXProvider example

In [Styling MDX] docs, the first code example doesn't do anything with the componentsWithStyles value. This PR passes it as the MDXProvider component's components prop, which seems like what was intended.

Forked On 04 Oct 2022 at 03:38:11

Hasparus

:rocket: PR was released in v0.15.2 :rocket:

Commented On 04 Oct 2022 at 03:38:11
Issue Comment

Hasparus

docs: Mention that /core doesn't add global styles

Fixes #2235 via an added docs line. Hopefully writing a new package for #2207 will make this a better DX for real.

Forked On 04 Oct 2022 at 03:38:08

Hasparus

:rocket: PR was released in v0.15.2 :rocket:

Commented On 04 Oct 2022 at 03:38:08
Issue Comment

Hasparus

docs: Group & update all MDX-related docs

This has been a long time coming! With @theme-ui/mdx now being its own optional package, it makes sense to have all the MDX-related documentation in one place, & the sidebar has been growing a bit unwieldy. I've added a new MDX overview page, moved each of the MDX docs inside it, updated all of them for our newer APIs (we had some outdated ThemeProvider components={{ & Themed.root examples hanging around), linked them better together, & added URL redirects. I've entirely dropped the "Using without MDX" page as that's now the default behavior/it was outdated.

Forked On 04 Oct 2022 at 03:38:05

Hasparus

:rocket: PR was released in v0.15.2 :rocket:

Commented On 04 Oct 2022 at 03:38:05

Hasparus

fix(gatsby-plugin-theme-ui) add @mdx-js/react to peerDependencies

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Set canary version

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Merge pull request #2331 from system-ui/plugin-mdx-peer

Add @mdx-js/react to peerDeps for gatsby-plugin-theme-ui

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Bump versions to: 0.15.2-develop.0 [skip ci]

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

docs: Mention that /core doesn't add global styles

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Group & update all MDX-related docs

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Update sidebar

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Merge pull request #2339 from system-ui/mdx-docs

docs: Group & update all MDX-related docs

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Merge pull request #2333 from system-ui/2235-core-mention-no-globals

docs: Mention that /core doesn't add global styles

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

Merge pull request #2340 from system-ui/develop

docs updates and peer deps

Pushed On 04 Oct 2022 at 03:28:26

Hasparus

docs updates and peer deps

Created On 04 Oct 2022 at 03:28:25

Hasparus

docs updates and peer deps

Created On 04 Oct 2022 at 03:28:15

Hasparus

Pass toast message through props

We're now expecting the user to handle displaying messages with a Toast component compatible with @edgeandnode/components.

Previous GraphiQL Playground we've used had its own snackbar implementation, but @cmwhited convinced me this is a responsibility of the host application. Same toast component should be displayed to communicate network errors.

To support this, we can notice that @radix-ui/react-toast exports a context provider to wrap the whole application:

  • https://www.radix-ui.com/docs/primitives/components/toast#provider

Forked On 04 Oct 2022 at 03:25:20

Hasparus

I'd like to go back to the Toast after shipping the Playground anyway, so... this might change and look better in the future.
On 04 Oct 2022 at 03:25:20

Hasparus

Pass toast message through props

We're now expecting the user to handle displaying messages with a Toast component compatible with @edgeandnode/components.

Previous GraphiQL Playground we've used had its own snackbar implementation, but @cmwhited convinced me this is a responsibility of the host application. Same toast component should be displayed to communicate network errors.

To support this, we can notice that @radix-ui/react-toast exports a context provider to wrap the whole application:

  • https://www.radix-ui.com/docs/primitives/components/toast#provider

Merged On 04 Oct 2022 at 03:25:20

Hasparus

Commented On 04 Oct 2022 at 03:25:20

Hasparus

Bump version to 0.1.14

Pushed On 04 Oct 2022 at 03:23:30

Hasparus

Pass toast message through props

Pushed On 04 Oct 2022 at 03:23:10

Hasparus

Pass toast message through props

Created On 04 Oct 2022 at 03:22:50

Hasparus

Remove unused settings dialog

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Export ESM again

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Remove unused Tabs code

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Clean up a test leftover

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Improve layout

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Fix spacing

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Improve spacing again

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Bump version to 0.1.10

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Bump version to 0.1.11

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Lower spacing in SavedQuerySelect

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Fix DefaultQueryChip spacing

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Bump version to 0.1.13

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Merge pull request #8 from edgeandnode/piotr/studio-integration-2

Styling tweaks and a very stupid bugfix

Pushed On 04 Oct 2022 at 03:18:51

Hasparus

Styling tweaks and a very stupid bugfix

Created On 04 Oct 2022 at 03:18:51