gugu Github contribution chart
gugu Github Stats
gugu Most Used Languages

Activity

29 Sep 2022

Gugu

meta: update dependency typescript to v4.8.4 (#15060)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 29 Sep 2022 at 02:50:37

Gugu

meta: fix commit type for lockfile update PRs (#15061)

Pushed On 29 Sep 2022 at 02:50:37

Gugu

meta: update dependency @types/mocha to v10 (#15063)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 29 Sep 2022 at 02:50:37

Gugu

meta: update dependency @types/lodash to v4.14.186 (#15064)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Pushed On 29 Sep 2022 at 02:50:37

Gugu

Merge branch 'main' into patch-2

Pushed On 29 Sep 2022 at 02:50:37
Issue Comment

Gugu

fix: OOM in bulkCreate with bigint value (v6)

Pull Request Checklist

  • [x] Have you added new tests to prevent regressions?
  • [x] If a documentation update is necessary, have you opened a PR to the documentation repository?
  • [x] Did you update the typescript typings accordingly (if applicable)?
  • [x] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [x] Does the name of your PR follow our conventions?

Description Of Change

Closes #15053

To prevent string concatenation and keep addition correct I've added a cast to BigInt To keep existing API result contains either number or string instead of bigint

Forked On 29 Sep 2022 at 02:50:34

Gugu

@ephys is there anything extra I need to change in this PR?

Commented On 29 Sep 2022 at 02:50:34
Issue Comment

Gugu

Performance issues - iterating over 9k rules for every domain

I've made some benchmarks and performance of psl is around 2k ops/sec:

psl#isValid x 2,310 ops/sec ±2.00% (92 runs sampled)
psl#parse x 2,428 ops/sec ±0.24% (97 runs sampled)
psl#parse invalid domain x 2,415 ops/sec ±1.56% (94 runs sampled) 

by using maps it is possible to increase speed to 300k ops/sec:

psl#isValid x 349,961 ops/sec ±0.48% (95 runs sampled)
psl#parse x 346,816 ops/sec ±0.18% (99 runs sampled)
psl#parse invalid domain x 375,047 ops/sec ±0.16% (96 runs sampled) 

Forked On 29 Sep 2022 at 10:59:28

Gugu

@lupomontero sorry for mentioning you. Can you please review this PR? I think 300x speed boost can helpful change to this module

Commented On 29 Sep 2022 at 10:59:28
Issue Comment

Gugu

fix: OOM in bulkCreate with bigint value

Pull Request Checklist

  • [ ] Have you added new tests to prevent regressions?
  • [ ] If a documentation update is necessary, have you opened a PR to the documentation repository?
  • [ ] Did you update the typescript typings accordingly (if applicable)?
  • [x] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [ ] Does the name of your PR follow our conventions?

Description Of Change

Closes #15053

To prevent string concatenation and keep addition correct I've added a cast to BigInt To keep existing API result contains either number or string instead of bigint

Forked On 26 Sep 2022 at 09:43:34

Gugu

I wrote tests and changed types to match input. The test fails for SQLite, but I think it is a part of a larger problem, which is out of scope of the fix

Commented On 26 Sep 2022 at 09:43:34

Gugu

don't run test for sqlite

Pushed On 26 Sep 2022 at 09:35:01

Gugu

Merge branch 'patch-2' of github.com:gugu/sequelize-1 into patch-2

Pushed On 26 Sep 2022 at 09:35:01

Gugu

meta: update sequelize AUTHORS (#15047)

Co-authored-by: SequelizeJS mail@sequelizejs.com Co-authored-by: Rik Smale 13023439+WikiRik@users.noreply.github.com

Pushed On 26 Sep 2022 at 08:12:53

Gugu

fix(postgres): add custom order direction to subQuery ordering with minified alias (#15046)

  • test written to reflect new bug report

  • fix: add custom order direction to subQuery ordering when minifyAliases is true

Pushed On 26 Sep 2022 at 08:12:53

Gugu

Merge branch 'main' into patch-2

Pushed On 26 Sep 2022 at 08:12:53

Gugu

test for bulk create with large bigints

Pushed On 26 Sep 2022 at 08:12:05

Gugu

keep the type of incoming identifier when producing autoIncrement values

Pushed On 26 Sep 2022 at 12:22:56
Issue Comment

Gugu

fix: OOM in bulkCreate with bigint value

Pull Request Checklist

  • [ ] Have you added new tests to prevent regressions?
  • [ ] If a documentation update is necessary, have you opened a PR to the documentation repository?
  • [ ] Did you update the typescript typings accordingly (if applicable)?
  • [x] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [ ] Does the name of your PR follow our conventions?

Description Of Change

Closes #15053

To prevent string concatenation and keep addition correct I've added a cast to BigInt To keep existing API result contains either number or string instead of bigint

Forked On 26 Sep 2022 at 12:17:36

Gugu

Type of value Sequelize returns strings for BigInts larger than Number.MAX_SAFE_INTEGER, so I tried to be consistent with that behaviour

Commented On 26 Sep 2022 at 12:17:36
Issue Comment

Gugu

fix: OOM in bulkCreate with bigint value

Pull Request Checklist

  • [ ] Have you added new tests to prevent regressions?
  • [ ] If a documentation update is necessary, have you opened a PR to the documentation repository?
  • [ ] Did you update the typescript typings accordingly (if applicable)?
  • [x] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?
  • [ ] Does the name of your PR follow our conventions?

Description Of Change

Closes #15053

To prevent string concatenation and keep addition correct I've added a cast to BigInt To keep existing API result contains either number or string instead of bigint

Forked On 26 Sep 2022 at 12:13:54

Gugu

@ephys can I write unit test for this formatData instead? I think it will be much simpler and faster

Commented On 26 Sep 2022 at 12:13:54

Gugu

Use bigint for increment

Pushed On 26 Sep 2022 at 11:45:04

Gugu

OOM in bulkCreate with bigint value

Created On 26 Sep 2022 at 11:30:52

Gugu

OOM in bulkCreate with bigint value

Pushed On 26 Sep 2022 at 11:25:55

Gugu

crash on bigint in bulk create

Pushed On 26 Sep 2022 at 11:04:35

Gugu

Base repository for creating and sharing Sequelize SSCCEs

Forked On 26 Sep 2022 at 10:45:59

Gugu

Revert "remove connection entity from connection"

This reverts commit 404ca3d710334262279c5fb18bb4c6c6269e780c.

Pushed On 16 Sep 2022 at 09:54:54

Gugu

Revert "repositories refactored"

This reverts commit 16728d0e107598739986f3e8f37f14a1403274da.

Pushed On 16 Sep 2022 at 09:54:54

Gugu

remove connection entity from connection

Pushed On 16 Sep 2022 at 09:28:28

Gugu

remove test start from dockerfile

Pushed On 16 Sep 2022 at 07:00:33

Gugu

max 10

Pushed On 16 Sep 2022 at 04:43:16
Issue Comment
Gugu Issue Comment avajs/ava

Gugu

[node v18.8.0] TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null

Please provide details about:

  • What you're trying to do

npm test

  • What happened
$ npm test

> sample-pubsub@0.0.1 test
> ava


  Uncaught exception in test.js

  test.js:10

    9:
   10: test("get win/loss P PSuccess", (t) => {
   11:   const wl = getWinLossProbabilityPSuccess(0.186, 0.5, 5);

  TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null.

  › file://node_modules/mem/dist/index.js:42:27
  › file://node_modules/mem/dist/index.js:42:27
  › file://test.js:10:1

  ✔ get win/loss P PSuccess
    ℹ 0.3573732358018241 0.6426267641981759
  ✖ Internal error when running test.js
  TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null.
  TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null.
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:398:9
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/mem/dist/index.js:42:27
      at mem.cacheKey.file.file (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:409:31)
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/mem/dist/index.js:42:27
      at determineSnapshotPaths (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:428:14)
      at load (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:468:16)
      at get snapshots [as snapshots] (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/runner.js:204:21)
      at Runner.saveSnapshotState (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/runner.js:228:36)
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/worker/base.js:84:40
      at /home/mark/dev/agkund/sportsbook-data/node_modules/emittery/index.js:319:13


  ✖ test.js exited with a non-zero exit code: 1
  ─

  1 test passed
  1 uncaught exception 
  • What you expected to happen

ava should work with node 18.8.0

it works fine with 18.7.0

Please share relevant sample code. Or better yet, provide a link to a minimal reproducible example.

could be related to the snapshot changes in node 18.8? https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.8.0

We'll also need your AVA configuration (in package.json or ava.config.* configuration files) and how you're invoking AVA. Share the installed AVA version (get it by running npx ava --version).

ava version 4.3.1

no ava.config

Forked On 25 Aug 2022 at 12:58:37

Gugu

sorry, my bad, 18.7 works for me as well

Commented On 25 Aug 2022 at 12:58:37
Issue Comment
Gugu Issue Comment avajs/ava

Gugu

[node v18.8.0] TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null

Please provide details about:

  • What you're trying to do

npm test

  • What happened
$ npm test

> sample-pubsub@0.0.1 test
> ava


  Uncaught exception in test.js

  test.js:10

    9:
   10: test("get win/loss P PSuccess", (t) => {
   11:   const wl = getWinLossProbabilityPSuccess(0.186, 0.5, 5);

  TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null.

  › file://node_modules/mem/dist/index.js:42:27
  › file://node_modules/mem/dist/index.js:42:27
  › file://test.js:10:1

  ✔ get win/loss P PSuccess
    ℹ 0.3573732358018241 0.6426267641981759
  ✖ Internal error when running test.js
  TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null.
  TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null.
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:398:9
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/mem/dist/index.js:42:27
      at mem.cacheKey.file.file (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:409:31)
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/mem/dist/index.js:42:27
      at determineSnapshotPaths (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:428:14)
      at load (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/snapshot-manager.js:468:16)
      at get snapshots [as snapshots] (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/runner.js:204:21)
      at Runner.saveSnapshotState (file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/runner.js:228:36)
      at file:///home/mark/dev/agkund/sportsbook-data/node_modules/ava/lib/worker/base.js:84:40
      at /home/mark/dev/agkund/sportsbook-data/node_modules/emittery/index.js:319:13


  ✖ test.js exited with a non-zero exit code: 1
  ─

  1 test passed
  1 uncaught exception 
  • What you expected to happen

ava should work with node 18.8.0

it works fine with 18.7.0

Please share relevant sample code. Or better yet, provide a link to a minimal reproducible example.

could be related to the snapshot changes in node 18.8? https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V18.md#18.8.0

We'll also need your AVA configuration (in package.json or ava.config.* configuration files) and how you're invoking AVA. Share the installed AVA version (get it by running npx ava --version).

ava version 4.3.1

no ava.config

Forked On 25 Aug 2022 at 12:53:03

Gugu

node 18.7.0, same issue

Commented On 25 Aug 2022 at 12:53:03

Gugu

make LoginResponse['authResponse'] non-empty in onSuccess

Created On 18 Aug 2022 at 12:32:35

Gugu

make LoginResponse['authResponse'] non-empty in onSuccess

It is checked in code to be non-empty, but the type allows it to be undefined

Pushed On 18 Aug 2022 at 12:29:45

Gugu

Well-Typed React Component for Facebook Login

Forked On 18 Aug 2022 at 12:28:45
Issue Comment

Gugu

[BUG] Regression: "SAML assertion AudienceRestriction has no Audience value"

After upgrading to beta 3 I get this error: "SAML assertion AudienceRestriction has no Audience value". I don't have assertion in my logs, unfortunately I don't have assertion available to debug

To Reproduce

The only information I have for now is that the client uses OneLogin. The code is:

const { profile } = await saml.validatePostResponseAsync(req.body);

Expected behavior It should work as before

Environment

  • Node.js version: 16
  • node-saml version: 4.0.0-beta.3

Forked On 17 Aug 2022 at 04:32:26

Gugu

It was me not reading changelog. I did not have audience parameter and defauld behaviour was changed

Commented On 17 Aug 2022 at 04:32:26