gondar00 Github contribution chart
gondar00 Github Stats
gondar00 Most Used Languages

Activity

29 Sep 2022

Gondar00

chore: apply primary-color in more places (#4025)

  • chore: apply primary-color in more places, ensure svg use currentColor too

  • fix: remove hard-coded colors to use defaults

  • fix: those images were intruducing noise when switch to dark-mode

  • fix: setup colors for rc-slider

  • fix: empty all predefined-colors to use defaults

  • Use primary-rgb-darker

Pushed On 29 Sep 2022 at 08:03:03

Gondar00

chore: apply primary-color in more places

Created On 29 Sep 2022 at 08:03:02

Gondar00

chore: apply primary-color in more places

Hi, I was investigating how easily you can change the $primary colors from the entire app and I found it's bit hardcoded on many places... so far what I did was replacing it with their proper variables, and also tweaking a bit the css+svgs to use currentColor and inherit whatever color the current theme is.

  • changes made on SVG icons is for taking into account the currentColor property
  • Button.jsx now considers if it has a custom background-color, and update its darker hue accordingly
  • for widgetConfig.js, I noticed if you leave the backgroundColor empty then it'll take the --tblr-btn-color as default

IMHO this would help companies adopting this technology to setup their own primary/accent color on build-time, by just replacing the $primary-rgb and $primary-rgb-darker variables. However this solution will not scale well because we're using Sass and we should be able to setup colors on the :root instead.

Do you think this PR is worth to merge? Thank you!

Merged On 29 Sep 2022 at 08:01:17

Gondar00

Commented On 29 Sep 2022 at 08:01:17

Gondar00

started

Started On 29 Sep 2022 at 05:52:45

Gondar00

chore: apply primary-color in more places

Hi, I was investigating how easily you can change the $primary colors from the entire app and I found it's bit hardcoded on many places... so far what I did was replacing it with their proper variables, and also tweaking a bit the css+svgs to use currentColor and inherit whatever color the current theme is.

  • changes made on SVG icons is for taking into account the currentColor property
  • Button.jsx now considers if it has a custom background-color, and update its darker hue accordingly
  • for widgetConfig.js, I noticed if you leave the backgroundColor empty then it'll take the --tblr-btn-color as default

IMHO this would help companies adopting this technology to setup their own primary/accent color on build-time, by just replacing the $primary-rgb and $primary-rgb-darker variables. However this solution will not scale well because we're using Sass and we should be able to setup colors on the :root instead.

Do you think this PR is worth to merge? Thank you!

Merged On 28 Sep 2022 at 05:14:05

Gondar00

Commented On 28 Sep 2022 at 05:14:05
Issue Comment

Gondar00

chore: apply primary-color in more places

Hi, I was investigating how easily you can change the $primary colors from the entire app and I found it's bit hardcoded on many places... so far what I did was replacing it with their proper variables, and also tweaking a bit the css+svgs to use currentColor and inherit whatever color the current theme is.

  • changes made on SVG icons is for taking into account the currentColor property
  • Button.jsx now considers if it has a custom background-color, and update its darker hue accordingly
  • for widgetConfig.js, I noticed if you leave the backgroundColor empty then it'll take the --tblr-btn-color as default

IMHO this would help companies adopting this technology to setup their own primary/accent color on build-time, by just replacing the $primary-rgb and $primary-rgb-darker variables. However this solution will not scale well because we're using Sass and we should be able to setup colors on the :root instead.

Do you think this PR is worth to merge? Thank you!

Forked On 28 Sep 2022 at 11:56:42

Gondar00

@pateketrueke could you please fix the merge conflicts

Commented On 28 Sep 2022 at 11:56:42

Gondar00

feat: add postgrest js

Pushed On 28 Sep 2022 at 11:53:46

Gondar00

feat: add create column form, create row form

Pushed On 28 Sep 2022 at 09:02:39

Gondar00

feat: add columns form

Pushed On 28 Sep 2022 at 07:44:35

Gondar00

chore: apply primary-color in more places

Hi, I was investigating how easily you can change the $primary colors from the entire app and I found it's bit hardcoded on many places... so far what I did was replacing it with their proper variables, and also tweaking a bit the css+svgs to use currentColor and inherit whatever color the current theme is.

  • changes made on SVG icons is for taking into account the currentColor property
  • Button.jsx now considers if it has a custom background-color, and update its darker hue accordingly
  • for widgetConfig.js, I noticed if you leave the backgroundColor empty then it'll take the --tblr-btn-color as default

IMHO this would help companies adopting this technology to setup their own primary/accent color on build-time, by just replacing the $primary-rgb and $primary-rgb-darker variables. However this solution will not scale well because we're using Sass and we should be able to setup colors on the :root instead.

Do you think this PR is worth to merge? Thank you!

Merged On 28 Sep 2022 at 05:18:39

Gondar00

Commented On 28 Sep 2022 at 05:18:39

Gondar00

feat: add react-table to load data

Pushed On 26 Sep 2022 at 10:01:04

Gondar00

Bugfix: update both comments collections when socket message is received

This PR fixes #3044 I split both notification collections into resolved and unresolved, because setting the collection based on the state of the tab and using the same collection for both tabs feels weird. Also whenever a notifications message is received, it is not possible to determine whether an unresolved comment is marked as resolved or visa versa. Therefore I suggest we update both collections whenever a message is received.

Merged On 26 Sep 2022 at 05:46:40

Gondar00

Commented On 26 Sep 2022 at 05:46:40
Merge

Gondar00

Bugfix: update both comments collections when socket message is received

This PR fixes #3044 I split both notification collections into resolved and unresolved, because setting the collection based on the state of the tab and using the same collection for both tabs feels weird. Also whenever a notifications message is received, it is not possible to determine whether an unresolved comment is marked as resolved or visa versa. Therefore I suggest we update both collections whenever a message is received.

Forked On 26 Sep 2022 at 05:46:39

Gondar00

@mslourens I believe the issue exists when the user switches to the "resolved" tab, feel like the issue can be solved by adding another check for `isResolved` based on the tab `key` value and prevent making an extra api call i.e ```js const isResolved = k === 'resolved' || key === 'resolved'; ```
On 26 Sep 2022 at 05:46:39

Gondar00

bug fixed : misaligned text and button in the events section in query manager (#4088)

Pushed On 26 Sep 2022 at 05:37:08

Gondar00

bug fixed : misaligned text and button in the events section in query manager

Created On 26 Sep 2022 at 05:37:07

Gondar00

bug fixed : misaligned text and button in the events section in query manager

Resolves #3309

Merged On 26 Sep 2022 at 05:37:00

Gondar00

Commented On 26 Sep 2022 at 05:37:00

Gondar00

started

Started On 23 Sep 2022 at 08:21:11

Gondar00

started

Started On 23 Sep 2022 at 08:20:55
Create Branch
Gondar00 In ToolJet/ToolJet Create Branchtables-design-implementation

Gondar00

Extensible low-code framework for building business applications. Connect to databases, cloud storages, GraphQL, API endpoints, Airtable, etc and build apps using drag and drop application builder. Built using JavaScript/TypeScript. 🚀

On 23 Sep 2022 at 08:16:39

Gondar00

fix crash on search

Pushed On 23 Sep 2022 at 07:45:43

Gondar00

add test url

Pushed On 23 Sep 2022 at 07:02:14

Gondar00

remove a href

Pushed On 23 Sep 2022 at 06:57:32

Gondar00

remove bg color + redirect issue due to href

Pushed On 23 Sep 2022 at 06:57:32

Gondar00

fix: add max file size validator for user avatar

Created On 23 Sep 2022 at 06:11:01

Gondar00

fix: add max file size validator for user avatar

Pushed On 23 Sep 2022 at 06:09:27

Gondar00

add todo

Pushed On 23 Sep 2022 at 06:05:47
Create Branch
Gondar00 In ToolJet/ToolJet Create Branchmax-file-size-usr-avatar

Gondar00

Extensible low-code framework for building business applications. Connect to databases, cloud storages, GraphQL, API endpoints, Airtable, etc and build apps using drag and drop application builder. Built using JavaScript/TypeScript. 🚀

On 23 Sep 2022 at 06:04:51

Gondar00

fix: max file size validation error message

Pushed On 23 Sep 2022 at 06:01:30