frenzzy Github contribution chart
frenzzy Github Stats
frenzzy Most Used Languages

Activity

21 Jul 2022

Frenzzy

Bump terser from 5.14.1 to 5.14.2 (#25)

Bumps terser from 5.14.1 to 5.14.2.


updated-dependencies:

  • dependency-name: terser dependency-type: indirect ...

Signed-off-by: dependabot[bot] support@github.com

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Pushed On 21 Jul 2022 at 07:51:14

Frenzzy

Bump terser from 5.14.1 to 5.14.2

Created On 21 Jul 2022 at 07:51:12

Frenzzy

started

Started On 09 Jul 2022 at 12:32:59
Issue Comment

Frenzzy

Allow empty string text nodes

Currently, if you try to render a node like this:

text('') 

It will actually render undefined 🤔

It goes through this part of the code to get HTML escaped, however, because the || operator considers '' a falsy value, it goes for node.name instead, which does not exist on a VDOM node. The first line in this escapeHtml function converts this undefined value to string, which ends up being the string 'undefined'.

I think this is a bug?

Hope this helps!

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [x] I have added tests to cover my changes.
  • [x] All new and existing tests passed.

Forked On 29 Jun 2022 at 03:42:20

Frenzzy

Just released under v4.0.1 :tada: Thank you!

Commented On 29 Jun 2022 at 03:42:20
Create Branch

Frenzzy

Render Hyperapp to an HTML string with SSR and Node.js streaming support.

On 29 Jun 2022 at 03:39:49

Frenzzy

4.0.1

Pushed On 29 Jun 2022 at 03:38:35

Frenzzy

Update chat badge

Pushed On 29 Jun 2022 at 03:32:58

Frenzzy

Allow empty string text nodes (#23)

  • Allow empty string text nodes

Currently, if you try to render a node like this:

text('') 

It will go through this part of the code to get HTML escaped, however, because the || operator considers '' a falsy value, it goes for node.name instead, which does not exist on a VDOM node. The first line in this escapeHtml function converts this undefined value to string, which ends up being the string 'undefined'.

I think this is a bug?

Hope this helps!

  • run ci workflow for pull request

Co-authored-by: Vladimir Kutepov frenzzy.man@gmail.com

Pushed On 29 Jun 2022 at 03:23:05

Frenzzy

Allow empty string text nodes

Created On 29 Jun 2022 at 03:23:03

Frenzzy

run ci workflow for pull request

Pushed On 29 Jun 2022 at 03:21:02

Frenzzy

Allow empty string text nodes

Currently, if you try to render a node like this:

text('') 

It will actually render undefined 🤔

It goes through this part of the code to get HTML escaped, however, because the || operator considers '' a falsy value, it goes for node.name instead, which does not exist on a VDOM node. The first line in this escapeHtml function converts this undefined value to string, which ends up being the string 'undefined'.

I think this is a bug?

Hope this helps!

Types of changes

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Merged On 29 Jun 2022 at 03:10:30

Frenzzy

Commented On 29 Jun 2022 at 03:10:30

Frenzzy

GitHub Actions (#24)

Pushed On 29 Jun 2022 at 03:08:59

Frenzzy

Allow empty string text nodes

Currently, if you try to render a node like this:

text('') 

It will go through this part of the code to get HTML escaped, however, because the || operator considers '' a falsy value, it goes for node.name instead, which does not exist on a VDOM node. The first line in this escapeHtml function converts this undefined value to string, which ends up being the string 'undefined'.

I think this is a bug?

Hope this helps!

Pushed On 29 Jun 2022 at 03:08:59