frankcalise Github contribution chart
frankcalise Github Stats
frankcalise Most Used Languages

Activity

02 Dec 2022

Issue Comment

Frankcalise

ignite-cli generate command leaves some unnecessary lines

Describe the bug

When I try to run npx ignite-cli generate model MODEL_NAME, the resulted file still contains some additional lines inherented from the .ejs template files like so: image

Ignite version

8.4.2

Additional info

System
  platform           win32       
  arch               x64         
  cpu                8 cores      Intel(R) Core(TM) i5-10300H CPU @ 2.50GHz
  directory          IgniteApp    C:\Users\mh\Desktop\Codes\_sketch\IgniteApp

JavaScript (and globally-installed packages)
  node                    16.14.0                                   C:\Program Files\nodejs\node.EXE
  npm                     8.3.1                                     C:\Program Files\nodejs\npm.CMD
    expo-cli              6.0.8                                    
  yarn                    1.22.15                                   C:\Program Files\nodejs\yarn.CMD                       
    create-vite           3.1.0                                    
    docsify-cli           4.4.4                                    
    expo-cli              6.0.8                                    
    react-native          0.70.2                                   
    turtle-cli            0.28.1                                   
  pnpm                    6.11.0                                    C:\Program Files\nodejs\pnpm.CMD
                          <no pnpm global package info available>  
  expo                    46.0.17                                   managed

Ignite
  ignite-cli         8.4.2        C:\Users\mh\AppData\Local\npm-cache\_npx\e31027f3785124a8\node_modules\.bin\ignite.CMD
  ignite src         build        C:\Users\mh\AppData\Local\npm-cache\_npx\e31027f3785124a8\node_modules\ignite-cli\build

Android
  java               11.0.13      C:\Program Files\Eclipse Adoptium\jdk-11.0.13.8-hotspot\bin\java.EXE
  android home       -            C:\Users\mh\AppData\Local\Android\Sdk

Tools
  git                git version 2.32.0.windows.2   C:\Program Files\Git\cmd\git.EXE 

Forked On 02 Dec 2022 at 07:23:43

Frankcalise

@hamzakat It's likely somewhere in src/tools/generators.ts would be my hunch.

I think it's a Windows only issue from what I can tell. So, perhaps something with parsing the content out in the frontMatter function or maybe some path isn't proper for the Windows side.

Maybe @kateinkim or @joshuayoes might have more direction.

Commented On 02 Dec 2022 at 07:23:43

Frankcalise

Feat/talk details

Created On 02 Dec 2022 at 02:20:31

Frankcalise

chore(talk-details): notes

Pushed On 02 Dec 2022 at 02:20:21

Frankcalise

fix(talk-details): animated header

Pushed On 02 Dec 2022 at 02:09:29

Frankcalise

feat: Expo 47 and react-native 0.70.5 (#17 by @frankcalise)

  • vendor: upgraded to Expo 47.0.8, react-native 0.70.5

  • fix(button): removed unnecessary flexGrow

  • chore: clean up unused files, yarn tsc success

Pushed On 01 Dec 2022 at 08:49:18

Frankcalise

chore: removed console log

Pushed On 01 Dec 2022 at 08:49:18

Frankcalise

feat(components): added new BoxShadow (#18 by @frankcalise)

  • feat(components): added BoxShadow

  • refactor(card): utilize reusable BoxShadow

  • refactor(box-shadow): renamed props

Pushed On 01 Dec 2022 at 08:49:18

Frankcalise

chore: merge branch 'main' into feat/talk-details

Pushed On 01 Dec 2022 at 08:49:18

Frankcalise

chore: added assets for talk details

Pushed On 01 Dec 2022 at 08:49:18

Frankcalise

fix(welcome-screen): centered button for Android

Pushed On 01 Dec 2022 at 08:49:18

Frankcalise

feat(talk-details): added shapes around speaker image

Pushed On 01 Dec 2022 at 08:49:18

Frankcalise

feat(components): added new BoxShadow (#18 by @frankcalise)

  • feat(components): added BoxShadow

  • refactor(card): utilize reusable BoxShadow

  • refactor(box-shadow): renamed props

Pushed On 01 Dec 2022 at 03:53:08

Frankcalise

feat(components): added new BoxShadow

Created On 01 Dec 2022 at 03:53:08

Frankcalise

refactor(box-shadow): renamed props

Pushed On 01 Dec 2022 at 01:50:42

Frankcalise

feat: Expo 47 and react-native 0.70.5 (#17 by @frankcalise)

  • vendor: upgraded to Expo 47.0.8, react-native 0.70.5

  • fix(button): removed unnecessary flexGrow

  • chore: clean up unused files, yarn tsc success

Pushed On 30 Nov 2022 at 10:10:28

Frankcalise

Merge branch 'main' into feat/component-box-shadow

Pushed On 30 Nov 2022 at 10:10:28

Frankcalise

feat(components): added new BoxShadow

Created On 30 Nov 2022 at 10:06:29
Create Branch
Frankcalise In infinitered/ChainReactApp2023 Create Branchfeat/component-box-shadow

Frankcalise

The official Chain React App for #ChainReact2023

On 30 Nov 2022 at 10:03:53

Frankcalise

fix(talk-details): bottom padding for scroll view

Pushed On 30 Nov 2022 at 02:44:51
Create Branch
Frankcalise In infinitered/ChainReactApp2023 Create Branchfeat/talk-details

Frankcalise

The official Chain React App for #ChainReact2023

On 29 Nov 2022 at 11:22:39

Frankcalise

feat: Expo 47 and react-native 0.70.5 (#17 by @frankcalise)

  • vendor: upgraded to Expo 47.0.8, react-native 0.70.5

  • fix(button): removed unnecessary flexGrow

  • chore: clean up unused files, yarn tsc success

Pushed On 29 Nov 2022 at 11:19:24

Frankcalise

feat: Expo 47 and react-native 0.70.5

Created On 29 Nov 2022 at 11:19:24

Frankcalise

feat: Expo 47 and react-native 0.70.5

Description

Trello Card

  • Upgrades to Expo 47.0.8 and react-native 0.70.5 (You will have to rebuild the dev client for this -I'm pretty sure, anyway)
  • Removed a flexGrow from the Button component causing issue on the WelcomeScreen, see graphic (@jonmajorc this didn't seem to impact the link button, so let me know if it is needed)
  • Removed unused i18n files and Toggle component (yarn tsc now succeeds)

Graphics

| iOS | | ------ | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Forked On 28 Nov 2022 at 10:54:22

Frankcalise

@jonmajorc LMK if this is an issue but it didn't seem to impact LinkButton, however it cleaned up the graphic displayed in the PR notes
On 28 Nov 2022 at 10:54:22

Frankcalise

feat: Expo 47 and react-native 0.70.5

Description

Trello Card

  • Upgrades to Expo 47.0.8 and react-native 0.70.5 (You will have to rebuild the dev client for this -I'm pretty sure, anyway)
  • Removed a flexGrow from the Button component causing issue on the WelcomeScreen, see graphic (@jonmajorc this didn't seem to impact the link button, so let me know if it is needed)
  • Removed unused i18n files and Toggle component (yarn tsc now succeeds)

Graphics

| iOS | | ------ | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Merged On 28 Nov 2022 at 10:54:46

Frankcalise

Notes from self

Commented On 28 Nov 2022 at 10:54:46

Frankcalise

feat: Expo 47 and react-native 0.70.5

Description

Trello Card

  • Upgrades to Expo 47.0.8 and react-native 0.70.5 (You will have to rebuild the dev client for this -I'm pretty sure, anyway)
  • Removed a flexGrow from the Button component causing issue on the WelcomeScreen, see graphic (@jonmajorc this didn't seem to impact the link button, so let me know if it is needed)
  • Removed unused i18n files and Toggle component (yarn tsc now succeeds)

Graphics

| iOS | | ------ | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Merged On 28 Nov 2022 at 10:54:46

Frankcalise

Notes from self

Commented On 28 Nov 2022 at 10:54:46

Frankcalise

Feat/expo 47

Created On 28 Nov 2022 at 10:52:11

Frankcalise

chore: clean up unused files, yarn tsc success

Pushed On 28 Nov 2022 at 10:52:02
Create Branch

Frankcalise

The official Chain React App for #ChainReact2023

On 28 Nov 2022 at 10:45:37

Frankcalise

style(card): fixed secondary color not showing

Pushed On 28 Nov 2022 at 03:37:26

Frankcalise

chore: add mock data to other days

Pushed On 28 Nov 2022 at 03:37:26

Frankcalise

feat(hooks): add useAppState hook

Pushed On 28 Nov 2022 at 03:37:26

Frankcalise

feat(schedule-screen): navigate to current day from backgrounded state

Pushed On 28 Nov 2022 at 03:37:26

Frankcalise

feat(schedule-screen): scroll to top of list if pressing same day again

Pushed On 28 Nov 2022 at 03:37:26

Frankcalise

feat(schedule-screen): return to active day during conference (#16 by @frankcalise)

Pushed On 28 Nov 2022 at 03:37:26

Frankcalise

feat(schedule-screen): return to active day during conference

Created On 28 Nov 2022 at 03:37:25

Frankcalise

feat(schedule-screen): return to active day during conference

Description

Screen: Schedule Screen

  • Upon pressing the day picker button, if the day is already selected, will scroll to top of the schedule list
  • If the app is backgrounded or killed, the next time it is active we will scroll to the specific schedule for the current day when the conference is ongoing (both pre and post conference the user will just remain where they are) - the gif for this really doesn't show the traveling to the Desktop

Graphics

| Top of list press | Backgrounded find correct day (pretend it's Thursday 😉) | | ------ | ------- | | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Forked On 28 Nov 2022 at 03:00:25

Frankcalise

Run `navigateToCurrentDay` if the app was backgrounded and now is active
On 28 Nov 2022 at 03:00:25

Frankcalise

feat(schedule-screen): return to active day during conference

Description

Screen: Schedule Screen

  • Upon pressing the day picker button, if the day is already selected, will scroll to top of the schedule list
  • If the app is backgrounded or killed, the next time it is active we will scroll to the specific schedule for the current day when the conference is ongoing (both pre and post conference the user will just remain where they are) - the gif for this really doesn't show the traveling to the Desktop

Graphics

| Top of list press | Backgrounded find correct day (pretend it's Thursday 😉) | | ------ | ------- | | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Forked On 28 Nov 2022 at 03:04:17

Frankcalise

Needed this helper to determine if we were already on the current day picker page - open to discuss how to move away from indexes
On 28 Nov 2022 at 03:04:17

Frankcalise

feat(schedule-screen): return to active day during conference

Description

Screen: Schedule Screen

  • Upon pressing the day picker button, if the day is already selected, will scroll to top of the schedule list
  • If the app is backgrounded or killed, the next time it is active we will scroll to the specific schedule for the current day when the conference is ongoing (both pre and post conference the user will just remain where they are) - the gif for this really doesn't show the traveling to the Desktop

Graphics

| Top of list press | Backgrounded find correct day (pretend it's Thursday 😉) | | ------ | ------- | | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Forked On 28 Nov 2022 at 02:59:51

Frankcalise

Otherwise we scroll them horizontally to the correct day
On 28 Nov 2022 at 02:59:51

Frankcalise

feat(schedule-screen): return to active day during conference

Description

Screen: Schedule Screen

  • Upon pressing the day picker button, if the day is already selected, will scroll to top of the schedule list
  • If the app is backgrounded or killed, the next time it is active we will scroll to the specific schedule for the current day when the conference is ongoing (both pre and post conference the user will just remain where they are) - the gif for this really doesn't show the traveling to the Desktop

Graphics

| Top of list press | Backgrounded find correct day (pretend it's Thursday 😉) | | ------ | ------- | | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Forked On 28 Nov 2022 at 03:01:43

Frankcalise

We can revisit this when the data is coming back to scroll more accurately to the ongoing talk depending on the time of day
On 28 Nov 2022 at 03:01:43

Frankcalise

feat(schedule-screen): return to active day during conference

Description

Screen: Schedule Screen

  • Upon pressing the day picker button, if the day is already selected, will scroll to top of the schedule list
  • If the app is backgrounded or killed, the next time it is active we will scroll to the specific schedule for the current day when the conference is ongoing (both pre and post conference the user will just remain where they are) - the gif for this really doesn't show the traveling to the Desktop

Graphics

| Top of list press | Backgrounded find correct day (pretend it's Thursday 😉) | | ------ | ------- | | | |

Checklist:

  • [x] I have done a thorough self-review of my code
  • [ ] I have tested with a screen reader and font-scaling turned on and added necessary accessibility features
  • [x] I have run tests and linter

Forked On 28 Nov 2022 at 03:01:17

Frankcalise

If the current day is one of the conference dates, then navigate to the correct page horizontally
On 28 Nov 2022 at 03:01:17