flexsurfer Github contribution chart
flexsurfer Github Stats
flexsurfer Most Used Languages

Activity

05 Oct 2022

Issue Comment

Flexsurfer

chore: add components to communities overview

Added disclaimer, channel list, preview list to communities overview page.

Forked On 05 Oct 2022 at 10:33:14

Flexsurfer

no issue?

Commented On 05 Oct 2022 at 10:33:14

Flexsurfer

feat: reply to message new ui

fixes #14066

Summary

This PR connects the reply component new UI to the chat input when the user presses "reply" on a message.

  • Android
  • iOS

status: ready

Forked On 05 Oct 2022 at 09:18:36

Flexsurfer

yes, thank you
On 05 Oct 2022 at 09:18:36

Flexsurfer

feat: reply to message new ui

fixes #14066

Summary

This PR connects the reply component new UI to the chat input when the user presses "reply" on a message.

  • Android
  • iOS

status: ready

Merged On 05 Oct 2022 at 09:18:37

Flexsurfer

Commented On 05 Oct 2022 at 09:18:37

Flexsurfer

Implement Token Gating

No according issue yet...

Summary

Implements the Token Gating component, as per design here: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Mobile-Components?node-id=2463%3A39587

Platforms

  • Android
  • iOS
Functional
  • public chats
  • group chats
  • networks

Steps to test

  • Open Status
  • Login
  • Try to join community/channel

status: wip

Forked On 05 Oct 2022 at 09:17:11

Flexsurfer

namespace is not used, we cut it, its only for IDE, but quo2 button uses quo2 icons which adds sizes to the icon name
On 05 Oct 2022 at 09:17:11

Flexsurfer

Implement Token Gating

No according issue yet...

Summary

Implements the Token Gating component, as per design here: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Mobile-Components?node-id=2463%3A39587

Platforms

  • Android
  • iOS
Functional
  • public chats
  • group chats
  • networks

Steps to test

  • Open Status
  • Login
  • Try to join community/channel

status: wip

Merged On 05 Oct 2022 at 09:17:11

Flexsurfer

Commented On 05 Oct 2022 at 09:17:11

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Forked On 04 Oct 2022 at 12:13:32

Flexsurfer

i mean, you can't just test it on high-end phone with no data, we had issues before on old android phones, and with RNN implementation they are all gone, the difference is the DOM, in the current implementation it will be huge, but i don't have any data on how different it will be , also we lost native buttons, but ok, lets make it implemented and we'll see how we could improve it later
On 04 Oct 2022 at 12:13:32

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Merged On 04 Oct 2022 at 12:13:33

Flexsurfer

Commented On 04 Oct 2022 at 12:13:33
Issue Comment

Flexsurfer

Allow Chinese characters as ENS names

This PR lowers the minimum stateofus.eth username requirement to one character to allow usernames like @1 and adds RegEx to support Chinese characters, to allow usernames like @中国

Why?

Lots of users in China want to use Chinese characters in their names, and over a dozen people have suggested this feature to me. There's a huge amount of unused address space on stateofus.eth, and this PR seeks to open that up.

Why not also emojis?

From my testing, emojis have rendering issues, but Chinese hanzi and short usernames do not.

Forked On 04 Oct 2022 at 12:00:07

Flexsurfer

Just curious, did the Status team remove my ENS names? They worked just fine last night, and now they were removed from registration.

cc @churik

Commented On 04 Oct 2022 at 12:00:07

Flexsurfer

Implement Token Gating

No according issue yet...

Summary

Implements the Token Gating component, as per design here: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Mobile-Components?node-id=2463%3A39587

Platforms

  • Android
  • iOS
Functional
  • public chats
  • group chats
  • networks

Steps to test

  • Open Status
  • Login
  • Try to join community/channel

status: wip

Forked On 04 Oct 2022 at 11:29:40

Flexsurfer

we have show-popup in utils
On 04 Oct 2022 at 11:29:40

Flexsurfer

Implement Token Gating

No according issue yet...

Summary

Implements the Token Gating component, as per design here: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Mobile-Components?node-id=2463%3A39587

Platforms

  • Android
  • iOS
Functional
  • public chats
  • group chats
  • networks

Steps to test

  • Open Status
  • Login
  • Try to join community/channel

status: wip

Merged On 04 Oct 2022 at 11:30:52

Flexsurfer

Commented On 04 Oct 2022 at 11:30:52

Flexsurfer

Implement Token Gating

No according issue yet...

Summary

Implements the Token Gating component, as per design here: https://www.figma.com/file/WQZcp6S0EnzxdTL4taoKDv/Mobile-Components?node-id=2463%3A39587

Platforms

  • Android
  • iOS
Functional
  • public chats
  • group chats
  • networks

Steps to test

  • Open Status
  • Login
  • Try to join community/channel

status: wip

Merged On 04 Oct 2022 at 11:30:52

Flexsurfer

Commented On 04 Oct 2022 at 11:30:52

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Forked On 04 Oct 2022 at 11:04:19

Flexsurfer

we must use bottomTabs from RNN instead, not sure if this should be done in this PR
On 04 Oct 2022 at 11:04:19

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Forked On 04 Oct 2022 at 09:17:17

Flexsurfer

could you please elaborate ?
On 04 Oct 2022 at 09:17:17

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Forked On 04 Oct 2022 at 11:00:57

Flexsurfer

could you pls elaborate?
On 04 Oct 2022 at 11:00:57

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Forked On 04 Oct 2022 at 11:02:41

Flexsurfer

why extra view ?
On 04 Oct 2022 at 11:02:41

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Merged On 04 Oct 2022 at 11:07:13

Flexsurfer

Commented On 04 Oct 2022 at 11:07:13

Flexsurfer

[WIP] Shell & Bottom Tabs Migration

status: WIP

Merged On 04 Oct 2022 at 11:07:13

Flexsurfer

Commented On 04 Oct 2022 at 11:07:13

Flexsurfer

feat: reply to message new ui

fixes #14066

Summary

This PR connects the reply component new UI to the chat input when the user presses "reply" on a message.

  • Android
  • iOS

status: ready

Forked On 04 Oct 2022 at 07:44:32

Flexsurfer

so it should be here, between the handle and input text, and we need to subtract from input height, and also we need to account for changes in translate-y , so we need to move drawer when we add new component in it
On 04 Oct 2022 at 07:44:32

Flexsurfer

feat: reply to message new ui

fixes #14066

Summary

This PR connects the reply component new UI to the chat input when the user presses "reply" on a message.

  • Android
  • iOS

status: ready

Merged On 04 Oct 2022 at 07:44:36

Flexsurfer

Commented On 04 Oct 2022 at 07:44:36

Flexsurfer

feat: reply to message new ui

fixes #14066

Summary

This PR connects the reply component new UI to the chat input when the user presses "reply" on a message.

  • Android
  • iOS

status: ready

Merged On 04 Oct 2022 at 07:44:36

Flexsurfer

Commented On 04 Oct 2022 at 07:44:36
Issue Comment

Flexsurfer

feat: reply to message new ui

fixes #14066

Summary

This PR connects the reply component new UI to the chat input when the user presses "reply" on a message.

  • Android
  • iOS

status: ready

Forked On 04 Oct 2022 at 07:40:26

Flexsurfer

it's not a simple one, message drawer is pretty complex and might be confusing, we don't have the dynamic part implemented yet, so this reply component should be inside the drawer, and its height should be taken into account in the drawer

Commented On 04 Oct 2022 at 07:40:26
Issue Comment

Flexsurfer

Allow Chinese characters as ENS names

This PR lowers the minimum stateofus.eth username requirement to one character to allow usernames like @1 and adds RegEx to support Chinese characters, to allow usernames like @中国

Why?

Lots of users in China want to use Chinese characters in their names, and over a dozen people have suggested this feature to me. There's a huge amount of unused address space on stateofus.eth, and this PR seeks to open that up.

Why not also emojis?

From my testing, emojis have rendering issues, but Chinese hanzi and short usernames do not.

Forked On 04 Oct 2022 at 07:33:37

Flexsurfer

@du64 Status team can't remove anything from the contract

Commented On 04 Oct 2022 at 07:33:37
Issue Comment

Flexsurfer

Allow Chinese characters as ENS names

This PR lowers the minimum stateofus.eth username requirement to one character to allow usernames like @1 and adds RegEx to support Chinese characters, to allow usernames like @中国

Why?

Lots of users in China want to use Chinese characters in their names, and over a dozen people have suggested this feature to me. There's a huge amount of unused address space on stateofus.eth, and this PR seeks to open that up.

Why not also emojis?

From my testing, emojis have rendering issues, but Chinese hanzi and short usernames do not.

Forked On 04 Oct 2022 at 07:32:16

Flexsurfer

@3esmit could you please take a look, thanks

Commented On 04 Oct 2022 at 07:32:16

Flexsurfer

Feature/#14025 messages loading skeleton

Fixes #14025

Summary

Implement Skeleton when messages are loading in the new UI.

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 58 38

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 59 26

Design

(Figma Link)

Areas impacted

  • 1-1 chat
  • Public chats
  • Group chats

Platforms

  • Android
  • iOS

Steps to test

  1. Open the Status application
  2. Navigate to the Profile tab
  3. Navigate to Advanced and enable the New UI
  4. Open any chats

status: ready

Forked On 04 Oct 2022 at 07:31:05

Flexsurfer

we need to implement this only for new design, so two ways , 1 - duplicate list-footer, or 2- use new-ui atom condition
On 04 Oct 2022 at 07:31:05

Flexsurfer

Feature/#14025 messages loading skeleton

Fixes #14025

Summary

Implement Skeleton when messages are loading in the new UI.

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 58 38

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 59 26

Design

(Figma Link)

Areas impacted

  • 1-1 chat
  • Public chats
  • Group chats

Platforms

  • Android
  • iOS

Steps to test

  1. Open the Status application
  2. Navigate to the Profile tab
  3. Navigate to Advanced and enable the New UI
  4. Open any chats

status: ready

Forked On 04 Oct 2022 at 07:29:43

Flexsurfer

this implementation only for the new design, so you don't need this event for old one
On 04 Oct 2022 at 07:29:43

Flexsurfer

Feature/#14025 messages loading skeleton

Fixes #14025

Summary

Implement Skeleton when messages are loading in the new UI.

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 58 38

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 59 26

Design

(Figma Link)

Areas impacted

  • 1-1 chat
  • Public chats
  • Group chats

Platforms

  • Android
  • iOS

Steps to test

  1. Open the Status application
  2. Navigate to the Profile tab
  3. Navigate to Advanced and enable the New UI
  4. Open any chats

status: ready

Merged On 04 Oct 2022 at 07:31:09

Flexsurfer

Commented On 04 Oct 2022 at 07:31:09

Flexsurfer

Feature/#14025 messages loading skeleton

Fixes #14025

Summary

Implement Skeleton when messages are loading in the new UI.

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 58 38

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 59 26

Design

(Figma Link)

Areas impacted

  • 1-1 chat
  • Public chats
  • Group chats

Platforms

  • Android
  • iOS

Steps to test

  1. Open the Status application
  2. Navigate to the Profile tab
  3. Navigate to Advanced and enable the New UI
  4. Open any chats

status: ready

Merged On 04 Oct 2022 at 07:31:09

Flexsurfer

Commented On 04 Oct 2022 at 07:31:09

Flexsurfer

Fix mentions on edited message

fixes #14051

Summary

Fixes edited messages mentions

Platforms

  • Android
  • iOS
Functional
  • 1-1 chat
  • public chats
  • group chats
  • account recovery
  • new account
  • user profile updates

Steps to test

  • Open Status
  • Send messages that mention other users (with and without ENS usernames)
  • Edit those messages
  • See if edited messages with ENS name are displayed correctly
  • Also check if anywhere username is mentioned is displayed correctly
  • Have a nice day

status: WIP

Forked On 30 Sep 2022 at 10:47:07

Flexsurfer

subscription still used in event, it's better probably to try to pass :chats/mentionable-users value into :chat.ui.input/set-chat-input-text from the UI
On 30 Sep 2022 at 10:47:07

Flexsurfer

Fix mentions on edited message

fixes #14051

Summary

Fixes edited messages mentions

Platforms

  • Android
  • iOS
Functional
  • 1-1 chat
  • public chats
  • group chats
  • account recovery
  • new account
  • user profile updates

Steps to test

  • Open Status
  • Send messages that mention other users (with and without ENS usernames)
  • Edit those messages
  • See if edited messages with ENS name are displayed correctly
  • Also check if anywhere username is mentioned is displayed correctly
  • Have a nice day

status: WIP

Merged On 30 Sep 2022 at 10:47:08

Flexsurfer

Commented On 30 Sep 2022 at 10:47:08

Flexsurfer

Feature/#14025 messages loading skeleton

Fixes #14025

Summary

Implement Skeleton when messages are loading in the new UI.

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 58 38

Simulator Screen Recording - iPhone 11 - 2022-09-29 at 14 59 26

Design

(Figma Link)

Areas impacted

  • 1-1 chat
  • Public chats
  • Group chats

Platforms

  • Android
  • iOS

Steps to test

  1. Open the Status application
  2. Navigate to the Profile tab
  3. Navigate to Advanced and enable the New UI
  4. Open any chats

status: ready

Forked On 29 Sep 2022 at 01:36:11

Flexsurfer

if you pass height here , you don't need on-layout and number-of-skeletons atom
On 29 Sep 2022 at 01:36:11