dominiksipowicz Github contribution chart
dominiksipowicz Github Stats
dominiksipowicz Most Used Languages

Activity

05 Oct 2022

Dominiksipowicz

started

Started On 05 Oct 2022 at 03:47:13
Issue Comment

Dominiksipowicz

feat: replace next-seo with custom solution

Why

  • We’re replacing next-seo because we haven’t been using it too much, and we’re trying to reduce our external dependencies

ENV varibables

  • Added new optional ENV variable NEXT_PUBLIC_STORE_URL which makes OG image URL absolute instead of relative. Some platforms (eg. Twitter) render only OG images when a full URL is present.
  • fallback to NEXT_PUBLIC_VERCEL_URL is used for Vercel deployments.

Considerations

  • Multiple open graph images were unable to be properly tested, as the social media platforms I tested could not properly select from multiple images.
  • changed seo.json to seo_meta.json to accommodate JSON+LD data structure files in the future.

Forked On 04 Oct 2022 at 09:06:05

Dominiksipowicz

Added new optional ENV variable NEXT_PUBLIC_STORE_URL which makes OG image URL absolute instead of relative. Some platforms (eg. Twitter) render only OG images when a full URL is present. fallback to NEXT_PUBLIC_VERCEL_URL is used for Vercel deployments.

Hi @dominiksipowicz , these variable names are not included in the .env.template on main branch.

Should they be to help avoid confusion?

@CraigWatt I think the NEXT_PUBLIC_STORE_URL can be added. Good spot! Thanks. Do you want to submit PR?

Commented On 04 Oct 2022 at 09:06:05
Issue Comment

Dominiksipowicz

feat: replace next-seo with custom solution

Why

  • We’re replacing next-seo because we haven’t been using it too much, and we’re trying to reduce our external dependencies

ENV varibables

  • Added new optional ENV variable NEXT_PUBLIC_STORE_URL which makes OG image URL absolute instead of relative. Some platforms (eg. Twitter) render only OG images when a full URL is present.
  • fallback to NEXT_PUBLIC_VERCEL_URL is used for Vercel deployments.

Considerations

  • Multiple open graph images were unable to be properly tested, as the social media platforms I tested could not properly select from multiple images.
  • changed seo.json to seo_meta.json to accommodate JSON+LD data structure files in the future.

Forked On 04 Oct 2022 at 09:01:46

Dominiksipowicz

@dominiksipowicz just found this PR while checking out how to add more metadata for instagram + facebook. I saw you guys added Twitter here. I was wondering, are there any guidelines for adding instagram and facebook? I'd be happy to try to put something up if you point me in the right direction. Thanks!

Hi @aecorredor, The purpose of this PR was to minimise the dependencies for the commerce project and give developers more freedom to customize. If you have a lightweight implementation please submit a PR. You can use this PR as an example how to add more OG tags.

Commented On 04 Oct 2022 at 09:01:46

Dominiksipowicz

Add missing declaration file to examples-ui

Type of Change

  • [ ] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [x] Other (changes to the codebase, but not to examples)

Merged On 03 Oct 2022 at 07:40:29

Dominiksipowicz

Commented On 03 Oct 2022 at 07:40:29

Dominiksipowicz

Added `relatedTemplates` to some examples

Description

The publish template action failed for those examples because the relatedTemplates field is required.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Merged On 03 Oct 2022 at 07:39:49

Dominiksipowicz

Commented On 03 Oct 2022 at 07:39:49

Dominiksipowicz

my changes

Pushed On 28 Sep 2022 at 04:26:52
Create Branch

Dominiksipowicz

Description not entered by the user.

On 28 Sep 2022 at 04:21:56

Dominiksipowicz

Description not entered by the user.

On 28 Sep 2022 at 04:21:47

Dominiksipowicz

Fix release workflow

Description

The workflow stopped working because packages/ui no longer has a pnpm-lock.yaml, this same fix has been applied to the Publish Template workflow.

Type of Change

  • [ ] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [x] Other (changes to the codebase, but not to examples)

Merged On 26 Sep 2022 at 04:18:28

Dominiksipowicz

Commented On 26 Sep 2022 at 04:18:28

Dominiksipowicz

Fix ES Modules in new version of vercel/examples package

Description

  • For Node.js to properly resolve relative imports they need to have the .js extension
  • Similarly, if the package imports a js file from a module that doesn't use exports, it also has to include the extension, so next/head becomes next/head.js
  • Only one example ab-testing-simple has been updated to the latest version of the UI package that's using SWC, I've changed the version in all other packages from latest to 0.3.6 which is the last one that used next-transpile-modules.
  • The pnpm-lock.yaml of the UI package was removed because the repo is a monorepo now

This changes continue to be part of the migration away from next-transpile-modules and to support the upcoming Next.js release.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [x] Other (changes to the codebase, but not to examples)

New Example Checklist

  • [ ] 🛫 npm run new-example was used to create the example
  • [ ] 📚 The template wasn't used but I carefuly read the Adding a new example steps and implemented them in the example
  • [ ] 📱 Is it responsive? Are mobile and tablets considered?

Merged On 26 Sep 2022 at 03:31:47

Dominiksipowicz

lgtm

Commented On 26 Sep 2022 at 03:31:47

Dominiksipowicz

started

Started On 22 Sep 2022 at 06:03:58

Dominiksipowicz

Fix Publish Templates workflow

Description

Its last run failed: https://github.com/vercel/examples/actions/runs/3086927515/jobs/4991774645

Type of Change

  • [ ] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [x] Other (changes to the codebase, but not to examples)

Merged On 22 Sep 2022 at 05:10:35

Dominiksipowicz

lgtm

Commented On 22 Sep 2022 at 05:10:35

Dominiksipowicz

Update playwright workflows for testing example

Description

I have tested the workflows on a private repo multiple times to make sure they work.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Forked On 13 Sep 2022 at 07:06:49

Dominiksipowicz

do you need `deployment_status:`?
On 13 Sep 2022 at 07:06:49

Dominiksipowicz

Update playwright workflows for testing example

Description

I have tested the workflows on a private repo multiple times to make sure they work.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Forked On 13 Sep 2022 at 07:11:08

Dominiksipowicz

👍🏼
On 13 Sep 2022 at 07:11:08

Dominiksipowicz

Update playwright workflows for testing example

Description

I have tested the workflows on a private repo multiple times to make sure they work.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Forked On 13 Sep 2022 at 07:08:31

Dominiksipowicz

Will it run on all branches now? This should only fire when I open a PR and on the main branch
On 13 Sep 2022 at 07:08:31

Dominiksipowicz

Update playwright workflows for testing example

Description

I have tested the workflows on a private repo multiple times to make sure they work.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Merged On 13 Sep 2022 at 07:11:30

Dominiksipowicz

Commented On 13 Sep 2022 at 07:11:30

Dominiksipowicz

Update playwright workflows for testing example

Description

I have tested the workflows on a private repo multiple times to make sure they work.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Forked On 13 Sep 2022 at 07:04:39

Dominiksipowicz

`if: ${{ always() }}` - mean run even if a previous step fails is that what we want?
On 13 Sep 2022 at 07:04:39

Dominiksipowicz

Update playwright workflows for testing example

Description

I have tested the workflows on a private repo multiple times to make sure they work.

Type of Change

  • [ ] New Example
  • [x] Example updates (Bug fixes, new features, etc.)
  • [ ] Other (changes to the codebase, but not to examples)

Merged On 13 Sep 2022 at 07:11:30

Dominiksipowicz

Commented On 13 Sep 2022 at 07:11:30

Dominiksipowicz

Update code owners

Description

Added Dev Rel as code owners (for the moment just Lee).

Type of Change

  • [ ] New Example
  • [ ] Example updates (Bug fixes, new features, etc.)
  • [x] Other (changes to the codebase, but not to examples)

Merged On 05 Sep 2022 at 09:23:43

Dominiksipowicz

Commented On 05 Sep 2022 at 09:23:43

Dominiksipowicz

started

Started On 31 Aug 2022 at 11:16:22

Dominiksipowicz

started

Started On 09 Aug 2022 at 09:30:20

Dominiksipowicz

started

Started On 09 Aug 2022 at 03:46:25