designorant Github contribution chart
designorant Github Stats
designorant Most Used Languages

Activity

17 Sep 2022

Designorant

started

Started On 17 Sep 2022 at 09:04:06

Designorant

started

Started On 10 Aug 2022 at 09:23:20

Designorant

started

Started On 10 Aug 2022 at 01:25:32

Designorant

started

Started On 05 Aug 2022 at 05:39:52

Designorant

started

Started On 18 Jul 2022 at 05:34:47
Issue Comment

Designorant

Module not found: Can't resolve '@storybook/addon-ondevice-actions/manager' in React Native

Describe the bug Getting module not found error when trying to run storybook in react native

./storybook/rn-addons.js:1
Module not found: Can't resolve '@storybook/addon-ondevice-actions/manager'
> 1 | import '@storybook/addon-ondevice-actions/manager';
  2 | import '@storybook/addon-ondevice-knobs/manager';
  3 |
./storybook/rn-addons.js:2
Module not found: Can't resolve '@storybook/addon-ondevice-knobs/manager'
  1 | import '@storybook/addon-ondevice-actions/manager';
> 2 | import '@storybook/addon-ondevice-knobs/manager';
  3 | 

To Reproduce Can't use repro command properly since there is no support of react native yet. Follow the steps depicted in Storybook get started:

  1. expo init --template tabs@sdk-36 taskbox (Create new empty expo project)

  2. cd taskbox

  3. npx -p @storybook/cli sb init --type react_native (Add storybook support)

  4. export {default} from './storybook'; (Export default from entrypoint of your app)

After setting up the project if you try to run storybook it will crash and you got the error depicted

System

System: OS: macOS 11.6.1 CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz Binaries: Node: 14.17.0 - /usr/local/bin/node Yarn: 1.22.17 - /usr/local/bin/yarn npm: 7.16.0 - /usr/local/bin/npm Browsers: Chrome: 103.0.5060.114 Firefox: 100.0 Safari: 15.2 npmPackages: @storybook/addon-actions: ^5.3 => 5.3.21 @storybook/addon-knobs: ^5.3 => 5.3.21 @storybook/addon-links: ^5.3 => 5.3.21 @storybook/addon-ondevice-actions: ^5.3.23 => 5.3.23 @storybook/addon-ondevice-knobs: ^5.3.25 => 5.3.25 @storybook/react-native: ^5.3.25 => 5.3.25

Additional context

Forked On 14 Jul 2022 at 02:42:47

Designorant

@shilman Looks like this got closed despite more updates needed in addons.js. Shall we reopen? Happy to open a PR for this.

Commented On 14 Jul 2022 at 02:42:47

Designorant

started

Started On 14 Jul 2022 at 01:51:37

Designorant

Fix PropDescriptor babel warnings

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Fix type export

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge pull request #13906 from storybookjs/fix-prop-descriptor-warning

Fix PropDescriptor babel warnings

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge pull request #13717 from storybookjs/fix/cli-eslint-error

CLI: Add safe check for eslint overrides

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge pull request #13758 from qoalu/patch-4

Fix import in badge-story-starter-example.mdx.mdx

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge pull request #13876 from storybookjs/tech/improve-cli

CLI: Don't try to add packages that are already installed

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge pull request #13905 from storybookjs/imgbot

[ImgBot] Optimize images

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Fix docs page for the addons/controls stories in official-storybook

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge branch 'next' of github.com:storybookjs/storybook into next

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Improve snippet for single-story hoisting

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge pull request #13910 from storybookjs/13039-improve-hoisted-snippet

Improve snippet for single-story hoisting

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Allow falsey default args

For #12767

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Change actions addon to override default values

For #12120. If you need to override the action, you can just set an arg! There's no need to mess with args.defaultValue.

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Merge pull request #13912 from storybookjs/12120-actions-override-defaultValues

Addon-actions: Change to override default values

Pushed On 14 Jul 2022 at 11:42:43

Designorant

6.2.0-alpha.28 changelog

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Update root, peer deps, version.ts/json to 6.2.0-alpha.28

Pushed On 14 Jul 2022 at 11:42:43

Designorant

v6.2.0-alpha.28

Pushed On 14 Jul 2022 at 11:42:43

Designorant

Update git head to 6.2.0-alpha.28

Pushed On 14 Jul 2022 at 11:42:43

Designorant

6.2.0-alpha.28 next.json version file

Pushed On 14 Jul 2022 at 11:42:43

Designorant

chore(angular): add examples/angular-cli/addon-jest.testresults.json in .gitignore

Pushed On 14 Jul 2022 at 11:42:43
Issue Comment

Designorant

Module not found: Can't resolve '@storybook/addon-ondevice-actions/manager' in React Native

Describe the bug Getting module not found error when trying to run storybook in react native

./storybook/rn-addons.js:1
Module not found: Can't resolve '@storybook/addon-ondevice-actions/manager'
> 1 | import '@storybook/addon-ondevice-actions/manager';
  2 | import '@storybook/addon-ondevice-knobs/manager';
  3 |
./storybook/rn-addons.js:2
Module not found: Can't resolve '@storybook/addon-ondevice-knobs/manager'
  1 | import '@storybook/addon-ondevice-actions/manager';
> 2 | import '@storybook/addon-ondevice-knobs/manager';
  3 | 

To Reproduce Can't use repro command properly since there is no support of react native yet. Follow the steps depicted in Storybook get started:

  1. expo init --template tabs@sdk-36 taskbox (Create new empty expo project)

  2. cd taskbox

  3. npx -p @storybook/cli sb init --type react_native (Add storybook support)

  4. export {default} from './storybook'; (Export default from entrypoint of your app)

After setting up the project if you try to run storybook it will crash and you got the error depicted

System

System: OS: macOS 11.6.1 CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz Binaries: Node: 14.17.0 - /usr/local/bin/node Yarn: 1.22.17 - /usr/local/bin/yarn npm: 7.16.0 - /usr/local/bin/npm Browsers: Chrome: 103.0.5060.114 Firefox: 100.0 Safari: 15.2 npmPackages: @storybook/addon-actions: ^5.3 => 5.3.21 @storybook/addon-knobs: ^5.3 => 5.3.21 @storybook/addon-links: ^5.3 => 5.3.21 @storybook/addon-ondevice-actions: ^5.3.23 => 5.3.23 @storybook/addon-ondevice-knobs: ^5.3.25 => 5.3.25 @storybook/react-native: ^5.3.25 => 5.3.25

Additional context

Forked On 14 Jul 2022 at 11:28:03

Designorant

@jsflor Yes, thanks, I did. I see Storybook in iOS Simulator just fine, but the web version via yarn storybook doesn't pick up the stories at all. Apparently this is a known issue but issues like this one makes me wonder whether Storybook in RN is a niche. Clearly there's quite a few things that just don't work.

Interestingly, when following the tutorial via Expo, yarn storybook still doesn't load stories, the Expo Web View works fine, but the Expo iOS Sim doesn't. Bit of a mix and match experience!

Commented On 14 Jul 2022 at 11:28:03

Designorant

started

Started On 14 Jul 2022 at 11:02:15

Designorant

started

Started On 14 Jul 2022 at 10:27:49
Issue Comment

Designorant

Module not found: Can't resolve '@storybook/addon-ondevice-actions/manager' in React Native

Describe the bug Getting module not found error when trying to run storybook in react native

./storybook/rn-addons.js:1
Module not found: Can't resolve '@storybook/addon-ondevice-actions/manager'
> 1 | import '@storybook/addon-ondevice-actions/manager';
  2 | import '@storybook/addon-ondevice-knobs/manager';
  3 |
./storybook/rn-addons.js:2
Module not found: Can't resolve '@storybook/addon-ondevice-knobs/manager'
  1 | import '@storybook/addon-ondevice-actions/manager';
> 2 | import '@storybook/addon-ondevice-knobs/manager';
  3 | 

To Reproduce Can't use repro command properly since there is no support of react native yet. Follow the steps depicted in Storybook get started:

  1. expo init --template tabs@sdk-36 taskbox (Create new empty expo project)

  2. cd taskbox

  3. npx -p @storybook/cli sb init --type react_native (Add storybook support)

  4. export {default} from './storybook'; (Export default from entrypoint of your app)

After setting up the project if you try to run storybook it will crash and you got the error depicted

System

System: OS: macOS 11.6.1 CPU: (8) x64 Intel(R) Core(TM) i5-1038NG7 CPU @ 2.00GHz Binaries: Node: 14.17.0 - /usr/local/bin/node Yarn: 1.22.17 - /usr/local/bin/yarn npm: 7.16.0 - /usr/local/bin/npm Browsers: Chrome: 103.0.5060.114 Firefox: 100.0 Safari: 15.2 npmPackages: @storybook/addon-actions: ^5.3 => 5.3.21 @storybook/addon-knobs: ^5.3 => 5.3.21 @storybook/addon-links: ^5.3 => 5.3.21 @storybook/addon-ondevice-actions: ^5.3.23 => 5.3.23 @storybook/addon-ondevice-knobs: ^5.3.25 => 5.3.25 @storybook/react-native: ^5.3.25 => 5.3.25

Additional context

Forked On 13 Jul 2022 at 04:08:20

Designorant

Thanks @jsflor & @retyui!

Somewhat related question: shouldn't the standard imports be updated too?

I'm getting:

ERROR in ./storybook/addons.js
Module not found: Error: Can't resolve '@storybook/addon-actions/manager' in '/my-app/storybook' 

Changing manager to register helps with the errors indeed but I can't seem to get the stories to load nevertheless.

Commented On 13 Jul 2022 at 04:08:20

Designorant

Add a separate ResumableUploader

Pushed On 30 Jun 2022 at 08:17:42

Designorant

Add missing dependency

Pushed On 30 Jun 2022 at 08:17:42