charliesantos Github contribution chart
charliesantos Github Stats
charliesantos Most Used Languages

Activity

29 Sep 2022

Issue Comment

Charliesantos

[BUG] TypeError: Cannot read properties of null (reading 'sdp')

  • [x] I have verified that the issue occurs with the latest twilio.js release and is not marked as a known issue in the CHANGELOG.md.
  • [x] I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
  • [x] I verified that the Quickstart application works in my environment.
  • [x] I am not sharing any Personally Identifiable Information (PII) or sensitive account information (API keys, credentials, etc.) when reporting this issue.

Expected behavior:

Not raising exceptions due to calling sdp on a null value.

Actual behavior:

Periodically, we get this exception raised by the voice-sdk:

TypeError: Cannot read properties of null (reading 'sdp') 

Here is the backtrace:

webpack://[name]/./node_modules/@twilio/voice-sdk/es5/twilio/rtc/rtcpc.js:120:in sdp
webpack://[name]/./node_modules/@twilio/voice-sdk/es5/twilio/call.js:250:in getSDP
webpack://[name]/./node_modules/events/events.js:158:in ReflectApply
webpack://[name]/./node_modules/@twilio/voice-sdk/es5/twilio/pstream.js:179:in emit
webpack://[name]/./node_modules/events/events.js:153:in ReflectApply
webpack://[name]/./node_modules/@twilio/voice-sdk/es5/twilio/wstransport.js:173:in emit 

We have seen this error twice in the last month, with a user base of ~400 users.

Software versions:

  • Browser(s): Chrome
  • Operating System: ChromeOS
  • twilio.js: 2.1.1
  • Third-party libraries (e.g., Angular, React, etc.): ReactJS 17.0.39

Forked On 29 Sep 2022 at 07:29:58

Charliesantos

Hello everyone. Apologies for the delay. We're not able to reproduce this internally, unfortunately. Do you have client logs and callsid by any chance?

Commented On 29 Sep 2022 at 07:29:58

Charliesantos

feat: send message api (#114)

  • feat: send message api

  • feat: address feedback

  • fix: add callsid check

  • fix: remove call status check

Pushed On 28 Sep 2022 at 09:14:22

Charliesantos

feat: send message api

Created On 28 Sep 2022 at 09:14:21
Issue Comment

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 28 Sep 2022 at 09:14:10

Charliesantos

I'll go ahead and merge this one @mhuynh5757

Commented On 28 Sep 2022 at 09:14:10

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 28 Sep 2022 at 09:13:37

Charliesantos

Commented On 28 Sep 2022 at 09:13:37
Issue Comment

Charliesantos

No mechanism for disabling sounds

v1 had an API to enable/disable sounds:

Device.audio.incoming(false) 

I can see some code related to this in v2: https://github.com/twilio/twilio-voice.js/blob/385c31fc7a2492f7b4f279af3816aa36365597b3/lib/twilio/device.ts#L349-L353

But there doesn't seem to be a public API to configure the settings.

Is this an oversight? It is currently blocking us from upgrading.

Forked On 28 Sep 2022 at 07:37:58

Charliesantos

@kamalbennani , you can definitely do that as a temporary workaround. But please keep in mind that _enabledSounds is a private member and might cause breaking changes in the future. But as long as you do manual updates and testing your updates before deployment, you should be good.

Commented On 28 Sep 2022 at 07:37:58
Issue Comment

Charliesantos

No mechanism for disabling sounds

v1 had an API to enable/disable sounds:

Device.audio.incoming(false) 

I can see some code related to this in v2: https://github.com/twilio/twilio-voice.js/blob/385c31fc7a2492f7b4f279af3816aa36365597b3/lib/twilio/device.ts#L349-L353

But there doesn't seem to be a public API to configure the settings.

Is this an oversight? It is currently blocking us from upgrading.

Forked On 28 Sep 2022 at 04:06:33

Charliesantos

Hello everyone, apologies for the delay. I updated our internal ticket and it will be considered in the next release.

Commented On 28 Sep 2022 at 04:06:33
Issue Comment

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 23 Sep 2022 at 10:13:16

Charliesantos

Latest changes looks good. Please address the callsid related discussion then we can merge https://twilio.slack.com/archives/C042FCK9WSD/p1663968312559099?thread_ts=1663961297.212249&cid=C042FCK9WSD

Commented On 23 Sep 2022 at 10:13:16

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 23 Sep 2022 at 08:46:19

Charliesantos

No, we don't want to check for callsid. I don't think callsid is generated until the call is established no?
On 23 Sep 2022 at 08:46:19

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 23 Sep 2022 at 08:46:19

Charliesantos

Commented On 23 Sep 2022 at 08:46:19

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 23 Sep 2022 at 08:41:22

Charliesantos

It's a valid use case. The customer can use it to send status events to their backend or other clients.
On 23 Sep 2022 at 08:41:22

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 23 Sep 2022 at 08:41:22

Charliesantos

Commented On 23 Sep 2022 at 08:41:22

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 23 Sep 2022 at 08:35:43

Charliesantos

@mhuynh5757 I just learned base on this [discussion](https://twilio.slack.com/archives/C02U2QQCMME/p1663964471252479) that client should be able to receive events outside of "open" status, such as ringing. This means, we should only check here if there's a websocket connection or not.
On 23 Sep 2022 at 08:35:43

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 23 Sep 2022 at 08:35:44

Charliesantos

Commented On 23 Sep 2022 at 08:35:44

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:51:33

Charliesantos

Do you mean keep the `typeof callSid !== 'string'` check? I don't think we need it. Check the status that it is open should cover that.
On 22 Sep 2022 at 09:51:33

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 22 Sep 2022 at 09:51:33

Charliesantos

Commented On 22 Sep 2022 at 09:51:33

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 22 Sep 2022 at 09:48:20

Charliesantos

Commented On 22 Sep 2022 at 09:48:20

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:48:20

Charliesantos

Right. We should not export anything that is not needed. Only do it when you need it. [YAGNI](https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it) 😉
On 22 Sep 2022 at 09:48:20

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 22 Sep 2022 at 09:46:06

Charliesantos

Commented On 22 Sep 2022 at 09:46:06

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:46:06

Charliesantos

Build the package, check the size of the minified/unminified file and compare it to the previous release (download from tags or npm)
On 22 Sep 2022 at 09:46:06

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:31:02

Charliesantos

I think it's better to check call status so you don't need these 2 checks. You will also probably cover more scenario. Something like ```ts if (this._status !== Call.State.Open) { throw new InvalidStateError( `Could not send message. Call status is ${this._status}` ); } ``
On 22 Sep 2022 at 09:31:02

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:34:55

Charliesantos

What is the size difference?
On 22 Sep 2022 at 09:34:55

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:34:43

Charliesantos

Let's use exact version for consistency. I know we now have a lock file, but we should keep this consistent.
On 22 Sep 2022 at 09:34:43

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:38:27

Charliesantos

Why are we exporting it? For unit tests? If so, we should still keep it private. We can hit this function by testing generateVoiceEventSid instead.
On 22 Sep 2022 at 09:38:27

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Merged On 22 Sep 2022 at 09:40:06

Charliesantos

Commented On 22 Sep 2022 at 09:40:06

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:29:12

Charliesantos

Should this be a promise? Or is that a separate task? Right now it just a straight hand off to signaling.
On 22 Sep 2022 at 09:29:12

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:23:38

Charliesantos

Should we check for empty strings?
On 22 Sep 2022 at 09:23:38

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:33:09

Charliesantos

Something to keep at the back of our heads. This pattern is old school and needs rework.
On 22 Sep 2022 at 09:33:09

Charliesantos

feat: send message api

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.

Pull Request Details

JIRA link(s):

Description

This PR adds the send message API for SDK Eventing.

Burndown

Before review

  • [ ] Updated CHANGELOG.md if necessary
  • [ ] Added unit tests if necessary
  • [ ] Updated affected documentation
  • [ ] Verified locally with npm test
  • [ ] Manually sanity tested running locally
  • [ ] Ready for review

Before merge

  • [ ] Got one or more +1s
  • [ ] Squashed erroneous commits if necessary
  • [ ] Re-tested if necessary

Forked On 22 Sep 2022 at 09:22:47

Charliesantos

Need to expand more on this. Just calling it out. No need to address now. We'll do it as part of polishing up the docs.
On 22 Sep 2022 at 09:22:47