chanceaclark Github contribution chart
chanceaclark Github Stats
chanceaclark Most Used Languages

Activity

04 Oct 2022

Issue Comment

Chanceaclark

chore(deps-dev): bump node-fetch from 2.6.7 to 3.2.10

Bumps node-fetch from 2.6.7 to 3.2.10.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Forked On 04 Oct 2022 at 06:50:34

Chanceaclark

Seems there are issues when importing 'node-fetch' related to ESM

Yeah, node-fetch@3+ is ESM only now :( https://github.com/node-fetch/node-fetch/releases/tag/v3.0.0

We will have to migrate a bunch of stuff to support ESM for scripting.

Commented On 04 Oct 2022 at 06:50:34

Chanceaclark

fix(component): Fix counter component when submitting a form

What?

  • Set type attribute as "button" in Decrease and Increate buttons.
  • Remove events in handlers.
  • Implement tests.
  • Additional update: replace fireEvent with userEvent.

Why?

  • To prevent counter input value decrementing when hitting enter to submit a form. More context: #940.

By default a button has a type "submit" so that is why the input value was changing instead of submitting the form. Also the event.preventDefault() used in the handlers were blocking the event used in a form.

Screenshots/Screen Recordings

Before:

https://user-images.githubusercontent.com/39739180/193672053-712fcfbb-0ada-418f-a1b4-9c24a6a24351.mp4

After:

https://user-images.githubusercontent.com/39739180/193671323-c2e3abb9-e82d-41cb-9aaa-51a3af6f44c3.mp4

Testing/Proof

Test pass

Merged On 04 Oct 2022 at 03:04:19

Chanceaclark

👏 👏 👏

Commented On 04 Oct 2022 at 03:04:19

Chanceaclark

started

Started On 04 Oct 2022 at 02:32:13

Chanceaclark

fix(component): prevent column resizing when editing text field

What?

Sets Worksheet to table-layout: fixed and add minWidth prop.

Fixes this issue introduced by #975:

Kapture 2022-09-28 at 12 01 48

Why?

The bug is happening because I set table-layout: auto, which means the table will try to automatically fit the content in the table (this is cool if we want all columns to remain visible even when shrinking the window), and overflow what doesn't fit (so we get a scroll bar).

Problem is that the input element is set to width: 100% and unless the td has a fixed width (set with the new width prop in the column), it won't calculate the 100% as I expected.

What I'm doing is reverting the table to table-layout: fixed. The problem with fixed and having static width columns it that when the table shrinks in size it will shrink all auto columns to 0 to accommodate the fixed width columns.

Like so:

Kapture 2022-09-28 at 10 46 43

To solve this I expose a minWidth prop for the Worksheet, so that we can set a minimum width. However this needs to be controlled by the developer, otherwise the issue above will happen.

Kapture 2022-09-28 at 10 49 35

Table will still have a static width if all columns have static widths.

Fixed inputs:

Kapture 2022-09-28 at 12 08 21

Overall this feels like a good compromise. We added the ability to set fixed widths to columns but by doing so developer needs to be mindful of setting a min-width if viewport gets too shrunk for the table. I believe minWidth was long overdue because the Worksheet has been breaking this way since it was introduced.

Testing/Proof

Locally.

Merged On 30 Sep 2022 at 04:37:01

Chanceaclark

Commented On 30 Sep 2022 at 04:37:01

Chanceaclark

7d91d820308

Pushed On 27 Sep 2022 at 07:01:05

Chanceaclark

chore(release): publish

  • @bigcommerce/big-design-icons@0.21.0
  • @bigcommerce/big-design-theme@0.17.0
  • @bigcommerce/big-design@0.34.0
  • @bigcommerce/docs@0.34.0
  • @bigcommerce/examples@0.21.0

Pushed On 27 Sep 2022 at 06:54:49

Chanceaclark

feat(deps): react@18 support

Pushed On 27 Sep 2022 at 06:49:33

Chanceaclark

feat(deps): react@18 support

Created On 27 Sep 2022 at 06:49:33

Chanceaclark

fix(component): persist selection across TableNext pages

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps): bump eslint from 8.23.1 to 8.24.0

Bumps eslint from 8.23.1 to 8.24.0.


updated-dependencies:

  • dependency-name: eslint dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps): bump typescript from 4.7.4 to 4.8.3 (#970)

  • chore(deps): bump typescript from 4.7.4 to 4.8.3

Bumps typescript from 4.7.4 to 4.8.3.


updated-dependencies:

  • dependency-name: typescript dependency-type: direct:production update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

  • chore: manual fixes

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Chancellor Clark chancellor.clark@bigcommerce.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps-dev): bump lerna from 5.1.6 to 5.5.2

Bumps lerna from 5.1.6 to 5.5.2.


updated-dependencies:

  • dependency-name: lerna dependency-type: direct:development update-type: version-update:semver-minor ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps-dev): bump jest and @types/jest (#980)

  • chore(deps-dev): bump jest and @types/jest

Bumps jest and @types/jest. These dependencies needed to be updated together.

Updates jest from 28.1.3 to 29.0.3

Updates @types/jest from 28.1.6 to 29.0.3


updated-dependencies:

  • dependency-name: jest dependency-type: direct:development update-type: version-update:semver-major
  • dependency-name: "@types/jest" dependency-type: direct:development update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com

  • test(component): updated snapshots

Signed-off-by: dependabot[bot] support@github.com Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Juan Vasquez juan.vasquez@bigcommerce.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps-dev): bump @vitejs/plugin-react from 1.3.2 to 2.1.0

Bumps @vitejs/plugin-react from 1.3.2 to 2.1.0.


updated-dependencies:

  • dependency-name: "@vitejs/plugin-react" dependency-type: direct:development update-type: version-update:semver-major ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps-dev): bump @types/prettier from 2.7.0 to 2.7.1

Bumps @types/prettier from 2.7.0 to 2.7.1.


updated-dependencies:

  • dependency-name: "@types/prettier" dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps-dev): bump @types/gtag.js from 0.0.10 to 0.0.11

Bumps @types/gtag.js from 0.0.10 to 0.0.11.


updated-dependencies:

  • dependency-name: "@types/gtag.js" dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps-dev): bump @types/styled-components from 5.1.25 to 5.1.26

Bumps @types/styled-components from 5.1.25 to 5.1.26.


updated-dependencies:

  • dependency-name: "@types/styled-components" dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(deps-dev): bump jest-styled-components from 7.1.0 to 7.1.1

Bumps jest-styled-components from 7.1.0 to 7.1.1.


updated-dependencies:

  • dependency-name: jest-styled-components dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

chore(release): publish

  • @bigcommerce/big-design-icons@0.20.1
  • @bigcommerce/big-design-theme@0.16.1
  • @bigcommerce/big-design@0.33.1
  • @bigcommerce/docs@0.33.1
  • @bigcommerce/examples@0.20.1

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

feat(deps): react@18 support

Pushed On 27 Sep 2022 at 05:38:01

Chanceaclark

f4a5fbeed75

Pushed On 27 Sep 2022 at 05:20:48

Chanceaclark

chore(release): publish

  • @bigcommerce/big-design-icons@0.20.1
  • @bigcommerce/big-design-theme@0.16.1
  • @bigcommerce/big-design@0.33.1
  • @bigcommerce/docs@0.33.1
  • @bigcommerce/examples@0.20.1

Pushed On 27 Sep 2022 at 05:13:58

Chanceaclark

chore(deps-dev): bump jest-styled-components from 7.1.0 to 7.1.1

Created On 27 Sep 2022 at 05:04:35

Chanceaclark

chore(deps-dev): bump jest-styled-components from 7.1.0 to 7.1.1

Bumps jest-styled-components from 7.1.0 to 7.1.1.


updated-dependencies:

  • dependency-name: jest-styled-components dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 05:04:35

Chanceaclark

chore(deps-dev): bump jest-styled-components from 7.1.0 to 7.1.1

Bumps jest-styled-components from 7.1.0 to 7.1.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Merged On 27 Sep 2022 at 05:04:26

Chanceaclark

Commented On 27 Sep 2022 at 05:04:26

Chanceaclark

chore(deps-dev): bump @types/styled-components from 5.1.25 to 5.1.26

Bumps @types/styled-components from 5.1.25 to 5.1.26.


updated-dependencies:

  • dependency-name: "@types/styled-components" dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 04:59:11

Chanceaclark

chore(deps-dev): bump jest-styled-components from 7.1.0 to 7.1.1

Bumps jest-styled-components from 7.1.0 to 7.1.1.


updated-dependencies:

  • dependency-name: jest-styled-components dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 04:59:11

Chanceaclark

chore(deps-dev): bump @types/styled-components from 5.1.25 to 5.1.26

Bumps @types/styled-components from 5.1.25 to 5.1.26.


updated-dependencies:

  • dependency-name: "@types/styled-components" dependency-type: direct:development update-type: version-update:semver-patch ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 27 Sep 2022 at 04:58:52

Chanceaclark

chore(deps-dev): bump @types/styled-components from 5.1.25 to 5.1.26

Created On 27 Sep 2022 at 04:58:51