caprica-Six Github contribution chart
caprica-Six Github Stats
caprica-Six Most Used Languages

Activity

07 Sep 2022

Caprica-Six

started

Started On 07 Sep 2022 at 04:56:11

Caprica-Six

started

Started On 04 Sep 2022 at 08:03:02

Caprica-Six

started

Started On 04 Sep 2022 at 07:59:06

Caprica-Six

started

Started On 04 Sep 2022 at 07:55:12

Caprica-Six

started

Started On 21 Aug 2022 at 09:53:33

Caprica-Six

started

Started On 20 Aug 2022 at 06:19:31

Caprica-Six

Changed _app.js to a functional component (#37635)

Changed the class component to a functional component of the _app.js file. This is for the Context API example.

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Bump version tailwindcss example to 3.1 (#37633)

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

feat(next export): add warning if using getInitialProps (#37642)

This PR builds on the work from @hattakdev (PR went stale: https://github.com/vercel/next.js/pull/14499) and adds a new integration test for the new warning.

Bug

  • [x] Related issues linked using fixes #number
  • [x] Integration tests added
  • [x] Errors have helpful link attached, see contributing.md

image

To run locally

  1. pnpm build
  2. pnpm testonly test/integration/export-getInitialProps-warn/test/index.test.js

Fixes #13946

Notes

I know the contributing.md doc said to avoid adding new tests to integration. It also said new tests should be written in TypeScript.

I wasn't sure where to put the tests for this so I went with integration. I also didn't see many other tests written in TS in this part of the codebase so I stuck with .js.

Co-authored-by: JJ Kasper 22380829+ijjk@users.noreply.github.com

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Update with-faunadb dependencies (#37650)

This is just a bump of tech stack used in the example and small rewrite of swr functionality.

Bug

  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Errors have helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm lint
  • [ x ] The examples guidelines are followed from our contributing doc

Co-authored-by: JJ Kasper 22380829+ijjk@users.noreply.github.com

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

[Script] Updates stale no-script-in-document-page error doc (#37568)

Recent changes to next/script introduced the capability to use beforeInteractive scripts in the custom document. This old error message is incorrect.

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Request library required by setup (#37658)

In my last PR I removed the request library as it is obsolete and the application does not use it. The database setup utility does though, so I am reverting this change.

Co-authored-by: JJ Kasper 22380829+ijjk@users.noreply.github.com

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Update matched path params priority (#37646)

This ensures we use the correct dynamic route params favoring params from the URL/matched-path over route-matches. This also ensures we properly cache _next/data requests client side when the page is not a getServerSideProps page.

x-ref: https://github.com/vercel/next.js/pull/37574

Bug

  • [ ] Related issues linked using fixes #number
  • [x] Integration tests added
  • [ ] Errors have helpful link attached, see contributing.md

Feature

  • [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • [ ] Related issues linked using fixes #number
  • [ ] Integration tests added
  • [ ] Documentation added
  • [ ] Telemetry added. In case of a feature if it's used or not.
  • [ ] Errors have helpful link attached, see contributing.md

Documentation / Examples

  • [ ] Make sure the linting passes by running pnpm lint
  • [ ] The examples guidelines are followed from our contributing doc

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Update flakey next-script tests (#37663)

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Update with-mux-video to use latest upchunk and replace video player with mux-player-react (#37621)

  • Update upchunk to latest (2.3.1).

  • Add mux-player package to package.json

  • WIP: Make VideoPlayer return mux-player

  • Remove unused code from prev video player

  • Use mux-player-react directly

  • Fix import line for mux-player-react

  • chore: fix lint issues

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Fix links in google-font-display error (#37661)

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

v12.1.7-canary.36

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Re-introduce Edge API Endpoints (#37481)

  • Re-introduce Edge API Endpoints

This reverts commit 210fa39961033842303495e86bf1658dcca01b24, and re-introduces Edge API endpoints as a possible runtime selection in API endpoints.

This is done by exporting a config object:

export config = { runtime: 'edge' } 

Note: 'edge' will probably change into 'experimental-edge' to show that this is experimental and the API might change in the future.

  • Support experimental-edge, but allow edge too

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Allow passing FileRef directly to createNext (#37664)

  • Allow passing FileRef directly to createNext

  • update type

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Fix rewrite/dynamic interpolation E2E cases (#37669)

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

v12.1.7-canary.37

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Fix Image Optimization cache-control regression with external images (#37625)

In a previous PR (#34075), the ISR behavior was introduced to the Image Optimization API, however it changed the cache-control header to always set maxage=0. While this is probably the right behavior (the client shouldn't cache the image), it introduced a regression for users who have CDNs in front of a single Next.js instance (as opposed to multiple Next.js instances).

Furthermore, the pros of client-side caching outweight the cons because its easy to change the image url (add querystring param for example) to invalidate the cache.

This PR reverts the cache-control behavior until we can come up with a better long-term solution.

  • Fixes #35987
  • Related to #19914
  • Related to #22319
  • Closes #35596

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Adds consistency to ESLint rules. (#34335)

  • Adds consistency to ESLint rules.

  • Fixes lint errors.

  • Fixes manifest.

  • Adds missing title.

  • Fixes copy / paste error.

Co-authored-by: Lee Robinson me@leerob.io

  • Update errors/no-script-in-document.md

Co-authored-by: Lee Robinson me@leerob.io

  • Update errors/no-sync-scripts.md

Co-authored-by: Lee Robinson me@leerob.io

  • Updates a couple of rule descriptions.

  • Adds redirects.

  • Fixes unit tests.

  • Removes duplicated section.

  • Updates no-before-interactive-script-outside-document description.

  • Fixes lint.

  • Fixes integration tests.

  • Adds description to no-before-interactive-script-outside-document documentation.

  • Removes link-passhref from rules list.

  • Updates remaining pages/_middleware.js references.

  • Adds consistancy to messaging in new no-styled-jsx-in-document rule.

  • Apply suggestions from code review

  • Apply suggestions from code review

Co-authored-by: Lee Robinson me@leerob.io Co-authored-by: Tim Neutkens tim@timneutkens.nl Co-authored-by: JJ Kasper jj@jjsweb.site

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Ensure custom middleware matcher is used correctly in client manifest (#37672)

  • Ensure custom middleware matcher is used correctly in client manifest

  • lint-fix

  • patch e2e case

  • fix rsc case

  • update test

  • add missing normalize

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

v12.1.7-canary.38

Pushed On 09 Aug 2022 at 05:58:33

Caprica-Six

Convert active-class-name example to TypeScript (#37676)

The Contributing guidelines say TypeScript should be leveraged for new examples, so I thought I'd convert this example over.

I also:

  • Upgraded all dependencies
  • Replaced the prop-types package with TypeScript types

Documentation / Examples

  • [X] Make sure the linting passes by running pnpm lint
  • [X] The examples guidelines are followed from our contributing doc

Pushed On 09 Aug 2022 at 05:58:33
Issue Comment

Caprica-Six

Upstream issue with NewsAPI

Seems like NewsAPI itself is not returning titles or news content data at the moment. Example response:

{
    "status": "ok",
    "totalResults": 35,
    "articles": [
        {
            "author": null,
            "source": {
                "Id": null,
                "Name": "Telegraph.co.uk"
            },
            "publishedAt": "2022-07-22T06:22:00Z",
            "url": "https://www.telegraph.co.uk/athletics/2022/07/22/dina-asher-smith-claims-bronze-race-among-best-have-ever-seen/"
        },
{...} 

Forked On 07 Aug 2022 at 02:56:04

Caprica-Six

Same issue here, seems data's been changed... 'description' is missing

Commented On 07 Aug 2022 at 02:56:04

Caprica-Six

started

Started On 04 Aug 2022 at 09:49:17

Caprica-Six

started

Started On 04 Aug 2022 at 09:26:02

Caprica-Six

chore(deps): update dependency @types/node to v16.11.39

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore(deps): update dependency rollup to v2.75.6

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore(deps): update storybook monorepo to v6.5.8

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix(curriculum): external blog link in FEDL (#46417)

  • fix(curriculum): external blog link in FEDL

  • to not increase the other issue load

  • I like learn more as well

Co-authored-by: Tom 20648924+moT01@users.noreply.github.com

Co-authored-by: Tom 20648924+moT01@users.noreply.github.com

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix?(curriculum): external google sheet in data analysis (#46433)

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix(deps): update dependency react-i18next to v11.17.1

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore(deps): update codesee to v0.280.0

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore(deps): update dependency tailwindcss to v3.1.2

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix(deps): update dependency react-instantsearch-dom to v6.27.0

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix(deps): update dependency reselect to v4.1.6 (#46459)

Co-authored-by: Renovate Bot bot@renovateapp.com

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix(curriculum): allow space between attribute and its value in tests (#46464)

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

Fix(curriculum): external Tower of Hanoi link in CIP (#46434)

  • removed the link

  • changed description

  • made example into one sentence and the description into another

  • Grammar typos

Co-authored-by: Sem Bauke 46919888+Sembauke@users.noreply.github.com

  • Yeab clearer and better description 👌

Co-authored-by: Jeremy L Thompson jeremy@jeremylt.org

  • Fix has been made 🛠️

Co-authored-by: Niraj Nandish nirajnandish@icloud.com

Co-authored-by: Sem Bauke 46919888+Sembauke@users.noreply.github.com Co-authored-by: Jeremy L Thompson jeremy@jeremylt.org Co-authored-by: Niraj Nandish nirajnandish@icloud.com

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix: links updated for cypress-tests guide (#46469)

Co-authored-by: Vibhanshu Jain vibhanshujain@ZBLR-ENG-Vibhanshu.local

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore: rename actions for consistency

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore(curriculum): strandize links in projects (#46465)

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix(actions): drop npm caching (#46480)

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

feat: add workflow for new contributors (#46479)

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore(i18n,learn): processed translations (#46485)

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

chore(i18n,client): processed translations (#46484)

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

fix(cirriculum): unclear instructions fixed (#46486)

  • fix(cirriculum): unclear instructions fixed

Instead of "class" definition, "class selector" is used.

  • fix(cirrixculum): selector words are added

Selector words are added include hints.

Pushed On 04 Aug 2022 at 08:39:33

Caprica-Six

started

Started On 30 Jul 2022 at 09:19:40