browniefed Github contribution chart
browniefed Github Stats
browniefed Most Used Languages

Activity

05 Sep 2022

Issue Comment

Browniefed

[expo-auth-session] allow multiple response types

Why

Google allows for you to pass in id_token token as a response type to get back both an id_token and access_token. If you were to pass id_token token it would pass wrong parameters assuming it was type code

How

I tested for if it includes the things and not strict equality

Test Plan

Checklist

  • [X] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [X] Conforms with the Documentation Writing Style Guide
  • [X] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Forked On 05 Sep 2022 at 12:49:54

Browniefed

@EvanBacon this is for what users are passing in for the token response types. But I think just best to add basic protection and should be good to go.

Commented On 05 Sep 2022 at 12:49:54

Browniefed

fix: undefine protection

Pushed On 05 Sep 2022 at 12:49:15

Browniefed

started

Started On 01 Sep 2022 at 03:44:53

Browniefed

started

Started On 25 Aug 2022 at 04:37:48

Browniefed

Turn a ReactElement into the corresponding JSX string

Forked On 25 Aug 2022 at 02:32:52
Issue Comment

Browniefed

[expo-auth-session] allow multiple response types

Why

Google allows for you to pass in id_token token as a response type to get back both an id_token and access_token. If you were to pass id_token token it would pass wrong parameters assuming it was type code

How

I tested for if it includes the things and not strict equality

Test Plan

Checklist

  • [X] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [X] Conforms with the Documentation Writing Style Guide
  • [X] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Forked On 23 Aug 2022 at 02:01:18

Browniefed

@Simek @EvanBacon how do you want me to handle the possibility of responseType being undefined?

I don't know that it ever is in the Google module from what I've seen but the types declare it optionally.

I can just make everything optional and I believe things would be the same? Or would you prefer something else?

const responseTypes = config.responseType?.split(' ');
responseTypes?.includes(ResponseType.IdToken) 

Commented On 23 Aug 2022 at 02:01:18
Merge

Browniefed

[expo-auth-session] allow multiple response types

Why

Google allows for you to pass in id_token token as a response type to get back both an id_token and access_token. If you were to pass id_token token it would pass wrong parameters assuming it was type code

How

I tested for if it includes the things and not strict equality

Test Plan

Checklist

  • [X] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [X] Conforms with the Documentation Writing Style Guide
  • [X] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Forked On 23 Aug 2022 at 01:46:26

Browniefed

@Simek that was set in the constructor and isn't available here since it seemingly uses the `super.getAuthRequestConfigAsync` to retrieve the config
On 23 Aug 2022 at 01:46:26

Browniefed

[expo-auth-session] allow multiple response types

Why

Google allows for you to pass in id_token token as a response type to get back both an id_token and access_token. If you were to pass id_token token it would pass wrong parameters assuming it was type code

How

I tested for if it includes the things and not strict equality

Test Plan

Checklist

  • [X] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [X] Conforms with the Documentation Writing Style Guide
  • [X] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Merged On 23 Aug 2022 at 01:46:26

Browniefed

Commented On 23 Aug 2022 at 01:46:26

Browniefed

[expo-auth-session] allow multiple response types

Why

Google allows for you to pass in id_token token as a response type to get back both an id_token and access_token. If you were to pass id_token token it would pass wrong parameters assuming it was type code

How

I tested for if it includes the things and not strict equality

Test Plan

Checklist

  • [X] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [X] Conforms with the Documentation Writing Style Guide
  • [X] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Merged On 23 Aug 2022 at 01:45:08

Browniefed

Commented On 23 Aug 2022 at 01:45:08
Merge

Browniefed

[expo-auth-session] allow multiple response types

Why

Google allows for you to pass in id_token token as a response type to get back both an id_token and access_token. If you were to pass id_token token it would pass wrong parameters assuming it was type code

How

I tested for if it includes the things and not strict equality

Test Plan

Checklist

  • [X] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md).
  • [X] Conforms with the Documentation Writing Style Guide
  • [X] This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

Forked On 23 Aug 2022 at 01:45:08

Browniefed

Oy. Reading one thing, typing another.
On 23 Aug 2022 at 01:45:08

Browniefed

fix: rename variables, fix reference to IdToken

Pushed On 23 Aug 2022 at 01:44:59
Pull Request

Browniefed

[expo-auth-session] allow multiple response types

Created On 23 Aug 2022 at 02:31:05

Browniefed

[expo-auth-session] allow multiple response types

Pushed On 23 Aug 2022 at 02:27:55

Browniefed

An open-source platform for making universal native apps with React. Expo runs on Android, iOS, and the web.

Forked On 23 Aug 2022 at 02:25:46

Browniefed

started

Started On 22 Aug 2022 at 06:23:22

Browniefed

started

Started On 22 Aug 2022 at 03:18:56

Browniefed

started

Started On 21 Aug 2022 at 04:28:35

Browniefed

started

Started On 20 Aug 2022 at 08:00:09

Browniefed

started

Started On 20 Aug 2022 at 08:00:06

Browniefed

started

Started On 20 Aug 2022 at 03:27:36

Browniefed

started

Started On 18 Aug 2022 at 11:26:57

Browniefed

Add container style prop

Currently there is no way to style the Ticker container, say if one wants to add a margin to the left or right of the Ticker without needing to wrap the ticker in another View it would be better to pass a style prop.

Usually I would add the margin to the textStyle prop but since this components text / children is mapped to individual text components textStyle is applied to each meaning the margin is applied to each Text component.

Forked On 13 Aug 2022 at 03:26:05

Browniefed

@JDMathew v5.1.0 published

Commented On 13 Aug 2022 at 03:26:05

Browniefed

Add container style prop

Currently there is no way to style the Ticker container, say if one wants to add a margin to the left or right of the Ticker without needing to wrap the ticker in another View it would be better to pass a style prop.

Usually I would add the margin to the textStyle prop but since this components text / children is mapped to individual text components textStyle is applied to each meaning the margin is applied to each Text component.

Forked On 12 Aug 2022 at 04:31:54

Browniefed

I'll deploy later

Commented On 12 Aug 2022 at 04:31:54

Browniefed

Add container style prop (#36)

Currently there is no way to style the Ticker container, say if one wants to add a margin to the left or right of the Ticker without needing to wrap the ticker in another View it would be better to pass a style prop.

Usually I would add the margin to the textStyle prop but since this components text / children is mapped to individual text components textStyle is applied to each meaning the margin is applied to each Text component.

Pushed On 12 Aug 2022 at 04:31:45

Browniefed

Add container style prop

Created On 12 Aug 2022 at 04:31:45

Browniefed

Add container style prop

Currently there is no way to style the Ticker container, say if one wants to add a margin to the left or right of the Ticker without needing to wrap the ticker in another View it would be better to pass a style prop.

Usually I would add the margin to the textStyle prop but since this components text / children is mapped to individual text components textStyle is applied to each meaning the margin is applied to each Text component.

Forked On 12 Aug 2022 at 04:31:41

Browniefed

Oh sure. I don't get notifications unless I get @ mentioned.

Commented On 12 Aug 2022 at 04:31:41

Browniefed

started

Started On 12 Aug 2022 at 05:48:43

Browniefed

started

Started On 11 Aug 2022 at 02:31:13

Browniefed

started

Started On 10 Aug 2022 at 04:31:51