bradleyayers Github contribution chart
bradleyayers Github Stats
bradleyayers Most Used Languages

Activity

28 Sep 2022

Bradleyayers

Bump @actions/core from 1.6.0 to 1.9.1

Created On 28 Sep 2022 at 06:37:25

Bradleyayers

Bump @actions/core from 1.6.0 to 1.9.1

Bumps @actions/core from 1.6.0 to 1.9.1.


updated-dependencies:

  • dependency-name: "@actions/core" dependency-type: direct:production ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 28 Sep 2022 at 06:37:25

Bradleyayers

Merge pull request #85 from dovetail/dependabot/npm_and_yarn/actions/core-1.9.1

Bump @actions/core from 1.6.0 to 1.9.1

Pushed On 28 Sep 2022 at 06:37:25

Bradleyayers

Bump @actions/core from 1.6.0 to 1.9.1

Bumps @actions/core from 1.6.0 to 1.9.1.


updated-dependencies:

  • dependency-name: "@actions/core" dependency-type: direct:production ...

Signed-off-by: dependabot[bot] support@github.com

Pushed On 28 Sep 2022 at 06:37:10

Bradleyayers

Merge pull request #92 from dovetail/dependabot/npm_and_yarn/actions/core-1.9.1

Bump @actions/core from 1.6.0 to 1.9.1

Pushed On 28 Sep 2022 at 06:37:10

Bradleyayers

Bump @actions/core from 1.6.0 to 1.9.1

Created On 28 Sep 2022 at 06:37:09
Issue Comment

Bradleyayers

Alternative variable syntax that's compatible with SQL formatters

I'd like to explore the idea of changing PgTyped to use syntax that is valid SQL, so that it can be formatted by SQL formatters that are standard compliant. At the moment I'm finding most SQL formatters get tripped up by the :foo and particularly the :foo! syntax.

Are there any ideas for alternative variable placeholder syntax that would stay SQL compliant? The best idea I've had is to use quoted identifier syntax (e.g. ":id!"), but unfortunately this is still a syntax error for spread scenarios.

FWIW it looks like https://sql-formatter-org.github.io/sql-formatter/ is one of the best out there.

Forked On 03 Aug 2022 at 09:58:32

Bradleyayers

Would it make more sense to provide our own formatting as part of pgTyped? I did some experiments with alternative parameter styles like @paramName but couldn't find any which would play nice with sql formatters.

As in include a SQL formatter in pgTyped? My initial reaction is no, as I'm skeptical that there's enough time from contributors (including yourself) to support that extra surface area, and competing with existing formatters seems like a battle that's inevitable to lose.

I'm still somewhat optimistic that there's an alternative syntax we could use that would be SQL compatible as well being something pgTyped could do variable substitution on, I don't feel confident we've explored the full landscape of possibilities.

I'd like to put together a full list of syntax ideas that have been considered, I think that would help me be confident whether there is/isn't a viable option.

Commented On 03 Aug 2022 at 09:58:32