bontibon Github contribution chart
bontibon Github Stats
bontibon Most Used Languages

Activity

26 Sep 2022

Started

Bontibon

started

Started On 26 Sep 2022 at 11:55:12
Issue Comment

Bontibon

resolvers-composition: do not mutate resolvers

Currently, composeResolvers mutates the resolvers argument. I am requesting that this behaviour be changed in a future major version, or add a setting so it can be set to not mutate.

Forked On 20 Sep 2022 at 09:17:30

Bontibon

I am trying to use the composeResolvers function as a replacement for graphql-middleware's applyMiddleware function.

Modifying the example from that package's README, I would have expected something like this to work:

 const typeDefs = `
type Query {
  hello(name: String): String
  bye(name: String): String
}
`
const resolvers = {
  Query: {
    hello: (root, args, context, info) => {
      console.log(`3. resolver: hello`)
      return `Hello ${args.name ? args.name : 'world'}!`
    },
    bye: (root, args, context, info) => {
      console.log(`3. resolver: bye`)
      return `Bye ${args.name ? args.name : 'world'}!`
    },
  },
}

const logInput = (next) => async (root, args, context, info) => {
  console.log(`1. logInput: ${JSON.stringify(args)}`)
  const result = await next(root, args, context, info)
  console.log(`5. logInput`)
  return result
}

const logResult = (next) => async (root, args, context, info) => {
  console.log(`2. logResult`)
  const result = await next(root, args, context, info)
  console.log(`4. logResult: ${JSON.stringify(result)}`)
  return result
}

const resolversWithMiddleware = composeResolvers(resolvers, {
  '*.*': [logInput, logResult],
});

const serverWithMiddleware = new ApolloServer({
  schema: makeExecutableSchema({ typeDefs, resolvers: resolversWithMiddleware }),
})

const serverWithoutMiddleware = new ApolloServer({
  schema: makeExecutableSchema({ typeDefs, resolvers })
}) 

But the serverWithoutMiddleware server has the middleware applied, because composeResolvers mutated resolvers.

Commented On 20 Sep 2022 at 09:17:30

Bontibon

started

Started On 02 Sep 2022 at 01:59:31

Bontibon

started

Started On 02 Sep 2022 at 11:09:03
Issue Comment

Bontibon

Distinguish connection or server error during client.Exchange()

Hi there!

Is there a way to check error type to distinguish connection/server error from packet encoding error? I need to walk thru the list of Radius servers and now it's not clear if I need to try next server or stop.

Thanks

Forked On 30 Aug 2022 at 11:59:36

Bontibon

There is not a great solution for this right now. Ideally, each type of error that this library would return would have its own specific error type that could be used in conjunction with errors.Is.

Commented On 30 Aug 2022 at 11:59:36
Issue Comment

Bontibon

Include authentication model in OpenAPI spec

Describe the feature

The model of the payload that is POSTed to externalAuthenticationURL should be defined in the openapi.yaml file. This allows OpenAPI code generation tools to generate the model for the payload.

Forked On 13 Jul 2022 at 01:35:09

Bontibon

@aler9 Updated

Commented On 13 Jul 2022 at 01:35:09

Bontibon

HLS.js is a JavaScript library that plays HLS in browsers with support for MSE.

Forked On 11 Jul 2022 at 08:30:07
Issue Comment

Bontibon

Custom RTMP service doesn't send username/password to server

Operating System Info

Ubuntu 20.04

Other OS

No response

OBS Studio Version

27.1.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

n/a

OBS Studio Crash Log URL

No response

Expected Behavior

OBS should send pubUser and pubPasswd to the server.

Current Behavior

No pubUser and pubPasswd is sent.

Steps to Reproduce

(0. Set up nginx with RTMP mod)

  1. Settings->Stream Enable [x] Use authentication
  2. Settings->Stream Enter a username and password
  3. Start the stream

Anything else we should know?

Tested with "Settings->Stream Custom RTMP service" Server: nginx + https://github.com/arut/nginx-rtmp-module Checked with wireshark + tcpdump In the connect('foo') RTMP packet there is app, type, flashVer, swfUrl, tcUrl but no pubUser/pubPasswd

Forked On 09 Jul 2022 at 01:12:22

Bontibon

I just noticed this today as well.

Commented On 09 Jul 2022 at 01:12:22