benwiley4000 Github contribution chart
benwiley4000 Github Stats
benwiley4000 Most Used Languages

Activity

22 Sep 2022

Issue Comment

Benwiley4000

Simplest way to detect if running in host mode or not?

I'm trying to configure another program to know when RaspiWiFi is in host/configuration mode or just running normally. Is there an easy way to do this?

Forked On 22 Sep 2022 at 07:51:09

Benwiley4000

Thank you! Super helpful.

Commented On 22 Sep 2022 at 07:51:09
Issue Comment

Benwiley4000

"RaspiWiFiConfig setup mode detected" even when not running in AP host mode

I installed RaspiWiFi to be able to easily connect to new networks with an access point. All works smoothly now but I'm not seeing a misleading message on the splash screen instructing me to connect to the access point, even if I'm already connected to a wifi network and there's no access point running from the raspberry pi. It seems we aren't actually detecting which mode we're in, just if RaspiWiFi is installed at all. Would this be a simple fix? I'm wondering if I can modify my existing installation to avoid setting up everything all over again.

Forked On 22 Sep 2022 at 07:28:55

Benwiley4000

I found a solution for an existing installation.

Step 1:

sudo nano /etc/rc.local 

Step 2:

Apply this diff:

@@ -1,3 +1,8 @@
 if [ "$_IP" ]; then
-  /usr/bin/python3 /home/pi/pikaraoke/app.py --use-vlc >> /var/log/pikaraoke.log 2>&1 &
+  if [ "$(ifconfig | grep "inet 10.0.0.1 ")" ]; then
+    # Host mode; show instructions for connecting to wifi
+    /usr/bin/python3 /home/pi/pikaraoke/app.py --use-vlc >> /var/log/pikaraoke.log 2>&1 &
+  else
+    /usr/bin/python3 /home/pi/pikaraoke/app.py --use-vlc --hide-raspiwifi-instructions >> /var/log/pikaraoke.log 2>&1 &
+  fi
 fi 

(You can remove the existing if [ "$_IP" ] block and replace with the following):

if [ "$_IP" ]; then
  if [ "$(ifconfig | grep "inet 10.0.0.1 ")" ]; then
    # Host mode; show instructions for connecting to wifi
    /usr/bin/python3 /home/pi/pikaraoke/app.py --use-vlc >> /var/log/pikaraoke.log 2>&1 &
  else
    /usr/bin/python3 /home/pi/pikaraoke/app.py --use-vlc --hide-raspiwifi-instructions >> /var/log/pikaraoke.log 2>&1 &
  fi
fi 

I chose this method for detecting the wifi mode after asking in the RaspiWiFi repo: https://github.com/jasbur/RaspiWiFi/issues/118#issuecomment-1254152107

Commented On 22 Sep 2022 at 07:28:55
Issue Comment

Benwiley4000

Removed cumulative and calculated it automatically

Hi, based on my testing I've found that you can run the cumulative code whenever the frames disposal is not equal to 3. There is an old PR for this same issue https://github.com/benwiley4000/gif-frames/pull/18 but it seems to have been abandoned, and their solution only worked in the browser. This is also related to issue https://github.com/benwiley4000/gif-frames/issues/13.

This PR removes the cumulative option and runs the relevant code only when the frames disposal !== 3.

Finally, I submitted another PR to add typings awhile back but I noticed that it was never uploaded to npm. If you can publish the changes to npm that would be great. I've also fixed the types to use HTMLCanvasElement instead of Node.js Canvas, since that was the intended type.

Forked On 17 Aug 2022 at 02:15:26

Benwiley4000

It's simply because I had too many GitHub notifications and I had other things to do and stopped reading all my emails. Not really any other good reason! I can try to look at this on Friday, it's my day off.

Ben

Le mar. 16 août 2022, 10 h 09 p.m., Moepi @.***> a écrit :

It didn't seem like this project was maintained anymore sorry, but I will open it again if you still want to look at it.

I also want to mention that you never released my last PR on npm (#17 https://github.com/benwiley4000/gif-frames/pull/17), is it because you lost access to your npm account or some other reason?

— Reply to this email directly, view it on GitHub https://github.com/benwiley4000/gif-frames/pull/36#issuecomment-1217375751, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHOD3OIZK75GWPHIK7DLZTVZRCXJANCNFSM5R45RABA . You are receiving this because you commented.Message ID: @.***>

Commented On 17 Aug 2022 at 02:15:26
Issue Comment

Benwiley4000

Removed cumulative and calculated it automatically

Hi, based on my testing I've found that you can run the cumulative code whenever the frames disposal is not equal to 3. There is an old PR for this same issue https://github.com/benwiley4000/gif-frames/pull/18 but it seems to have been abandoned, and their solution only worked in the browser. This is also related to issue https://github.com/benwiley4000/gif-frames/issues/13.

This PR removes the cumulative option and runs the relevant code only when the frames disposal !== 3.

Finally, I submitted another PR to add typings awhile back but I noticed that it was never uploaded to npm. If you can publish the changes to npm that would be great. I've also fixed the types to use HTMLCanvasElement instead of Node.js Canvas, since that was the intended type.

Forked On 16 Aug 2022 at 11:55:50

Benwiley4000

This looks ok at a glance. I would probably need to release as a major version since it would increase performance overhead.

Commented On 16 Aug 2022 at 11:55:50
Issue Comment

Benwiley4000

Removed cumulative and calculated it automatically

Hi, based on my testing I've found that you can run the cumulative code whenever the frames disposal is not equal to 3. There is an old PR for this same issue https://github.com/benwiley4000/gif-frames/pull/18 but it seems to have been abandoned, and their solution only worked in the browser. This is also related to issue https://github.com/benwiley4000/gif-frames/issues/13.

This PR removes the cumulative option and runs the relevant code only when the frames disposal !== 3.

Finally, I submitted another PR to add typings awhile back but I noticed that it was never uploaded to npm. If you can publish the changes to npm that would be great. I've also fixed the types to use HTMLCanvasElement instead of Node.js Canvas, since that was the intended type.

Forked On 16 Aug 2022 at 11:55:03

Benwiley4000

Why did you close it?

Commented On 16 Aug 2022 at 11:55:03

Benwiley4000

started

Started On 16 Aug 2022 at 01:07:38
Issue Comment

Benwiley4000

rclone sync with --auto-confirm still prompt interactive

What is the problem you are having with rclone?

I am trying to add rclone sync in crontab but the global flag --auto-confirm still prompt interactive

$ rclone sync -i test BackupStorage:backup-test -v --auto-confirm

rclone: copy "test"?
y) Yes, this is OK (default)
n) No, skip this
s) Skip all copy operations with no more questions
!) Do all copy operations with no more questions
q) Exit rclone now.
y/n/s/!/q> 

What is your rclone version (output from rclone version)

rclone v1.55.0
- os/type: linux
- os/arch: amd64
- go/version: go1.16.2
- go/linking: static
- go/tags: cmount 

Which OS you are using and how many bits (e.g. Windows 7, 64 bit)

Ubuntu 20.04.1 LTS

Which cloud storage system are you using? (e.g. Google Drive)

OpenStack Swift

The command you were trying to run (e.g. rclone copy /tmp remote:tmp)

rclone sync -i test BackupStorage:backup-test -v --auto-confirm

A log from the command with the -vv flag (e.g. output from rclone -vv copy /tmp remote:tmp)

2021/04/01 08:22:30 DEBUG : Using config file from "/root/.config/rclone/rclone.conf"
2021/04/01 08:22:30 DEBUG : rclone: Version "v1.55.0" starting with parameters ["rclone" "sync" "-i" "test" "BackupStorage:backup-test" "-vv" "--auto-confirm"]
2021/04/01 08:22:30 DEBUG : Creating backend with remote "test"
2021/04/01 08:22:30 DEBUG : fs cache: adding new entry for parent of "test", "/srv/test"
2021/04/01 08:22:30 DEBUG : Creating backend with remote "BackupStorage:backup-test"
2021/04/01 08:22:33 DEBUG : test: Need to transfer - File not found at Destination
rclone: copy "test"?
y) Yes, this is OK (default)
n) No, skip this
s) Skip all copy operations with no more questions
!) Do all copy operations with no more questions
q) Exit rclone now.
y/n/s/!/q> 

Forked On 09 Aug 2022 at 02:34:57

Benwiley4000

Just wasted like half an hour trying to find in rclone help flags anything like force, yes, --y, copy, prompt, supress, interactive, skip, but it appeared that the first command here https://rclone.org/s3/#configuration already includes the -i that you copypaste not knowing that it's the cause of the prompt...

Thanks this comment helped me understand what was wrong on my end!

Commented On 09 Aug 2022 at 02:34:57

Benwiley4000

Changed imports to ESM
Forked On 07 Aug 2022 at 07:19:46

Benwiley4000

I'm not sure I understand the context for create react app. What version are you using? Have you done any custom configuration? Normally webpack should support commonjs modules, although perhaps a new update removed this support?

Commented On 07 Aug 2022 at 07:19:46

Benwiley4000

Changed imports to ESM
Forked On 07 Aug 2022 at 02:39:05

Benwiley4000

Thanks for the PR, however I'm not sure why it was needed. Could you please explain with some text instead of just opening a PR with no comment ? Otherwise it will be closed. Thanks for understanding.

Commented On 07 Aug 2022 at 02:39:05

Benwiley4000

[TypeScript] styled wrapper doesn't preserve generic props

TypeScript 2.9.1

Using the styled(Component) method while wrapping a component with generic props doesn't preserve the generic argument, it simply defaults it to {}.

Reproduction

import React, { Fragment, ReactNode } from 'react';
import styled from 'styled-components';

interface Props<T> {
  renderChild: (props: T) => ReactNode;
  values: T[];
}

function GenericComponent<T>(props: Props<T>) {
  return (
    <Fragment>
      {props.values.map(props.renderChild)}
    </Fragment>
  );
}

const ThisWorks = (
  <GenericComponent
    values={[{ id: 1, value: 'foo' }]}
    renderChild={props => <p key={`I_${props.id}`}>{props.value}</p>}
  />
);

const StyledGenericComponent = styled(GenericComponent)`
  position: relative;
`;

const ThisDoesntWork = (
  <StyledGenericComponent
    values={[{ id: 1, value: 'foo' }]}
    renderChild={props => <p key={`I_${props.id}`}>{props.value}</p>} // Errors: Property 'id' does not exist on '{}', Property 'value' does not exist on '{}' 
  />
); 

Expected Behavior

TypeScript should be able to evaluate the props object passed to renderChild, in this case, it should recognize it as id: number; value: string.

Actual Behavior

When wrapped in styled, props resolves to {}. renderChild in the wrapped example throws: Error: Property 'id' does not exist on '{}' Error: Property 'value' does not exist on '{}'

Forked On 12 Jul 2022 at 01:32:32

Benwiley4000

For anyone having this issue, this is my workaround:

const StyledSelect = styled(Select)`
  margin: 0 var(--spacing);
` as typeof Select; 

For a solution to support extra props passed for styled components CSS, I used

as <T>(props: SelectProps<T> & { $specialProp: string }) => React.ReactElement; 

Does anyone see an issue with this approach?

Commented On 12 Jul 2022 at 01:32:32
Issue Comment

Benwiley4000

SF2 sounds different across apps

First of all, thanks! This is a very cool app, great to be able to play sf2 files on the iPad.

I've noticed that if I compare the sound of a soundfont instrument across LMMS versus SoundFonts for iPad, it's noticeably different. My best guess would be some kind of low pass filter applied to the SoundFonts for iPad version, but it's hard to say exactly. Maybe it's just a lower default velocity for this app? Or maybe something more fundamental?

Here is the Soundfont. I'm using the instrument SK MHZ1 Brass. https://musical-artifacts.com/artifacts/1366

And here is a low quality video showing the difference between the two sounds.

https://user-images.githubusercontent.com/13558253/177812100-f2f0eea8-575f-49d3-b347-a7b61ffbc086.mp4

It's difficult for me to say which one is "correct". However if you watch this gameplay video that uses the original Megadrive sound you can hear that the polyphonic brass sound matches the LMMS playback more closely.

https://www.youtube.com/watch?v=3BguOvOrfBY

Forked On 10 Jul 2022 at 04:00:32

Benwiley4000

Ok thanks! Sorry I just saw your message. I will take a look later today if I have time. Thanks for the info.

Ben

Le jeu. 7 juill. 2022, 4 h 53 p.m., Brad Howes @.***> a écrit :

Really, just lots of testing and bug fixing. As I mentioned, the rendering engine seems to be working so far as it generates audio without glitching, but I've only tested with a piano font so there could be plenty of cases that are not working correctly, including parameters settings (called generators in the SF2 spec) that are not working per spec. The SF2Lib code does have in-line documentation and there are various directory README files that should be fairly accurate.

— Reply to this email directly, view it on GitHub https://github.com/bradhowes/SoundFonts/issues/4#issuecomment-1178215651, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHOD3MV2LTDMEMAWWHP3ITVS47V7ANCNFSM5253FCUA . You are receiving this because you authored the thread.Message ID: @.***>

Commented On 10 Jul 2022 at 04:00:32
Issue Comment

Benwiley4000

SF2 sounds different across apps

First of all, thanks! This is a very cool app, great to be able to play sf2 files on the iPad.

I've noticed that if I compare the sound of a soundfont instrument across LMMS versus SoundFonts for iPad, it's noticeably different. My best guess would be some kind of low pass filter applied to the SoundFonts for iPad version, but it's hard to say exactly. Maybe it's just a lower default velocity for this app? Or maybe something more fundamental?

Here is the Soundfont. I'm using the instrument SK MHZ1 Brass. https://musical-artifacts.com/artifacts/1366

And here is a low quality video showing the difference between the two sounds.

https://user-images.githubusercontent.com/13558253/177812100-f2f0eea8-575f-49d3-b347-a7b61ffbc086.mp4

It's difficult for me to say which one is "correct". However if you watch this gameplay video that uses the original Megadrive sound you can hear that the polyphonic brass sound matches the LMMS playback more closely.

https://www.youtube.com/watch?v=3BguOvOrfBY

Forked On 07 Jul 2022 at 08:24:26

Benwiley4000

Thanks so much for the information! I will try to clone the project this week and see if I can get somewhere.

Just one more question, what do you see as "TODO" before you switch in the released version to using SF2Lib (not including the unimplemented filters you already mentioned)?

Commented On 07 Jul 2022 at 08:24:26
Issue Comment

Benwiley4000

SF2 sounds different across apps

First of all, thanks! This is a very cool app, great to be able to play sf2 files on the iPad.

I've noticed that if I compare the sound of a soundfont instrument across LMMS versus SoundFonts for iPad, it's noticeably different. My best guess would be some kind of low pass filter applied to the SoundFonts for iPad version, but it's hard to say exactly. Maybe it's just a lower default velocity for this app? Or maybe something more fundamental?

Here is the Soundfont. I'm using the instrument SK MHZ1 Brass. https://musical-artifacts.com/artifacts/1366

And here is a low quality video showing the difference between the two sounds.

https://user-images.githubusercontent.com/13558253/177812100-f2f0eea8-575f-49d3-b347-a7b61ffbc086.mp4

It's difficult for me to say which one is "correct". However if you watch this gameplay video that uses the original Megadrive sound you can hear that the polyphonic brass sound matches the LMMS playback more closely.

https://www.youtube.com/watch?v=3BguOvOrfBY

Forked On 07 Jul 2022 at 06:43:15

Benwiley4000

Is there anything I could do to help? I'm not making a long term commitment but if the work could be broken down into smaller tasks that I might be able to handle, I'd be interested to know. I'm starting to learn Swift but I have good experience in other languages like Javascript, Python and C++.

Commented On 07 Jul 2022 at 06:43:15

Benwiley4000

"This mac is no longer eligible to create Apple ID accounts" after Catalina install

I'm on a macOS 10.14 Mojave host, ran this script (with the option to gather info from my system set to yes) and got a Catalina VM set up. When I got to the step for logging in to Apple services it said "this mac is no longer eligible to create Apple ID accounts. Create an account on a different device." Note that I had previously tried to install a Monterey VM without this script (which worked also), but I couldn't log in with my apple ID there either, however the error message was different, about an UNSUPPORTED_APPLE_ID.

Is there something I forgot to do that is important to make this work?

And yes I am also logged into my Apple ID from the host.

Forked On 06 Jul 2022 at 07:34:46

Benwiley4000

Thanks so much for the info! I think I will probably just dual boot to avoid this issue. A shame they don't make it simpler.

Le mer. 6 juill. 2022, 3 h 06 p.m., Jack @.***> a écrit :

When registering an Apple ID, there are checks for some parameters that are not configured by the script. The registration process can tell that it's not a genuine Apple device and fails.

If you wish to create a VM that's indistinguishable from a genuine Apple device (for the purpose of registering an Apple ID) you're going to have to figure out which parameters the registration process checks.

You can start by applying all the hundreds of EFI and NVRAM parameters from a genuine Mac...

— Reply to this email directly, view it on GitHub https://github.com/myspaghetti/macos-virtualbox/issues/610#issuecomment-1176574257, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADHOD3KDX6Y7QN5BK7PP57LVSXKLDANCNFSM52ZZ7VBA . You are receiving this because you authored the thread.Message ID: @.***>

Commented On 06 Jul 2022 at 07:34:46
Issue Comment

Benwiley4000

[BUG] Chromium and webkit headless/head rendering differences

System:

  • OS: Linux 5.4 Ubuntu 20.04.3 LTS (Focal Fossa)
  • Memory: 1.12 GB / 15.45 GB

Binaries:

  • Node: 14.18.0 - /usr/local/bin/node
  • Yarn: 1.22.5 - /usr/bin/yarn
  • npm: 8.5.1 - /usr/local/bin/npm

Languages:

  • Bash: 5.0.17 - /bin/bash

Playwright env.:

  • Playwright Version: 1.19.2
  • Browser: All

The bug

Hi there! We are testing a kind of "analytics" web where some charts and diagrams are shown using amCharts library. The first approach is being made with snapshot testing.

The issue comes with head/headless option, as we develop with headless option set to false and the CI environment uses headless executions.

When the snapshots are made with headless option enabled and then we launch the tests in headful mode the tests in Chromium and Webkit are failing, the images are not equal. This doesn't happen with Firefox, that makes identically component screenshots.

Evidences

We made a simple project that enters an amChart example and makes a snapshot of a pie chart component. The test consist on comparing a snapshot made with headless option set to true and then repeat the test in headful mode (and vice versa).

https://github.com/manuman94/playwright-head-vs-headless-rendering

Further, I tried to compare the images using pixelmatch library (which Playwright is using too I believe) and get the image difference. Here you can see the both images and the difference image: Headless: headless

HeadFul: noHeadless

Difference: difference

Previous issues

There was an issue opened on Jan 4th 2021 (https://github.com/microsoft/playwright/issues/11177) regarding this issue, but as for today is closed and a pull request was created to solve the font family problems.

There is another closed issue (https://github.com/microsoft/playwright/issues/5371) but it seems that it was reporting a completely different problem.

Side notes

  • Consequent screenshots in the same mode (headless or headful) are identical. This confirms that the amCharts library renders its components in the same way every time.
  • The font family is not the only issue as the difference image shows that some pixels part of the chart are different too.
  • Firefox does not have this difference.
  • Is there any way of obtaining the result image using the matcher .toMatchSnapshot? The method signature tells that it returns a Buffer but I'm not able to obtain the difference image. The one I got is using pixelmatch function directly.

Thank you so much, greetings.

Forked On 05 Jul 2022 at 01:47:21

Benwiley4000

The problem with our case is that headed vs headless renders the image with one pixel difference of dimensions. I'm not sure I understand how maxDiffPixelRatio will work. Does it also require maxDiffPixels to be set? Or does it replace this?

Commented On 05 Jul 2022 at 01:47:21