banderson Github contribution chart
banderson Github Stats
banderson Most Used Languages

Activity

25 Aug 2022

Banderson

Remove version and add CRM card location configuration property

"location" is the new configuration property used to specify where a CRM card extension should render, currently either "crm.record.tab" and "crm.record.sidebar".

I've tested this with both locations, everything works as intended.

Merged On 25 Aug 2022 at 10:30:44

Banderson

:shipit:

Commented On 25 Aug 2022 at 10:30:44

Banderson

chore: Set up Prettier

This PR sets up Prettier for this repository, includes eslint-config-prettier to prevent collisions between ESLint and Prettier, and runs the existing files through it (excluding the generated LICENSE.md file and the other files that are by default excluded by Prettier, like anything in node_modules/). It also adds a brief explanation of Prettier and how to use it if one so chooses to the README.

Merged On 16 Aug 2022 at 07:43:59

Banderson

Commented On 16 Aug 2022 at 07:43:59

Banderson

started

Started On 14 Aug 2022 at 03:07:41

Banderson

refactor(deps): updates card example with dependencies

Removes a dependency on node-hubspot-api and adds a dependency on @hubspot/api-client for doing HubSpot API requests.

Forked On 14 Jul 2022 at 12:08:51

Banderson

Are we sure this works? From the slack thread, I was expecting the `node-hubspot-api` dep to be removed, but I am surprised to see axios and api-client added. Since the latter deps are already bundled with the project<sup>*</sup>, do you know if this affects the runtime behavior when you `require('axios')`? Without testing it, I would fear two possibilities: 1. This change is a noop, and `require('axios')` inside your fn returns the instance we already bundle with the project regardless of what's listed in package.json, or... 2. This conflicts with or overrides the existing modules already installed and bundled Based on your testing, what are you seeing? * <sub>I am not totally clear on how those modules are bundled (a custom lambda layer?) but at first glance it seems like this would cause confusion at best if the versions in package.json don't match what's in runtime</sub>
On 14 Jul 2022 at 12:08:51

Banderson

refactor(deps): updates card example with dependencies

Removes a dependency on node-hubspot-api and adds a dependency on @hubspot/api-client for doing HubSpot API requests.

Merged On 14 Jul 2022 at 12:23:04

Banderson

Commented On 14 Jul 2022 at 12:23:04

Banderson

refactor(deps): updates card example with dependencies

Removes a dependency on node-hubspot-api and adds a dependency on @hubspot/api-client for doing HubSpot API requests.

Merged On 14 Jul 2022 at 12:23:04

Banderson

Commented On 14 Jul 2022 at 12:23:04