almet Github contribution chart
almet Github Stats
almet Most Used Languages

Activity

05 Oct 2022

Almet

Specify the version in copanier/__init__.py.

Created On 05 Oct 2022 at 09:35:13
Create Branch
Almet In spiral-project/copanier Create Branchalmet/css-version

Almet

A minimalist collective buying software.

On 05 Oct 2022 at 09:34:51
Issue Comment

Almet

Make data immutable

It could be useful to mark data as immutable, or to attribute it to someone, so data doesn't get accidentally or intentionally removed. (Thanks to Michiel Leenaars for the suggestion)

Forked On 05 Oct 2022 at 08:56:18

Almet

That seems interesting. If we go this way, we could enable/disable it project-wide.

The main problem I see with the author attribution is that users aren't currently identified on their own (everybody connects with the same project-credentials), so changing this would mean a rework of the authentication workflow. Not sure we want this, because it adds complexity.

Commented On 05 Oct 2022 at 08:56:18

Almet

Update documentation

Pushed On 05 Oct 2022 at 12:35:16
Issue Comment

Almet

Integrate flask-limiter

For the moment, it's just the integration of flask-limiter instead of the old and hand-made LoginThrottler.

Open discussion: since we are about to use limiter in more places than admin login, I modified the main layout to display limit breached. But… should we displayed the content block in this case? Or just optionnally, based on some variable?

Forked On 03 Oct 2022 at 07:42:08

Almet

We probably shouldn't display the content block if we reached the max limit.

Should we merge this?

Commented On 03 Oct 2022 at 07:42:08
Issue Comment

Almet

Updated the readme

Added the contributer image and the link to their profile using contrib.rocks to give them some more respect.

Forked On 03 Oct 2022 at 07:40:14

Almet

Thanks! Why not, I added a few remarks.

Commented On 03 Oct 2022 at 07:40:14

Almet

Updated the readme

Added the contributer image and the link to their profile using contrib.rocks to give them some more respect.

Merged On 03 Oct 2022 at 07:39:57

Almet

Commented On 03 Oct 2022 at 07:39:57

Almet

Updated the readme

Added the contributer image and the link to their profile using contrib.rocks to give them some more respect.

Forked On 03 Oct 2022 at 07:39:56

Almet

I don't think we need to name the tool here.
On 03 Oct 2022 at 07:39:56

Almet

Updated the readme

Added the contributer image and the link to their profile using contrib.rocks to give them some more respect.

Forked On 03 Oct 2022 at 07:39:38

Almet

We're using Markdown instead of HTML here, so it would be better to use it here as well :-)
On 03 Oct 2022 at 07:39:38

Almet

Updated the readme

Added the contributer image and the link to their profile using contrib.rocks to give them some more respect.

Merged On 03 Oct 2022 at 07:39:39

Almet

Commented On 03 Oct 2022 at 07:39:39

Almet

Updated the readme

Added the contributer image and the link to their profile using contrib.rocks to give them some more respect.

Forked On 03 Oct 2022 at 07:39:15

Almet

Typo: I believe it should be contribut**o**rs (no capital C, and o instead of e). Repository should also not be capitalized. Something like "Join the other contributors" would work.
On 03 Oct 2022 at 07:39:15

Almet

Updated the readme

Added the contributer image and the link to their profile using contrib.rocks to give them some more respect.

Merged On 03 Oct 2022 at 07:39:16

Almet

Commented On 03 Oct 2022 at 07:39:16
Issue Comment

Almet

Add support for photo as proof / file upload

From Michiel Leenaars, by email.

Anybody that needs to account for spending, would need at least a photo of the bill as proof. Not everyone lives in a high trust setting, and obviously different use cases involve different features not of use to others. Keeping it simple works for simple use cases only, offering more functionality but keeping the UX easy is where the challenge lies.

We currently have an option to attach links in the form of URLs, but it doesn't support file uploads on its own.

Forked On 03 Oct 2022 at 06:40:48

Almet

I think we would need to store the pictures on the host, as files.

Commented On 03 Oct 2022 at 06:40:48
Issue Comment

Almet

Docker ARM build

Hello. Would it be possible to publish and maintain an arm build of the Docker Hub image, so that it can be ran from a Raspberry Pi, etc.?

Forked On 02 Oct 2022 at 07:42:58

Almet

cc @youegraillot

Commented On 02 Oct 2022 at 07:42:58
Issue Comment

Almet

sqlite3 unable to connect to db

Recieve the following error on running command - ihatemoney runserver

 warnings.warn(
D:\test_ihatemoney\ihatemoney\lib\site-packages\ihatemoney\run.py:44: UserWarning: The database is currently stored in /tmp and might be lost at next reboot.
  warnings.warn(
Traceback (most recent call last):
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\base.py", line 2336, in _wrap_pool_connect
    return fn()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 304, in unique_connection
    return _ConnectionFairy._checkout(self)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 778, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 495, in checkout
    rec = pool._do_get()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\impl.py", line 241, in _do_get
    return self._create_connection()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 309, in _create_connection
    return _ConnectionRecord(self)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 440, in __init__
    self.__connect(first_connect_check=True)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 660, in __connect
    with util.safe_reraise():
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\util\langhelpers.py", line 68, in __exit__
    compat.raise_(
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\util\compat.py", line 182, in raise_
    raise exception
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 656, in __connect
    connection = pool._invoke_creator(self)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\strategies.py", line 114, in connect
    return dialect.connect(*cargs, **cparams)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\default.py", line 508, in connect
    return self.dbapi.connect(*cargs, **cparams)
sqlite3.OperationalError: unable to open database file

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "C:\Users\sudhi\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 196, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\sudhi\AppData\Local\Programs\Python\Python310\lib\runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "D:\test_ihatemoney\ihatemoney\Scripts\ihatemoney.exe\__main__.py", line 7, in <module>
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\click\core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\click\core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\click\core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\click\core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\click\core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\click\decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\flask\cli.py", line 354, in decorator
    app = __ctx.ensure_object(ScriptInfo).load_app()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\flask\cli.py", line 301, in load_app
    app = self.create_app()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\ihatemoney\run.py", line 173, in create_app
    setup_database(app)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\ihatemoney\run.py", line 55, in setup_database
    if _pre_alembic_db():
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\ihatemoney\run.py", line 37, in _pre_alembic_db
    con = db.engine.connect()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\base.py", line 2263, in connect
    return self._connection_cls(self, **kwargs)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\base.py", line 104, in __init__
    else engine.raw_connection()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\base.py", line 2369, in raw_connection
    return self._wrap_pool_connect(
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\base.py", line 2339, in _wrap_pool_connect
    Connection._handle_dbapi_exception_noconnection(
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\base.py", line 1583, in _handle_dbapi_exception_noconnection
    util.raise_(
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\util\compat.py", line 182, in raise_
    raise exception
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\base.py", line 2336, in _wrap_pool_connect
    return fn()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 304, in unique_connection
    return _ConnectionFairy._checkout(self)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 778, in _checkout
    fairy = _ConnectionRecord.checkout(pool)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 495, in checkout
    rec = pool._do_get()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\impl.py", line 241, in _do_get
    return self._create_connection()
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 309, in _create_connection
    return _ConnectionRecord(self)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 440, in __init__
    self.__connect(first_connect_check=True)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 660, in __connect
    with util.safe_reraise():
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\util\langhelpers.py", line 68, in __exit__
    compat.raise_(
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\util\compat.py", line 182, in raise_
    raise exception
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\pool\base.py", line 656, in __connect
    connection = pool._invoke_creator(self)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\strategies.py", line 114, in connect
    return dialect.connect(*cargs, **cparams)
  File "D:\test_ihatemoney\ihatemoney\lib\site-packages\sqlalchemy\engine\default.py", line 508, in connect
    return self.dbapi.connect(*cargs, **cparams)
sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) unable to open database file
(Background on this error at: http://sqlalche.me/e/13/e3q8)``` 

Forked On 02 Oct 2022 at 07:42:33

Almet

Hi, can you please specify what's your operating system and version?

Commented On 02 Oct 2022 at 07:42:33
Issue Comment

Almet

Éviter la mise en cache des modifications CSS

@Gwenael-F dans une autre discussion indique :

Un truc, comme il n'y a pas de versionnage sur les fichiers css, les modifs css ne sont pas prises en compte (sauf pour les gens qui vident le cache régulièrement mais c'est rare). Pour y remédier, il faudrait juste ajouter ça par exemple aux fichiers (surtout app.css et page.css en fait) : app.css?v=1.12 Et on peut faire évoluer la version au fur et à mesure. J'ai fait ça sur tout les sites que j'ai codé, ça marche très bien. C'est possible de faire ça facilement?

Forked On 30 Sep 2022 at 01:13:53

Almet

Effectivement, ce serait bien de trouver une solution pour gérer ça ! Le fait d'utiliser les querystrings me semble un moyen simple, et ça devrait fonctionner facilement.

De manière générale, ça pose la question du déploiement continu. Si c'est le modèle qu'on choisit alors on peut imaginer ajouter le hash du dernier commit de manière automatique dans le querystring.

Je suis plutôt pour faire des modifs localement et pour les déployer à un moment où on pense que c'est le moins risqué, auquel cas on peut imaginer de faire des montées de version de d'utiliser ce numéro de version dans le querystring?

Commented On 30 Sep 2022 at 01:13:53

Almet

Suppression de l’affichage de ‘+ d’infos’

Created On 28 Sep 2022 at 10:26:31
Issue Comment

Almet

Suppression de l’affichage de ‘+ d’infos’
Forked On 28 Sep 2022 at 10:23:50

Almet

Je viens de publier tes modifs du coup ! A l'occasion, je pourrais te donner les accès pour que tu puisse le faire aussi si tu souhaites. On peut imaginer un moment discussion / explications de trucs si c'est utile.

Commented On 28 Sep 2022 at 10:23:50
Issue Comment

Almet

Affichage des infos sup. produit par défaut

Ajout du css au media print pour afficher par défaut les infos produit pour l’impression.

Forked On 28 Sep 2022 at 10:20:10

Almet

Ah mais ce serait super ! C'est un cas d'utilisation que je n'ai pas, mais je trouve ça très pertinent !

Est-ce que tu peux préciser une URL par exemple d'une page que tu imprimes ?

Commented On 28 Sep 2022 at 10:20:10
Issue Comment

Almet

Affichage des infos sup. produit par défaut

Ajout du css au media print pour afficher par défaut les infos produit pour l’impression.

Forked On 28 Sep 2022 at 04:16:55

Almet

Est-ce que tu peux me préciser ton cas d'utilisation (qu'est-ce que tu imprime exactement ?) pour que je teste ici et que je voie ce que ça donne ?

PS : j'ai essayé tes autres modifs en local avec la base de données et ça marche très bien, merci !

Commented On 28 Sep 2022 at 04:16:55
Issue Comment

Almet

Affichage des infos sup. produit par défaut

Ajout du css au media print pour afficher par défaut les infos produit pour l’impression.

Forked On 28 Sep 2022 at 03:03:05

Almet

Du coup, je ne sais pas si c'est une bonne idée d'avoir toutes ces infos visibles par défaut. Est-ce que le mieux pour cette partie là ne serait pas de tester en local voir ce que ça donne avec une base de données « réelle », avant de merger ?

Commented On 28 Sep 2022 at 03:03:05

Almet

Ajout css pour la fonctionnalité ‘Plus d'infos’

Created On 28 Sep 2022 at 03:01:59

Almet

Ajout code pour la fonctionnalité ‘Plus d'infos’ (#122)

Pushed On 28 Sep 2022 at 03:02:04